This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 18 Jul, 2015 2 commits
-
-
It was not possible to add media to the page properties if the user has only the permissions for "page edit" and not for "page content".. Resolves: #66702 Releases: master, 6.2 Change-Id: I553ee805a0e992d2ea5e00b91e7de733b2e4c94e Reviewed-on: http://review.typo3.org/40835 Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
Susanne Moog <typo3@susannemoog.de> Reviewed-by:
Markus Sommer <markussom@posteo.de> Tested-by:
Markus Sommer <markussom@posteo.de> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org>
-
In english you have to use "an" before any spoken vowel. Resolves: #68326 Releases: master Change-Id: I2f8996d14eb532bd297b7035a6daaee4fea3f140 Reviewed-on: http://review.typo3.org/41651 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Nicole Cordes <typo3@cordes.co>
-
- 17 Jul, 2015 1 commit
-
-
The patch fixes a todo that was marked as code smell already. The FormEngine class construct relies on a defined return structure for child nodes. This must not be violated and may throw all kind of warnings. An edge case is fixed, where the InlineRecordContainer is called by FormEngine ajax inline "extend" or by the InlineControlContainer, those parents must react differently, so this communcation is now done with an exception. Resolves: #68262 Resolves: #67592 Releases: master Change-Id: I32996e31d27be3d0556b9b68c7291624e0d289d2 Reviewed-on: http://review.typo3.org/41521 Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
Susanne Moog <typo3@susannemoog.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-
- 16 Jul, 2015 1 commit
-
-
Benni Mack authored
Remove leftover styles. Resolves: #67354 Releases: master Change-Id: Iac6607b0efbb3b59f120d163418e78b84eff9123 Reviewed-on: http://review.typo3.org/41488 Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org>
-
- 13 Jul, 2015 1 commit
-
-
Stefan Neufeind authored
The usage of the ternary operator just for conversion to boolean like ... ? TRUE : FALSE is be replaced by a normal (bool) typecast. Change-Id: Ia32f63b423ffa7e066c9cf8bb002dde51b419bfa Resolves: #68063 Releases: master Reviewed-on: http://review.typo3.org/41110 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de>
-
- 01 Jul, 2015 1 commit
-
-
By forging edit URLs it was possible to edit meta data records of files which were not within a user mount. Implement several hooks to check access to the file and only grant access to a meta data record if the user has access to the file. Resolves: #56644 Releases: master, 6.2 Security-Bulletin: TYPO3-CORE-SA-2015-002 Change-Id: I0f0704af2e7f01d16b9420f9ba4ac1a7846b5270 Reviewed-on: http://review.typo3.org/40804 Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org> Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
Helmut Hummel <helmut.hummel@typo3.org>
-
- 26 Jun, 2015 1 commit
-
-
inline records are now closed correctly when using expandSingle. Prior to this commit if a record was opened, all open records remained open instead of being closed Resolves: #67691 Releases: master Change-Id: I5e815824181be17622558c55c452d4a1dac5c339 Reviewed-on: http://review.typo3.org/40552 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- 16 Jun, 2015 1 commit
-
-
Since 2012, there is a special mechanism to allow some tables for editing even if their records reside on a page that is inaccessible for the user. This is checked for regular forms in ``EditDocumentController``, but the check for inline elements was missing until this patch. Resolves: #65563 Releases: master, 6.2 Change-Id: I6d984c28672e2b3ba225ea91f6c7292aa3e1127d Reviewed-on: http://review.typo3.org/37586 Reviewed-by:
Benjamin Mack <benni@typo3.org> Reviewed-by:
Daniel Maier <dani-maier@gmx.de> Tested-by:
Daniel Maier <dani-maier@gmx.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org>
-
- 03 Jun, 2015 1 commit
-
-
For details, see the ReST files with examples for new API and TCA changes. * Split TCA config "type" to "type" and "renderType": TCA config "type" is a technical debt since it both defines the database storage as well as the widget that is used to render a certain field in FormEngine. While "type" is kept, the render widget is now extracted to a "renderType". * t3editor uses this "renderType" now. type=text with renderType=t3editor will call the new T3editorElement provided by ext:t3editor, and falls back to TextElement if t3editor is not loaded. * t3editor is now enabled for "setup" and "constants" of sys_template records if opening the whole record. * t3editor now works when configured in a flex form. * Introduce an API in FormEngine NodeFactory to register new renderType, used by t3editor. * Introduce a resolver API in FormEngine NodeFactory to change the class that renders a widget or container. * Split TextElement into TextElement that only renders a textarea and RichTextElement provided by ext:rtehtmlarea that renders RTE. ext:rtehtmlarea uses the new resolver API to route rendering to its own class in case RTE is enabled and configured for a field. * In TCA section "types" a new array "columnsOverrides" is introduced that allows overwriting some column configurations of fields. Currently, this works for some View/FormEngine related settings like renderType and defaultExtras. * TCA Migration is introduced to dynamically rewrite TCA before it is put into cache. * TCA migration is called a second time in ext:compatibility6 in case TCA is still registered via ext_tables.php. This has performance penalty since it is done on every frontend and backend call. * TCA migration is also called dynamically for flex form definitions. * TCA migration moves configured t3editor wizards to type=text with renderType=t3editor. * TCA migration removes the 5th parameter "style pointer" from types showitem * TCA migration moves the 4th showitem parameter "extra configuration" to "defaultExtras" of "columnsOverrides" of given TCA type. Change-Id: Ia2c2bc16463a01021c7a6be765b4efa872a130fd Resolves: #67229 Releases: master Reviewed-on: http://review.typo3.org/39662 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
Frank Nägler <typo3@naegler.net> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 18 May, 2015 2 commits
-
-
This patch resolves it for all FormEngine related classes. Resolves: #66635 Releases: master Change-Id: I436e8990aa3c003dd5005937a429168825b56fb5 Reviewed-on: http://review.typo3.org/39037 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Creation of container and elements instances in the FormEngine is hard coded and hard to overwrite or adapt. The patch extends the existing NodeFactory with resolver code to find an appropriate class for a given requested type. All FormEngine internal container and element requests are now routed through NodeFactory. This allows to loosen the strict dependency between TCA config "type" to an implementing class by moving the resolving code into the factory. This is done for SelectElement which is now split into multiple smaller classes - one for each display type. The NodeFactory is covered by unit tests since the resolving code will become more complex and fine grained in the future. As a side effect the patch resolves a hack in the FormDataTraverser which no longer calls internal stuff of the select element. The NodeFactory is prepared to be extended with an API for extensions to steer and overwrite default implementations. This will be added with a next patch. Change-Id: I2253a0fe3240366d0d271a3cd82119ce3dc52012 Resolves: #67006 Releases: master Reviewed-on: http://review.typo3.org/39517 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 11 May, 2015 1 commit
-
-
Christian Kuhn authored
Data submitted by FormEngine to DataHandler is prefixed in four different ways: * data - Transferred data * cmd - A dataHandler command to execute * data_files - Contains uploaded files * action[control] - Overwrite fields data for NULL handling These four prefixes are given along from FormEngine to the whole container and element structure and never change. To simplify this stuff, the patch removes the prefixes and hardcodes them, and introduces a new globalOptions $elementBaseName that contains the stuff behind the prefixes. Quite some methods can be simplified this way and become more obvious. Usage of $elementBaseName will be extended with the next patch. Change-Id: I8103b1d2068382e0b01bbe5d9bd79aeba2d00b08 Resolves: #66894 Releases: master Reviewed-on: http://review.typo3.org/39462 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 28 Apr, 2015 1 commit
-
-
Christian Kuhn authored
This patch introduces a structural code refactoring to the FormEngine class and its related friend classes. FormEngine used to call itself over and over again with itself and sub classes writing to public properties of FormEngine keeping a global state that is then magically merged to sometimes working output. The patch introduces a tree approach with lots of small containers doing an encapsulated part of the rendering process and calling sub containers for inner details. As main construct a "globalOptions" array is modified in containers and given down to sub containers (tree knots) or elements (leaves), while sub structures always return a defined array that is merged by the parent and accumulates the full result. Goal is to have a better encapsulated code structure with better visible impact on changes done to this system. The patch creates this main structure. There is still a lot of mess around and additional patches can further improve the overall situation with smaller changes. Change-Id: I56b898dc0eaae8de4d31016997cfefe8d14ec53e Releases: master Resolves: #63846 Resolves: #63854 Resolves: #63856 Resolves: #63858 Resolves: #63859 Resolves: #63860 Resolves: #63861 Resolves: #63862 Resolves: #63863 Resolves: #63865 Resolves: #63876 Resolves: #63881 Resolves: #63882 Resolves: #63883 Resolves: #63893 Reviewed-on: http://review.typo3.org/38433 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-