This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 28 Jul, 2021 1 commit
-
-
Due to several modules initializing tooltips, it might happen that they are initializing the same element twice or even more times. This can be easily avoided by using the new bootstrap Tooltip method "getOrCreateInstance". This should fix weird behaviour, where the tooltip did not disappear. Also, since updating to a newer bootstrap version the fix 0005bc5b did not work anymore. This is fixed by using the container context as selector basis. Resolves: #94477 Releases: master Change-Id: Iea67db7fe63825f2eba028302d435cf7e2c8e7b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70119 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 21 Jul, 2021 1 commit
-
-
Since #93892, clearing the search field did not longer submit the form. This is now fixed by adding a dedicated JS module, listening on the browsers "search" event. When using the search in the Record selector, the search options dropdown is now not longer cut off, in case no search results are present. Additionally, the functionality to toggle the search field in the recordlist module is now moved into the Recordlist JS module, as it does not belong to EXT:backend and furthermore does not require a dedicated JS module. Resolves: #94463 Resolves: #94557 Releases: master Change-Id: I504a27fc6cb3d3689555169ac3e39813e2029544 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69830 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Jul, 2021 1 commit
-
-
The column names, defined in backend layouts, were not properly encoded at some places and therefore led to a XSS vulnerability. The issue is addressed by properly encoding user input. Resolves: #93683 Releases: master, 11.3, 10.4, 9.5, 8.7 Change-Id: I787cee9f56a30aeaf69294412c8d5198a144e31c Security-Bulletin: CORE-SA-2021-011 Security-References: CVE-2021-32669 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69993 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 12 Jul, 2021 2 commits
-
-
Benni Mack authored
Due to the change of scalable SVG icons the tree actions for selecting actions in the Page Selector / File Selector were not rendered again. This change fixes the issue by properly using a SVG inside another SVG again, just like with icons of the actual tree. Resolves: #94545 Releases: master Change-Id: I7bfae2e422adce6fd07eed46a26e8ab9767f12a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69814 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
With the upgrade to Bootstrap 5, the CSS classes for setting a tab's state need to get applied to the anchor element, which was not the case for the CE wizard filter. This patch fixes the behavior by applying the classes to the correct elements. Resolves: #94512 Releases: master Change-Id: I034e12d7cc7553aeb89c33d063efffb6651fc40d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69766 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 09 Jul, 2021 2 commits
-
-
The validation is already done in the FormEngineValidation on load. In the method loadDataAfter the tree nodes are not yet loaded for whatever reason and thus the validation always fails if having minitems set. Resolves: #94466 Releases: master Change-Id: I47b0c3bcbb64887239ba30b1a56fbc5681072120 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69731 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
To reduce the amount of inline JavaScript corresponding `window.open` occurrences are removed from TYPO3 backend user interface: * Backend Login refresh handling + tests checking for arbitrary inline JavaScript were removed * ViewPage page preview * FormEngine + "open in new window" button in top right bar + close behavior when editing form in new window Resolves: #91815 Releases: master Change-Id: I39c9c0350a0bdcf22b12bb6dba8fee8e9a03e315 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65050 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 29 Jun, 2021 3 commits
-
-
The switch user handling was previously placed in EXT:beuser, more precisely in the BackendUserControllers' indexAction. It was therefore necessary to link to the extbase based controller with a mix of prefixed arguments and the non prefixed "switchUser" argument. Latter was internally evaluated with GU:_GP(). This means, switching users was done via GET requests in an extbase action, but only in case a non extbase prefixed argument was set. In #94209 this got worse when the BackendUserGroupController was merged into BackendUserController. Since this controller features a "remember my last action" functionality, switch user could no longer reliably be triggered. The evaluation of the non extbase prefixed "switchUser" argument only took place in the "user listing" (indexAction) and the success of the call therefore depended on the users' last called action, as this action was automatically used. This patch now extracts the switch user functionality from EXT:beuser into a dedicated EXT:backend controller, featuring two ajax routes "/switch/user" and "/switch/user/exit". Both accessible via POST requests only. To trigger those requests, a new JS module "TYPO3/CMS/Backend/SwitchUser" is introduced. This also allows to completely remove the logout hook by using the concrete markup (custom element) for the "exit" button. Resolves: #94426 Related: #94209 Releases: master Change-Id: I556b323fe6ae77cf696e7e34dbbe269eb4f9927a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69635 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
This patch removes the last remains of sys_language in the site configurations' TCA. Therefore, the TCA of `site` and `site_langauge` is changed to always retrieve possible site languages via an itemsProcFunc, instead of using a relation to sys_language. As new site languages now have to be created in the module directly, a new internal TCA type "siteLanguage" is introduced. The new type behaves similar to type "inline", but contains some necessary features, e.g. unique record selector box next to a "create new" button, which are not available in type "inline". Also some not needed functionality is omitted. Instead of the sys_language records, all available site languages from all existing site configurations are now presented in the selector box. On selecting one of them, a new site language record is created, with most of the fields pre filled. Resolves: #94399 Releases: master Change-Id: I60ac5b4259aa3c9d90a4aba9881bc1dc2341b464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69188 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
A click on "Image Processing", "Configure Installation-Wide Options" or "Configuration Presets" in the install tool returns an error in PHP8. Add fallback for unefined array keys to workaround the array undefined key warnings. Add acceptance tests for InstallTool -> Settings module to make sure settings of each card can be loaded and saved. Resolves: #94425 Releases: master Change-Id: Icf3b11b0e4c490f8054605cd531f77906dfa7ac6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69633 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 14 Jun, 2021 1 commit
-
-
Bootstrap beta3 introduced a regression, which reversed the slide direction. This therefore broke our implementation, since we are using an event listener, evaluating the direction. Because we were not aware of this being "just" a regression instead of an intended API change, we switched the direction in our event listener in #94037, too. In the final 5.0 release, we updated to in #94089, the regression has been fixed, breaking our event listener once again. This is fixed by restoring the initial and correct direction check. Related bootstrap PRs: - https://github.com/twbs/bootstrap/pull/32913 - https://github.com/twbs/bootstrap/pull/33499 Resolves: #94338 Releases: master Change-Id: I0bc4dc2dfd37935fc43e04f311bd850916c31004 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69486 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 11 Jun, 2021 1 commit
-
-
All tables were previously wrapped by one form in the recordlist. Since #94218 this leads to problems because all tables now define another form for the "Show columns" selector. Nested forms are invalid markup. Therefore, effectively only the first table was wrapped by the general form. The remaining tables were not longer wrapped into a form, leading to problems when using the clipboard actions. This is now fixed by replacing the all-embracing form with dedicated forms for each displayed table. Besides fixing the mentioned problems, this change results in further improvements: * The forms are now dedicated to their table * The "Show columns" selector does not longer need to define a form itself * When updating the "Show columns" selection or when executing a clipboard action, the recordlist jumps to the correct table after reload, using an anchor tag * The clipboard related JavaScript can be simplified in an follow-up patch Resolves: #94302 Related: #94218 Releases: master Change-Id: Ib57abfe7bc9a2c9b6b3919a9ec78c25a87b8f08a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69453 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 10 Jun, 2021 1 commit
-
-
Usage of FriendsOfTYPO3/rsaauth is pretty low and there is no reason to support the extension any more in TYPO3 11. This patch removes all ext:rsaauth related code. Resolves: #94279 Releases: master Change-Id: I8e318bcc3c04fcc66a033507d0dddb931529c17d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69397 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 08 Jun, 2021 1 commit
-
-
Atfer a lot of preperation in #93048 and #93988, it's finally possible to share URLs to TYPO3 backend modules. Even special modules such as FormEngine. To ease the use for editors, the ShortcutButton is extended for a new option. If enabled, which is the default behaviour, the shortcut button in the module header is replaced. The new button allows to open a dropdown with the additional possibility to copy the URL of the current page to the operating systems' clipboard. Next to the already exisiting "Add shortcut" option. Since those URLs should not contain the user specific token, the UriBuilder features a new constant "SHAREABLE_URL". If set as $referenceType in one of the supporting methods, e.g. buildUriFromRoute(), an absoulte URL without the token is returned. To copy the URL to the operating systems' clipboard, a new web component "CopyToClipboard" is introduced. This component is added without any dependency to the URL sharing functionality and can therefore be freely used for other backend components as well. For the new button, the font awesome "share-alt" icon is registered in the IconRegistry. Resolves: #93921 Releases: master Change-Id: Id1dcfe1f2af764fbe000659ddb49a7369322d5b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69338 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 07 Jun, 2021 1 commit
-
-
Oliver Bartsch authored
The translation mode buttons in the localization wizard are now translatable as the rest of the wizard. Resolves: #94277 Releases: master, 10.4 Change-Id: Ie2bbaebbcf5c701a8e3446a3406dece565c2013b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69405 Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
- 01 Jun, 2021 2 commits
-
-
In order to determine whether HTTP referrer headers would be submitted to server-side backend API, a corresponding "reload" was triggered for the backend's main login form. Since the behavior resulted in reduced user experience, the refreshing mechanism was replaced by an equivalent AJAX endpoint and request. Resolves: #92293 Releases: master, 10.4, 9.5 Change-Id: I745d266a97135496276437b8eaf9dd206bc5806e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69336 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Currently the preview of the generated code for a backend layout uses only <code> tag. To streamline the ui this will use the t3editor if installed to display the generated code Resolves: #94222 Releases: master Change-Id: I1df1d03af120c50662ec5806c067b9af49c85dc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69308 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 30 May, 2021 1 commit
-
-
The modal stack handling is slightly changed to update the instance stack when a modal was requested to get closed already and not once a modal has been destroyed anymore. This fixes an issue in case a closing modal triggers a new modal which resulted in the new modal being broken. Resolves: #94219 Releases: master, 10.4 Change-Id: Idbc16ac08e95d8b3fed896783672b58ff062cafe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69305 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 27 May, 2021 1 commit
-
-
Bootstraps modals are not designed to have multiple instances opened at once, which was workarounded in TYPO3 a while ago. If a modal overlays another modal AND is smaller, its backdrop does not overlay the "lower" modal due to hardcoded z-index values. With this patch the z-index of both, the modal and its backdrop are re-calculated depending on the amount of open modals. We use "1000" as an overall base to circumvent a stuttering UI as Bootstrap uses a z-index of "1040" for backdrops on initial rendering. However, this will clash again when at least four modals are open, which is fine and should never happen - if it does, it at least reveals a bad UX. Resolves: #94155 Releases: master Change-Id: Ia15d0cdba903d9ec6a9ebe8518b07daf5e52e59f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69181 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 26 May, 2021 1 commit
-
-
With the introduction of the new backend module web component router, the title of the backend windows will be set to the title of the main iframe. Most of the modules didn't provide a proper name though. For most modules we have a proper name now which will show up in the title of the backend window, if no title is propagated by the module, the backend router will fallback to the default backend title. As the format of the title is quite "personal". If you are used to have opened more TYPO3 backend windows, you would like to see which installation you have open. If you only work in one backend, you might want to see on which module you are currently working. It is possible to set the order of the title of the backend within your user settings now. By default it will be title - siteName [version] Resolves: #94182 Releases: master Change-Id: I02602650370140217aa252bbd8e29ea4e05d994a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69172 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 19 May, 2021 1 commit
-
-
Benjamin Franzke authored
This change performs the following optimizations: * Detach spinner from content flow using a relative+absolute position normalization, allowing an equivalent positioning to the regular backend icons. This is to ensure that both, <typo3-backend-spinner> and <typo3-backend-icon> render equally when used in inline(-block) containers (for example .svg-toolbar__drag-node). <typo3-backend-spinner> used to cause vertical alignment offsets, when the spinner was positioned in inline text-flow and therefore caused the vertical flow to cause offsets. * Add a variant="light|dark" attribute to select between the available TYPO3 spinner variants. By default the current color is now used. * Adapt sizing to inherit size from current font-size when used without a specific size attribute. Also apply that to the backend icon component to stay interchangeable. * Render spinner via SVG and only animate the spinning part instead of the entire shape. This is to avoid the bouncing-icon effect that CSS animations on the entire element cause (as often seen with font-awesome spinners for example). Releases: master Resolves: #94149 Change-Id: I00d2e4915a0644726f78abe485fd9e276b539259 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69162 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 17 May, 2021 1 commit
-
-
Benni Mack authored
When using Drag+Drop in Page Module a different functionality is used than using Clipboard (Move+Paste) while moving a record in the page module. This results in a different behaviour when dealing in Workspaces. The patch uses the same "cmd" instead of "data" for DataHandler now for Drag+Drop than in Clipboard. Resolves: #92849 Releases: master, 10.4 Change-Id: Idb8566b166a18c514d149e53699489b7b9eb9247 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69137 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 May, 2021 2 commits
-
-
Executed command: yarn add "bootstrap@^5.0.1" Also, some minor coding issues were solved that popped up with the update. Resolves: #94138 Releases: master Change-Id: Ie80eff09efba43cfb9ae60862cb2167b0bc3f12f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69146 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
The SVG Tree now builds a SVG-in-SVG element around all icons (icon + overlay) to ensure the sizes are consistent and can be positioned properly. This fixes the issue that possible custom icons have a different size. Resolves: #86280 Releases: master Change-Id: Icf39e74c398d149a9216a64551bdeb250ed2bf00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69147 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 13 May, 2021 2 commits
-
-
Resolves: #94133 Releases: master Change-Id: I2101f3acc5c32c45efa3a8330bb7b6aa1d9716ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69138 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Andreas Fernandez authored
TCA's value picker uses a lot inline JavaScript for its picker handling, therefore, the handling has been moved into a dedicated web component. As a side-effect a bug in TextElement and InputTextElement is fixed. Both elements previously used exactly the opposite insert mode. Resolves: #94112 Releases: master Change-Id: Ib3a1f9697477cab4b9a00c606fcd0bd6524450b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69108 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 11 May, 2021 1 commit
-
-
Since the bootstrap v5 update, the inputLinkElement is styled with flex form instead of display table. This became a problem, because this broke the appearance of the explanation toggling. The initial idea to hide the complete clearable wrap didn't work properly as it is loaded dynamically and it's not ensured it exists when trying to hide it. To circumvent this problem, the styling is now done with some extra css. Additionally the wrong form-control class is removed from the clearable wrap and the styling is now also moved to own css. Resolves: #93941 Releases: master Change-Id: I0bb0d1cf26ed40dd3c87a58e08cc39e449b96c0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69064 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 03 May, 2021 2 commits
-
-
The MultiStepWizard has some obvious programming errors, which surprisingly didn't cause any problems in TYPO3 v10. It was built primarily with the multi step wizard of the form module in mind. This fact reflects on some parts of the code. As the direct commits to the module didn't change anything dramatically it's reasonable to conclude the bootstrap v5 update revealed the flaws. Most notably all 4 slides are now visible in the progress bar. Before only 3 slides were visible (Step 3 was overridden with finish). This patch fixes the prev and next logic to work properly with any size of slides in a clear and understandable way. Other notable changes: - The missing progress bar titles in the form module multi step wizard are added. - The jQuery slideUp and slideDown of the buttons when going back to the first step are removed as it serves no meaningful purpose. - The hard coded forceSelection change when switching to first slide (=true) and last slide (=false) is removed. Resolves: #94037 Releases: master Change-Id: I4f70dd30b3caf29a71491a69b18c6753666ccef4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68960 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Differentiate between tags 'a' and 'button' in the record list. An a-tag opens a page, a button triggers an action. Additionally the change includes 3 accessibility related issues: Implement browser "tooltips" (ie title attributes) on a-tags and button-tags as Bootstrap tooltips. Add aria-haspopup="dialog" on buttons that open a Bootstrap modal which are implemented as ARIA role dialog. Remove attribute role="group" from elements without accessible name. Resolves: #92652 Releases: master Change-Id: I685c7713edc4a4dfc6568c59c3e921ce951d26f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66237 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 02 May, 2021 1 commit
-
-
This fixes the popover position after clicking on a csh link. Side note: The popover loads in two steps: First it shows a "loading ..." text and when the content is fetched the popover must be updated. Before it was achieved by hiding and then immediately showing the popover again. This doesn't quite work with bootstrap v5 anymore. The popover is stuck in the middle of the process before the positioning applies. New method: Use the "setContent" method of the bootstrap popover instance. This method is not documented, but it can be used. Nevertheless we should keep an eye on that, as it's not public API. Resolves: #93984 Resolves: #93152 Releases: master Change-Id: If96028bd70bead243af1937cd2f87afed3b61c5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68962 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 01 May, 2021 2 commits
-
-
Benjamin Franzke authored
With the history-synchronization introduced in #93988, window.currentSubScript has been unconditionally overwritten after loading a new module in the content frame. This causes an empty currentSubScript string to be stored for secondary modules (modules not linked in the module menu), and results in subsequent faults, when currentSubScript is used to open a different page with the current module context. Releases: master Resolves: #94036 Related: #93988 Change-Id: Id957e72da5eb39437f35d19469dcdbd8a36c2b7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68959 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
The extension manager now provides a new module, which allows an integrator to display all available extensions with composer deficits, like missing composer.json or missing extension-key. The new module informs about the deficit and automatically generates a valid composer.json. proposal. In case no composer.json exists, the corresponding ext_emconf is sent to a new TER endpoint (https://extensions.typo3.org/composerize). This endpoint then generates a new composer.json proposal by resolving all dependencies. Furthermore, a new report is added to EXT:reports which also informs about such extensions by directly linking to the new EM module. This helps especially in non-composer-mode installations to ease the upgrade path for future TYPO3 versions which (hopefully) will rely on composer.json only for e.g. PackageStates.php. Resolves: #93931 Releases: master, 10.4 Change-Id: I1230363d5d03e03bff39e7070faf4e331532a292 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68778 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com>
-
- 30 Apr, 2021 1 commit
-
-
Benjamin Franzke authored
A custom Lit-based web componenent router is added which reflects module URLs into the browser adress bar and at the same time prepares for native web components to be used as future iframe module alternatives. Such modules will be implemented as JavaScript modules, that provide an implementation for a custom HTML Web Component. The first of such components (added within this change) is a wrapper component for traditional iframe-based backend modules. Module state changes are advertised via DOM events and propagated to the browser address bar, browser title, and the module menu. Adress bar updates ================== The module URL to address bar synchronisation enables sharable module deeplinks to be copied from the browser address bar. Whenever a component advertises a state change (e.g. iframe change), a sharable deep link is generated and shown in the browser adressbar. Technical preparation for the required deeplinking has been added with #93674. History Management ================== Browser history state is managed via the iframe history context of the content module frame (that is unlike other modern Single Page Applications which use history.pushState and history.replaceState). This approach required some synchronisation work, but there are technical limitations that prevent a combination of iframe history updates in combination for newer API like history.pushState. (The limitation is: state added by history.pushState is skipped by iframe history handling). The advantage of this compromise is: All "traditional" modules will preserve their state handling as before, no breaking/behavioral changes for iframe-based modules. Routing ======= The router uses two parameters to perform routing: * module – Module name as defined in ext_tables.php * endpoint – (json) api to be used by the component (= module URL) The module attribute is used to perform the actual routing to the respective backend module component, while the endpoint attribute serves as API to parse/fetch the state of the module. A named slot is used to switch between the available module components. That means only one of the routers childNodes will be visible at a time, while all modules are actively attached to the DOM. State is therefore preserved when switching between modules and the iframe is always kept active, allowing to act as history state-container (as described in "History Management"). Example of two modules that are attached to the DOM, where only <typo3-configuration-module> is visible as the <slot> in the shadow root puts a reference to this childNode: <typo3-backend-module-router module="system_config" endpoint="…"> #shadow-root <slot name="TYPO3/CMS/Lowlevel/ConfigurationModule"></slot> <typo3-iframe-module endpoint="…" slot="TYPO3/CMS/Backend/Module/Iframe"></…> <typo3-configuration-module endpoint="…" slot="TYPO3/CMS/Lowlevel/ConfigurationModule"></…> </typo3-backend-module-router> Note: The "TYPO3/CMS/Lowlevel/ConfigurationModule" component is not yet part of this commit, and only serves as an example (will be implemented later on). The slot name is resolved from the module key. Out of scope for this patch (will follow later) =============================================== * Link based routing interception via data-module tag for anchor tags. To be added as an additional convenience API on top of the router module and endpoint attribute (current API). * Convenience components for module layout * Integration into shortcut handler * Install-tool URLs do not reflect into addressbar right now Install-tool modules are redirected, therefore url updates can not be mapped as backend URLs right now Solution will probably be to integrate the install tool components as web component into the backend. Resolves: #93988 Related: #93674 Releases: master Change-Id: I682e89649b597c8c74b6a0a8f198f6bcf5bbc347 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67464 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 27 Apr, 2021 1 commit
-
-
TBE_EDITOR has some old code still managing FormEngine today, even with substitutions available since at least TYPO3 v7. This patch replaces the last occurrences of TBE_EDITOR.fieldChanged() and deprecates the method. Resolves: #93975 Releases: master Change-Id: I58b9e40284495a15e327d2ab2c8caaebc0107e95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68757 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
- 23 Apr, 2021 3 commits
-
-
Benjamin Franzke authored
Lit is the umbrella term for the next major lit-html (v2) and lit-element (v3) versions. Therefore we will refer to these components as *Lit* in TYPO3 from now on as well. These two libraries also have been migrated into a single entry point module named `lit`. It is officially described as: > The main module exports the core pieces needed for component > development: LitElement, html, css, and the most lit-html v2 and lit-element v3 are mostly compatible to the previous major versions. Main changes are * Deprecation of the `lit-element` entry point in favor of the new `lit` module * @internalProperty changed to @state * shadow css declaration via static property instead of static getter method * The CSSResult type declaration is gone * Directive (currently unused in TYPO3) API has changed Related testing framework change is: https://github.com/TYPO3/testing-framework/pull/229 Commands used: rm -rf typo3/sysext/core/Resources/Public/JavaScript/Contrib/{@lit,lit-element,lit-html,lit}/ yarn add lit@^2.0.0-rc.1 lit-html@^2.0.0-rc.2 lit-element@^3.0.0-rc.1 yarn add --dev rollup@^2.32.0 @rollup/plugin-replace grunt build git add typo3/sysext/core/Resources/Public/JavaScript/Contrib/{@lit,lit-element,lit-html,lit}/ composer require --dev typo3/testing-framework:^6.8.1 composer require --dev typo3/testing-framework:^6.8.1 \ --no-update --working-dir=typo3/sysext/core Resolves: #93965 Releases: master Change-Id: I9b659d851e6ad9dc3cc649bd40aab886b86fb0f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68104 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Will hide all tooltips when scrolling in the page tree panel to avoid multiple tooltips to show up and get stuck on screen Resolves: #87496 Releases: master Change-Id: Ie4be5c0cc9df01b26c658ac02ddcfdf2a2102c77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68839 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
This change re-adds the highlighting of filter results in the Svg Trees, which was present before in the Page Tree before it was built on SVG. Due to the nature of SVG, it is rather complicated to color the actual background of the text than the text itself (using <tspan>), but still, the highlighting is IMHO better than having no highlighting. Resolves: #87743 Releases: master, 10.4 Change-Id: Ie37173149c8f9388194e63a07ae89eb2fc774f30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68835 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 22 Apr, 2021 1 commit
-
-
Benni Mack authored
This change adds a <rect> element inside the icon group for making the icon better clickable. Resolves: #87453 Resolves: #93284 Releases: master Change-Id: I17a70cc0cf6bdf466c710a3599d3ede87fda700d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68800 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Apr, 2021 2 commits
-
-
This change limits the GET request for the PersistentStorage to only "get" and "getAll", where as the others are only working for "post". Since this logic is encapsulated properly in the Persistent JavaScript API, no other parts are affected. Resolves: #93948 Releases: master Change-Id: I965ea4552671c743cabed10c4cd8ad7275532420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68715 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Allow a user to move a folder into a folder on the same level and prevent moving a folder into its child folder. Resolves: #93954 Releases: master Change-Id: I444a87e862075ecd0a3e54ce5afd02314b1931c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68833 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-