Skip to content

GitLab

Switch branch/tag
This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
  1. 30 Jul, 2021 1 commit
  3. 28 Jul, 2021 2 commits
  5. 27 Jul, 2021 1 commit
  7. 26 Jul, 2021 1 commit
  9. 22 Jul, 2021 1 commit
  11. 21 Jul, 2021 2 commits
  13. 20 Jul, 2021 2 commits
  15. 19 Jul, 2021 1 commit
  17. 16 Jul, 2021 1 commit
    • Oliver Bartsch's avatar
      [TASK] Clean up Permission controllers · 6d956e81
      Oliver Bartsch authored and Benni Mack's avatar Benni Mack committed 
      The PermissionController was previously handled
via extbase, even though no pure Extbase-related
feature (validation, type-converting, persistence)
was used. Furthermore a combination of non-extbase
arguments and extbase-prefixed arguments was used,
leading to a couple of GeneralUtility::_GP() usages.

To clean up the controller, it is now not longer
registered as extbase module, while keeping
the module name "system_BeuserTxPermission"
for backwards-compatibility reasons.

Furthermore, is the PermissionAjaxController,
used for inline updates in the tree view,
moved into the PermissionController. This
allowed to streamline and clean up its only
endpoint.

Besides the clean up, some things got improved,
e.g. the shortcut button does now also take the
current action into account and all used labels
can now be translated.

Resolves: #94564
Releases: master
Change-Id: Ic03e341df5b69aa154be1a5b737df2eecc433e55
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69893

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Jochen's avatarJochen <rothjochen@gmail.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Jochen's avatarJochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      6d956e81
  19. 14 Jul, 2021 2 commits
  21. 12 Jul, 2021 5 commits
  23. 10 Jul, 2021 1 commit
  25. 09 Jul, 2021 6 commits
  27. 08 Jul, 2021 2 commits
    • Benni Mack's avatar
      [BUGFIX] Allow proper back-linking in File List · 1eda4529
      Benni Mack authored 
      The File List now creates links through
the UriBuilder, allowing to use actions (such as rename)
while then keeping search parameter, or pagination parameters
properly.

In addition, some code is now cleaned up and streamlined (e.g.
the styling of the buttons in the "multi-clipboard mode" is now correct).

Resolves: #94506
Releases: master
Change-Id: I0cf7dde9e94738b124818de724ec5e47dc1a8ac0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69761

Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Jochen's avatarJochen <rothjochen@gmail.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen's avatarJochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      1eda4529
    • Oliver Bartsch's avatar
      [TASK] Unify code in FileList · cdc6b71f
      Oliver Bartsch authored 
      Currently, the Backend module File > FileList
has two main views:

* The list view
* The search result view

Both are handled via an Extbase controller, even
though no pure Extbase-related feature (validation,
type-converting, persistence) is used.

Instead, the list view is generated by a PHP-based
code "FileList" (similar to DatabaseRecordList),
where as the search result view is built on top of
Fluid. The latter approach hinders flexibility,
and also leads to inconsistencies, due to the nature of
using two different approaches.

Most notable:

- The search result view looks different than the
  list view, also no additional icons are possible.

- The search result view has a clipboard, but does
  not allow to expand.

- The search result view does not respect the listing
  limit, nor is the pagination displayed.

- The search result view changes the module headline
  to "Search: <word>", removing the context on
  which folder the search was performed.

However, the search result view works with the
SearchDemand object which is a clean way to
put the query requirements into the File List
to render the found files.

Therefore, this patch merges both Search Result Fluid
view and PHP-based view back into one, more flexible
and consistent, view. This also means, FileListController
is not longer registered as an Extbase backend module
and some internal ViewHelpers and classes were removed.

The main benefits:
* Exchanging features between DatabaseRecordList and FileList
  are easier to achieve
* Hooks for additional icons also work in the search result view
* Numeric Clipboards also work in the search result view
* Buttons in each found file row look the same now
* The current folder is now also displayed in search result view
* Bookmarking also works properly now and additionally
  also takes a possible searchTerm into account
* The search results are now paginated, respecting the
  listing limit
* Invalid folders do not longer lead to an exception
  in the search result view

Resolves: #87974
Resolves: #89867
Resolves: #92247
Resolves: #92747
Resolves: #93185
Releases: master
Change-Id: I259fe7f63ef8ea69f6bdf0c787330f4338d4bd5a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69718

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Jochen's avatarJochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Jochen's avatarJochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      cdc6b71f
  29. 06 Jul, 2021 1 commit
  31. 05 Jul, 2021 3 commits
  33. 01 Jul, 2021 2 commits
  35. 29 Jun, 2021 4 commits
  37. 27 Jun, 2021 1 commit
  39. 24 Jun, 2021 1 commit