This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 29 Jul, 2021 1 commit
-
-
This change migrates $result->fetch() methods to $result->fetchAssociative() and $result->closeCursor() to $result->free() methods. Since TYPO3 uses fetchMode "associative" by default when setting up the connections, this change is another step towards Doctrine DBAL 3.0 compatibility. Resolves: #94659 Releases: master Change-Id: Idce7c8466925a6e58059e7e16ebc3ffe35ca6fa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70125 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
-
- 28 Jul, 2021 1 commit
-
-
Since TYPO3 uses the \PDO::FETCH_ASSOC fetch mode by default, fetchAll() is the equivalent for fetchAllAssociative() which is the new API for Doctrine 3. In order to move towards the new Doctrine DBAL 3.x API, this change migrates all fetchAll() calls to fetchAllAssociative() or fetchFirstColumn(). Resolves: #94618 Releases: master Change-Id: I2ab4db871d0b65ad07e629b54bb79b1c3b411005 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70016 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 22 Jul, 2021 2 commits
-
-
Christian Kuhn authored
The class logs a deprecation in __construct(), but the @deprecated annotation is missing. Unit and functional tests of QueryGenerator are moved now and a PHP8 related patch that has been done to core QueryGenerator is now merged into lowlevel QueryGenerator, too. Resolves: #94587 Related: #92129 Releases: master Change-Id: Ibb59c6bf576c6589a1cbb654ebd4773065b3e8c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69962 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
This change replaces all query results from the database from fetchColumn() to fetchOne(), as this is the new API used in Doctrine DBAL. This change is one of a few to prepare for Doctrine DBAL 3.0 compatibility. Resolves: #94605 Releases: master Change-Id: Ia9ca2bbb7b2c16a230c5946941cc3023203f494d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69917 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
-
- 20 Jul, 2021 1 commit
-
-
Properly encodes error messages to be used in HTML output in "EXT:lowlevel" Query Generator and Query View components. Resolves: #93868 Releases: master, 11.3, 10.4, 9.5 Change-Id: I05812ac7c1cded39edbf10d50bb4dc0fd8faf577 Security-Bulletin: CORE-SA-2021-010 Security-References: CVE-2021-32668 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69992 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 12 Jul, 2021 1 commit
-
-
Due to refactoring or very old code some places in the core define unused variables or variables, which are immediately overridden. They are mostly unnecessary. Even in places, where they might be slightly helpful if defined at the beginning of a function, the benefit doesn't excuse the existence. Resolves: #94528 Releases: master Change-Id: I6071bb0bc96472a4b4b7f679bfabbacfb761f472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69805 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 08 Jul, 2021 1 commit
-
-
Add fallback for undefined array keys to make "DB Check" compatible with PHP8. Also basic tests have been added to check each page in the module. Resolves: #94498 Releases: master Change-Id: I98a598d0e809077cd89e7620efe31a498b3fbfa1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69759 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
- 17 Jun, 2021 1 commit
-
-
EXT:lowlevel EXT:recordlist EXT:recycler EXT:reports EXT:rte_ckeditor Resolves: #94265 Releases: master Change-Id: I4e5e94f3e9f041e4ee8bab93a7ced73077250ee9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69371 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 12 May, 2021 1 commit
-
-
in * EXT:workspaces * EXT:tstemplate * EXT:setup * EXT:scheduler * EXT:recycler * EXT:lowlevel * EXT:linkvalidator * EXT:install * EXT:info Releases: master Resolves: #94121 Change-Id: Idb153afd9763cd9c3238be68d2290bde68e88b35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69038 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 04 May, 2021 1 commit
-
-
Oliver Bartsch authoredImproves the overall look and feel of the filters in various backend modules, thanks to the new bootstrap v5 grid. We can therefore now rely on flex-form instead of float technology. By using the `g-X` gutter classes and the `align-items-X` arrangement classes, we ensure the positioning and spacing is the same in each module. This allows to effectively remove the `form-inline-spaced` class since this can easily be done with flex-form and the mentioned classes in bootstrap v5. Adjustments done: * Use of flex-form to align and position form fields * Add missing labels and unify arrangement * Adjust size and position of form components * Unify select field size * Unify search field display * Unify submit and reset button styles Resolves: #94042 Resolves: #94026 Releases: master Change-Id: Iae95a3e90179c6708ce6e1f0f272f267b6cae645 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68926 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
-
- 19 Jan, 2021 1 commit
-
-
This change uses Twitter Bootstrap 5 usages across TYPO3 Backend, and fixes the toggle / icon toggle switch. Now the bootstrap-5 based toggle (form-switch) is used, and can be modified easily with a custom SVG later-on, but is kept as is for now, in order to make sure it is used consistently everywhere. Resolves: #93310 Releases: master Change-Id: If52d06932e1ee087d9c7d76cfb7d0f0c0e92276a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67461 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 07 Jan, 2021 1 commit
-
-
If a reqest object already is around, $request->getAttribute('normalizedParams')->getRequestUri() can be used as a drop in replacement. As a fallback $GLOBALS['TYPO3_REQUEST'] is almost always available and contains the request object. Resolves: #93178 Releases: master Change-Id: I2bb13a54e6b8705be5783042a4f67f9735c627a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67255 Tested-by:Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 04 Jan, 2021 1 commit
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
-
- 14 Dec, 2020 1 commit
-
-
In preparation for Doctrine DBAL 3.0, 1. all usages of Doctrine\DBAL\DBALException have been migrated to Doctrine\DBAL\Exception, because DBAL Exception does not exist in Doctrine 3.0 anymore. 2. Doctrine\DBAL\Platforms\PostgreSqlPlatform has been migrated to Doctrine\DBAL\Platforms\PostgreSQL94Platform because this class does not exist anymore in Doctrine DBAL 3.0, same goes for Doctrine\DBAL\Platforms\SQLServerPlatform which has been replaced by Doctrine\DBAL\Platforms\SQLServer2012Platform 3. Doctrine\DBAL\Driver\PDOException has been renamed to Doctrine\DBAL\Driver\PDO\Exception 4. Doctrine\DBAL\Driver\PDOStatement has been renamed to Doctrine\DBAL\Driver\PDO\Statement Resolves: #93071 Releases: master Change-Id: I05e82f2fca09eb7718a90c09f95e503980ae10ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67109 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 26 Nov, 2020 1 commit
-
-
The global configuration option, which is always active by default, restricts ALL non-administrators to be locked in to their webroots (DB mounts). Disabling this option would allow any editor to see the whole page tree, overriding most of the concepts used in TYPO3 Backend and permission handling. As stated in the description of the option, it is highly recommended for security reasons to leave this option enabled. This option is removed to streamline TYPO3's permission handling. Resolves: #92940 Releases: master Change-Id: I15f6538bdb34077a99cb8d2db7a21e60492bb923 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66908 Tested-by:
-
- 09 Oct, 2020 1 commit
-
-
If the configuration `['BE']['debug']` is enabled and the current user is an administrator, the name of a DB table or DB field is appended to the select options in the "Full Search" module of ext:lowlevel. Resolves: #92522 Releases: master Change-Id: I1da79ac49f7d9b7c4890d3ebc0141f48b89ff00d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66089 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- 06 Oct, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Resolves: #92171 Releases: master, 10.4 Change-Id: I814aa008b102121359146c2d32da967965f96b30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65907 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 31 Aug, 2020 1 commit
-
-
The classes QueryView and QueryGenerator in the core extension are detail implementations of the databases search functionality of the lowlevel extension. The patch merges both classes into one, moves it to the lowlevel extension and deprecates the old classes. Minor refactorings like protecting properties and methods is applied to the new class to enable further refactoring if desired. Change-Id: If8b16e8eeb39ed1e3d3aa52eed02b6c27a114e1a Resolves: #92129 Related: #92080 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65457 Tested-by:
-
- 25 Aug, 2020 1 commit
-
-
The nearly identical methods getTreeList() of core classes QueryGenerator and QueryView are standalone methods that do not depend on further state of those classes. Those classes mostly belong to the ext:lowlevel DatabaseIntegrityController as their main jobs. To allow further refactoring of them, the patch drops 3rd party usages in ext:extbase and ext:workspaces, and protects the methods in a backwards compatible way. The new implementations are slightly more effective by skipping string implode/explode operations. The extbase change is accompanied by a new functional test to drop two heavy mocking unit tests. Change-Id: I38bcb4c25da159a86055d007428634eecd0d2f67 Resolves: #92080 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65440 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 24 Aug, 2020 1 commit
-
-
With #82729 the $GLOBALS['SOBE'] = $this; assignment in DatabaseIntegrityController has been removed. This is a good thing, however parts of QueryGenerator class still relied on this. The patch gives the module settings that have been introduced for #83428 from QueryView down to QueryGenerator as well. This fixes a couple of details, most importantly the 'Show even deleted entries' checkbox of the full search advanced query view works again. Resolves: #92079 Related: #83428 Related: #82729 Releases: master, 10.4 Change-Id: If8b5ef9e2d86910625455e37d029c5e93e5ef519 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65439 Tested-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 23 Feb, 2020 1 commit
-
-
Resolves: #90499 Relates: #90491 Releases: master Change-Id: Ib2a3f53b88f4a19da0ca2d115114278ddd628f60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63383 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Susanne Moog <look@susi.dev> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Ingo Fabbri <ingo.fabbri@gmail.com> Reviewed-by:
-
- 22 Feb, 2020 1 commit
-
-
This patch cleans up stylings across various modules and streamlines the used markup as well as the folder structure. Resolves: #90491 Releases: master Change-Id: I7cf564da3e981f455c466dbc24a33858145525b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63362 Tested-by:
-
- 30 Dec, 2019 1 commit
-
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
-
- 18 Dec, 2019 1 commit
-
-
php bin/rector process Releases: master Resolves: #89807 Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448 Tested-by:Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
-
- 17 Dec, 2019 2 commits
-
-
Resolves: #89005 Releases: master, 9.5, 8.7 Security-Commit: 82656cf8149d04f31b1441a03415b5e9a067c614 Security-Bulletin: TYPO3-CORE-SA-2019-026 Change-Id: If312a53b24d919439fa70f5df96be383876957a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62720 Tested-by:
-
Resolves: #89452 Releases: master, 9.5, 8.7 Security-Commit: d73e50f02afc5459f737282ede6cc70579fe7181 Security-Bulletin: TYPO3-CORE-SA-2019-025 Change-Id: I55afb17f4b1509a3dfc945e28e5d35671f6c28f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62719 Tested-by:
-
- 27 Nov, 2019 1 commit
-
-
composer require --dev rector/rector:"^0.5.0" This commit introduces the requirement to rector/rector to automatically process code changes by given set of rules. To make this commit more meaningful, a first set "php53" has been processed. Releases: master Resolves: #89785 Change-Id: I6e2ff9654266458ae9fb6800547ff4712b0b66d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62437 Tested-by:
-
- 13 Sep, 2019 1 commit
-
-
Incoming field values are now also checked for being plain integers to be able to handle timestamps properly. Resolves: #89154 Related: #84588 Releases: master, 9.5 Change-Id: I220096faa563b3700eceb8a85839eed2a70d2170 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61670 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
- 11 Sep, 2019 1 commit
-
-
With the change in https://forge.typo3.org/issues/83675 every value could be converted into a unix timestamp, which leads to incorrect conversions in some cases e.g. if an interger value like a pid 5134 is passed to the method. Releases: master, 9.5 Resolves: #84588 Resolves: #85020 Change-Id: Id92367bae3085015399ed89531c019e8aacd6510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/56530 Tested-by:
-
- 23 Aug, 2019 1 commit
-
-
This patch replaces all usages of `strstr()` and its friends where the existence of a certain substring is checked, but the result isn't used at all with `strpos()`, which uses less memory. Resolves: #88922 Releases: master Change-Id: Ie45589ac9410e22e1b48e82dd8086eadb6d74107 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61445 Tested-by:
-
- 15 Jul, 2019 1 commit
-
-
The following database fields from "tt_content" have been removed: * tt_content.spaceBefore (now used via space_before_class) * tt_content.spaceAfter (now used via space_after_class) Resolves: #88744 Releases: master Change-Id: I2da1645b94b68fadb2945c2f1708809e2e9cbab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61286 Tested-by:
-
- 05 Apr, 2019 1 commit
-
-
Exception is thrown when changing the operator from an array handling one to a string handling. ("is in list" to "equals") Also the selection is not set properly after changing. Resolves: #88010 Releases: master, 9.5 Change-Id: Ibf7f607a51ac92d2c45dbfe16384f71c959e6c1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342 Tested-by:Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by: Daniel Windloff Tested-by:
-
- 26 Mar, 2019 1 commit
-
-
Querying the database for the placeholder `--div--` is rather pointless, thus this possibility is removed. Instead, the placeholder is converted into an optgroup. Resolves: #87976 Releases: master, 9.5 Change-Id: I60729a3fae1bc37c12612fccf0f8491ad27d8908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60305 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- 15 Mar, 2019 1 commit
-
-
Replace string concatenations like 'abc' . 'def' with 'abcdef'. Resolves: #87004 Releases: master Change-Id: I9c1a610e88dd4bd4e617214989a915b1dafda094 Reviewed-on: https://review.typo3.org/c/60155 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- 11 Feb, 2019 1 commit
-
-
Used * composer update friendsofphp/php-cs-fixer --with-all-dependencies The new php-cs-fixer is compatible with PHP7.3+ and fixes some more issues configured according to our code style settings. Resolves: #87684 Releases: master, 9.5 Change-Id: Ibb2150eea173ded11495866aa171dd171aca7efd Reviewed-on: https://review.typo3.org/59677 Reviewed-by:
-
- 15 Jan, 2019 1 commit
-
-
With TCA type=group with internal_type=file and file_reference being dropped, the uploads/ folder is unused and obsolete. The patch drops further related code in this area, especially the ext_emconf.php property uploadsfolder is obsolete. It is dropped from all ext_emconf.php files together with its handling in extensionmanager. Change-Id: I93abc7d614b17adf4d0f2f896e346d3147c49472 Resolves: #87445 Releases: master Reviewed-on: https://review.typo3.org/59443 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- 19 Dec, 2018 1 commit
-
-
Removed classes: TYPO3\CMS\Backend\Module\AbstractFunctionModule TYPO3\CMS\Backend\Module\AbstractModule TYPO3\CMS\Backend\Module\BaseScriptClass Resolves: #87210 Releases: master Change-Id: I56c92246e7b18fd87707e767f743fd4c84f043a1 Reviewed-on: https://review.typo3.org/59208 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- 28 Nov, 2018 1 commit
-
-
Due to the removal of pages_language_overlay the queries for fetching trees have to work as before - mainly because the concept of the "pid" (= storagePid) works the same - records on a page have the pid of the default language, not of any translation. Therefore, the used queries have to be built to check for sys_language_uid=0. Resolves: #87020 Related: #86961 Releases: master Change-Id: Ie7740b6a32618a213d569362a58b9f8e5ed7824d Reviewed-on: https://review.typo3.org/58967 Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
