Commits · b6c2a5eac7ca90dec1d815e506b8ac6f0ad0f706 · accessibility / TYPO3.CMS

This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed Feb 20, 2022.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update Feb 18, 2022.

22 Jul, 2021 1 commit

[BUGFIX] Use ForwardResponse arguments if not null · b6c2a5ea

Alexander Schnitzler authored Jul 21, 2021 and

Christian Kuhn committed Jul 22, 2021

Issue #92815 introduced a regression which triggered an endless
recursion in case of a validation error.

A bit longer explanation:

Given there is an extbase controller action with an argument
whose properties have to validated, extbase maps the incoming
data of the request onto the internally handled arguments
object which then performs the validation on all given arguments.

In case of an error, extbase tries to redirect to the referring
request aka the current request with an updated set of arguments.
The idea is to remove all arguments of the current request to not
trigger the same validation error again on the next try.

There was a condition in the past which eventually led to the
overriding of current arguments which was refactored wrong.

The solution is to make the arguments of the ForwardResponse null
by default and have the same null check like before.

Releases: master
Resolves: #94457
Change-Id: I1701001ce0cf55df79b2ed896d69a08659a2902b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70020


Tested-by: core-ci <typo3@b13.com>
Tested-by: waldhacker <hello@waldhacker.dev>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: waldhacker <hello@waldhacker.dev>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

b6c2a5ea

05 Dec, 2020 1 commit

[FEATURE] Introduce ForwardResponse for extbase · 785ff682

Alexander Schnitzler authored Nov 07, 2020 and

Benni Mack committed Dec 05, 2020

This patch introduces a PSR-7 compatible response class
which allows users to initiate forwarding to another
extbase controller action.

Returning a ForwardResponse replaces the helper function
forward() in the ActionController.

Releases: master
Resolves: #92815
Change-Id: I37b40d9e3de1125c0173d2115e0224cb1b13dc2f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66564


Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Torben Hansen <derhansen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Torben Hansen <derhansen@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>

785ff682