Commits · b318751030453f80cdb5c09f110915e4020f9856 · accessibility / TYPO3.CMS

This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed Feb 20, 2022.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update Feb 18, 2022.

29 Jul, 2021 11 commits

[BUGFIX] Fix sphinx warnings in previous changelog entries · b3187510

Lina Wolf authored Jul 18, 2021 and

Christian Kuhn committed Jul 29, 2021

Fixes Layout problems: Malformed lists, malformed
headlines, non-working links to documentation or
other changelogs.
Directive `:ts:` and `.. code-block:: ts` is only
used for typescript, exchanged it into `:typoscript:`
for typoscript examples.

Resolves: #94534
Releases: master, 10.4, 9.5
Change-Id: I61e3c5910d6a5bc97f1ec887ce5b2c1e6d59a2db
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69922


Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

b3187510

[FEATURE] Find image resources in srcset attributes · bf8c6585

Stefan Neufeind authored Nov 22, 2015 and

Benni Mack committed Jul 29, 2021

Extend the HtmlParser to support srcset attributes, which can
be found in img tags or source tags inside of HTML 5 picture
elements, making it fully compatible with responsive images.

Change-Id: If47af154b059c0744c3d660c760fb2cc2d703aeb
Resolves: #71775
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/44901


Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

bf8c6585

[TASK] Synchronize core changelog files between v11, v10, v9 · 737af52d

Christian Kuhn authored Jul 29, 2021

The nifty ruleset for handling core changelog files described at
https://docs.typo3.org/c/typo3/cms-core/10.4/en-us/Changelog/Howto.html
sometimes gets violated by the one or the other patch.

This happens, so we occassionally synchronize Changelog
files between versions.

Resolves: #94668
Releases: master, 10.4, 9.5
Change-Id: Ia02af5909687a6f200257b791fee098ced7f32b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70154


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

737af52d

[TASK] Move a Changelog file to correct directory · 544c0da4

Christian Kuhn authored Jul 29, 2021

The patch for issue #91123 was originally planned for
having a v10 backport, but made it to master only and
has been released as 11.0.
The Important.rst file has been added to 10.4.x
directory, but it should reside in 11.0 directory.
Adapt that and fix a reference to it.

Change-Id: Ia28b3b7d75b27b5f2d1ccd2fe9ec77a767eaeeae
Resolves: #94667
Related: #91123
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70153


Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

544c0da4

[BUGFIX] Improve loading of related records in Backend UI · a22be10b

Benni Mack authored Jul 27, 2021 and

Christian Kuhn committed Jul 29, 2021

This change uses RelationHandler for foreign_table / allowed and MM
in BackendUtility::getProcessedValue in a consistent way.

In addition, the RelationHandler now fetches the full
record by default and adds this to the processed array, making
fewer queries to the database by fetching each record
fully directly.

Some bugs are fixed with that:
* FAL images (as in all inline fields) in list module now have the correct order
* Fewer DB queries when fetching relations in Group field in FormEngine

Setting the option in RelationHandler to fetch all fields by default
avoids unneeded calls in general when fetching the records.

Resolves: #94651
Releases: master
Change-Id: I8261a0c2657b9b71ae7cdc686ee43eaa7461c8b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70117


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

a22be10b

[BUGFIX] Skip range validation if input value and default are both "0" · 2d04af91

Nikita Hovratov authored Jul 23, 2021 and

Benni Mack committed Jul 29, 2021

This patch fixes a regression originally introduced in #94103. The
problem there was simply an erroneous strict comparison, which further
got completely removed in #94527 due to a misconception.

The mentioned condition is important for date type fields with a lower
range set in TCA. If the user doesn't provide a value for that date
field, the range validation should be skipped. Otherwise this empty
value would always be interpreted as 0, resulting the validation to
change it to the lower range value.

As this is a special case, the condition was extracted and rewritten,
to only apply for this exact scenario. Other than that the validation
should not be skipped.

An acceptance test and a unit test are added to ensure this behavior
can't break anymore.

Resolves: #94621
Related: #94103
Related: #94527
Releases: master, 10.4
Change-Id: I54c1a815077e48064f9f6eeba9584184c5f760d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70060


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

2d04af91

[TASK] Remove exclude setting from important fields · fdfed0d5

Georg Ringer authored Sep 09, 2020 and

Christian Kuhn committed Jul 29, 2021

To simplify setting up permissions the following fields
are now always shown to editors:

- 'slug' in table 'pages'
- 'colPos' in table 'tt_content'

Resolves: #92202
Releases: master
Change-Id: I854d03f8a4b7b56cb69bed0a914697201462939e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65687


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

fdfed0d5

[FEATURE] Add autocomplete attribute to PasswordViewHelper · 367424f3

Oliver Bartsch authored Jul 28, 2021 and

Christian Kuhn committed Jul 29, 2021

The PasswordViewHelper is extended for a new tag
attribute "autocomplete", which can be used to
instruct the users' password manager how to fill
the password field.

Resolves: #94653
Releases: master
Change-Id: I00941f3bb61624d405dcdd8a6af48777c3364d1b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70121


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

367424f3

[TASK] Doctrine DBAL: Use fetchAssociative() instead of fetch() · c975426b

Benni Mack authored Jul 28, 2021 and

Oliver Bartsch committed Jul 29, 2021

This change migrates $result->fetch() methods
to $result->fetchAssociative() and $result->closeCursor()
to $result->free() methods.

Since TYPO3 uses fetchMode "associative" by default when
setting up the connections, this change is another
step towards Doctrine DBAL 3.0 compatibility.

Resolves: #94659
Releases: master
Change-Id: Idce7c8466925a6e58059e7e16ebc3ffe35ca6fa6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70125


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

c975426b

[BUGFIX] Fix several PHP 8 warnings for non admin users · e5805210

Oliver Bartsch authored Jul 28, 2021 and

Christian Kuhn committed Jul 29, 2021

Resolves: #94652
Releases: master
Change-Id: I805352b13eae98fd207ca45bbade34c489cc4c6d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70120


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

e5805210

[BUGFIX] Extend settings ac tests to revert changes when done · 5e18c1c7

Jochen Roth authored Jun 30, 2021 and

Christian Kuhn committed Jul 29, 2021

Settings acceptence tests has been extended to revert
all changes done to the installer when the test finished.

On top of that the tests now verify the changed setting
by re-open the modal and compare the values.

Resolves: #94445
Releases: master
Change-Id: I94219db58cd624da2789e2cd5903a14f0091fd47
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69672


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

5e18c1c7

28 Jul, 2021 2 commits

[TASK] Raise typo3/cms-styleguide:~11.4.0 · fcf3b07f

Christian Kuhn authored Jul 28, 2021

Similar to styleguide's backend TCA data generator,
the extension can now generate a demo frontend to
render a page tree with menu having examples of
the default core content elements and demos for
ext:felogin and ext:form.
The generator is accessible through the existing
backend styleguide module below the '?' help button
in the toolbar.
The FE data will be used for core acceptance tests
soon.

The raise also brings a minor TCA change for a
pending core regression patch.

composer req --dev typo3/cms-styleguide:~11.4.0
composer req --dev typo3/cms-styleguide:~11.4.0 -d typo3/sysext/core --no-update

Change-Id: Ie1ef73400cda2b82c6379401341e69ff9e78645e
Resolves: #94658
Related: #94621
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70124


Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

fcf3b07f

[TASK] Migrate Doctrine DBAL fetchAll() to fetchAllAssociative() · cfb31933

Benni Mack authored Jul 21, 2021 and

Georg Ringer committed Jul 28, 2021

Since TYPO3 uses the \PDO::FETCH_ASSOC fetch mode
by default, fetchAll() is the equivalent for fetchAllAssociative()
which is the new API for Doctrine 3. In order to
move towards the new Doctrine DBAL 3.x API,
this change migrates all fetchAll() calls
to fetchAllAssociative() or fetchFirstColumn().

Resolves: #94618
Releases: master
Change-Id: I2ab4db871d0b65ad07e629b54bb79b1c3b411005
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70016


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

cfb31933

27 Jul, 2021 1 commit

[FEATURE] Allow icon identifiers in the report module registration · 2ea7f0c5

Nikita Hovratov authored Jul 19, 2021 and

Benni Mack committed Jul 27, 2021

To further streamline the usage of the IconRegistry, the reports
registration array now allows to define an icon identifier. Absolute
paths and paths with "EXT:" prefix are still possible.

Further improvements:
The IconViewHelper of the reports extension has been dropped. It had
the same functionality as a normal ImageViewHelper with the addition of
a fallback icon. This logic has been moved to the controller action.

Some minor code refactoring and template cleanup while at it.

Resolves: #94588
Resolves: #94590
Releases: master
Change-Id: I901b8a0c56f26459c609a36a59c67b341c6b4168
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69965


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

2ea7f0c5

26 Jul, 2021 3 commits

[BUGFIX] Cast $siteUrl to string · 906873a6

Jochen Roth authored Jul 23, 2021 and

Benni Mack committed Jul 26, 2021

In case substr returns false $siteUrl
is now casted to string and covered
by an additional unit test.

Resolves: #94624
Releases: master
Change-Id: Id778319104d107c329a2ee8f947571a87e3c401d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70059


Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>

906873a6

[TASK] Use Composer runtime platform check instead of our own · 4ab93f35

Helmut Hummel authored Jan 10, 2021

Several benefits come (basically for free) with this change.

1. We only maintain platform dependencies in composer.json
2. Advanced users can omit the runtime check from being generated
3. Relying on canonical functionality instead of our own

For this to work, Composer 2.0 must be required not only for
development, but also for any production install of the packages.

With doing so, eventually other runtime functionality like installed
package versions can be used as well.

composer req composer-runtime-api:^2.0

This also remove the upper version check for PHP <9
because Composer runtime API does not provide upper bound checks,
to allow future compatiblity of software installs, in case it isn't
updated any more, but would run with later PHP versions.

Upper PHP version check and failing with an appropriate error message
is useful for cases when users accidentally use a PHP version
higher than TYPO3 is capable of running on. However not only isn't
there a PHP version 9 on the horizon, it isn't even remotely clear,
whether this PHP version would have a compatiblity impact on TYPO3.

Therefore an upper version check at this point in time provides zero
value and can be safely omitted.

Besides that, also from a maintainer perspective it will be much easier
to check the impact on PHP 9 release candidates, because tests could be run
automatically against this version, without modifying the code, so that
compatiblity with this future PHP version can be provided ahead of time,
making the upper bound check obsolete as well.

Resolves: #93257
Releases: master
Change-Id: I55c0c17088f222736afa99d929fe8646a483a5ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67371


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>

4ab93f35

[TASK] Rename github.com/TYPO3/TYPO3.CMS to github.com/typo3/typo3 · 6aa3ebe0

Benni Mack authored Jul 26, 2021

The GitHub main repository has been renamed from "TYPO3/TYPO3.CMS"
to "typo3/typo3".

The new URL is https://github.com/typo3/typo3

This change reflects all places in TYPO3 Core to adapt to this
renaming.

Resolves: #94639
Releases: master, 10.4, 9.5
Change-Id: Ia5c3136a48b8b4580283277da4b7b11768c32132
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70092


Tested-by: core-ci <typo3@b13.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Benni Mack <benni@typo3.org>

6aa3ebe0

23 Jul, 2021 2 commits

[TASK] Deprecate extbase ObjectManager · 5c8d0397

Christian Kuhn authored Jul 22, 2021

With all non-legacy usages of ObjectManager being gone,
this final patch adds a series of @deprecation annotations
throughout the core, adapts some comments, and finally
adds a trigger_error() to ObjectManager->get().

Resolves: #94619
Related: #90803
Releases: master
Change-Id: Iaa65f7dee4e5aa9eb4e2c217e76105b0263dc6dc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70054


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

5c8d0397

[BUFIX] Set fallback for undefined array keys in PHP8 · 6e75da76

Jochen Roth authored Jul 22, 2021 and

Benni Mack committed Jul 23, 2021

Fix undefined array keys in form, core and
indexed_search for the frontend and in
extensionmanager.

Resolves: #94613
Releases: master
Change-Id: I96230feb46f33c9a606a72f765bc79e19d8b28dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70024


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

6e75da76

22 Jul, 2021 7 commits

[FEATURE] Use https by default when autolinking in RTE · 8cff525a

Benni Mack authored Jul 19, 2021 and

Christian Kuhn committed Jul 22, 2021

When using CKEditor with autolinking plugin enabled
(e.g. simply typing www.typo3.org in the RTE) https:// is
now used by default when a link is generated.

This change reflects the "secure-first" approach by
using https:// by default, however users can still manually
change this to http://.

More than 90% of the web now serve via HTTPS
(also see https://transparencyreport.google.com/https)

Resolves: #90336
Releases: master
Change-Id: I38e4034915f66fd1f169bc96f27026a6427de156
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69923


Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

8cff525a

[BUGFIX] Correctly resolve arrays in log messages · bcb50908

Oliver Bartsch authored Jul 20, 2021 and

Christian Kuhn committed Jul 22, 2021

When using an array as data for a log entry placeholder,
it must be imploded as otherwise the placeholder would
not be resolved by AbstractWriter->interpolate().

Additionally, the exception is now correctly added to the
log message string in PhpErrorLogWriter again.

Resolves: #94594
Related: #94315
Releases: master
Change-Id: I0aa79e511fd164a75e974547057477479234c25b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69978


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

bcb50908

[TASK] https as default scheme in f:uri.external and f:link.external · e5bf0c14

Christian Kuhn authored Jul 22, 2021

When no scheme is given using f:uri.external or
f:link.external fluid view helpers, they now fall
back to https instead of http.

Resolves: #94615
Releases: master
Change-Id: I33ce251d4f38cd504d163dd91f70fbe753952f2d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70026


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

e5bf0c14

[BUGFIX] Properly mark QueryView as deprecated · 8972957a

Christian Kuhn authored Jul 19, 2021

The class logs a deprecation in __construct(),
but the @deprecated annotation is missing.

Unit and functional tests of QueryGenerator are
moved now and a PHP8 related patch that has been
done to core QueryGenerator is now merged into
lowlevel QueryGenerator, too.

Resolves: #94587
Related: #92129
Releases: master
Change-Id: Ibb59c6bf576c6589a1cbb654ebd4773065b3e8c2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69962


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

8972957a

[TASK] Replace fetchColumn with fetchOne for Doctrine DBAL · d6fa37ea

Benni Mack authored Jul 18, 2021 and

Oliver Bartsch committed Jul 22, 2021

This change replaces all query results from the
database from fetchColumn() to fetchOne(), as this
is the new API used in Doctrine DBAL.

This change is one of a few to prepare for
Doctrine DBAL 3.0 compatibility.

Resolves: #94605
Releases: master
Change-Id: Ia9ca2bbb7b2c16a230c5946941cc3023203f494d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69917


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

d6fa37ea

[BUGFIX] Undefined array key with PHP8 in old services API · 29fb5f52

Devid Messner authored Jul 20, 2021 and

Georg Ringer committed Jul 22, 2021

Fix a PHP Warning on custom auth services that have
no service subtype "processLoginDataBE".

Resolves: #94599
Releases: master
Change-Id: I5046236b659674cebc761861ccf668c9bb226dc5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70012


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

29fb5f52

[BUGFIX] Another DataHandler PHP 8 fix · 637fb942

Christian Kuhn authored Jul 21, 2021 and

Oliver Bartsch committed Jul 22, 2021

A rather obvious TCA access scenario.

Resolves: #94611
Releases: master
Change-Id: Ie4ac8c7d1978e89de28076e0d036db1930c51149
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70021


Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

637fb942

20 Jul, 2021 5 commits

[SECURITY] Do not log sensitive data in authentication process · 678dfccb

Benni Mack authored Jul 20, 2021 and

Oliver Hader committed Jul 20, 2021

When having the debug logging activated for the
authentication process, sensitive data is not being
logged anymore.

This change
* removes password from being logged
* hashes the cookie value processed for logging

Resolves: #93925
Releases: master, 11.3, 10.4, 9.5
Change-Id: I8c610a72014de571ef52b4430c43f8d149b273d9
Security-Bulletin: CORE-SA-2021-012
Security-References: CVE-2021-32767
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69994


Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

678dfccb

[SECURITY] Encode error messages in Query Generatory & Query View · a976a18a

Oliver Hader authored Jul 20, 2021 and

Oliver Hader committed Jul 20, 2021

Properly encodes error messages to be used in HTML output in
"EXT:lowlevel" Query Generator and Query View components.

Resolves: #93868
Releases: master, 11.3, 10.4, 9.5
Change-Id: I05812ac7c1cded39edbf10d50bb4dc0fd8faf577
Security-Bulletin: CORE-SA-2021-010
Security-References: CVE-2021-32668
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69992


Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

a976a18a

[TASK] Mitigate downstream CSV code injection · 7fbe487a

Oliver Hader authored Jul 20, 2021 and

Oliver Hader committed Jul 20, 2021

* uses stream filter to enclose multi-line content
* adds three choosable strategies dealing with control literals
  + TYPE_REMOVE_CONTROLS - removes control literals (default)
  + TYPE_PREFIX_CONTROLS - prefixes control literal sequence with `'`
  + TYPE_PASSTHROUGH - nothing, passthrough data

The default strategy is `TYPE_REMOVE_CONTROLS` when
invoking `\TYPO3\CMS\Core\Utility\CsvUtility::csvValues`.

Resolves: #94271
Releases: master, 11.3, 10.4, 9.5
Change-Id: I2568a0c2dfa6d4636e211e97d66a513984532cc9
Security-Bulletin: TYPO3-PSA-2021-002
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69974


Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

7fbe487a

[BUGFIX] Avoid PHP8 fatal errors in CommandLineUserAuthentication · 26198673

Helmut Hummel authored Jul 20, 2021

Releases: master
Resolves: #94592
Change-Id: I0616e362b598beb49859f5e78a3f2636f6cdf73f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69969


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>

26198673

[TASK] Clean up $coreExtensionsToLoad in functional tests · 5e676a21

Christian Kuhn authored Jul 19, 2021 and

Georg Ringer committed Jul 20, 2021

FunctionalTestCase loads these core extensions by default:
core, backend, frontend, extbase, install, recordlist, fluid

Functional tests do not need to set these explicitely in
$coreExtensionsToLoad. The patch cleans this up.

Resolves: #94591
Releases: master
Change-Id: I038cea486c20edc5262dc6a575ed965c876bdc88
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69968


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

5e676a21

19 Jul, 2021 3 commits

[TASK] Refactor ViewHelper tests · ad3a216d

Christian Kuhn authored Jul 14, 2021

We have a decent test coverage of view helpers, especially
those within ext:fluid. This is an important asset and we're
sure all main functionality works.

Most of the tests rely on ViewHelperBaseTestcase from the
testing framework. This class prepares the main mocking
of view helper dependencies. Reading the code it becomes
obvious that this approach is kinda unfortunate: View
helpers are part of a bigger system - they have some
general dependencies like the rendering context, the
request and render children. This leads to a mocking
party in many unit tests, making the test goal hard to
understand and follow.
The mock preparations and assumptions of internal handling
actively block further separation of concern patches
within ext:fluid since the ViewHelperBaseTestcase breaks
all the time.

The patch refactors all unit tests that extend
ViewHelperBaseTestcase towards functional tests:
Most of them simply create a StandaloneView, feed a
template string for the specific view helper and
string compare the render result. Some FE related VH
tests additionally set up a full frontend and retrieve
a rendered fluid view as sub request.

This makes the tests much easier to read, follow and
understand. The functional tests are now good examples
to show the various features of single VH's.

Change-Id: I6c5d4eeb0c79ba66a18398a5623a591381a6d707
Resolves: #94580
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69857


Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

ad3a216d

[TASK] Skip another SVG sanitizer test causing seg fault · 53bbf190

Christian Kuhn authored Jul 19, 2021

A second test is marked skipped until
an upstream patch is merged and released.

Resolves: #94582
Related: #94565
Related: #94492
Releases: master, 10.4, 9.5
Change-Id: Ia899c47a80bba60840f011766b816af90e160498
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69924


Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

53bbf190

[TASK] Reduce invalid arguments mentioned by PHPStan · dc620aea

Benni Mack authored Jul 16, 2021 and

Georg Ringer committed Jul 19, 2021

Resolves: #94571
Releases: master
Change-Id: Ic84bf7ba69ef5b020f91661ff5387ef4b62f34f2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69905


Tested-by: core-ci <typo3@b13.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

dc620aea

16 Jul, 2021 3 commits

[BUGFIX] Fix undefined array key warnings for frontend in PHP8 · d418d600

Jochen Roth authored Jul 13, 2021 and

Benni Mack committed Jul 16, 2021

Add fallback for undefined array keys in EXT:frontend,
EXT:indexed_search, EXT:core.

This fixes frontend rendering of a basic site package
including all available content elements.

Resolves: #94546
Releases: master
Change-Id: I051f2d6d0b2278394e95af8eb26be11b3f4aa9a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69819


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

d418d600

[FEATURE] Allow overriding fileFolder config with TSconfig · 2f0c2656

Oliver Bartsch authored Jul 14, 2021 and

Benni Mack committed Jul 16, 2021

The "fileFolder" configuration options, available for TCA
columns of type "select" are used to fill the select field
with predefined files (images / icons). Nowadays this is
frequently used to make a corporate icon set available for
editors. In multi site installations however, those icon sets
usually differ from site to site.

Therefore, the AbstractItemProvider is now extended to allow
overriding those settings with TSconfig (TCEFORM).

Furthermore, to streamline the TCA configuration and to be
in line with the corresponding overrides, the "fileFolder"
TCA configuration options are moved into a dedicated sub array
"fileFolderConfiguration" and the properties are renamed
to be consistent with other TCA options.

* fileFolder => folder
* fileFolder_extList => allowedExtensions
* fileFolder_recursions => depth

A TCA migration is in place.

Resolves: #94406
Releases: master
Change-Id: I621198523edfd328ad68d692d9194017c445406f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69832


Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>

2f0c2656

[TASK] Skip SVG sanitizer test causing segmentation fault · 0e53b48b

Oliver Hader authored Jul 15, 2021 and

Oliver Hader committed Jul 16, 2021

SVG sanitizer test dataset entity.svg is causing segmentation fault
in certain scenarios - which might be related to libxml2 before
version 2.9.12. Unfortunately, investigations did not reveal any
further details other than libxml2.

As a result `entity.svg` test dataset, which is causing this problem is
skipped until https://github.com/darylldoyle/svg-sanitizer/pull/53 is
merged and released in the upstream library.

Resolves: #94565
Releases: master, 10.4, 9.5
Change-Id: I8375954dad64e3955f88122fa51dca7f796d077b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69894


Tested-by: core-ci <typo3@b13.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

0e53b48b

15 Jul, 2021 1 commit

[BUGFIX] Fix undefined array key warnings for PHP8 · bb9b14e8

Jochen Roth authored Jul 12, 2021 and

Benni Mack committed Jul 15, 2021

Added fallback for undefined array keys
in backend, core, recycler, impexp, scheduler and
linkvalidator

Resolves: #94542
Releases: master
Change-Id: Ieeda20879f1906c9e9a743e0377767cfce8dec09
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69813


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

bb9b14e8

14 Jul, 2021 1 commit

[FEATURE] Add filter option "Never hit" to Redirects module · c671a1c5

Oliver Bartsch authored Jul 13, 2021 and

Benni Mack committed Jul 14, 2021

The Redirects module is extended for a new filter option
"Never hit". When used, the list is filtered for redirects,
which were never hit before. This is especially handy
for editors managing large sites, while the "automatic
redirect generation on slug change" is enabled.

The redirect demand already features the property
"maxHits", which however was previously only used
for the CLI command and is now also used for the
new filter option.

Resolves: #94489
Releases: master
Change-Id: Ied510109de1c6bfb651ea0b8fdec0cfecbfab43a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69823


Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>

c671a1c5

13 Jul, 2021 1 commit

[TASK] Adjust RST syntax in SVG sanitizer documentation · 0c13ea72

Oliver Hader authored Jul 13, 2021 and

Andreas Fernandez committed Jul 13, 2021

Resolves: #94554
Releases: master, 10.4, 9.5
Change-Id: I30ad916b71adaa7db97b40584f7d65453936ec87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69824


Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

0c13ea72