Each entry in the New Content Element wizard is tested to be valid,
i.e. the tt_content_defValues defined by that entry must be allowed
for the current BE user. Also, an entry may not select values that are
removed via TSconfig.

Setting TCEFORM.tt_content.[column].keepItems acts as a whitelist of
allowed values for *that* column. But the validity checks are done
hardcoded against the *CType* column.

Resolves: #23864
Releases: 6.2, 6.1
Change-Id: I5b6578f35552bd571fc822ac72f8f5fe12fe11f7
Reviewed-on: https://review.typo3.org/27588
Reviewed-by: Stefan Neufeind
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Felix Kopp authored Feb 23, 2014 and Georg Ringer committed Feb 24, 2014

Hides bullet points in New Content Element Wizard.

Resolves: #56062
Releases: 6.2
Change-Id: Iead660b30df3cabea76d22dc962802c61be01ea7
Reviewed-on: https://review.typo3.org/27804
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014

Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The rendering of the plugin menu gets messed up if a plugin hasn't any
description. This patch clears floating for every list item to ensure
it is displayed on the left side.

Resolves: #53895
Releases: 6.2
Change-Id: Ib64b99865fda1359ade4b7c22d160fbfe28350c9
Reviewed-on: https://review.typo3.org/25655
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The message when having a hook for the wizard items
is still the same, although the interface has been
renamed. So the check is valid, but if the check
fails then the message is misleading.

Releases: 6.2
Resolves: #55455
Change-Id: If1b9e4285c02e8a3ab92eee562b6516f24bae9a8
Reviewed-on: https://review.typo3.org/27146
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

When using Content Element Wizard configured to render items with
tabs their body container has fixed width of 680px. This leads
to visual problems when using some extra tabs registered - their
titles are rendered outside body content. This patch removes
fixed width and some other styles that are not needed. For example
there are some styles for tables inside tab content but items are
rendered in lists not tables so we can remove them.

Change-Id: I1d749649ffa86cd2220460f1ebf4894aca98f4bc
Resolves: #53904
Releases: 6.2
Reviewed-on: https://review.typo3.org/26906
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

"textfile" will be replaced by "text file"

Resolves: #54893
Releases: 6.2
Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b
Reviewed-on: https://review.typo3.org/26736
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch replaces about 300 places using strcmp()
in the whole core. There are different contexts for strcmp()
within this set, i.e. checking for strings being '0',
'', not '' and the like.

strcmp() has to stay when it comes to real sorting of strings,
which is a rather rare case, otherwise it can be replaced with
faster alternatives.

The following 'rules' were used for the replacement:

* Use a type cast if you can't be sure about the incoming values.
  We do not need type casts if the types are implicitly defined
  before by another function. i.e. intval(), trim(), substr()
* Use int-cast whenever the values to be compared are numbers only.
* Use string-cast for any other combination. i.e
  (string)$len === '0' when $len can be NULL, which is different
  to (int)$len === 0

Resolves: #54085
Releases: 6.2
Change-Id: I88fb294ae20d8c23ff58d8296fbb37925d5213c8
Reviewed-on: https://review.typo3.org/25843
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Christian Kuhn authored Oct 01, 2013 and Anja Leichsenring committed Oct 01, 2013

Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Make use of boolean value TRUE as third parameter in
trimExplode function.

Change-Id: Ied33efac6cddfc2e2798435fe9b1ef748c11905b
Resolves: #50402
Releases: 6.2
Reviewed-on: https://review.typo3.org/22542
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Georg Ringer authored Jul 02, 2013 and Anja Leichsenring committed Jul 03, 2013

Resolves: #49603
Releases: 6.2
Change-Id: I3ddef9670d16a39d6f96033873f70a06791abc64
Reviewed-on: https://review.typo3.org/21814
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Nicole Cordes authored May 05, 2013 and Anja Leichsenring committed May 05, 2013

Cleanup ext:backend with the following code changes:
* Make use of the "use" statement for GeneralUtility
* Make use of the "use" statement for BackendUtility
* Case in switch statements are tabbed with one more tab

Change-Id: I6549316dddc9575cab4e661b7c111ec947757cb8
Fixes: #47900
Releases: 6.2
Reviewed-on: https://review.typo3.org/20479
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Felix Kopp authored May 01, 2013 and Christian Kuhn committed May 01, 2013

Most html templates in backend are used in one extension only.
Those templates should be held in extension context to reduce
dependencies.

Creates extbase/flow directory structures.

Change-Id: I7638092b695d36c4cea2a2755d8285bf92114bb0
Fixes: #47786
Releases: 6.2
Reviewed-on: https://review.typo3.org/20374
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Remove radio buttons from "new content elements" as icons
serves the same purpose
Change-Id: Ibea517d19389ad2645d630b4416e7f45207faec7
Fixes: #38623
Releases: 6.1
Reviewed-on: https://review.typo3.org/12566
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Deprecates classes:

- BigDocumentTemplate
- SmallDocumentTemplate
- MediumDocumentTemplate
- StandardDocumentTemplate

These classes are rarely used.
Also the standard style in the backend move along.

Resolves: #45955
Releases: 6.1
Change-Id: Ic6e261eef960a71f56a8c5af4724f24e5da8e32c
Reviewed-on: https://review.typo3.org/18555
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Magdalena Leichsenring
Tested-by: Magdalena Leichsenring

Wouter Wolters authored Mar 16, 2013 and Christian Kuhn committed Mar 19, 2013

In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.

Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch refactors TCA handling especially in the frontend to
a new codebase, making it more easy to work with, removing
developer headaches, without significant performance impact:

* In FE, full TCA is always loaded and cached after first call
to a core cache disk. ext_tables are not executed on every call.
* In BE, intermediate TCA is cached, rendering the dynamicConfigFile
setting useless. The destinction between 'ctrl' and 'columns' is
gone.
* TCA files should now be located at
ext:extensionname/Configuration/TCA/tablename.php' and should return
an array with the TCA for the table specified by the filename. On
first access, those files are read and cached. 'ctrl' sections from
ext_tables.php can be removed completly.
* TSFE->includeTCA(), TSFE->getCompressedTCarray() and
GeneralUtility:loadTca() are obsolete and deprecated.
* Extensions not using the new TCA load scheme have a compatibility
layer in ext_tables.php to resolve 'dynamicConfigFile' directly after
a specific extensions ext_tables.php file was loaded, so the next one
can already manipulate it with ExtensionManagementUtility methods.
* t3lib/stddb is gone, all files are merged to core.

Resolves: #45767
Releases: 6.1
Change-Id: I50ebe00c80b9b58ded0586637c85e0f495a63dad
Reviewed-on: https://review.typo3.org/18452
Tested-by: Soren Malling
Tested-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Felix Kopp
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This reverts commit d7b5d829

Change-Id: Ifdde18979c8ca0b617132daf84d283e9fc257a3d
Related: #45107
Reviewed-on: https://review.typo3.org/18252
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The frontend rendering aims to not load the full TCA including
columns settings to reduce rendering time for full cache pages.

This approach is ridiculous complex and using it is so hard to get
right for developers that even core patches in this area are
usually broken. The current situation is neither simple
nor transparent.

Currently, if no page cache entry exists during rendering, the whole
ext_tables.php are executed, the page is rendered and stuffed to
cache. While the full TCA is available at this point, it is reduced
to the 'ctrl' sections for the next run, without 'columns', and
stuffed to cache. On next access, the cache entry is used,
ext_tables.php and TCA is not fully loaded. This leads to all sort of
problems, if for example those pages contain USER_INT plugins that
rely on some TCA settings. Furthermore, it might happen, that
different plugins or the core then requires the ext_tables files more
than once, which leads to funny problems if some developer does not
know this and uses require_once instead of require inside
ext_tables.php. Issues like that are very hard to track down.

The current implementation relies on the methods TSFE->includeTCA(),
TSFE->getCompressedTCarray() and GeneralUtility->loadTCA(), where
especially includeTCA() with its parameter is so hard to understand
that it is impossible to use in a correct way without digging through
the content rendering for hours.

The patch obsoletes all three of the above methods. Instead, from now
on, the bootstrap in the frontend is configured to always load the
full TCA including columns sections, even in full cached context.
The only exception are eID scripts, but the existing API to load
additional TCA in the eID controller is modified to also load all.

On the downside, this patch costs around 30% of additional
performance for the rendering of full cached pages. As soon as there
is some USER_INT on a page, or if a page is not cached, the overhead
is around zero. So, this patch costs performance for 'simple' pages,
while it is of no effect for anything more complex.

The goal is to reduce developer headaches at this point and to
make the frontend rendering better predictable and more easy
to maintain. It is furthermore one step to implement a better
configuration handling in the long run.

Change-Id: I5aecd542abe92f2de4ee0d40b5db44c493d304a3
Resolves: #45107
Releases: 6.1
Reviewed-on: https://review.typo3.org/17978
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson

With namespaces the @package and @subpackage annotations
do not have a real benefit anymore and can be removed.

Change-Id: Id8f4718db0c1c51ae5143a3353dd5efb42dadf70
Resolves: #43019
Releases: 6.0
Reviewed-on: http://review.typo3.org/16474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Roland Waldner authored Oct 01, 2012 and Christian Kuhn committed Oct 28, 2012

Change-Id: I9970ef5e2087233db095a1d296261c6eb06def18
Resolves: #41498
Releases: 6.0
Reviewed-on: http://review.typo3.org/15198
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I8a30e8689c1c567770d0c03beaa12a0bf29e9b09
Resolves: #40878
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14563
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Thomas Maroschik authored Aug 23, 2012 and Christian Kuhn committed Aug 23, 2012

Change-Id: Id49218118087244bcd063b730631ee69b2820670
Resolves: #40096
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14015
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn