This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
  1. 12 Mar, 2014 24 commits
    • Ludwig Rafelsberger's avatar
      [BUGFIX] Correctly validate New Content Element entries · b2372ee7
      Ludwig Rafelsberger authored
      Each entry in the New Content Element wizard is tested to be valid,
      i.e. the tt_content_defValues defined by that entry must be allowed
      for the current BE user. Also, an entry may not select values that are
      removed via TSconfig.
      
      Setting TCEFORM.tt_content.[column].keepItems acts as a whitelist of
      allowed values for *that* column. But the validity checks are done
      hardcoded against the *CType* column.
      
      Resolves: #23864
      Releases: 6.2, 6.1
      Change-Id: I5b6578f35552bd571fc822ac72f8f5fe12fe11f7
      Reviewed-on: https://review.typo3.org/27588
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Tymoteusz Motylewski
      Tested-by: Tymoteusz Motylewski
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      b2372ee7
    • Oliver Hader's avatar
      [BUGFIX] Missing localizeChildrenAtParentLocalization for CSV tests · 548ba6f6
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      The "localizeChildrenAtParentLocalization" behaviour needs to be
      set to automatically localize children for IRRE CSV functional
      tests as well.
      
      Resolves: #56819
      Releases: 6.2
      Change-Id: I14a09e715ad9674922776de450d519583770e0f5
      Reviewed-on: https://review.typo3.org/28299
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      548ba6f6
    • Oliver Hader's avatar
      [BUGFIX] InvalidArgumentException in ActionControllerTest · f1612c12
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      The cache identifier causing the exception looks like this:
      randomviewobjectpattern_@package_mycontroller_myaction_myformat
      
      However, "@package" should be "@extension" in that regard and
      besides that, the cache identifier using the vendor names shall
      be used in the tests.
      
      Resolves: #56822
      Releases: 6.2
      Change-Id: Ic78a8690559486efcbc7f5da7219a445f3f6707f
      Reviewed-on: https://review.typo3.org/28300
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Markus Klein
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      f1612c12
    • Ernesto Baschny's avatar
      [TASK] Follow-up to "Add functional tests for generic persistence" · 57caf5a4
      Ernesto Baschny authored
      Test directory changed from "Relation" to "Persistence".
      
      Resolves: #55661
      Related: #55360
      Related: #55167
      Releases: 6.2
      
      Change-Id: I422dbfb6bdad4215bdc70dea775917cf3159605f
      Reviewed-on: https://review.typo3.org/28297
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      57caf5a4
    • Felix Oertel's avatar
      [TASK] Add functional tests for generic persistence · cf42649b
      Felix Oertel authored
      To backup the changes in Extbase's generic persistence,
      we add some functional tests.
      
      Resolves: #55661
      Related: #55360
      Related: #55167
      Releases: 6.2
      Change-Id: I0b845618b1cec9788ca36ac59e25ea6779f01cb6
      Reviewed-on: https://review.typo3.org/28262
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      cf42649b
    • Steffen Ritter's avatar
      [BUGFIX] FollowUp to #56797 in I1f15fbd262036b6b2d0159cd0e9613ad7135a296 · 855ca509
      Steffen Ritter authored
      Somehow a double $this->$this slipped into the cleanup on line 390
      which now fatals. This needs to be fixed.
      
      Resolves: #56797
      Releases: 6.2
      Change-Id: Ibb23b5f56c95106c4fea6e9a3ba09fbc9f9905dd
      Reviewed-on: https://review.typo3.org/28296
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      855ca509
    • Philipp Gampe's avatar
      [BUGFIX] Wrong namespace in functional test of FluidTemplate cObject · 8e4284db
      Philipp Gampe authored and Christian Kuhn's avatar Christian Kuhn committed
      Resolves: #56816
      Releases: 6.2
      Change-Id: I3abed35a5e27bdc9db2b18d5caa13681ef5a9305
      Reviewed-on: https://review.typo3.org/28294
      Reviewed-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      8e4284db
    • Marian Pollzien's avatar
      [BUGFIX] Download link for absolute file path · 4b3ae395
      Marian Pollzien authored and Frans Saris's avatar Frans Saris committed
      Support FAL adapters that return absolute urls as public file url
      
      Change-Id: I68f2675a1a5137e6d0c5cadee7b21e82e8730fdf
      Resolves: #56659
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28168
      Reviewed-by: Wouter Wolters
      Reviewed-by: Christian Weiske
      Tested-by: Christian Weiske
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      4b3ae395
    • Felix Oertel's avatar
      [TASK] Use prepared statements in generic persistence · ab2dc4e5
      Felix Oertel authored
      While Typo3DbBackend claims to be the glue between Extbase
      and TYPO3, it hardly uses the TYPO3 DB API.
      
      This patch enhances getObjectData- and getObjectCountByQuery
      - the main methods used when dealing with domain models
      through a repository - to use the TYPO3 DB API. In conjunction
      this enables Extbase to use the preparedStatement introduced
      in TYPO3 4.5.
      
      Because prepared queries might not be desirable in all circum-
      stances, they are disabled by default. They can be enable on
      a per-query-basis via
        $query->getQuerySettings()->setUsePreparedStatement(TRUE);
      
      Prepared statements will *only* be used for SELECT queries.
      
      * consistent use of the TYPO3 DB API
        use exec_SELECTgetRows and exec_SELECTcountRows() even for
        non-prepared queries. This should help a lot along the way
        to support DBAL.
      
      * preparedStatement in custom statements
        When using custom statements, it's now possible to use a pre-
        pared statement in $query->statement(), instead of a query-
        string. The prepared statement has to be initialized already
        though, because Extbase cannot take care of splitting your
        custom query string. The parameters are given as array in the
        second argument as usual.
      
      * deprecated using parameters in non-prepared custom statement
        If a custom query string is used with $query->statement(),
        giving the parameters in the second argument is deprecated.
      
      * get count working
        Counting - especially with limit and offset - has been broken
        for quite some time now. By refactoring the limit and offset
        parameters and adapting exec_SELECTcountRows() this should
        now work again.
      
      The next step is to separate the query parsing from the backend
      and introduce an intelligent query cache. This will work as a
      drop-in-replacement. The @todo-annotations are intended to stay
      there for the next patch.
      
      Resolves: #55360
      Releases: 6.2
      Change-Id: I91a3fd69470df178a8a5465511e50766b50d7f52
      Reviewed-on: https://review.typo3.org/27426
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Marc Bastian Heinrichs
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      ab2dc4e5
    • Markus Klein's avatar
      [CLEANUP] ClassLoader · 2eaa891a
      Markus Klein authored
      Add methods to better structure class information loading/creation.
      This is necessary as the follow up patches will need this code
      more often.
      
      Resolves: #56797
      Releases: 6.2
      Change-Id: I1f15fbd262036b6b2d0159cd0e9613ad7135a296
      Reviewed-on: https://review.typo3.org/28279
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Sebastian Fischer
      Reviewed-by: Patrick Broens
      Tested-by: Patrick Broens
      2eaa891a
    • Frans Saris's avatar
      [TASK] Enable info icon for inline fileReference elements · 59da5b90
      Frans Saris authored and Georg Ringer's avatar Georg Ringer committed
      The editor has no way to find the origin of the shown files when
      you add file to a content element for instance.
      
      This patch changes the default settings of
      ExtensionManagementUtility::getFileFieldTCAConfig() so
      the info icon is shown.
      
      Resolves: #56804
      Releases: 6.2
      Change-Id: I00752e73f891285525a7aae1a9c5caddfacc13d4
      Reviewed-on: https://review.typo3.org/28291
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      59da5b90
    • Fabien Udriot's avatar
      [BUGFIX] Outside storages can never be marked as public · a736ba2f
      Fabien Udriot authored and Frans Saris's avatar Frans Saris committed
      There are some edge cases where "is_public"
      can never be true within a storage record in the BE,
      for instance for storage located outside
      the document root or for storage driven by special driver
      such as Flickr, ...
      
      Change-Id: Id7ce8006f182c98d7a908c2e6c49e0c66a7c9da4
      Releases: 6.2
      Resolves: #56730
      Reviewed-on: https://review.typo3.org/28224
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      a736ba2f
    • Oliver Hader's avatar
      [TASK] Reduce record data in functional test failure message · 4fca5376
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      If records are found in a database table that are not part of
      the assertion data-set, currently the whole record array from
      the database is shown as failure.
      The assertion has information about the fields that should have
      been asserted. To keep a better overview, the failure message
      is reduced now to exactly those fields.
      
      Resolves: #56803
      Releases: 6.2
      Change-Id: Ib8f2afd0d464e8a4b850929277508770ff56eb91
      Reviewed-on: https://review.typo3.org/28285
      Reviewed-by: Wouter Wolters
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      4fca5376
    • Oliver Hader's avatar
      [TASK] Remove functional workspaces DataHandlerTest · bb942d71
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      DataHandling::canChangeTtContentInTheWorkspace() is now covered
      by DataHandling\Regular\Modify\ActionTest::modifyContent() with
      additional assertions. The mentioned test class can be removed.
      
      Resolves: #56805
      Releases: 6.2
      Change-Id: I968c593f50cd7453db87e1c4fe9e0478cf045381
      Reviewed-on: https://review.typo3.org/28288
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      bb942d71
    • Daniel Siepmann's avatar
      [BUGFIX] Only valid package names will be processed. · d24ae450
      Daniel Siepmann authored
      To prevent the extension manager from further steps while
      invalid package keys exists in the system, the package keys are
      validated earlier.
      
      This prevents further actions that will lead to rewrite
      of PackageState.php and invalid opcode cache.
      
      Change-Id: Ib8d9f25dc1d6c97b94a59b15255b96d5a1960093
      Resolves: #56532
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28286
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      d24ae450
    • Oliver Hader's avatar
      [BUGFIX] Split functional workspaces DataHandling test execution · 0a46d003
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      Travis-CI stops after 10 minutes of not having received any data,
      unfortunately it seems that the execution of the whole bunch of
      functional workspaces tests takes longer,
      see https://travis-ci.org/TYPO3/TYPO3.CMS/jobs/20590551
      
      The "solution" is to explicitly split up these tests for
      parallel execution in Travis-CI.
      
      Resolves: #56806
      Releases: 6.2
      Change-Id: Ib5e67e6793adb9d7896ce89872ccfa080ca849bd
      Reviewed-on: https://review.typo3.org/28289
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      0a46d003
    • Cynthia Mattingly's avatar
      [TASK] Text changes in the Install Tool · 762442c2
      Cynthia Mattingly authored
      Fix many small grammar and typo issues. Rewrite some larger
      portions of text to be more clear to the user. These
      rewrites are listed in the issue tracker.
      
      Resolves: #56754
      Related: #51965
      Releases: 6.2
      Change-Id: I72f3ccbbeb815d93e904154b5da0ad48213ed63c
      Reviewed-on: https://review.typo3.org/28287
      Reviewed-by: Sebastian Fischer
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      762442c2
    • Steffen Ritter's avatar
      [BUGFIX] Adapt ShowPic popup to use FAL · 2a85eeb6
      Steffen Ritter authored
      If not using own Lightboxes TYPO3 ships a custom solution
      of an image-enlarge popup. This combines an eID for rendering
      the image as well as a short JavaScript snippet opening that
      in a new window.
      
      The php code for rendering that link as well as the popup code
      itself are not fal aware and to image-processing on their own.
      As a result this feature is only able to deal with files in local
      file system.
      
      This change refactors both imageLinkWrap as well as
      ShowImageController to use and work on FAL objects.
      
      Releases: 6.2
      Resolves: #56723
      Change-Id: Iebf1379b8f72cf57d69a06b0b7540cbd8ccb32c1
      Reviewed-on: https://review.typo3.org/28252
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      Reviewed-by: Fabien Udriot
      Tested-by: Fabien Udriot
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      2a85eeb6
    • Fabien Udriot's avatar
      [BUGFIX] Remove baseUri from the Storage · d1ef7120
      Fabien Udriot authored
      The baseUri in the Storage has a Getter and is the
      only thing initialized in the "processConfiguration"
      method of a Storage. Due to the fact that "baseUri"
      is not a field in the storage-table this never could
      be set, and therefore always has been null.
      
      It appears that this has been a left over from earlier
      days and it is save to remove this, since the getter
      always returned NULL (and as a result was unusable).
      In addition the processConfiguration and its signals
      are removed as they have and never had an effect anyhow.
      
      Change-Id: I3416ee393a1eb3d0f1ea5fc588a351bb1555cdba
      Releases: 6.2
      Resolves: #56783
      Reviewed-on: https://review.typo3.org/28271
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      d1ef7120
    • Patrick Broens's avatar
      [BUGFIX] Language labels taken from wrong language file · b02956ee
      Patrick Broens authored and Wouter Wolters's avatar Wouter Wolters committed
      The module "Pagetree overview" in Web > Info is showing an empty
      selectbox because the language labels for this dropdown are called from
      the wrong language file.
      
      This patch changes the calls to the language labels
      
      Change-Id: I791598933704752fd6d5ed0d987f43bde1811452
      Resolves: #56762
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28255
      Reviewed-by: Sebastian Müller
      Tested-by: Sebastian Müller
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      b02956ee
    • Patrick Broens's avatar
      [BUGFIX] Different button behaviour Page module views · ade237ee
      Patrick Broens authored
      In the Page module the button behaviour for adding new content elements
      "Add a new record at this place" is different in the "columns" and
      "languages" view.
      
      The columns view shows the all buttons in a column when hovering over this
      column, the languages view will show one button when hovering over this
      hidden button. A backend user needs to know where the button is.
      
      The languages view should have the same behaviour as the columns view.
      
      Change-Id: Ia1b98de5b8622c7586bd03e7769ba4aa39121e38
      Resolves: #56722
      Releases: 6.2, 6.1
      Related: #56720
      Reviewed-on: https://review.typo3.org/28219
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      ade237ee
    • Oliver Hader's avatar
      [TASK] Add functional tests for TCA types select and group/db · 07c8cdab
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      The tests for TCA types 'select' and 'group' include for each
      * Modify in live
      * Modify in workspace
      * Publish in workspace
      * PublihAll in workspace
      
      Resolves: #56707
      Releases: 6.2
      Change-Id: I4bd8584f01122d0c4a974618d00e126b91270589
      Reviewed-on: https://review.typo3.org/27823
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      07c8cdab
    • Georg Ringer's avatar
      [BUGFIX] Typecast cookie value to string · 34fcdead
      Georg Ringer authored
      The cookie might be null, therefore the INSERTquery fails in
      indexed_search.
      
      As a solution, use a type cast to string.
      
      Change-Id: If9e650ee713c75420859813546d138000b3023ff
      Resolves: #55989
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28281
      Reviewed-by: Christian Kuhn
      Reviewed-by: Tymoteusz Motylewski
      Tested-by: Tymoteusz Motylewski
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      34fcdead
    • Ernesto Baschny's avatar
      [BUGFIX] Index on sys_file_processedfile is too large · aa1fb872
      Ernesto Baschny authored
      Resolves: #56786
      Related: #54234
      Releases: 6.2
      Change-Id: I9c91f3e989e65df559542135d0b84025dacbbaf2
      Reviewed-on: https://review.typo3.org/28272
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Marcin Sągol
      Tested-by: Marcin Sągol
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      aa1fb872
  2. 11 Mar, 2014 16 commits
    • Oliver Hader's avatar
      [TASK] Add Publish and PublishAll DataHandler workspaces tests · 0bf260e1
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      Extend current functional action tests with those actions:
      * modification (Modify)
      * publish single records (Publish)
      * publish all records in a workspace (PublishAll)
      
      The Publish and PublishAll tasks extend the accordant basic
      Modify functional tests.
      
      Resolves: #56708
      Related: #56710
      Releases: 6.2
      Change-Id: I1f7a70df39585c29b3b4ff5675b5147610f254f2
      Reviewed-on: https://review.typo3.org/28236
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      0bf260e1
    • Andreas Fernandez's avatar
      [TASK] Update ADOdb to 5.18 · f6c044d9
      Andreas Fernandez authored and Jigal van Hemert's avatar Jigal van Hemert committed
      Update ADOdb to current version 5.18 which fixes various bugs
      and adds PHP 5.4 compatibility.
      
      Resolves: #56761
      Releases: 6.2
      Change-Id: I5d46f52f8beb2407a40a3ee5796b00229b79992f
      Reviewed-on: https://review.typo3.org/28253
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      f6c044d9
    • Oliver Hader's avatar
      [TASK] Add possibility to assert error log entries · e05bd486
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      During the action tests it might happen, that errors occur.
      To assert expected or unexpected error log entries in the
      sys_log table, this functionality shall be added to the
      functional testing framework.
      
      Resolves: #56369
      Releases: 6.2
      Change-Id: I07806e69cb7f575c844a3adf442233a82fa01505
      Reviewed-on: https://review.typo3.org/27886
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      e05bd486
    • Oliver Hader's avatar
      [BUGFIX] Use clean DataHandler for each functional test action · 596d1706
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      Currently the DataHandler is reused in functional tests which
      leads to unexpected behaviour for copied/deleted records. The
      regular use case in the backend is to use a new DataHandler
      instance for each HTTP request.
      
      Resolves: #56729
      Releases: 6.2
      Change-Id: Iea685f58625e6ef611d543e375a8c24c1595008d
      Reviewed-on: https://review.typo3.org/28222
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      596d1706
    • Christian Kuhn's avatar
      [BUGFIX] Tests: Incomplete mocking in ext:frontend · f61e17ed
      Christian Kuhn authored
      Improve the fluid standalone tests by not calling __construct() of
      a dependency.
      Additionally, renderWorksWithNestedFluidtemplate() not only tests
      the standalone view, but also its connection to the content object
      renderer, so this is more a functional than a unit test. The test
      is streamlined and moved to the functional test suite.
      
      Change-Id: I3ae357de4861395622bc6f70aeed6011c7760cde
      Resolves: #56788
      Related: #51436
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28274
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      f61e17ed
    • Christian Kuhn's avatar
      [BUGFIX] Tests: Incomplete mocking in ext:beuser · e0fee4ad
      Christian Kuhn authored
      The module data storage test subject calls several static
      dependencies that can not be mocked without code refactoring. Those
      dependencies do database stuff in the end, so DB needs to be properly
      mocked for this test.
      
      Change-Id: Id882b3a3a785940b5499c9afeff67f193c480e3b
      Resolves: #56791
      Related: #51436
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28275
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      e0fee4ad
    • Patrick Broens's avatar
      [BUGFIX] Alignment of button "add a new element at this place" · d5a233b9
      Patrick Broens authored and Wouter Wolters's avatar Wouter Wolters committed
      In the page module using the "Languages" view, the buttons "add a new
      element at this place" are wrongly aligned.
      
      This patch fixes this issue by adding a div which controls this alignment
      by CSS
      
      Change-Id: I9de8a47368682ed0b33c2ebfa0a590402c1ca8ef
      Resolves: #56720
      Releases: 6.1, 6.2
      Reviewed-on: https://review.typo3.org/28217
      Reviewed-by: Sebastian Fischer
      Tested-by: Sebastian Fischer
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      d5a233b9
    • Christian Kuhn's avatar
      [BUGFIX] Tests: Incomplete mocking in ext:scheduler · bbfaf395
      Christian Kuhn authored
      Use getMock() instead of new() to create the test subject in order to
      suppress execution of __construct() of parent AbstractTask.
      
      Change-Id: Id0c297b845db7064b15a859eefa71830ab12074d
      Resolves: #56787
      Related: #51436
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28273
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      bbfaf395
    • Steffen Ritter's avatar
      [BUGFIX] FollowUp to #56660 · bab84b55
      Steffen Ritter authored
      Fixes the unit-test according to the changes in review
      https://review.typo3.org/#/c/28195/.
      
      Since the BasePath (and therefore vfs://...) cannot be
      handover anymore on initialize() it has to be injected
      via _set().
      
      Releases: 6.2
      Resolves: #56660
      Change-Id: I88d03f0305ff08810d6fea82c5c891b1a7a99771
      Reviewed-on: https://review.typo3.org/28270
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      bab84b55
    • Patrick Broens's avatar
      [TASK] Styling and placement of Toggle All button install tool · a7445219
      Patrick Broens authored
      The "Toggle All" button in the install tool is currently clickable plain
      text, which should be a button. It also needs to move to the fixed footer,
      so it's always accessible.
      
      This patch changes the plain text to a button and moves the button to the
      fixed footer
      
      Change-Id: I25a57e7a7f0f25fe2fe204f68fe2ee4dbbf1ade0
      Resolves: #55469
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28243
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Sebastian Fischer
      Tested-by: Sebastian Fischer
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      a7445219
    • Wouter Wolters's avatar
      [BUGFIX] PackageManager initialize() signature is incompatible · 61a9d4bc
      Wouter Wolters authored
      PackageManagerInterface contains following method declaration:
      
       public function initialize(\TYPO3\Flow\Core\Bootstrap $bootstrap);
      
      however in the PackageManager the signature is:
      
        public function initialize(\TYPO3\Flow\Core\Bootstrap $bootstrap,
          $packagesBasePath = FLOW_PATH_PACKAGES,
          $packageStatesPathAndFilename = '')
      
      This will create a fatal error on some versions of php and when running
      unit tests on hhvm (of CMS), see
      http://php.net/manual/en/language.oop5.interfaces.php
      
      "The class implementing the interface must use the exact same method
      signatures as are defined in the interface. Not doing so will result
      in a fatal error."
      
      This change updates the method signature of the PackageManager to be in
      line with the interface.
      
      Resolves: #56660
      Related: #56409
      Releases: 6.2
      Change-Id: Iab7ae0d6d9809abe7cb6f9b73adb77f06d2f0820
      Reviewed-on: https://review.typo3.org/28195
      Reviewed-by: Thomas Maroschik
      Reviewed-by: Sebastian Müller
      Reviewed-by: Sebastian Fischer
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      61a9d4bc
    • Frans Saris's avatar
      [BUGFIX] Remove wrong storage->isPublic() check in localFolderTree · 0d1cef2e
      Frans Saris authored
      In localFolderTree->ext_isLinkable() is a check for storage->isPublic()
      but the isPublic flag has nothing to do with the fact if links
      to the files can be created.
      
      This change removes this check.
      
      Resolves: #56183
      Releases: 6.2
      Change-Id: Ia0e264b46259c0bd284a789a4eab48cf9a9e3b14
      Reviewed-on: https://review.typo3.org/27772
      Reviewed-by: Wouter Wolters
      Reviewed-by: Sebastian Fischer
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      0d1cef2e
    • Xavier Perseguers's avatar
      [BUGFIX] DatabaseConnection must be initialized · f2dc0f8d
      Xavier Perseguers authored
      The install tool forgets to initialize the database connection.
      
      Change-Id: Ib7355e4f931c7152a6d13df99ed550c1b61eacf9
      Fixes: #56763
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28254
      Reviewed-by: Andreas Fernandez
      Tested-by: Andreas Fernandez
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      f2dc0f8d
    • Xavier Perseguers's avatar
      [BUGFIX] DBAL: Incomplete database configuration · c5f4b18b
      Xavier Perseguers authored
      When no database connection is established, handler_init() is used. But
      at this point, the credentials are unkown and the method returns void.
      
      As all parameters of method sql_pconnect() are deprecated, move the
      _DEFAULT initialization into method handler_init() to get credentials
      into the DBAL configuration.
      
      Resolves: #56257
      Releases: 6.2
      Change-Id: Ifd908fab1382434d376a9358d0ae9c3af083616e
      Reviewed-on: https://review.typo3.org/28045
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Andreas Fernandez
      Tested-by: Andreas Fernandez
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      c5f4b18b
    • Patrick Broens's avatar
      [BUGFIX] Inconsistent visual appearance Install Tool · 97aa83fc
      Patrick Broens authored and Frans Saris's avatar Frans Saris committed
      The install tool function System Environment is not according to the
      style sheet of the install tool. This is due to the fact phpinfo() is
      called on this page which comes with its own CSS styles. These styles
      are influencing the visual appearence of the rest of the page.
      
      This patch adds a new utility class to cleanup the output of phpinfo()
      before assigning it to the view. It also comes with our own CSS for
      phpinfo().
      
      Change-Id: Ib0b087cae4bf5db723b0e9c3481619c984ef674f
      Resolves: #55116
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28225
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      97aa83fc
    • Alexander Stehlik's avatar
      [TASK] Add api tag to ElementBrowser::setRecordList() · ac29ff00
      Alexander Stehlik authored and Wouter Wolters's avatar Wouter Wolters committed
      This method was introduced in TYPO3 6.2 with the purpose to be used
      by Extensions. Therefore the @deprecated tag is replaced with an
      @api tag.
      
      Resolves: #56742
      Releases: 6.2
      Change-Id: Ia48a8c6997c26318a6fea50af32cd73f1138bb2b
      Reviewed-on: https://review.typo3.org/28237
      Reviewed-by: Tymoteusz Motylewski
      Tested-by: Tymoteusz Motylewski
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      ac29ff00