This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 31 Aug, 2017 1 commit
-
-
Resolves: #82175 Releases: master, 8.7 Change-Id: I4b70b2a662b1818171bb180f88f8d40a48ee91ed Reviewed-on: https://review.typo3.org/53788 Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 23 Aug, 2017 1 commit
-
-
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- 13 Jul, 2017 1 commit
-
-
The 'imagefile_ext' list only contains the lowercase versions of all supported extensions. This patch makes sure that a lowercase version of the file extension is used and it is recognised as an image file. Resolves: #81826 Releases: master, 8.7 Change-Id: Ice5881be4c685432987530dcdd50b1f758d883ef Reviewed-on: https://review.typo3.org/53427 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 04 Jun, 2017 2 commits
-
-
Check files if they are image files before thumbnail generation. Change-Id: I7dae2ccbb5ab93e582d21efe8f7d29cf7006a1c3 Resolves: #81147 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53107 Reviewed-by:
Jo Hasenau <info@cybercraft.de> Tested-by:
-
- actions-add Link to one new record or a wizard to select the type of the record - actions-page-new Link to one new page record - actions-document-new Link to create multiple new records (EditDocumentController) Resolves: #81428 Releases: master Change-Id: Ic95a4b3b7727e96a2da818633d03cba7a1c7bde7 Reviewed-on: https://review.typo3.org/53105 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
- 02 Jun, 2017 2 commits
-
-
Christian Kuhn authored
Change-Id: Ie35ced0d902497a6eacf2d3e9a8463cdd2066ac8 Resolves: #71183 Releases: master Reviewed-on: https://review.typo3.org/47934 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
If the info icon is disabled it is now removed completely. Previously the logic for new records was not caught correctly, so that the case for the enabled icon with a new record was executed. Disabling the icon should remove it completely, as a disabled non-clickable icon is not helpful and confusing for editors. This is now done, and the case for the enabled icon with new records is also correctly caught. Resolves: #81380 Releases: master, 8.7 Change-Id: I1c78a99a83efa3c88e3a6337df9cd0c8a959ea7b Reviewed-on: https://review.typo3.org/52970 Reviewed-by:
Daniel Windloff <daniel.jc.windloff@googlemail.com> Tested-by:
-
- 18 May, 2017 1 commit
-
-
In order to be consistent, change the button order and styling (according to the list module) in the InlineRecordContainer. Resolves: #78174 Releases: master, 8.7 Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0 Reviewed-on: https://review.typo3.org/50104 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
-
- 27 Apr, 2017 1 commit
-
-
This function now does the same as makeInstance() except for an if() clause, since the API should be unified this method should be considered as dropped, allowing to use callUserFunction() and makeInstance() as the only two proper ways to call custom classes / methods. Resolves: #80993 Releases: master Change-Id: I0c2042dbe6c83a86f211bab4eaf64d75e6424232 Reviewed-on: https://review.typo3.org/52518 Reviewed-by:
-
- 20 Apr, 2017 1 commit
-
-
Christian Kuhn authored
Resolves: #80913 Releases: master Change-Id: I151fbf7a02df3e4713d623eb1659ac35ae2cb35a Reviewed-on: https://review.typo3.org/52490 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- 18 Apr, 2017 1 commit
-
-
Drop methods and change method signatures of methods within GeneralUtility. Resolves: #80703 Releases: master Change-Id: I7c617d7dbf0a7f877f6ae248319f4d28eb1f725c Reviewed-on: https://review.typo3.org/52480 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 28 Mar, 2017 2 commits
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
There are some places where PHP comments have been done wrong (using doccomments) or where there is no comment at all. Resolves: #80503 Releases: master Change-Id: Ib12d3b82755d801abcbefe7127f1189239f766af Reviewed-on: https://review.typo3.org/52200 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 25 Mar, 2017 2 commits
-
-
Resolves: #48883 Resolves: #76048 Resolves: #73609 Releases: master, 7.6 Change-Id: Id782bd41bfe30d9f9574e4b444d6e361ac76d0c6 Reviewed-on: https://review.typo3.org/52148 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Nicole Cordes authored
On creating child records for an inline field, currently no language is set and the children are stored with sys_language_uid 0. This patch adds the proper configuration to ensure a default children language according to its parent language. Resolves: #48883 Resolves: #76048 Resolves: #73609 Releases: master, 7.6 Change-Id: Id9e449dbb06fed11670eedec45a92529fb4acb6f Reviewed-on: https://review.typo3.org/52061 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
- 20 Mar, 2017 2 commits
-
-
Christian Kuhn authored
TCA property l10n_cat has been there since ever and nobody understood it. The docs about it never said what it really does and the according arguments from EditDocumentController were never used. The patch removes l10n_cat and some left over handling in EditDocumentController. Do not confuse this l10n_cat related localizationMode text/media with the localizationMode select/keep from inline: The inline part is not touched by the patch. Change-Id: Ia7b54bddabffcad3e38df76731d7fe9f6b8ff40f Resolves: #80331 Releases: master Reviewed-on: https://review.typo3.org/52086 Reviewed-by:
-
TCA type's inline localizationMode can either be "keep" or "select". At least "keep" is counter-productive if allowLanguageSynchronization is enabled. That's why the whole localizationMode behaviour setting shall be deprecated and ignored in case allowLanguageSynchronization is enabled for the very same TCA field. This change does not migrate non-conflicting localizationMode settings automatically, since this potentially might be breaking and cannot be done without side-effects. Besides that calls to the static function BackendUtility::getInlineLocalizationMode() do not trigger a new entry in the deprectation log since the usage of localizationMode in TCA is logged already. Resolves: #79770 Releases: master Change-Id: Ic2072877d08bb880e9e957d6d31f0527333c2cc5 Reviewed-on: https://review.typo3.org/51650 Tested-by:
-
- 26 Feb, 2017 1 commit
-
-
The code to transfer the inline parent context to form engine in Ajax requests exists but is currently non functional in some situations. The config is stored as array, which is hashed by serializing the array, and building the hash on that string. However that string is not transferred over the wire, but the json encoded array. If a float value was present at some place in this array, json_encode and json_decode will add a slight offset to these numbers than if the value is serialized. To avoid such errors, the hmac is now calculated and checked against the json encoded value. We also clean up the code in this area to avoid duplication and improve the hash calculation and comparison. By doing so, we can clean up and simplify the flex form handling for IRRE fields as well. Resolves: #79999 Releases: master Change-Id: I049d699f9f30edad0a9c8b06bbc3970e2cdac417 Reviewed-on: https://review.typo3.org/51783 Tested-by:
-
- 17 Feb, 2017 1 commit
-
-
* Initialize some uninitialized variables * Fix invalid argument count on function calls * Fix case typo in function call * Fix some phpdoc issues Resolves: #79865 Releases: master Change-Id: I4e41940d849daa818735f75169e7cc686ee908c9 Reviewed-on: https://review.typo3.org/51725 Tested-by:
-
- 15 Feb, 2017 1 commit
-
-
PHP’s `array_pop()` requires its argument being passed as reference, but the result of `array_keys()` is directly used. The result of `array_keys()` is now stored into a variable which gets passed to `array_pop()`. Resolves: #79686 Releases: master, 7.6 Change-Id: Icda3040abefbffad64e93acf0d7ae632ccee00bf Reviewed-on: https://review.typo3.org/51590 Reviewed-by:
Armin Vieweg <armin@v.ieweg.de> Tested-by:
-
- 12 Feb, 2017 1 commit
-
-
ListOfFieldsContainer of FormEngine render construct is used to reduce the field list of a full record down to a given list of fields that should be rendered, only. It is triggered for instance from the list module if only a single field of multiple different records should be edited at once. Until now, the container did not fully validate if a given field actually exists within the showitem field or palette and basically delegated the handling down to a different container which in the end skipped that field if it was not configured in TCA for given record type. The patch fixes this by improving the lookup. Field rendering is no longer delegated down to other containers if the field in question does not exist within the 'types' section and is not within a referenced 'palette' of given record type. Change-Id: I750ebf7c3d87ecb381f7bbe21b63528765841277 Resolves: #79750 Releases: master Reviewed-on: https://review.typo3.org/51630 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- 11 Feb, 2017 1 commit
-
-
Resolves: #79729 Releases: master Change-Id: I689e8ecd0ffa2d005931e6162fb8df5d9694da3d Reviewed-on: https://review.typo3.org/51629 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
- 07 Feb, 2017 2 commits
-
-
This change unifies the ClickMenu functionality of the pagetree (ExtJS) with the ClickMenu code given in other areas of the TYPO3 Backend. The following changes are made: * Unify the naming, it's "ContextMenu" not "ClickMenu" anymore * Configuration for record types are unified, the clickmenu shows the same entries in the same order in any place. * ExtJS-based ContextMenu is removed, all based on the new ContextMenu functionality. * A new way for extending the items inside the ContextMenu is handled via ItemProviders, which can easily be extended. * Configuring clickmenu items is not done based on PageTS (as it was handled with the ExtJS pagetree), however certain items can be disabled via PageTS. Resolves: #78192 Releases: master Change-Id: I380ac73ced10fdc7b1fdec7261e2d56da3d7d938 Reviewed-on: https://review.typo3.org/50124 Reviewed-by:
-
This feature introduces a new functionality called "allowLanguageSynchronization" which can be set on a field configuration of a TCA column. This is the successor of "l10n_mode=mergeIfNotBlank" as the old option had several conceptual downsides: 1) "mergeIfNotBlank" took the value of the default record during runtime, but only if the translation field was empty. This means it was not possible to see what the record actually contained without having all fields of the parent at hand. 2) It was not possible to have a value "santa" in the original record but remove the option in a translation (because an empty string "" implicitly triggered the runtime call in the frontend) 3) "mergeIfNotBlank" did not work on relations except for files fetched via the FileRepository API calls, but for no other inline elements. 4) "mergeIfNotBlank" did the overlay functionality in the frontend, but only FormEngine and DataHandler took care of the option. Custom backend modules had to implement the same functionality. 5) In FormEngine, there was an icon in the translation record that if the record kept empty the value of the original language was taken, but this is not optimal in terms of usability. 6) "mergeIfNotBlank" did not take the new l10n_source option into account, where localizations could be made from other records than the default language "0". The new feature can be set on any TCA column setting: $GLOBALS['TCA'][<table-name>]['columns'] [<field-name>]['config']['behaviour'] ['allowLanguageSynchronization'] = true; This brings an option to records with translations (both from l10n_parent and l10n_source) to have the value for all translations synchronized or explictly have a checkbox to use a custom value. The information whether a field is custom filled, or kept in sync from l10n_parent/l10n_source is stored in a separate field called "l10n_state" inside the database. The introduced upgrade wizard and TCA migration to remove "l10n_mode=mergeIfNotBlank" has been modified to migrate to this option and add a l10n_state database field if a TCA table used "mergeIfNotBlank" but did not add the l10n_state field manually via ext_tables.sql yet. New extensions can easily use the new option right away, extensions that need to stay compatible with v7 and v8 can add both options right away to have the same output. The main goals to achieve with this change is now: * Have consistent database values for all records regardless of l10n_mode=mergeIfNotBlank paving the way to fetch translated records without having to overlay (once l10n_mode=exclude is also copying values and relations) * Be more explicit for editors about records that have a different or the same state as their l10n_parent/l10n_source as a benefit for bigger instances with a lot of languages * Avoid hidden magic when retrieving localized records in the TYPO3 Frontend. Resolves: #79658 Related: #79243 Releases: master Change-Id: I6c2dbfeb09b47f958a536c9ab050c24ba4bbcbbd Reviewed-on: https://review.typo3.org/51291 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
- 01 Feb, 2017 1 commit
-
-
Change string comparison for string checks. Checks which could lead to false positives like comparing with '0' or '' are excluded. RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+') Resolves: #79540 Resolves: master Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9 Reviewed-on: https://review.typo3.org/51462 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- 28 Jan, 2017 1 commit
-
-
Use tooltips instead of ancient JavaScript alerts for locked records. Resolves: #79422 Releases: master Change-Id: Ia9911f8eaad1c55c2af14e366af13e0e9b7b21df Reviewed-on: https://review.typo3.org/51387 Tested-by:
-
- 26 Jan, 2017 1 commit
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a pretty huge list of TCA changes and simplifications, all TCA changes are supported by TCA migration, so existing extensions should benefit out of the box and just get deprecations logged. Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab Resolves: #79440 Resolves: #70032 Releases: master Reviewed-on: https://review.typo3.org/51151 Tested-by:
-
- 25 Jan, 2017 1 commit
-
-
With the update of cs-fixer to version 2.0, some checks got minor changes in behaviour. The core follows now in applying those suggested changes. Resolves: #79469 Relates: #79361 Releases: master Change-Id: I5d17b750231dcb386002b3e46b3a89c59eca2989 Reviewed-on: https://review.typo3.org/51428 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- 18 Jan, 2017 1 commit
-
-
Tags must not be stripped away for creating diffs as those are essential for editors. Otherwise it is not possible to see changed links or changing a header from h1 to h2. Resolves: #78767 Resolves: #79205 Releases: master, 7.6 Change-Id: Icb174f3522354fa8ef5d2b8ccca039e33ef472e7 Reviewed-on: https://review.typo3.org/51220 Tested-by:
-
- 11 Jan, 2017 1 commit
-
-
The TCA setting "l10n_mode=mergeIfNotBlank" for a single column is removed from the list of values. The functionality was there to use the value of a field of the original record, if the value of the translated record is empty (or trim'ed empty), and is then overlaid. The new behaviour is to duplicate the behaviour during the localize process, and then completely separate. As a result the related TypoScript setting config.sys_language_softMergeIfNotBlank is not required anymore and is removed as well. Resolves: #79243 Releases: master Change-Id: I55f3ebd2fe2ddd8412101d5496a0da3c5ab64c68 Reviewed-on: https://review.typo3.org/51239 Tested-by:
-
- 03 Jan, 2017 1 commit
-
-
The patch adapts a series of nasty form engine areas to more solid code. The evaluate condition code is rewritten and works much better in flex form scenarios. The suggest wizard and svg tree are much more solid in flex forms. The group element is rewritten towards a better readable and easier to refactor code, dropping method dbFileIcons(). A bunch of issues is resolved along the way. * TCA "default" now works in flex form section container elements * The "displayCond" parser is now strict and throws exceptions on invalid syntax and wrong referenced fields to help debugging faulty display conditions * TCA displayCond on flex fields can now be prefixed with the sheet name and can reference field values from neighbor sheets * TCA displayCond now works with flex section containers * TCA flex section container now throw an exception if select or group fields configure a MM relation - this is not supported * TCA ctrl requestUpdate field is dropped, onChange=reload is now allowed not only on flex form fields, but also on normal columns fields * TCA tree now works as section container element and initializes correctly on new records and new containers * GroupElement rewrite to drop dbFileIcons() * config option maxitems now optional for type=group and type=select and defaults to "many items allowed" * inline now works in "fancy" flex situations with "new" records by handing the final dataStructureIdentifier around * FormEngine no longer loads extJS Change-Id: Id1d081627529cc1502bb198389e5bd69372815cd Resolves: #78899 Resolves: #72307 Resolves: #75646 Resolves: #76637 Resolves: #72106 Resolves: #78824 Resolves: #76793 Resolves: #68247 Resolves: #69715 Related: #78460 Related: #67198 Related: #72294 Releases: master Reviewed-on: https://review.typo3.org/50879 Tested-by:
-
- 20 Dec, 2016 1 commit
-
-
Adding the root paths to the partials, which aren't autoguessed anymore. Resolves: #78969 Releases: master Change-Id: I578fd21ed0b232198301f73c702569980ed82906 Reviewed-on: https://review.typo3.org/50948 Tested-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- 02 Dec, 2016 1 commit
-
-
IRRE records have to point to their specific localized parent record. This works in general for tables containing records of the default language as well as localizations. For the "pages" table this look-up has to be extended to query from "pages_language_overlay". Change-Id: I84b6ee9304f85222430a5bdf62bd2271aae68fd5 Resolves: #76174 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/48495 Tested-by:
-
- 01 Dec, 2016 1 commit
-
-
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
-
- 18 Nov, 2016 1 commit
-
-
The patch refactors the TCA tree form engine data calculation. The tree now works with "new" (not yet persisted) records, even if the record has types in combination with flex forms. For instance, a new ext:news tt_content element now renders the category tree within flex forms, even in new tt_content records that have not been saved. The TCA tree no longer fetches all items when opening a record initially, but defers that to the ajax request. This gives a massive performance improvement on initial load of a record if the displayed TCA tree is bigger. The ajax request itself now compiles only data of the requested TCA field, also resulting in a significant performance improvement. As example, ext:styleguide "elements select" is now rendered much quicker and the single ajax calls per tree are reduced from about 4 seconds to less than a second each with my test data. Change-Id: If3c4c1779f5fe1510ffc13d1c9f1151bddab13e9 Resolves: #78744 Releases: master Reviewed-on: https://review.typo3.org/50700 Reviewed-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
-
- 12 Nov, 2016 1 commit
-
-
Markus Klein authored
Adding an empty alert message to the fieldChangeFunc array causes the fieldChangeFunc_hash to mismatch when pagination or search is used in the link browser popup. Add a check for an empty value, which is already present in another place in Core. Resolves: #75743 Releases: master, 7.6 Change-Id: I1a15400960d577c1a2a0a905643b56533d957100 Reviewed-on: https://review.typo3.org/50586 Tested-by:
-
- 26 Oct, 2016 1 commit
-
-
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- 20 Oct, 2016 1 commit
-
-
If the first palette of a form is hidden, a tiny line is append under the tab title. This patch removes it. Resolves: #78327 Releases: master, 7.6 Change-Id: Ibf0f3b9ed243a3d30de9bb726b17ffdec8414c65 Reviewed-on: https://review.typo3.org/50295 Tested-by:
Jérémie Roulin <jeremie@hemmer.ch> Tested-by:
-
- 09 Oct, 2016 1 commit
-
-
Resolves: #77819 Releases: master Change-Id: If39540863a1114ce5ce3e57289da54bdfdffc4f2 Reviewed-on: https://review.typo3.org/49764 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Reviewed-by:
-
