This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 04 Feb, 2021 1 commit
-
-
Benni Mack authored
This change migrate the TreeToolbar (used in FormEngine Category Tree for example) to TypeScript, removing effectively one RequireJS call and replacing it with a native TypeScript component. Removing the rest of the jQuery will be part of a separate effort. Resolves: #93432 Releases: master Change-Id: I3df66cd1c28d096c0f32982347dbd37c58834e4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67640 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 02 Feb, 2021 2 commits
-
-
Benni Mack authored
With #89496 the ContextMenu got keyboard support added. However, the underlying code does still use only a click event to trigger the ContextMenu, which is now also manually triggered for keypress events. It was therefore not possible to differ between the three possible ways, the ContextMenu can be used: 1. Mouse click only 2. Mixed 2.1 Click on ContextMenu and navigate via keyboard 2.2 Access ContextMenu via keyboard and navigate via click 3. Keyboard only Therefore, we now check the mouse position. If it's NULL, the ContextMenu was openend via keyboard. Furthermore, we use a boolean flag, which helps the getPosition method to determine the correct position in mixed mode. Using mouse click will now behave like before. Using the keyboard will now always use the boundingRect for positioning. Resolves: #93362 Releases: master Change-Id: I1e2be756b85d0a2286524f0bdc9cca76208935d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67510 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
In order to avoid loading an unnecessarily large complete d3 bundle, we now only pull in the small amount of modules we actually need. d3.transition() is replaced by the native web animation api, as d3-transition would pull in 4 more libraries (d3-color, d3-ease, d3-interpolate and d3-timer). d3-dispatch could easily be replaced by native CustomEvents, but it is a dependency of d3-drag and therefore shipped right now. This change reduces load size from 262K to 19K. yarn remove d3 yarn add d3-dispatch d3-drag d3-selection grunt build Releases: master Resolves: #93396 Change-Id: I1f4b58b967e2dcc57484863faafab3c2ec5d469a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67622 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 01 Feb, 2021 1 commit
-
-
Benni Mack authored
The PageTree component (added in TYPO3 v9) is based on SVG Tree, which was added in a previous version (TYPO3 v8). However, changes like https://review.typo3.org/c/Packages/TYPO3.CMS/+/55878/ unnecessarily coupled the SVG Tree to the PageTree. In addition, some minor details to NOT use pagetree IDs everywhere allows to use other SVG-tree based components in the navigation container in the future. id=typo3-pagetree-treeContainer is kept for typo3/testing-framework compatibility, for now. Resolves: #93389 Releases: master Change-Id: Ieb51e46937cfb2f11efeb976da09bc600af8b5cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67575 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 29 Jan, 2021 1 commit
-
-
+ removed NavigationComponentInterface - actually no class-like component did implement it + introduced TreeInterface, having some aspects of previous NavigationComponentInterface + aim to use native DOM operations (instead jQuery) where possible + switched templating in PageTreeElement and PageTreeToolbar to lit-html Resolves: #93380 Releases: master Change-Id: Ia2a05ff3d05193e52d440e409ecca4c1e1feb518 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67544 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 27 Jan, 2021 3 commits
-
-
When an IRRE field in FormEngine has maxitems set, and an item gets removed (thus, allowing an inline element to be added again), the buttons to create new elements are shown again. This fixes a regression introduced with #91595. Resolves: #93091 Resolves: #93238 Related: #91595 Releases: master, 10.4 Change-Id: If4c8152ab6e4fc1388fbfcf1af72fa2609f6df16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67541 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörn Wagner <joern.wagner@explicatis.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Jörn Wagner <joern.wagner@explicatis.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
The button in the topbar for switching of the navigation area (page tree for example) is removed in favor of: 1) a button to switch the navigation frame on / off layered above the nav container 2) a resizable handler on the right to finally resize the navigation tree again The feature now keeps the previously selected size in the users' "uc" configuration. When a user resizes the pagetree, it is kept during reload and next login. It is possible to resize (drag&drop) via the mouse or with touch events. Kudos to Benjamin Kott for his first draft in 2019 for this feature, where some parts of this implementation are taken from. Resolves: #78760 Resolves: #89355 Releases: master Change-Id: I4ead734fe2a4e7ce93191eeb03c3312ce7d94643 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67511 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
In #92704 the module menu got improved. The toolbar events were delegated to dedicated objects instead of just delegating to "document". Since the help menu is not the only toolbar component using those events, it must be delegated to the whole toolbar instead. Resolves: #93358 Releases: master Change-Id: I30b81ffcbdb5b460a548d2ffac90d8dca198808d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67522 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 22 Jan, 2021 2 commits
-
-
Use flexbox for layouting to avoid transform/position based shifting of the content module. Also use `position: sticky` instead of `position: fixed`, as it allows to avoid padding hacks. Also remove manual Viewport.doLayout() hacks, as we can now use `width: auto` as replacement for a static snapped-module menu width. Resolves: #93353 Releases: master Change-Id: I7d56a3b3b405e36d65c9a87a03360074354c3d9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67502 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
This change migrates the responsive topbar to flexbox, getting rid of some ugly "position: fixed" functionality as well as manual calculation of width / padding via JS, making the scaffolding better to understand and to use. On top, this change fixes bugs related to styling when using the topbar in non-desktop clients Resolves: #93318 Releases: master Change-Id: I510fd15cfce3243c0a8e6d5dcfcbd438476bb630 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67465 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Jan, 2021 1 commit
-
-
The module menu implements the keyboard navigation suggested by the ARIA Best Practices 1.1 for roles "menubar" and "menu". The first level menu has a "menubar" role, the second level submenus have a "menu" role. The buttons have the "menuitem" role. Both the "menubar" and the "menu" are oriented vertically for assistive technology matching the visual representation which affects the keyboard navigation. Space/Enter show the module unless the item has a submenu. Space/Enter and Right Arrow open a submenu and move focus to the first item. Up/Down Arrow and Home/End navigate within the current level of the menu. Ctrl + Home/End navigate within the first level of the menu (extension of the ARIA pattern). Left/Right Arrow moves to the parent item's predecessor/successor when on a submodule item. The submenu will not be closed (deviation from the ARIA pattern). Escape moves to the parent item of a submodule item. The submenu will not be closed (deviation from the ARIA pattern). Tab and Shift + Tab move to the next item outside of the module menu. The help menu implements the keyboard navigation suggested by the ARIA Best Practices 1.1 for the role "menu". This is the same as the module menu but limited to a single level. The change detaches again the module menu's event listener from the document as in #91642, but reinitializes the event listeners to handle situations as described in #93008 properly. Resolves: #92704 Resolves: #92634 Resolves: #92613 Releases: master Change-Id: I58ae5caa81882ccebd4e2ae2d944eb99e15a4b18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66283 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 19 Jan, 2021 1 commit
-
-
The Permissions backend module and its JavaScript module now ditch jQuery in favor of native browser API and TYPO3 API. The JavaScript has been refactored a little bit; initially checking the permission checkboxes or writing back the calculcated permission value is now decoupled and executed in the Permission module only. To support for..of with NodeList collections, TypeScript now loads the internal "dom.iterable" library. Additionally, the interim solution to add `editform` to Document has been removed which made another change in LinkPopup necessary. Furthermore, a bug has been fixed, where the value of the first visible select element was used when saving any other select element with a completely different value. Resolves: #93301 Releases: master Change-Id: Iffede862a0eb36e805a5f127d7b19f32c899ce31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67457 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 18 Jan, 2021 1 commit
-
-
The opendocs toolbar item does not have a badge background anymore, this changes re-adds the background and also unifies the badge from the system information toolbar to use the rounded-pill class. Resolves: #93303 Releases: master Change-Id: Ie2ecc99fd5ad4ad8845923af018c051665ac6118 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67459 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 11 Jan, 2021 3 commits
-
-
If a Flexform section gets deleted, the container must be hidden in DOM and not deleted, as the underlying DataHandler code relies on getting the field submitted. This patch is less intrusive as possible to allow a backport to stable releases. Flexforms needs a major refactoring and should act similar to IRRE, but this can go into the master branch only. Resolves: #93061 Releases: master, 10.4 Change-Id: I69dfdd6f2029547d600939f23e21b03abd45042d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67369 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
The correct height of the input group is restored by removing unnecessary wrappers around the buttons. See: https://getbootstrap.com/docs/5.0/forms/input-group/#button-addons Resolves: #93262 Releases: master Change-Id: I3e8276f66efbb593480371d3ee26d0ec08ba35d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67399 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
When an error occurs in a DataHandler AJAX call, the error message should only be shown once. Resolves: #93207 Releases: master, 10.4 Change-Id: I8f341d08bfe051af5a485f21628907c74a812490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 07 Jan, 2021 2 commits
-
-
Benjamin Franzke authored
SelectTreeElement makes use of $.param() without importing jquery via requireJS. Instead of adding the missing jquery import, we simply migrate to the native URLSearchParams, as it is available in all supported browsers. Furthermore we avoid decoding the datastructureidentifier json, as it is encoded to json server side. We do this, because URLSearchParams does not url encode nested objects. Resolves: #93200 Releases: master Change-Id: I0da98092da6e09d6576bbdb59112d738086be238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67323 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Colour contrast for footnote text meets WCAG 2.1 requirements. Role status for the caps-lock notice belongs to the div wrapping the image. The HTML document has a heading structure (h1 to h3). The content is placed in ARIA regions. The first form field has the autofocus (interface selector comes after password). All password fields have a caps lock status notification. The copyright notice implements the WAI-ARIA 1.1 disclosure pattern. The message after successful changing the password contains an accessible link. Resolves: #92904 Releases: master Change-Id: I67a2e61644711d20a20432b3eed4dca808ec591b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66818 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 06 Jan, 2021 4 commits
-
-
The FormEngine field type `selectMutlipleSideBySide` is very special, as it's a combination of four input and select fields. With the refactoring done in #87324 an issue in the validation has been introduced which caused the validation of the wrong field which contains no validation rules. This patch uses the correct field to obtain the validation rules from, now. Another issue is that values of `selectCheckBox` never have been validated as the necessary validation rules were missing. The rules are now appended to the outermost div container. In the same run, minor styling and markup changes were necessary. Resolves: #93191 Related: #87324 Releases: master, 10.4 Change-Id: I7195213a768fa4814eb3ecd81953a500c77ede5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67317 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
Benjamin Franzke authored
Migrates backend UI component `Notification` to be based on `lit-html`. Resolves: #93102 Releases: master Change-Id: Ic79ff0261c75fa5e7654ff44c213784302dc1b59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67179 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Andreas Fernandez authored
When sorting elements in an IRRE container, the sorting took grandchildren into account as well, which broke the sorting in the database. With this patch, a new data attribute is added to be able to identify direct ancestors and limit sorting to these records only. Resolves: #92804 Releases: master, 10.4 Change-Id: I09876c3a8be45b060c133d758807e4df25fee0d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66933 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
The login logo is linked only for technical reasons of a security check. It is not meant to be used by humans but is placed prominently enough to be an accessibility issue. Remove the link around the logo and create a new one hidden from the user interface. Resolves: #93172 Releases: master, 10.4 Change-Id: Id1edc5dd0e059a8700e4bb6c0e09e3f443b6f9fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67252 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 04 Jan, 2021 1 commit
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 29 Dec, 2020 3 commits
-
-
Loading the module menu on any page caused a JavaScript error. The fix prevents this by checking if the necessary HTML for the module menu is found in the HTML. Resolves: #91913 Releases: master Change-Id: I7d52b82706a06215583794b7bb4f9ffe44e3711a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67254 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
The module ImmediateActionElement is used to render a defined custom HTML tag triggering certain actions once it's rendered, like reloading the module menu or the backend's topbar. To achieve this, it needs functionality from the modules TYPO3.ModuleMenu.App.refreshMenu and TYPO3.Backend.Topbar.refresh. This module is loaded at a very early stage where those dependencies cannot do anything meaningful as there is nothing to do, namely the backend login, which causes JavaScript warnings and increases loading time. To relax the situation, the modules are now loaded dynamically when required by using async functions. In a perfect world, there would be some kind of a hooking system and no hardcoded list of actions, but we're not there, yet. Resolves: #92350 Releases: master, 10.4 Change-Id: I50029789f564ce339b3204d51f61e4cc39bb3cf9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65795 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Probably since ever, FormEngine validates the whole form when a field changed or an IRRE item got removed. This patch introduces the following changes: - only fields affected by the `change` event get validated - FormEngineValidation.validate() accepts an optional argument to define the container whose fields get validated. If omitted, the whole form is validated. Resolves: #93046 Releases: master, 10.4 Change-Id: I48d2f597c88815ebc0374bb02cf0aed6ac4086fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67094 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 21 Dec, 2020 1 commit
-
-
Bootstrap v5 – introduced in #92616 – was added with CCS from beta1 but JavaScript from alpha2. bootstrap.bundle.js was manually wrapped into a AMD closure, and because bootstrap 5.0.0-beta1 contains alot of changes regarding data tags, it couldn't be updated in the initial patch. Bootstrap is now bundled using rollup using the ES6 sources in order to allow for automatic updates through `grunt build`. popperjs – previously bundled into bootstrap distributed files – is now added as dependency. The bootstap ES6 sources, that we now use through rollup, do not bundle this external dependency (for good reasons). Dependency added with: yarn add @popperjs/core Further adaptions contained in this change to ensure beta1 compatibility: a) Carousel "item" to "carousel-item" class migration b) $.fn.modal(options) does no longer imply $.fn.modal('show') c) Fix panels, both JS and CSS (card-group can't be used here) d) All bootstrap data- tags are migrated to data-bs-. (see https://github.com/twbs/bootstrap/pull/31827) Migrated with # renderes a sed substition with the help of a nested sed from all the # data-bs attributes that where changed in the twbs/bootstrap commit git grep -l data- | xargs sed -i $( \ curl -s \ https://patch-diff.githubusercontent.com/raw/twbs/bootstrap/pull/31827.patch | \ sed 's/data-bs-[a-z-]*/\n&\n/g' | grep "data-bs-[a-z-]" | \ sort | uniq | \ sed 's/data-bs-\(.*\)\([^a-z-]\|$\)/ -e s\/data-\1\\\([^a-z-]\\\)\/data-bs-\1\\1\/g -e s\/data('"'"'\1'"'"')\/data('"'"'bs-\1'"'"')\/g/g' \ ) # Revert false positives from the above auto-replacement git checkout -- typo3/sysext/core/Documentation/Changelog/ \ typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php \ Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LiveSearch.ts \ Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineFlexForm.ts \ Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/ExtensionConfiguration.ts \ Build/Sources/Sass/typo3/_element_panel.scss (cd Build && grunt build) Resolves: #93126 Resolves: #93123 Resolves: #93132 Related: #92616 Releases: master Change-Id: Ie194d0f87d2c60df7b9e8a6de4893cfaaea55356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67215 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Dec, 2020 2 commits
-
-
See: https://getbootstrap.com/docs/5.0/components/navs-tabs/ for reference. Resolves: #93124 Releases: master Change-Id: Ifacfe27b269cb09fb002a37e9d809192708f13da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67213 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
This changes removes the frontend framework Bootstrap 3, and adds Bootstrap 5 beta 1 (we expect Bootstrap 5 final by the time we release TYPO3 v11 LTS). Bootstrap v3 is not supported by the Bootstrap team any longer, so an update is critical for TYPO3 Core. Bootstrap v5 adds a few accessibility improvements as well as flexbox for rendering containers and grids throughout TYPO3 Backend. All JS components are not bound to jQuery anymore, and have been reworked. A lot of HTML/CSS changes happened, which we slowly migrate (and not in a huge change) to TYPO3's templates, in order to keep this change managable. A legacy CSS/SCSS file is added to keep some backwards-compatibility classes to ease the migration for extension developers who have built their own backend modules. Key features of Bootstrap 5: * "rem" instead of "px" is used by default * CSS variables are introduced * Improved bootstrap focus outline styling (buttons / inputs / links) * Simplified grid functionality * use new button color mixin to increase contrast: Primary, Success and Warning Button color is now dark instead of white EXT:styleguide was used as a basis for upgrading to keep compatibility as much as possible, but more changes will be coming in the next few minor releases. Resolves: #92616 Releases: master Change-Id: Iec989f39649b5460b055ec879199faf38e424f2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 18 Dec, 2020 1 commit
-
-
The FormEngine table wizard in the backend is replace by a HTML custom element which allows to avoid server-side round-trips when manipulating table rows and columns. Resolves: #91811 Releases: master Change-Id: I8f9bc5b6c142d7492ff26461b4760eb68e132f2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65048 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 17 Dec, 2020 1 commit
-
-
To be able to introduce URL rewrites for the backend, the internal handling and registration of the shortcut PHP API is reworked. The Shortcut PHP API previously has the full URL of the shortcut target stored in the database. This lead to many problems such as shortcuts got invalid as soon as their target module changed its route path. Furthermore, this required unnecessary functionality like replacing tokens on URL creation. Therefore, a shortcut record now stores only the route identifier of the module to link to and necessary arguments in two new database columns. A upgrade wizard is in place to migrate existing data. The rework also required to deprecate some methods in the ShortcutButton API and a parameter signature change of the JavaScript function `TYPO3.ShortcutMenu.createShortcut()` which performs the AJAX call to create new shortcuts. Side effect, this also deprecated the last remains of xMOD_alt_doc.php in the core. Resolves: #93093 Releases: master Change-Id: I07666a299651e4953b4adf2987fcd3469094c288 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67143 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 14 Dec, 2020 1 commit
-
-
This reverts commit 6558a6bd. The client side template engine introduced in #91810 is inspired by lit-html. It was introduced because ES6 modules like lit-html could not be included in core AMD builds. With the help of rollup, lit-html can be converted to AMD within our build process. Therefore our own implementation is removed in order for lit-html to be introduced afterwards. Resolves: #93058 Reverts: #91810 Releases: master Change-Id: I2d5d20a6f9e0c8c4c683dafb6e36500f1966bd35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67095 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 11 Dec, 2020 1 commit
-
-
With #91642 some event listeners were detached from the global document object and reattached to better fitting DOM nodes to avoid pollution of too many event listeners in document. Unfortunately, this broke the module menu toggle after it has been reloaded, e.g. after installing an extension via Extension Manager. This change binds the event listener for the module menu state toggle to the document object again. Resolves: #93008 Related: #91642 Releases: master Change-Id: I5da58a997db311205accfbaf57874460ce077e91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67091 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 Dec, 2020 2 commits
-
-
Introduce a slim and simplistic client-side templating engine to avoid using custom template processing with e.g. jQuery and keep results robust agains cross-site scripting. This module has been inspired by `lit-html`, uses some of their vocabulary and behavior, but actually does not have all of their great features - see https://lit-element.polymer-project.org/ Resolves: #91810 Releases: master Change-Id: I4402f64625cb5526d246c315312a7977b68e88ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65047 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Inline JavaScript produced by BackendUtility:viewOnClick is substituted with markup based instructions and static JavaScript event handlers. // basically delivers window.open(generatedUri) BackendUtility::viewOnClick($pageId, $backPath, $rootLine, $section, $viewUri, $getVars, $switchFocus); can be substituted with e.g. \TYPO3\CMS\Backend\Routing\PreviewUriBuilder::create($pageId, $viewUri) ->withRootLine($rootLine) ->withSection($section) ->withAdditionalQueryParameters($getVars) ->serializeDispatcherAttributes([ PreviewUriBuilder::OPTION_SWITCH_FOCUS => $switchFocus, ]); which results in the following HTML data attributes (data can be retrieved as array of complete element as well) data-dispatch-action="TYPO3.WindowManager.localOpen" data-dispatch-args="["https://...",null,"previewWin"]" Resolves: #91123 Releases: master Change-Id: Iedd9bfe60827977677ee68e2c948c63e359abf84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64243 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 05 Dec, 2020 1 commit
-
-
The context menu shows on right click and pressing the context menu button as well as Shift+F10 where available. Inside the menu you are able to navigate using the arrow keys, the home and end keys. Items are activated with ENTER or SPACE key. Using the ESC key you can hide the current context menu. Resolves: #89496 Releases: master Change-Id: Icb10bdb927d1891785e82929e05e90475a846f08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66258 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 04 Dec, 2020 1 commit
-
-
TYPO3 has native Browser Notification API since a few TYPO3 versions. However, also due to recent security implementations (permission API) in browsers, and TYPO3 not strongly using this feature (only for LoginRefresh when a login is about to expire, and ONLY when this window is not focussed), this feature is dropped in favor of UX. Resolves: #92988 Releases: master Change-Id: I8e92d96bb47bf060f35b06375d8ff49ff131c185 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66997 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 03 Dec, 2020 1 commit
-
-
With the introduction of a new datetime picker, the listener for the event `formengine.dp.change` was not attached properly which broke the validation of updated datetime field. The listener is now attached to the datetimer field properly. To avoid introducing jQuery again, the method `FormEngineValidation.markFieldAsChanged` became aware of non-jQuery objects. Resolves: #92913 Related: #91606 Releases: master Change-Id: I3727f362a7d685fdea9bcdf0f1d3b37eca12d424 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66966 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 20 Nov, 2020 1 commit
-
-
Also add aria-expanded and aria-controls arguments for screen readers Resolves: #92682 Releases: master, 10.4 Change-Id: I48d0edcbea4d185d11216048d7847ad3574d704d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66271 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 11 Nov, 2020 1 commit
-
-
No need to use a fully qualified namespace for 3rd party modules that are placed in TYPO3/CMS/Core/Contrib. There are usually aliases configured in the requirejs configuration, and if they are missing, we add them now. This change additionally drops an unneded module declaration for "TYPO3/CMS/Core/Contrib/imagesloaded.pkgd.min" which is not needed when simply using "imagesloaded" as module name. Commands used: grunt build Releases: master, 10.4 Resolves: #92725 Change-Id: I6e7c02104050202d5c1a8bd0d7546a1496f5636c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65693 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-