This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 25 Aug, 2020 9 commits
-
-
This patch ensures the correct context (previous child id) is set on appending a new inline child after an existing one. Resolves: #91912 Related: #91863 Releases: master, 10.4 Change-Id: Ie6159049d23059a5fce38637499217af5a0b25a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65450 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Do not allow creating new records after translated records in the connected translation mode. Furthermore, disable cut, copy and paste for translated records in the connected translation mode. Finally, disable move records in the connected translation mode. Releases: master, 10.4 Resolves: #92084 Change-Id: I3a8bc68f572984d6c01a18719223a1e23a9034a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65445 Tested-by:
-
Using the context menu to create new pages on translated page records will create a new page with the default language. As this is not an expected behaviour, the new item of the context menu should be disabled in this case. Releases: master, 10.4 Resolves: #92081 Change-Id: I9f5aec78505d5f09a96d31ca83e9c3234d8d166d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65442 Tested-by:
-
On translated records in the connected translation mode the new item of the context menu has been disabled. Creating new records with that would end up in the unwanted mixed translation mode. Releases: master, 10.4 Resolves: #92082 Change-Id: I49f1aae3fbd9d6fd0f7208438d34b436fd3ecbd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65443 Tested-by:
-
The internal property oddColumnsCssClass is always empty. So it has been removed. Releases: master Resolves: #92085 Change-Id: I909fb72ea6e5edfdf321b8971f68484c41b990c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65446 Tested-by:
-
A loop in the Slug "uniqueIn*" check is broken because the comparison uses post-increment, and in case no valid slug with a counter suffix is found, $counter will be 101, not 100. Resolves: #91547 Releases: master, 10.4 Change-Id: If96974b52c6254b4b8298df24403ff3941489fbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64623 Tested-by:
-
The nearly identical methods getTreeList() of core classes QueryGenerator and QueryView are standalone methods that do not depend on further state of those classes. Those classes mostly belong to the ext:lowlevel DatabaseIntegrityController as their main jobs. To allow further refactoring of them, the patch drops 3rd party usages in ext:extbase and ext:workspaces, and protects the methods in a backwards compatible way. The new implementations are slightly more effective by skipping string implode/explode operations. The extbase change is accompanied by a new functional test to drop two heavy mocking unit tests. Change-Id: I38bcb4c25da159a86055d007428634eecd0d2f67 Resolves: #92080 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65440 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
When discarding a workspace change of a record that has been moved, the move-to-pointer (t3ver_state=3) is not set to deleted=1 as it should. This leads to issues, for instance the list module shows the records twice. The patch partially fixes this behavior: For top-level records, move pointer are now properly deleted as shown by Regular/Modify test moveContentToDifferentPageAndDiscard for a 'discard' case, and for a 'flush' related test case in existing deletingSysWorkspaceDeletesWorkspaceRecordsResult, which removes two todos. For relations, the issue is harder to tackle, for now coverage is added for inline csv and foreignField, to nail with @todos that delete cascading of move pointer records is still troublesome. Change-Id: I4598049973485c8559f7aabf574b7d78fdf66698 Resolves: #92092 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65447 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
With #90235 db based sorting in the main query that fetches the content elements to render has been accidentially removed. In many cases, this did not have any impact: The sorting field is part of a db index that is used for the query and some dbms like maria/mysql then tend to return rows determined by that index. But it can go wrong, too. The fix is to add proper ordering again of course. Resolves: #91223 Related: #90235 Releases: master, 10.4 Change-Id: If0931d8857a0e981181c72cc1a746d0a6b13ae12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64567 Tested-by:
Jürgen Venne <venne@schaffrath-digital.de> Tested-by:
Denis Mir <mir.denis@googlemail.com> Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de>
Reviewed-by: Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
- 24 Aug, 2020 2 commits
-
-
With #82729 the $GLOBALS['SOBE'] = $this; assignment in DatabaseIntegrityController has been removed. This is a good thing, however parts of QueryGenerator class still relied on this. The patch gives the module settings that have been introduced for #83428 from QueryView down to QueryGenerator as well. This fixes a couple of details, most importantly the 'Show even deleted entries' checkbox of the full search advanced query view works again. Resolves: #92079 Related: #83428 Related: #82729 Releases: master, 10.4 Change-Id: If8b5ef9e2d86910625455e37d029c5e93e5ef519 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65439 Tested-by:
-
The changes in #91990 required at least version 6.4.1, but the version was not pinned in composer.json to reflect that (only composer.lock was updated). Therefore bamboo nightly composer min stage failed. Used command: composer require --dev typo3/testing-framework:^6.4.1 Resolves: #92083 Related: #91990 Releases: master Change-Id: I1397cc4d922e90c7864e2f7682b7d1ff1c59133c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65444 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- 23 Aug, 2020 7 commits
-
-
By having testing-framework load ext:fluid by default for functional tests, the workaround of disabling autowiring for TemplateView class can be removed. DI is now available for TemplateView class as expected. used command: composer require --dev typo3/testing-framework:^6.4 Resolves: #91990 Releases: master Related: #88689 Change-Id: I4b525afbb271934f325ef6b8da83cec673dceb1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65290 Tested-by:
-
Since the bugfix #92075 the internal property pageinfo isn't used anymore. Releases: master Resolves: #92076 Change-Id: I9e21b9ac0e789b3a7554b4e103815646c166a93a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65436 Tested-by:
-
The information about collapsed tables is only needed in the getTable method. So the information could be collected there and the property tableCollapsed has been dropped. Releases: master Resolves: #92077 Change-Id: If6c6bc6d6b7108975a2b1b4e0fdfb01fe2e06fbe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65437 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Reviewed-by:
-
The property has been dropped, as it doesn't do anything useful. It is internal (see section), it could be dropped without further notice. Releases: master Resolves: #92074 Change-Id: Iced7f072c180467c1ee0473477e1d10369cc17ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65434 Tested-by:
-
The internal property addElement_tdParams is always empty. So it has been removed. Releases: master Resolves: #92078 Change-Id: If6900b8aec4cbc96230ef07a6889a1015775e709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65438 Tested-by:
-
Respect the configuration mod.newContentElementWizard.override and make it work again. Releases: master, 10.4 Resolves: #92075 Change-Id: I5d9d6ada2c502629a4cae67794d9d3a251de600f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65435 Tested-by:
-
This reverts commit 99b0da83. Reason for revert: The patch breaks bookmarks handling of info sub modules. Change-Id: Ie2ae033508728c55557bb5bd4f2d508a5dd3cd2e Reverts: #92070 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65425 Tested-by:
-
- 22 Aug, 2020 12 commits
-
-
Symfony expects a colon after the class name. Releases: master, 10.4 Resolves: #92073 Change-Id: I5476acb035875fa55a1ec00a57d0b34c74242750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65433 Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: -
Helmut Hummel authored
Use IMAGECROPSCALEMASK to render IRRE thumbnails, so that the crop area is properly respected and the TCA configuration for the rendering is applied as well. Also fix the resolving of the crop area, which remained undiscovered, as the crop configuration is ignored with IMAGEPREVIEW processing. Releases: master, 10.4, 9.5 Resolves: #91978 Change-Id: Ia986bc4ec77ce06a9dacbced0b536462f19db1a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65278 Tested-by:
Tim Schreiner <schreiner.tim@gmail.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Helmut Hummel authored
Due to the fact that configurable processors weren't present when online media handling was introduced, a lot of code needed to be duplicated to make the processing work in a pre process event. Since we have configurable processors now, the code should is moved to a processor and the code duplication removed. This change is also a prerequisite to make deferred image processing work more smoothly, because the online media preview processing should be handled after a deferred image processor but before regular local image processing. Resolves: #92024 Releases: master, 10.4 Change-Id: Ifbc1159a0e98d2e42fedf6a57764778293b6035d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65346 Tested-by:
-
Helmut Hummel authored
Instead of spreading (similar) code that handles SVG files in multiple classes with conditional code branching, processing SVG files (mostly calculating new width and height according to the configuration) is now placed in an own file processor. Cropping SVGs is still done like before using IM/GM and resulting in an png image. In this case the new processor is skipped and the file is passed to the existing LocalImageProcessor. A new class is introduced, which calculates resulting image dimension from an original dimension and a given processing task. Releases: master, 10.4 Resolves: #92014 Change-Id: I5799c09b06d32a495a917da523506a6cc1f8e45d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65339 Tested-by:
-
This change makes sure to set up the page in the TYPO3 Backend, to load JS and CSS directly in PageRenderer when the ModuleTemplate object is instantiated, allowing to load custom JavaScript or CSS. Before, renderContent (the last call in ModuleTemplate) was used to add default CSS and JS. Resolves: #91812 Releases: master, 10.4 Change-Id: I87c8392d3784d3ac63a086846e85fae76663d4a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65236 Tested-by:
Marcus Schwemer <ms@schwemer.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
So far always the SKIP action was executed. But in the drop-down of the actions the correct option was already selected. Now the default action is also executed and not only displayed. Resolves: #91985 Releases: master, 10.4 Change-Id: I1b03019eb6b0ed112abc2e6afb528094faf83018 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65398 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Since #90272 the PageLayoutView works well without the SOBE assignment. Drop that from InfoModuleController. Resolves: #92070 Related: #90272 Releases: master Change-Id: I3cc243cfabe5728b3e6dc93a7340386165aff501 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65409 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
The $GLOBALS['SOBE'] = $this; assignment has been kept in EditDocumentController together with two public properties to keep an old working version of the ConditionMatcher. This has been resolved meanwhile, the code can be dropped. Resolves: #92069 Related: #87607 Releases: master Change-Id: I89598d13f68c17451c0acad1f6e04b501f5fd792 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65408 Tested-by:
-
Releases: master Resolves: #92072 Change-Id: Ife789cdff756261b59785ad816af35d58cc7bb4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65411 Tested-by:
-
For each TCA table a query to determine if a result exists is made. It could have been some kind of performance optimization, but it results in an additional query for each table with records in place. Such optimizations should be done in the getTable method by using the existing query to count the total number of records of the table. Therefore, the query result (the total number of records of the table) has been used for a guard clause. Releases: master Resolves: #92071 Change-Id: Idc2026eaaa699ab358625d00670a5bc1e8ab341f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65410 Tested-by:
-
Furthermore, there is no need to query the references for each record twice. So this has been dropped as well. Releases: master, 10.4 Resolves: #92049 Change-Id: Ia873baaad5ace7f0713ccba293eeaccf5b2a985b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65432 Tested-by:
-
The patch for issue #91210 introduced a side effect that bookmarks to controllers which are not directly registered as backend modules do not show up again because the ModuleLoader->checkMod() call does not return an array anymore. Bookmarks to records of FormEngine / EditDocumentController are affected by this and are simply not rendered as bookmark toolbar items. The patch applies a hack to the ShortcutRepository to deal with this. We need a better module / controller access API substituting TBE_MODULES to deal with this properly. EditDocumentController does it's own access checks for records, so the patch shouldn't add security harm. Releases: master, 10.4 Resolves: #91368 Related: #91210 Change-Id: I0add57326b12182a1c11ee6bd09e61b0f1c204f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64476 Tested-by:
-
- 21 Aug, 2020 10 commits
-
-
Resolves: #92048 Release: master, 10.4 Change-Id: I5fa64c5559e53864eb36a0bea01e51cd3ebf8702 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65364 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Andreas Fernandez authored
The events dispatched by AjaxDataHandler are changed to be always named `typo3:datahandler:process`. This is done to ease registering event listeners as the executed action is part of the sent payload already. Since this feature is not documented and propagated yet, this is considered being not breaking. Resolves: #92028 Releases: master, 10.4 Change-Id: Ibe69d7297bbc6e17fd744ebf96c3f88f719e533d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65349 Tested-by:
-
Move table related query parts to getQueryBuilder: * Move the hook "getTable" to getQueryBuilder * Move query constraints from getTable to getQueryBuilder * Set field list as parameter to getQueryBuilder * Set limit, offset, addSorting as add. parameters to getQueryBuilder * Move code from prepareQueryBuilder to getQueryBuilder Related to the usage of getQueryBuilder: * Use getQueryBuilder to calculate if a table has any result. * Use getQueryBuilder to calculate the total number of hits. Move getSearchString to makeSearchString. Releases: master Resolves: #92065 Change-Id: Ic9dcdca3172b3229986c065e8aa0fd2f5ebb6078 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65402 Tested-by:
-
This commit changes the return hint of TYPO3\CMS\Core\Domain\Repository\PageRepository::getRecordOverlay to mention that the function returns NULL instead of FALSE, if $OLmode is "hideNonTranslated" and no translation is found Resolves: #92052 Releases: master, 10.4 Change-Id: I5ee9504d234b230f80a6108ad53698770cc56f60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65392 Tested-by:
-
The setting `detectDomainRecords` and its sub configuration `detectDomainRecords.target` must be created by using the TypoScriptService. Resolves: #91979 Releases: master, 10.4 Change-Id: Iaeaa97487be62b10364a9ac2f87430ee2b47bd94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65285 Reviewed-by:
-
The class seems to be unused for a while. Drop without substitution. Don't confuse this removal with class TYPO3\CMS\Backend\Tree\View\PageTreeView. Resolves: #92060 Releases: master Change-Id: Ic35f42bc3fe0cb6803482f29f8a205e0b14795d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65397 Tested-by: Daniel Windloff Tested-by:
-
`import = require('…')` should only be used when the required module exports via the respective `export =` instruction. As MessageUtility exports only one named export (called `MessageUtility`), we should import via ES6 named import syntax. Note: Technically (in the generated source) this change makes no difference, as the named export was available as property of the AMD export-object, and therefore `import = ` worked. Therefore there are no changes to the generated files when executing: grunt build Resolves: #92064 Releases: master, 10.4 Change-Id: Ie2376890e23a6d233387ab5cc3914e9dc57a8015 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65404 Tested-by: -
In extension 'recycler', the DeletedRecordsController is only used from within the RecyclerAjaxController. Controller calling other controllers this way is bad code smell. The patch merges the transform() method together with its helper methods into the RecyclerAjaxController and applies minor cleanups to the class along the way. Resolves: #92055 Releases: master Change-Id: I75f39375a55cca7f640836f8550204e4a5da3475 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65393 Tested-by:
-
Remove the unnecessary wrapper method initCSV. Use addHeaderRowToCSV instead. Releases: master Resolves: #92063 Change-Id: I7d5b710cf174c172c0d327f6e8dd070654e6b4c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65403 Tested-by:
-
The patch fixes a couple of database restrictions to prevent the recycler from showing workspace related records in live workspace. Note there are further issues with the recycler in workspace context. Those need work on workspace record lifecycles first, and are not tackled with the patch. Resolves: #92056 Related: #21299 Releases: master, 10.4 Change-Id: Ib2d9a14231d01a861c731f4ce39b8f0cf5eddc73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65394 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
