This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 30 Oct, 2020 1 commit
-
-
Resolves: #92681 Releases: master, 10.4 Change-Id: Ibd8af66dbcbab596d2f1538e2342092235a98f2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66254 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 02 Oct, 2020 1 commit
-
-
For the inline record header controls the InlineRecordContainer calculates the permissions for the page, the record is on. Previously the calculation was based on the records pid. This does not work for new records as the pid is a negative integer in this case - uid of the record the `new` button was pressed on - and therefore led to no header controls were displayed till the record was saved. The calculation now uses the correct uid from `parentPageRow`. Resolves: #84867 Releases: master, 10.4 Change-Id: I3d60f41ed51ff2f013d37c6aa9c118974d06acad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65999 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 19 Sep, 2020 1 commit
-
-
Resolves: #92344 Releases: master, 10.4 Change-Id: Ia34b93a6fefaee408da7b54965cf02e138cadf26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65769 Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by:
-
- 03 Sep, 2020 1 commit
-
-
The Permission class unnecessarily had been implemented as Enumeration although the features of the Enumeration base class hadn't been used. As the Permission class only handles boolean flags, it is now implemented as bit set, which improves the performance in comparison to Enumeration classes. Releases: master Resolves: #89465 Change-Id: I73eff34090a7ea8e02f7d538e2db52045c86d438 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 25 Aug, 2020 1 commit
-
-
Each node in an IRRE container now has a new `data-placeholder-record` attribute to be able to identify such node w/out accessing CSS classes used for styling purpose. Nodes where `data-placeholder-record` has a truthy value are localizable and are ignored now when the sorting is changed which solves an issue where such records would have been moved into a different language. In the same run the localization is fixed as it was tried to iterate an object, which doesn't work. Alternatively, the object values are fetched and iterated now. Resolves: #91942 Resolves: #91938 Releases: master, 10.4 Change-Id: Ic6622eb5d6950893f79d4ae9697d7eaa096d2ef9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65214 Tested-by:
-
- 22 Aug, 2020 1 commit
-
-
Helmut Hummel authored
Use IMAGECROPSCALEMASK to render IRRE thumbnails, so that the crop area is properly respected and the TCA configuration for the rendering is applied as well. Also fix the resolving of the crop area, which remained undiscovered, as the crop configuration is ignored with IMAGEPREVIEW processing. Releases: master, 10.4, 9.5 Resolves: #91978 Change-Id: Ia986bc4ec77ce06a9dacbced0b536462f19db1a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65278 Tested-by:
Tim Schreiner <schreiner.tim@gmail.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- 29 Jun, 2020 1 commit
-
-
nprogress is used to indicate activity when a collapsed IRRE node is about to get loaded. In case of FlexForms the id attribute may contain a dot which is not an issue if handled correctly. However, nprogress doesn't treat this value as an id, but rather as a full CSS selector which causes issues and breaks loading the IRRE node. To work around this issue, the id of the container used to render the progress bar is now MD5 hashed. Resolves: #91585 Releases: master, 10.4 Change-Id: I893d0cf24ea0f384d9ffff4d84f83b0fa35341b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 03 May, 2020 1 commit
-
-
Andreas Fernandez authored
IRRE relied on the HTML comment `<!--notloaded-->` to detect whether a record is already loaded or not. As this might collide with HTML minification, the comment has been replaced with a class placed in the panel. Resolves: #91258 Releases: master Change-Id: Ibe890317bdcb9707a71de1168de0d404fb3c67a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64385 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- 17 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/backend/Classes bin/rector process --set=php53 typo3/sysext/backend/Tests Releases: master Resolves: #91064 Change-Id: I9e91882ab233b0e34bc991fd348fceba197a91ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64187 Tested-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 06 Mar, 2020 1 commit
-
-
Benni Mack authored
Most access to the configuration options are made against AbstractFile objects in FAL, which is now centralized in one place in AbstractFile. This reduces errors when checking for file patterns. Resolves: #90305 Releases: master Change-Id: I7835d877bae1addf830ede3645ff8f1faa113052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63155 Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 30 Jan, 2020 1 commit
-
-
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
-
- 09 Nov, 2019 2 commits
-
-
In case of IRRE in site context not the full form engine variables are available - therefor a fallback has been implemented. Resolves: #89628 Releases: master, 9.5 Change-Id: I0c499d41354e4dc369f5a53f2109d8559b5e3bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62265 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
The value of `data-table-unique-original-value` was accidentally of type array. This causes runtime errors since a string is expected. This patch now creates a proper value passed to FormEngine to handle the original unique value. Resolves: #89588 Related: #87711 Releases: master, 9.5 Change-Id: I9184aa025f01196d0c206b5b86c712dc1049487f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62195 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 11 Sep, 2019 1 commit
-
-
This patch fixes some flaws in the IRRE uniqueness handling: - Validation is triggered once a record has been removed from DOM - Removed records are now added to their selector again if not opened before - Uniqueness handling now works for records with uid "0", which is relevant for a site's language handling - The unique update is now triggered only when the value of its selector in a record actually changes Resolves: #87711 Releases: master, 9.5 Change-Id: I9fe15d8e8790eff305024b706450cd2c37da9340 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61578 Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
- 05 Sep, 2019 1 commit
-
-
If a TCA field is set to readOnly=true and is using the type "inline", all buttons are now hidden and the fields of the relation are set to readOnly as well. Resolves: #56060 Releases: master, 9.5 Change-Id: If2b1cb2be0591d765f40512aaf341a9c26a2f87f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61490 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
- 24 May, 2019 1 commit
-
-
This patch refactors the IRRE handling on client side, the JavaScript land has been rewritten to have a better structure and do less repeating on-the-fly calculations. Each IRRE container is represented by a independent instance of InlineControlContainer. Most of the internally used `scriptCall` directives have been removed. Currently, `scriptCall` can't get removed completely, as further refactorings in different areas are required. All of the "external" communication via `inline.foobar()` has been replaced by a event-driven approach. This also affects ElementBrowser windows, those use a minimalistic API based on postMessage. Some code that was never evaluated in ElementBrowser is considered dead and has been removed regarding inserting multiple items. A new sorting library has been added in order to replace jqueryui piece by piece. Executed command: yarn add --dev sortablejs On PHP side, some code has been removed as well since the rewritten client code is event-based and doesn't depend on external calls anymore. Resolves: #88182 Releases: master Change-Id: I4176483d2882cef49fbaddb5e2e1914c1f76c908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59324 Tested-by:
-
- 15 Mar, 2019 1 commit
-
-
Replace string concatenations like 'abc' . 'def' with 'abcdef'. Resolves: #87004 Releases: master Change-Id: I9c1a610e88dd4bd4e617214989a915b1dafda094 Reviewed-on: https://review.typo3.org/c/60155 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- 07 Mar, 2019 1 commit
-
-
Despite $resultArray['additionalHiddenFields'] being properly set by the elements, this section is never evaluated in InlineRecordContainer. Evaluate content in this property and render the fields in the HTML output. Resolves: #87614 Releases: master, 9.5, 8.7 Change-Id: Idb45a906d3cb019e915c94df59fa215405cb1af3 Reviewed-on: https://review.typo3.org/c/59605 Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
-
- 02 Sep, 2018 1 commit
-
-
strpos will use only CPU resources, substr also needs memory allocation. Resolves: #85477 Releases: master Change-Id: Ic25c99986f7e2e7237c10acaa75be8d0f6289f13 Reviewed-on: https://review.typo3.org/57466 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- 25 Apr, 2018 1 commit
-
-
This commit moves any language file of EXT:lang into a proper destination, which renders EXT:lang obsolete. This change requires an update of typo3/testing-framework, done with this command: composer update typo3/testing-framework Resolves: #84680 Releases: master Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d Reviewed-on: https://review.typo3.org/56017 Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
- 02 Mar, 2018 1 commit
-
-
These parentheses are redundant and may be safely removed. Resolves: #84092 Releases: master Change-Id: I59f2b7454316ecd05f57d28e344f03a65d13e5c5 Reviewed-on: https://review.typo3.org/55952 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- 12 Feb, 2018 1 commit
-
-
Resolves: #83844 Releases: master Change-Id: I5fef80a48d52da9800a7a9a2a23445d60168e8b5 Reviewed-on: https://review.typo3.org/55659 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
-
- 27 Dec, 2017 1 commit
-
-
Some PHP classes still contain unused use statements. They have been removed. Thanks to @cd on his initial patch https://review.typo3.org/52014/ Resolves: 83432 Releases: master Change-Id: I9020f505a826c40fcf11f75f87245293e7c6154f Reviewed-on: https://review.typo3.org/55217 Reviewed-by:
-
- 19 Dec, 2017 1 commit
-
-
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- 30 Nov, 2017 1 commit
-
-
The new PSR-7-based solution since TYPO3 v7 should be used everywhere instead of "BackendUtility::getModuleUrl()". This is possible because modules can be addressed via the "route" GET parameter instead of the "M" parameter since a few months. The patch changes all occurrences within TYPO3 Core to use the new API. Resolves: #83172 Releases: master Change-Id: Iec40e8ae00f1d900d7479b84a3a62827ddba653b Reviewed-on: https://review.typo3.org/54755 Reviewed-by:
-
- 28 Nov, 2017 1 commit
-
-
This avoids an error in case file metadata is edited through a file reference and there is no file metadata translation for the current language. Resolves: #76262 Resolves: #82178 Releases: master, 8.7 Change-Id: Ifecf659637773c5f3773fc3439b09df9c030cb3f Reviewed-on: https://review.typo3.org/54778 Tested-by:
-
- 27 Nov, 2017 1 commit
-
-
Several hundred function calls and vast numbers of indentations can be saved by using the null coalesce operator instead of checking empty/array. Change-Id: I38f2ce2de83a454aaa0d16c771014b6de84b3f7a Releases: master Resolves: #80812 Reviewed-on: https://review.typo3.org/52416 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 03 Nov, 2017 1 commit
-
-
If an inline child, opened via ajax request, generates links leaving the current records and opening a different one, on closing that record the returnUrl is wrong and points to the url of the inline ajax request. The original return url of the main record is lost in the compile chain. The returnUrl data provider sets $data['returnUrl'] to current url if not otherwise given. The patch hands over the original return url to the inline ajax controller and lets it 'sink down' in the data compile chain to inline children so the original return url is available when container or elements generate urls. Additionally some broken 'returnURL' handling in InlineRecordContainer and jsfunc.inline.js is cleaned up and removed. Change-Id: Ia47dc8cee068fc9c4d1c5e16c1960b1a58fcb2f5 Resolves: #82525 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54543 Tested-by:
Kjeld Schumacher <k.schumacher@familie-redlich.de> Reviewed-by:
-
- 09 Sep, 2017 1 commit
-
-
Until now all of the backend icons were a manually edited array of file paths. With this patch defined icon folders in the core are scanned for existing icon files and build most of that static array automatically. For historic reason (and hopefully soon to be removed alltogether) a second array of statically declared icons is added and merged into. Some icons that were in the original static list but whose files actually are missing or misnamed are marked as deprecated. Resolves: #82348 Releases: master Change-Id: I8dc4fbbe815d923eda55e1c1b072369e62f66d87 Reviewed-on: https://review.typo3.org/54020 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- 13 Jul, 2017 1 commit
-
-
The 'imagefile_ext' list only contains the lowercase versions of all supported extensions. This patch makes sure that a lowercase version of the file extension is used and it is recognised as an image file. Resolves: #81826 Releases: master, 8.7 Change-Id: Ice5881be4c685432987530dcdd50b1f758d883ef Reviewed-on: https://review.typo3.org/53427 Tested-by:
-
- 04 Jun, 2017 1 commit
-
-
Check files if they are image files before thumbnail generation. Change-Id: I7dae2ccbb5ab93e582d21efe8f7d29cf7006a1c3 Resolves: #81147 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53107 Reviewed-by:
Jo Hasenau <info@cybercraft.de> Tested-by:
-
- 02 Jun, 2017 1 commit
-
-
If the info icon is disabled it is now removed completely. Previously the logic for new records was not caught correctly, so that the case for the enabled icon with a new record was executed. Disabling the icon should remove it completely, as a disabled non-clickable icon is not helpful and confusing for editors. This is now done, and the case for the enabled icon with new records is also correctly caught. Resolves: #81380 Releases: master, 8.7 Change-Id: I1c78a99a83efa3c88e3a6337df9cd0c8a959ea7b Reviewed-on: https://review.typo3.org/52970 Reviewed-by:
Daniel Windloff <daniel.jc.windloff@googlemail.com> Tested-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
- 18 May, 2017 1 commit
-
-
In order to be consistent, change the button order and styling (according to the list module) in the InlineRecordContainer. Resolves: #78174 Releases: master, 8.7 Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0 Reviewed-on: https://review.typo3.org/50104 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
-
- 27 Apr, 2017 1 commit
-
-
This function now does the same as makeInstance() except for an if() clause, since the API should be unified this method should be considered as dropped, allowing to use callUserFunction() and makeInstance() as the only two proper ways to call custom classes / methods. Resolves: #80993 Releases: master Change-Id: I0c2042dbe6c83a86f211bab4eaf64d75e6424232 Reviewed-on: https://review.typo3.org/52518 Reviewed-by:
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 01 Feb, 2017 1 commit
-
-
Change string comparison for string checks. Checks which could lead to false positives like comparing with '0' or '' are excluded. RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+') Resolves: #79540 Resolves: master Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9 Reviewed-on: https://review.typo3.org/51462 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- 28 Jan, 2017 1 commit
-
-
Use tooltips instead of ancient JavaScript alerts for locked records. Resolves: #79422 Releases: master Change-Id: Ia9911f8eaad1c55c2af14e366af13e0e9b7b21df Reviewed-on: https://review.typo3.org/51387 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
-
