The SQL parser is capable of parsing

    JOIN T1 ON T1.some_field = T2.some_other_field

and

    JOIN T1 ON T1.some_field = 4

but not

    JOIN T1 ON T1.some_field = 'some string'

Change-Id: I7806699ea44685ab717cc0e8a75f7b53a1b2b1cc
Resolves: #67385
Related: #66614
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/40144


Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>

Frank Nägler authored May 29, 2015 and Andreas Fernandez committed Jun 03, 2015

The patch fix problems with multiple parenthesis. e.g.
uid_foreign,tablenames(255),fieldname(255),sorting_foreign

Resolves: #66738
Releases: master
Change-Id: I49abc597e9c325a22d49c3d76355ecadec30a35d
Reviewed-on: http://review.typo3.org/39786


Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>

It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.

The replacement rules are applied as follows:
 *    if (strlen($str))
   => if ((string)$str !== '')
 *    if (!is_string($str) || strlen($str) === 0)
   => if (!is_string($str) || $str === '')
 * If it can be seen easily that $str is a string,
   the typecast is omitted.

Change-Id: I888d70e42f925bd57ad23b873b72d6a38acb39ef
Resolves: #54091
Releases: master
Reviewed-on: http://review.typo3.org/27794


Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>

Andreas Fernandez authored Jul 23, 2014 and Christian Kuhn committed Jan 15, 2015

Introduce a few optimizations in
the SqlParser classes of "core" and "dbal".

* Change some regular expressions (see benchmark file in forge)
* Strict comparison
* Put often used variable manipulation into a new method
* Definition of $comparatorPatterns was in a while() without any
  modification on it, so make it a protected member

Resolves: #60479
Releases: master
Change-Id: Ica1d3686e30835b7540e159bb5a34127d206f054
Reviewed-on: http://review.typo3.org/31730


Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Roland Waldner authored Dec 16, 2014 and Christian Kuhn committed Dec 17, 2014

Most of TYPO3's PHP files have an empty line before a class' closing curly
brace. This commit adds this empty line (if it is missing) before a class'
closing curly brace.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
(}\n)(})

Replace:
$1\n$2

Resolves: #63942
Release: master
Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7
Reviewed-on: http://review.typo3.org/35527


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Roland Waldner authored Dec 06, 2014 and Christian Kuhn committed Dec 13, 2014

This regular expression was used to replace PHPDoc style comments
with ordinary comments:

Search:
/\*\*(\n \* This file is part of the TYPO3 CMS project.)

Replace with:
/*$1

Resolves: #63328
Releases: master
Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8
Reviewed-on: http://review.typo3.org/35103


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>

Also convert FIXME to @todo.

Change-Id: I98cf8a2c4c732acc7024e36ed949fc4546bee439
Resolves: #63619
Releases: master
Reviewed-on: http://review.typo3.org/35086


Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>

* Add phpDoc to properties
* Add phpDoc to functions

Resolves: #62706
Releases: master
Change-Id: Id836e7a6e6110502769b48a7693315c42d79e28a
Reviewed-on: http://review.typo3.org/33802


Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>

* Use bool in @return
* Use int in @return
* Use bool in @param
* Use int in @param
* Remove extra tabs and spaces in @param

Resolves: #62506
Releases: master
Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2
Reviewed-on: http://review.typo3.org/33577


Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>

Resolves: #62468
Releases: master
Change-Id: I2790ca5817e16cfe0dc1c43151d2587ca796294a
Reviewed-on: http://review.typo3.org/33523


Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>

Georg Ringer authored Sep 29, 2014 and Wouter Wolters committed Oct 11, 2014

The "@todo Define visibility" is not very helpful because:

 * Nobody knows what breaks if changing the visibility
 * The code is flooded with todos which makes it hard
   to work with in an IDE

During ACME it was decided to remove the @todo again.

Resolves: #61957
Releases: master
Change-Id: I0caa9756bba326dc132b6a2dabe79218c53a32c8
Reviewed-on: http://review.typo3.org/33044


Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>

The Extension Manager creates a virtual "position" field containing
the relevance of a search hit. The relevance is calculated in a hacky
way working in MySQL only. This is replaced by a more understandable
query that is parsable by the SqlParser.

Resolves: #61204
Releases: 6.3, 6.2
Change-Id: I541cbeef745e8dc25131af2a937ec2d028a2fc2c
Reviewed-on: http://review.typo3.org/32393


Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>

Stefano Kowalke authored Feb 04, 2014 and Xavier Perseguers committed Sep 08, 2014

There are lines-breaks inside the string which produces
'SELECT * \n\t\t\t\tFROM table_name\n\t\t\t\tWHERE'
queries while compile the sql query back from the array.

This breaks the test for EXT:dbal because debugAndCompare()
function will die.

Releases: 6.3, 6.2
Resolves: #55648
Change-Id: Iab6ad451d30bb94494ebbd3cb3b69e661ee55c00
Reviewed-on: http://review.typo3.org/27318


Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>

For create-table "tableType" was still used while an alter-table
used "engine".

Change-Id: Idee0e569e331ec66084484f1e8d55d9cab03ff9f
Resolves: #61129
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32304


Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59780 for further details.

Resolves: #59780
Releases: 6.3, 6.2
Change-Id: I00eff31cdff19774527e3b1bb06e29152928414c
Reviewed-on: https://review.typo3.org/31025
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Properly implement MySQLi for DBAL native mode.

Resolves: #50752
Releases: 6.2
Change-Id: I0c36e7d2828c94cc7c726757f3adc086ffd68015
Reviewed-on: https://review.typo3.org/27875
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein

DBAL's DatabaseConnection::INSERTquery() builds an array. The keys
(fields) are mapped through quoteFieldNames(), which returns an empty
string. DBAL's SqlParser tries to use $GLOBALS['TYPO3_DB'], which is
not available here.

Resolves: #56306
Releases: 6.2
Change-Id: I97eff8f796fcb8d530d16ff5f6111ebd5d28d5ce
Reviewed-on: https://review.typo3.org/27864
Reviewed-by: Markus Klein
Tested-by: Markus Klein

This reverts commit de27a20a

Change-Id: I078d2f7bbff605c91d83a9853e8feb9c31d57ccc
Reviewed-on: https://review.typo3.org/27792
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.

The replacement rules are applied as follows:
 *    if (strlen($str))
   => if ((string)$str !== '')
 *    if (!is_string($str) || strlen($str) === 0)
   => if (!is_string($str) || $str === '')
 * If it can be seen easily that $str is a string,
   the typecast is omitted.

Resolves: #54091
Releases: 6.2
Change-Id: I59c5cbccea4f98b8f282377e6aa67d970859a457
Reviewed-on: https://review.typo3.org/27091
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Change-Id: Ib58894a67f0292b9d62da81511ce12d3f16590ef
Resolves: #55445
Releases: 6.2
Reviewed-on: https://review.typo3.org/27136
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Stefan Neufeind authored Dec 20, 2013 and Christian Kuhn committed Jan 30, 2014

Shorten some constructs, make them easier to read
and less error-prone.

Resolves: #46400
Releases: 6.2
Change-Id: I7b0126ccfeaefdfdb89321d7287c6347d8aee050
Reviewed-on: https://review.typo3.org/19007
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

"textfile" will be replaced by "text file"

Resolves: #54893
Releases: 6.2
Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b
Reviewed-on: https://review.typo3.org/26736
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch replaces about 300 places using strcmp()
in the whole core. There are different contexts for strcmp()
within this set, i.e. checking for strings being '0',
'', not '' and the like.

strcmp() has to stay when it comes to real sorting of strings,
which is a rather rare case, otherwise it can be replaced with
faster alternatives.

The following 'rules' were used for the replacement:

* Use a type cast if you can't be sure about the incoming values.
  We do not need type casts if the types are implicitly defined
  before by another function. i.e. intval(), trim(), substr()
* Use int-cast whenever the values to be compared are numbers only.
* Use string-cast for any other combination. i.e
  (string)$len === '0' when $len can be NULL, which is different
  to (int)$len === 0

Resolves: #54085
Releases: 6.2
Change-Id: I88fb294ae20d8c23ff58d8296fbb37925d5213c8
Reviewed-on: https://review.typo3.org/25843
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Christian Kuhn authored Oct 01, 2013 and Anja Leichsenring committed Oct 01, 2013

Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Stefan Neufeind authored Jul 26, 2013 and Andreas Wolf committed Aug 03, 2013

Using TYPE is deprecated since a MySQL 4.x and was removed in MySQL
5.5. Core already uses ENGINE but SqlParser turned that into TYPE,
leading to errors.

From https://dev.mysql.com/doc/refman/5.0/en/storage-engines.html:
"The older term TYPE is supported as a synonym for ENGINE for
backward compatibility, but ENGINE is the preferred term and TYPE
is deprecated."

Change-Id: I6607d3e726c43cb74ca00f33ec2332de4f6a76d8
Resolves: #50466
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22592
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Stefan Neufeind authored Jul 06, 2013 and Wouter Wolters committed Jul 06, 2013

* "case" needs to be indented one level more than switch().
* default-case should not have a break-statement

Change-Id: I8215ba2bdb19b9abbfe6ed45af3905d7e6c688d6
Resolves: #49527
Releases: 6.2
Reviewed-on: https://review.typo3.org/21748
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Main features:
* The god class "Installer" is gone and split into two major parts.
A step controller handling major upgrade and install tasks, and a
tool controller handling the known install tool actions.

* The step controller is designed to be always called prior to the
tool controller, if a step needs execution, it comes up, otherwise
the tool controller will be executed.

* The entry point typo3/install/index.php is gone and substituted
by typo3/sysext/install/Start/Install.php. The file contains a
lengthy comment to document the main request flow and used GET/POST
parameters.

* Most parts of the install tool do not bootstrap the whole system
anymore, in general only the base bootstrap, dbal (if loaded),
extbase and fluid ext_localconf.php are loaded. This makes sure
the install tool can not fatal if some extensions ext_localconf
is broken. The whole install tool runs without any caching, so a fatal
in some cache file can not kill the install tool execution.

* Installing TYPO3 CMS on a dbal enabled system is now handled in
the step installer directly to make the according code easier to
understand.

* Rendering is done with a simplified fluid standalone view.

* All install tool forms are CSRF protected.

* A new and fully unit tested class structure is introduced, designed
to take care of the basic file and folder structure of the instance.
It is used during installation to create the needed structure and
can be called in the install tool to compare and fix the current
instance structure with the expected structure. In effect, the
"dummy" package is obsolete. An instance can be created by just
linking index.php, typo3_src/ and typo3/ within the document root,
the installer takes care of creating everything else.

* The installation procedure is released from the package handling.
Packages will be handled by the extension manager after initial
installation with another patch.

Loose ends:
* The whole package handling needs to be implemented in the
extension manager.

* Not all upgrade wizards work, this code area needs some love.

* A 'core' auto updater could be implemented now. A GSoC project
is currently running to realize this.

* The SQL schema migration API is a mess and should be refactored.
For now, another helper class is introduced to encapsulate some
of the nasty details.

* An auto configuration and configuration suggestion system is
planned and needs to be done. It should suggest best configuration
options in the install tool, and should auto configure the system
during installation in the last install step.

* If the backend or frontend fatals due to some extension that
triggers a fatal in ext_localconf or ext_tables (for example
due to a require() of a no longer existing file), a small helper
action in the install tool could find those extensions and suggest
to unload them.

Change-Id: Ice3248caa903449ad6a83ea4f234c7bd125bdb66
Resolves: #49162
Releases: 6.2
Reviewed-on: https://review.typo3.org/21468
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Alexander Opitz
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Wouter Wolters authored Mar 16, 2013 and Christian Kuhn committed Mar 19, 2013

In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.

Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Stefan Neufeind authored Nov 29, 2012 and Christian Kuhn committed Dec 01, 2012

SqlParser only trimmed semicolon and newlines
from end of string. Make it strip all characters
usually stripped by trim().

Add a unit test to avoid regressions.

Change-Id: I2ddc1fca2ac0db1b6ca0989c93c37ab39e0675d8
Fixes: #43470
Releases: 4.5, 4.6, 4.7, 6.0, 6.1
Reviewed-on: http://review.typo3.org/16875
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

With namespaces the @package and @subpackage annotations
do not have a real benefit anymore and can be removed.

Change-Id: Id8f4718db0c1c51ae5143a3353dd5efb42dadf70
Resolves: #43019
Releases: 6.0
Reviewed-on: http://review.typo3.org/16474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Roland Waldner authored Oct 01, 2012 and Christian Kuhn committed Oct 28, 2012

Change-Id: I9970ef5e2087233db095a1d296261c6eb06def18
Resolves: #41498
Releases: 6.0
Reviewed-on: http://review.typo3.org/15198
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Currently, the SQL Parser uses raw binary characters. In some cases,
this breaks the PHP interpreter. This results in the file
SqlParser.php not being parsed (the PHP interpreter just dumps
"???..." to stdout) and a follow-up fatal error because the class
cannot be found.

This patch replaces the raw binary characters with corresponding
character sequence in double quotes.

Change-Id: I28fb5d0c8401794e8f4bf20e7e2611b4cf7014ae
Fixes: #40932
Relates: #40672
Releases: 6.0
Reviewed-on: http://review.typo3.org/14689
Reviewed-by: Oliver Hader
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I818d55a2f00b549fef8377f1c6766c293edd021c
Resolves: #40880
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14565
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Thomas Maroschik authored Aug 23, 2012 and Christian Kuhn committed Aug 23, 2012

Change-Id: Id49218118087244bcd063b730631ee69b2820670
Resolves: #40096
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14015
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Georg Ringer authored Aug 07, 2012 and Christian Kuhn committed Aug 07, 2012

Change-Id: I69e63dd7bd03ad03bca3b825fbd4b5b2376386a0
Resolves: #39565
Releases: 6.0
Reviewed-on: http://review.typo3.org/13490
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Wouter Wolters authored May 18, 2012 and Christian Kuhn committed May 19, 2012

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_refindex.php
* t3lib/class.t3lib_scbase.php
* t3lib/class.t3lib_softrefproc.php
* t3lib/class.t3lib_sqlparser.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I1297ce2e244c7d19c590537d93b090f75a6043ce
Resolves: #37288
Releases: 6.0
Reviewed-on: http://review.typo3.org/11286
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Stefano Kowalke authored May 06, 2012 and Christian Kuhn committed May 06, 2012

This patch replaces some forgotten and/or
overseen space chars in indention into tab chars.

Change-Id: I1118488ee3e06d5529d741b2811095548ca818a5
Resolves: #36871
Reviewed-on: http://review.typo3.org/11018
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Tolleiv Nietsch authored Apr 17, 2012 and Christian Kuhn committed Apr 29, 2012

After #31893 is merged we can remove the XCLASS blocks from the
Core. This patchset removes it from the classes within t3lib.

Besides that it declares t3lib_TimeTrackNull and t3lib_TimeTrack
to be final to make sure that extending them is still denied.

This patchset itself should not be merged before the related patch
for EXT:dbal (#31183) is merged.

Change-Id: I09e5253191972ac4b3b033aeb770758690ea3755
Fixes: #36184
Releases: 6.0
Reviewed-on: http://review.typo3.org/10556
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Stefan Neufeind authored Dec 16, 2011 and Xavier Perseguers committed Dec 20, 2011

Comparator != was supported before.
But <> is ANSI SQL and therefore should be
supported as well.

Change-Id: I49dde6f06715ecd33df044d8a2e85a813516d6ad
Fixes: #32626
Releases: 4.4, 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7325
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The function index in the head of core classes is not maintained
and not useful in the time of powerful IDE's anymore.

Change-Id: If4e327b4e78f3b6fb74a3011d8c2eb5090abe690
Resolves: #27985
Reviewed-on: http://review.typo3.org/3128
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn