This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 09 Nov, 2019 1 commit
-
-
The value of `data-table-unique-original-value` was accidentally of type array. This causes runtime errors since a string is expected. This patch now creates a proper value passed to FormEngine to handle the original unique value. Resolves: #89588 Related: #87711 Releases: master, 9.5 Change-Id: I9184aa025f01196d0c206b5b86c712dc1049487f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62195 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 11 Sep, 2019 1 commit
-
-
This patch fixes some flaws in the IRRE uniqueness handling: - Validation is triggered once a record has been removed from DOM - Removed records are now added to their selector again if not opened before - Uniqueness handling now works for records with uid "0", which is relevant for a site's language handling - The unique update is now triggered only when the value of its selector in a record actually changes Resolves: #87711 Releases: master, 9.5 Change-Id: I9fe15d8e8790eff305024b706450cd2c37da9340 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61578 Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
- 05 Sep, 2019 1 commit
-
-
If a TCA field is set to readOnly=true and is using the type "inline", all buttons are now hidden and the fields of the relation are set to readOnly as well. Resolves: #56060 Releases: master, 9.5 Change-Id: If2b1cb2be0591d765f40512aaf341a9c26a2f87f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61490 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
- 24 May, 2019 1 commit
-
-
This patch refactors the IRRE handling on client side, the JavaScript land has been rewritten to have a better structure and do less repeating on-the-fly calculations. Each IRRE container is represented by a independent instance of InlineControlContainer. Most of the internally used `scriptCall` directives have been removed. Currently, `scriptCall` can't get removed completely, as further refactorings in different areas are required. All of the "external" communication via `inline.foobar()` has been replaced by a event-driven approach. This also affects ElementBrowser windows, those use a minimalistic API based on postMessage. Some code that was never evaluated in ElementBrowser is considered dead and has been removed regarding inserting multiple items. A new sorting library has been added in order to replace jqueryui piece by piece. Executed command: yarn add --dev sortablejs On PHP side, some code has been removed as well since the rewritten client code is event-based and doesn't depend on external calls anymore. Resolves: #88182 Releases: master Change-Id: I4176483d2882cef49fbaddb5e2e1914c1f76c908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59324 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 15 Mar, 2019 1 commit
-
-
Replace string concatenations like 'abc' . 'def' with 'abcdef'. Resolves: #87004 Releases: master Change-Id: I9c1a610e88dd4bd4e617214989a915b1dafda094 Reviewed-on: https://review.typo3.org/c/60155 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- 07 Mar, 2019 1 commit
-
-
Despite $resultArray['additionalHiddenFields'] being properly set by the elements, this section is never evaluated in InlineRecordContainer. Evaluate content in this property and render the fields in the HTML output. Resolves: #87614 Releases: master, 9.5, 8.7 Change-Id: Idb45a906d3cb019e915c94df59fa215405cb1af3 Reviewed-on: https://review.typo3.org/c/59605 Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 02 Sep, 2018 1 commit
-
-
strpos will use only CPU resources, substr also needs memory allocation. Resolves: #85477 Releases: master Change-Id: Ic25c99986f7e2e7237c10acaa75be8d0f6289f13 Reviewed-on: https://review.typo3.org/57466 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 25 Apr, 2018 1 commit
-
-
This commit moves any language file of EXT:lang into a proper destination, which renders EXT:lang obsolete. This change requires an update of typo3/testing-framework, done with this command: composer update typo3/testing-framework Resolves: #84680 Releases: master Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d Reviewed-on: https://review.typo3.org/56017 Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
- 02 Mar, 2018 1 commit
-
-
These parentheses are redundant and may be safely removed. Resolves: #84092 Releases: master Change-Id: I59f2b7454316ecd05f57d28e344f03a65d13e5c5 Reviewed-on: https://review.typo3.org/55952 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- 12 Feb, 2018 1 commit
-
-
Resolves: #83844 Releases: master Change-Id: I5fef80a48d52da9800a7a9a2a23445d60168e8b5 Reviewed-on: https://review.typo3.org/55659 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
-
- 27 Dec, 2017 1 commit
-
-
Some PHP classes still contain unused use statements. They have been removed. Thanks to @cd on his initial patch https://review.typo3.org/52014/ Resolves: 83432 Releases: master Change-Id: I9020f505a826c40fcf11f75f87245293e7c6154f Reviewed-on: https://review.typo3.org/55217 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 19 Dec, 2017 1 commit
-
-
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- 30 Nov, 2017 1 commit
-
-
The new PSR-7-based solution since TYPO3 v7 should be used everywhere instead of "BackendUtility::getModuleUrl()". This is possible because modules can be addressed via the "route" GET parameter instead of the "M" parameter since a few months. The patch changes all occurrences within TYPO3 Core to use the new API. Resolves: #83172 Releases: master Change-Id: Iec40e8ae00f1d900d7479b84a3a62827ddba653b Reviewed-on: https://review.typo3.org/54755 Reviewed-by:
-
- 28 Nov, 2017 1 commit
-
-
This avoids an error in case file metadata is edited through a file reference and there is no file metadata translation for the current language. Resolves: #76262 Resolves: #82178 Releases: master, 8.7 Change-Id: Ifecf659637773c5f3773fc3439b09df9c030cb3f Reviewed-on: https://review.typo3.org/54778 Tested-by:
-
- 27 Nov, 2017 1 commit
-
-
Several hundred function calls and vast numbers of indentations can be saved by using the null coalesce operator instead of checking empty/array. Change-Id: I38f2ce2de83a454aaa0d16c771014b6de84b3f7a Releases: master Resolves: #80812 Reviewed-on: https://review.typo3.org/52416 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 03 Nov, 2017 1 commit
-
-
If an inline child, opened via ajax request, generates links leaving the current records and opening a different one, on closing that record the returnUrl is wrong and points to the url of the inline ajax request. The original return url of the main record is lost in the compile chain. The returnUrl data provider sets $data['returnUrl'] to current url if not otherwise given. The patch hands over the original return url to the inline ajax controller and lets it 'sink down' in the data compile chain to inline children so the original return url is available when container or elements generate urls. Additionally some broken 'returnURL' handling in InlineRecordContainer and jsfunc.inline.js is cleaned up and removed. Change-Id: Ia47dc8cee068fc9c4d1c5e16c1960b1a58fcb2f5 Resolves: #82525 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54543 Tested-by:
Kjeld Schumacher <k.schumacher@familie-redlich.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 09 Sep, 2017 1 commit
-
-
Until now all of the backend icons were a manually edited array of file paths. With this patch defined icon folders in the core are scanned for existing icon files and build most of that static array automatically. For historic reason (and hopefully soon to be removed alltogether) a second array of statically declared icons is added and merged into. Some icons that were in the original static list but whose files actually are missing or misnamed are marked as deprecated. Resolves: #82348 Releases: master Change-Id: I8dc4fbbe815d923eda55e1c1b072369e62f66d87 Reviewed-on: https://review.typo3.org/54020 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- 13 Jul, 2017 1 commit
-
-
The 'imagefile_ext' list only contains the lowercase versions of all supported extensions. This patch makes sure that a lowercase version of the file extension is used and it is recognised as an image file. Resolves: #81826 Releases: master, 8.7 Change-Id: Ice5881be4c685432987530dcdd50b1f758d883ef Reviewed-on: https://review.typo3.org/53427 Tested-by:
-
- 04 Jun, 2017 1 commit
-
-
Check files if they are image files before thumbnail generation. Change-Id: I7dae2ccbb5ab93e582d21efe8f7d29cf7006a1c3 Resolves: #81147 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53107 Reviewed-by:
Jo Hasenau <info@cybercraft.de> Tested-by:
-
- 02 Jun, 2017 1 commit
-
-
If the info icon is disabled it is now removed completely. Previously the logic for new records was not caught correctly, so that the case for the enabled icon with a new record was executed. Disabling the icon should remove it completely, as a disabled non-clickable icon is not helpful and confusing for editors. This is now done, and the case for the enabled icon with new records is also correctly caught. Resolves: #81380 Releases: master, 8.7 Change-Id: I1c78a99a83efa3c88e3a6337df9cd0c8a959ea7b Reviewed-on: https://review.typo3.org/52970 Reviewed-by:
Daniel Windloff <daniel.jc.windloff@googlemail.com> Tested-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
- 18 May, 2017 1 commit
-
-
In order to be consistent, change the button order and styling (according to the list module) in the InlineRecordContainer. Resolves: #78174 Releases: master, 8.7 Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0 Reviewed-on: https://review.typo3.org/50104 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
-
- 27 Apr, 2017 1 commit
-
-
This function now does the same as makeInstance() except for an if() clause, since the API should be unified this method should be considered as dropped, allowing to use callUserFunction() and makeInstance() as the only two proper ways to call custom classes / methods. Resolves: #80993 Releases: master Change-Id: I0c2042dbe6c83a86f211bab4eaf64d75e6424232 Reviewed-on: https://review.typo3.org/52518 Reviewed-by:
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 01 Feb, 2017 1 commit
-
-
Change string comparison for string checks. Checks which could lead to false positives like comparing with '0' or '' are excluded. RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+') Resolves: #79540 Resolves: master Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9 Reviewed-on: https://review.typo3.org/51462 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- 28 Jan, 2017 1 commit
-
-
Use tooltips instead of ancient JavaScript alerts for locked records. Resolves: #79422 Releases: master Change-Id: Ia9911f8eaad1c55c2af14e366af13e0e9b7b21df Reviewed-on: https://review.typo3.org/51387 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
-
- 26 Jan, 2017 1 commit
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a pretty huge list of TCA changes and simplifications, all TCA changes are supported by TCA migration, so existing extensions should benefit out of the box and just get deprecations logged. Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab Resolves: #79440 Resolves: #70032 Releases: master Reviewed-on: https://review.typo3.org/51151 Tested-by:
-
- 03 Jan, 2017 1 commit
-
-
The patch adapts a series of nasty form engine areas to more solid code. The evaluate condition code is rewritten and works much better in flex form scenarios. The suggest wizard and svg tree are much more solid in flex forms. The group element is rewritten towards a better readable and easier to refactor code, dropping method dbFileIcons(). A bunch of issues is resolved along the way. * TCA "default" now works in flex form section container elements * The "displayCond" parser is now strict and throws exceptions on invalid syntax and wrong referenced fields to help debugging faulty display conditions * TCA displayCond on flex fields can now be prefixed with the sheet name and can reference field values from neighbor sheets * TCA displayCond now works with flex section containers * TCA flex section container now throw an exception if select or group fields configure a MM relation - this is not supported * TCA ctrl requestUpdate field is dropped, onChange=reload is now allowed not only on flex form fields, but also on normal columns fields * TCA tree now works as section container element and initializes correctly on new records and new containers * GroupElement rewrite to drop dbFileIcons() * config option maxitems now optional for type=group and type=select and defaults to "many items allowed" * inline now works in "fancy" flex situations with "new" records by handing the final dataStructureIdentifier around * FormEngine no longer loads extJS Change-Id: Id1d081627529cc1502bb198389e5bd69372815cd Resolves: #78899 Resolves: #72307 Resolves: #75646 Resolves: #76637 Resolves: #72106 Resolves: #78824 Resolves: #76793 Resolves: #68247 Resolves: #69715 Related: #78460 Related: #67198 Related: #72294 Releases: master Reviewed-on: https://review.typo3.org/50879 Tested-by:
-
- 01 Dec, 2016 1 commit
-
-
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
-
- 26 Oct, 2016 1 commit
-
-
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- 08 Oct, 2016 1 commit
-
-
Use the following icons to indicate different kinds of "edit actions": * actions-open: single edit action * actions-document-open: multi edit action * actions-page-open: edit page properties Resolves: #77963 Releases: master Change-Id: I2d3198b56755eef5eb715058caf5d8574124c9ca Reviewed-on: https://review.typo3.org/49946 Tested-by:
Tomasz Stępniak <stempl88@gmail.com> Reviewed-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 28 Jul, 2016 1 commit
-
-
Resolves: #77291 Releases: master Change-Id: Ide336171ccfabb2d347dbad0a7e2f801c062f4e3 Reviewed-on: https://review.typo3.org/49252 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Frederic Gaus <frederic.gaus@flagbit.de> Reviewed-by:
-
- 27 Jul, 2016 2 commits
-
-
This patch corrects the IRRE header for sys_file_references. Resolves: #77248 Related: #76399 Related: #76668 Related: #76900 Releases: master, 7.6 Change-Id: Ic0791d71b7ff5aa3e9caf098ea75fa254efa6c4b Reviewed-on: https://review.typo3.org/49206 Reviewed-by:
-
Wouter Wolters authored
When opening a window with a file reference in a full window it is not possible to click the edit metadata button. Use a normal href to avoid the issue with choosing the correct frame. Resolves: #76729 Releases: master,7.6 Change-Id: Iaa140f28104782870c50ef0d876e472067a09fed Reviewed-on: https://review.typo3.org/48667 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
- 25 Jul, 2016 1 commit
-
-
This patch removes default record title escaping in resolved DataProvider data and adds proper escaping where html output is generated. Resolves: #76399 Resolves: #76668 Resolves: #76900 Releases: master, 7.6 Change-Id: I03cf41c5200e920088116d1a67a2e342e46142d3 Reviewed-on: https://review.typo3.org/48779 Tested-by:
Susanne Moog <typo3@susannemoog.de> Reviewed-by:
-
- 11 Jul, 2016 1 commit
-
-
Migrate the first part of DB calls of EXT:backend Resolves: #76624 Releases: master Change-Id: Iac323bed36af22e5c38eb4fb8a0e0f72bbee6d93 Reviewed-on: https://review.typo3.org/48574 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 10 Jun, 2016 1 commit
-
-
Helmut Hummel authored
Resolves: #76449 Releases: master Change-Id: Ie0a7302d8a2f2d9aabfb7a351114f7e91e7d7ac8 Reviewed-on: https://review.typo3.org/48442 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
- 28 May, 2016 1 commit
-
-
Remove the second parameter of sL and replace it with htmlspecialchars directly in the code. Resolves: #76325 Related: #71917 Releases: master Change-Id: I6668eea01d80446a6b6f2ec95435c6e3d93cb0c3 Reviewed-on: https://review.typo3.org/48346 Reviewed-by:
-
- 16 May, 2016 1 commit
-
-
The exceptions show now the affected class that does not implement the required interface. Where possible, the FQCN in the exception message string was replaced with the shorter ::class syntax. Resolves: #76187 Releases: master, 7.6 Change-Id: Id2c290a0cf29bdec5da504a8959996bb747f1c27 Reviewed-on: https://review.typo3.org/48115 Reviewed-by:
-
