This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
  1. 13 Jan, 2014 10 commits
    • Roland Waldner's avatar
      [TASK] Fix typo in copyright notice · 8289e607
      Roland Waldner authored
      "textfile" will be replaced by "text file"
      
      Resolves: #54893
      Releases: 6.2
      Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b
      Reviewed-on: https://review.typo3.org/26736
      Reviewed-by: Michiel Roos
      Tested-by: Michiel Roos
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      8289e607
    • Torben Hansen's avatar
      [BUGFIX] Template dropdown doesn't refresh template title after save · 273958a4
      Torben Hansen authored
      Reloads the template menu after the template title has been changed.
      
      Resolves: #51805
      Releases: 6.2, 6.1
      Change-Id: I5d987a3ffc6a11dfa1ebe54480c9c3b69ccc1959
      Reviewed-on: https://review.typo3.org/26766
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      273958a4
    • Xavier Perseguers's avatar
      [BUGFIX] Only variables should be passed by reference · 6b951001
      Xavier Perseguers authored
      array_shift() takes argument by reference.
      
      Releases: 6.2
      Fixes: #54933
      Change-Id: I94c16bc739f36d669640701561ff94aebd63b1f5
      Reviewed-on: https://review.typo3.org/26779
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      6b951001
    • Markus Klein's avatar
      [BUGFIX] Fix PHP warnings in PackageManager · f294b262
      Markus Klein authored
      
      Resolves: #54963
      Releases: 6.2
      Change-Id: I58b1f6109872d6eb8059fceb1bec1af7134e84e2
      Reviewed-on: https://review.typo3.org/26789
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Thomas Maroschik
      Tested-by: Thomas Maroschik
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      f294b262
    • Tomita Militaru's avatar
      [TASK] Check for libxml bug in install tool · 51ebe1cf
      Tomita Militaru authored
      Add check for libxml bug when saving special characters ">><<"
      in a flexform
      
      Resolves: #51271
      Releases: 6.2
      Change-Id: I5d120cdfeb9538209273c8761d017cb67256617b
      Reviewed-on: https://review.typo3.org/25089
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      51ebe1cf
    • Steffen Ritter's avatar
      [TASK] Calculated hash of File object is never used · a9f111f3
      Steffen Ritter authored and Benni Mack's avatar Benni Mack committed
      The indexing pre-calculates the file hash and stores it in
      the sys_file table. Sadly the getter of file objects never looks
      at this again and always recalculates the hash via the driver,
      which is very slow.
      
      Resolves: #54235
      Releases: 6.2, 6.1, 6.0
      Change-Id: I16bfa2126031f26b8e31da8d8c0b3fc07d0217dc
      Reviewed-on: https://review.typo3.org/26689
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      Reviewed-by: Oliver Klee
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      a9f111f3
    • Helmut Hummel's avatar
      [BUGFIX] Ignore dependencies of inactive packages · df96f236
      Helmut Hummel authored and Oliver Hader's avatar Oliver Hader committed
      It might happen that activating or deactivating
      a package throws an exception because other inactive
      packages are available on the system with broken or
      not fulfilled dependencies.
      
      To solve this issue, only active packages
      are regarded when resolving dependencies.
      
      To remove a side effect from this change,
      cache clearing in extension manager is
      moved to a later point (see #54951).
      
      This needs a proper fix in another change,
      but makes this fix work for now.
      
      Resolves: #54879
      Releases: 6.2
      Change-Id: Id81b66b2d2b6f4ba7d1c6ea2d001c271982539b3
      Reviewed-on: https://review.typo3.org/26719
      Reviewed-by: Thomas Maroschik
      Reviewed-by: Markus Klein
      Tested-by: Kasper Ligaard
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      df96f236
    • Ingo Schmitt's avatar
      [TASK] Add index to sys_file_metadata · cc3b0298
      Ingo Schmitt authored and Benni Mack's avatar Benni Mack committed
      Since sys_file_metadata records are enabled to be 
      translated the file list module is capable of metadata 
      translations, too. In order to directly link to edit 
      or create a new translation depending on wether this 
      language already has been translated for each file the 
      metadata translations are fetched from the database.
      
      In order to improve that query this patch adds an index 
      including l10n_parent and sys_language_uid.
      
      Resolves: #54927
      Releases: 6.2
      Change-Id: I6cc5c74505e96647c5ddd7e7ee77518176d2ba0b
      Reviewed-on: https://review.typo3.org/26774
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      cc3b0298
    • Ingo Schmitt's avatar
      [TASK] Update SQL definition for sys_file_storage · 85edd0e1
      Ingo Schmitt authored and Benni Mack's avatar Benni Mack committed
      There are missing indexes as well as a mismatch between the
      TCA definition (and therefore actual usage) and the SQL
      definition at database level.
      
      This change
      * adds combined index to deleted / hidden to speedup the
        query initializing storages in Be_UserAuth
      
      * changes SQL definition for field "name" to match their
        usage in TCA
      
      Resolves: #54923
      Releases: 6.2
      Change-Id: I86f345a941802304ed7fbe29d00ae38130f8e5d2
      Reviewed-on: https://review.typo3.org/26768
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Oliver Klee
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      85edd0e1
    • Ingo Schmitt's avatar
      [TASK] Add index to sys_category · 1044c801
      Ingo Schmitt authored and Benni Mack's avatar Benni Mack committed
      All page, content and file-records TCEforms render a category 
      tree in order to assign these. The tree building executes the 
      same queries quite often. In order to optimize these queries
      this change adds
      * an index "category_parent" to sys_category.parent in order
        to for the parent category while index "parent" currently
        indexes the pid the record is stored.
      
      * a combined index "category_list" to columns pid, deleted 
        and sys_language_uid.
      
      Resolves: #54929
      Releases: 6.2
      Change-Id: I1d42ba7171dc1213d5d5559ae190092acaa57464
      Reviewed-on: https://review.typo3.org/26775
      Reviewed-by: Oliver Klee
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      1044c801
  2. 12 Jan, 2014 1 commit
    • Markus Klein's avatar
      [BUGFIX] Indexer tries to insert NULL into DB · cca2d700
      Markus Klein authored and Georg Ringer's avatar Georg Ringer committed
      The Indexer of indexed_search tries to insert NULL values
      into NOT NULL columns of the database.
      
      Since #53662 NULL values are passed to the database,
      hence these insert statements now fail.
      
      Resolves: #54917
      Releases: 6.2
      Change-Id: Ia935abe14b9c3be2062f1b38ec98fb63921a1c2f
      Reviewed-on: https://review.typo3.org/26757
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      cca2d700
  3. 11 Jan, 2014 3 commits
    • Nico de Haen's avatar
      [BUGFIX] Skip validation of uninitialized collections · b90e09b5
      Nico de Haen authored
      Elements in LazyObjectStorages should not be validated,
      since the values would be reconstituted from persistence anyway.
      This patch adds the same behaviour as implemented in Flow and
      adds the tests found in Flow (and one additional test).
      
      Resolves: #53816
      Releases: 6.2
      Change-Id: I65f62a4ef6777e3678b2fdd06fc58d828bb8cb87
      Reviewed-on: https://review.typo3.org/25549
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Steffen Müller
      Tested-by: Steffen Müller
      b90e09b5
    • Francois Suter's avatar
      [BUGIFX] Drop usage of addTofeInterface parameter · ada821d1
      Francois Suter authored and Wouter Wolters's avatar Wouter Wolters committed
      In #54613, usage of parameter $addTofeInterface in method
      ExtensionManagementUtility::addTCAcolumns() was deprecated.
      However it is used in a few places of the Core.
      Those calls must be modified too.
      
      Resolves: #54899
      Releases: 6.2
      Change-Id: I22696cb4655578dc583edcb9cfa4693b69e228c8
      Reviewed-on: https://review.typo3.org/26745
      Reviewed-by: Oliver Klee
      Reviewed-by: Eric Chavaillaz
      Tested-by: Eric Chavaillaz
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      ada821d1
    • Steffen Müller's avatar
      [BUGFIX] Add missing logger names · b8280294
      Steffen Müller authored and Wouter Wolters's avatar Wouter Wolters committed
      A logger name is mandatory to configure a particular logger.
      The convention is use __CLASS__ as the logger name when
      instanciating a new logger using LogManager->getLogger().
      
      Resolves: #54909
      Releases: 6.2, 6.1
      Change-Id: I5dbda770ec92fd75c3aff9ed89c68c5666669b07
      Reviewed-on: https://review.typo3.org/26754
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      b8280294
  4. 09 Jan, 2014 13 commits
    • Steffen Müller's avatar
      [BUGFIX] Allow empty values in start/stop filter of belog · beb80664
      Steffen Müller authored and Wouter Wolters's avatar Wouter Wolters committed
      One can limit records in the backend log module to a custom period
      of time using the "User defined" mode and a start and stop field.
      
      Leaving these fields empty is now supported in the corresponding
      domain model setters by adding default values to the DateTime
      arguments.
      
      Resolves: #53975
      Releases: 6.1, 6.2
      Change-Id: I944322bb3747a29fab33c3d32e17dd070c7cb6db
      Reviewed-on: https://review.typo3.org/26723
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      beb80664
    • Felix Oertel's avatar
      [BUGFIX] Assume pid 0 for global backend context · ba2386e7
      Felix Oertel authored and Anja Leichsenring's avatar Anja Leichsenring committed
      If outside from "Web", extbase modules try to figure out some pid,
      while in reality there is just none. The core takes "0" in this
      situations, for looking for typoscript templates and tagging
      cf_cache_pagesection entries.
      
      To enable extbase to use the core's cache entries, we should streamline
      this.
      
      * Return 0, if no pid is set
      * Remove needless unit-tests
      
      Resolves: #54813
      Releases: 6.2
      Change-Id: I58cbaac0b40323e1766229488973b775accd1b97
      Reviewed-on: https://review.typo3.org/26675
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Froemken
      Tested-by: Stefan Froemken
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      ba2386e7
    • Georg Ringer's avatar
      [TASK] Improve feedit · 545610af
      Georg Ringer authored and Wouter Wolters's avatar Wouter Wolters committed
      The frontend editing + admin panel needs some polishing.
      Following changes are included:
      
      General
      =======
      - Reformat code
      - Use Sprite API which means using the correct icons
      
      Admin Panel
      ==============
      - Add missing translations
      - Show "Simulate usergroup" only if usergroups are available
      - Remove "Total page count" in Info Tab as information is wrong
        (counting images + document is not the total page size)
      
      Frontend Editing
      =================
      - Remove "edit_editNoPopup", "forceNoPopup", "editFormsOnPage"
        for direct inline editing
      - Remove setting "previewBorder" which is not needed and looks just ugly
      
      Releases: 6.2
      Resolves: #49640
      Change-Id: I35f88bc4e8c138fc21b74c0448b2f3892ab61918
      Reviewed-on: https://review.typo3.org/21859
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      545610af
    • Markus Klein's avatar
      Revert "[BUGFIX] IRRE creates new records when using foreign_selector" · b3a82c72
      Markus Klein authored
      This reverts commit 692bd22c
      
      The patch breaks IRRE. It is impossible to add images.
      
      Change-Id: Iac9f0a7af3cc8532a953ac1947f6877ded4f915f
      Resolves: #43239
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26726
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      b3a82c72
    • Kai Vogel's avatar
      [BUGFIX] IRRE creates new records when using foreign_selector · 692bd22c
      Kai Vogel authored
      This patch links existing child records correctly to the parent IRRE
      field when selecting it in the generated dropdown.
      
      Scenario:
      
      Parent table configuration:
      ====================================================
      [...]['columns']['irreField']['config'] = array(
        'type' => 'inline',
        'foreign_table' => 'childTable',
        'foreign_selector' => 'childSelector',
      );
      
      Child table configuration:
      ====================================================
      [...]['columns'][childSelector']['config'] = array(
        'type' => 'select',
        'foreign_table' => 'childTable',
      );
      
      What happens?
      ====================================================
      1. The parent IRRE field renders a dropdown field
         before the child records
      2. Selecting one of the items in the dropdown should
         link this child record to current IRRE field
      3. Without patch, it will only create a blank child
         record
      4. Using the patch, it will link the existing child
         to the parent IRRE field
      
      Resolves: #43239
      Releases: 6.2, 6.1
      Change-Id: I2a308cb050962b71e9ba28b64a44962c91bde440
      Reviewed-on: https://review.typo3.org/16690
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      692bd22c
    • Jo Hasenau's avatar
      [TASK] Replace all strcmp() calls with === · 0a761995
      Jo Hasenau authored
      This patch replaces about 300 places using strcmp()
      in the whole core. There are different contexts for strcmp()
      within this set, i.e. checking for strings being '0',
      '', not '' and the like.
      
      strcmp() has to stay when it comes to real sorting of strings,
      which is a rather rare case, otherwise it can be replaced with
      faster alternatives.
      
      The following 'rules' were used for the replacement:
      
      * Use a type cast if you can't be sure about the incoming values.
        We do not need type casts if the types are implicitly defined
        before by another function. i.e. intval(), trim(), substr()
      * Use int-cast whenever the values to be compared are numbers only.
      * Use string-cast for any other combination. i.e
        (string)$len === '0' when $len can be NULL, which is different
        to (int)$len === 0
      
      Resolves: #54085
      Releases: 6.2
      Change-Id: I88fb294ae20d8c23ff58d8296fbb37925d5213c8
      Reviewed-on: https://review.typo3.org/25843
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      0a761995
    • Tymoteusz Motylewski's avatar
      [TASK] Add functional tests from irre_tutorial to the core · c9651784
      Tymoteusz Motylewski authored and Oliver Hader's avatar Oliver Hader committed
      Add irre_tutorial extension as mock extension for functional tests.
      Port functional tests from IRRE tutorial to the functional testing
      framework and include them in the core and workspaces extensions.
      Some tests are skipped for now, because the core is buggy.
      
      Releases: 6.2
      Resolves: #54812
      Change-Id: I691dd97e7649c8239b6e96ce6f9a9d59e9b124c4
      Reviewed-on: https://review.typo3.org/26674
      Tested-by: Markus Klein
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      c9651784
    • Oliver Hader's avatar
      [BUGFIX] Test extensions not considered in functional tests · 82a24fa0
      Oliver Hader authored and Oliver Hader's avatar Oliver Hader committed
      The functional testing framework offers the possibility to define
      custom extension to be installed for each test scenario. However,
      this does not work at all, only extensions that are available in
      the original base installation can be used.
      
      This change cleans and adds the package state definition for any
      extension to be used during a functional test execution.
      
      Fixes: #54857
      Releases: 6.2
      Change-Id: I91b1cd1bc5d147287a154283e94d03d1392ac92d
      Reviewed-on: https://review.typo3.org/26705
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Thomas Maroschik
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      82a24fa0
    • Mario Rimann's avatar
      [BUGFIX] File browser fails on inexistent expandFolder · a24bfae4
      Mario Rimann authored
      If a user browsed to a directory "foo" and re-opens the file-
      browser later, the same directory is shown expanded.
      
      In case the directory has been moved/renamed/deleted in the
      meantime, the user gets an exception due to the inexistent
      directory.
      
      This change just adds a try/catch block around to handle that
      situation.
      
      Change-Id: I39aab6be46aec1d3f1f365e5d5f5455aca9b3aa2
      Resolves: #50266
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/26466
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Pascal Maechler
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      a24bfae4
    • Georg Ringer's avatar
      [TASK] Adopt order of cols in ext:documentation · af996702
      Georg Ringer authored
      Each of the actions 'show' and 'download' got a different sorting of the
      columns. Change the order of the download action so that the action links
      are placed at the end.
      
      Change-Id: Ifa8aa7ed2eb9bee1ebbc086607ce1261fe1a3c95
      Resolves: #54840
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26712
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      af996702
    • Georg Ringer's avatar
      [BUGFIX] Properly escape the ImageMagick frame selector · c5fcc5fd
      Georg Ringer authored
      The frame selector looks like a glob pattern and gets interpreted as
      such by the shell. Currently the generated shell argument is, for
      example, 'image.png'[0] which matches a file called image.png0.
      Thus, if such a file exists, the wrong argument would be passed to
      ImageMagick.
      
      Only if there is no filename that matches the pattern, the string is
      correctly passed to ImageMagick (i.e. as-is). But even in that case
      there is a performance penalty, because the shell has to scan the whole
      directory to check if the file exists. This becomes especially bad if
      you're not dealing with a local file system.
      
      By properly escaping the frame selector we stop the shell from
      interpreting the glob pattern and both problems get fixed.
      
      Resolves: #31797
      Releases: 6.2, 6.1
      Change-Id: Ib6dc6556bb9f1d64a0154b0cbe9e253b185c74c2
      Reviewed-on: https://review.typo3.org/6662
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      c5fcc5fd
    • Tom Ruether's avatar
      [BUGFIX] Only create one keypair in rsaauth · 6c4c4d95
      Tom Ruether authored
      If there are two login forms on one page the second form's private
      key overwrites the first form's private key so the first form doesn't
      work. With this patch only one keypair gets created and it doesn't
      matter how many login forms you have one one page.
      
      Change-Id: I42660140aea72d1888cc73d56e83b823206a0797
      Fixes: #24877
      Fixes: #6708
      Releases: 6.2, 6.1, 6.0, 4.5
      Reviewed-on: https://review.typo3.org/10485
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      Reviewed-by: Daniel Gorges
      Tested-by: Daniel Gorges
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      6c4c4d95
    • Ralf Hettinger's avatar
      [BUGFIX] use search word(s) for ordering search results (again) · b96eaa47
      Ralf Hettinger authored
      There has been a regression in http://review.typo3.org/6657 which
      removes correlation between searched words and ordering of search
      results. Therefore the ordering of search results had nothing to do
      with the search term anymore. This is fixed hereby by using the code
      parts from prior versions.
      
      Resolves: #38767
      Releases: 6.2, 6.1, 6.0, 4.7
      Change-Id: I9cfaceaeede38456dd7622085879c1bd0648be85
      Reviewed-on: https://review.typo3.org/20294
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      Reviewed-by: Wouter Wolters
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      b96eaa47
  5. 08 Jan, 2014 9 commits
    • Markus Klein's avatar
      [BUGFIX] Fix wording of encryption key in Installer · 1341588d
      Markus Klein authored
      The description of the encryption key uses the irregular verb
      'output' in the wrong way.
      
      Resolves: #54677
      Releases: 6.2
      Change-Id: Iad5cf8fea6e57cd8449da6d93edd7d05b3b52bf8
      Reviewed-on: https://review.typo3.org/26611
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      1341588d
    • Philipp Gampe's avatar
      [BUGFIX] Installer fails when no database is selected · 9dfc355c
      Philipp Gampe authored
      Display an error message, if the selected database name is empty.
      
      Resolves: #54569
      Releases: 6.2
      Change-Id: Idbf768d7edc0e5d5e1d0faf87d62e1060c70b1e9
      Reviewed-on: https://review.typo3.org/26544
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      9dfc355c
    • Oliver Hader's avatar
      [BUGFIX] Functional tests cannot write to backend log · 270a7eaa
      Oliver Hader authored and Wouter Wolters's avatar Wouter Wolters committed
      Functional test cases cannot write to the backend log. The
      log entry also has an information about the currently used
      IP address, which is taken from the environment variable
      REMOTE_ADDR. In a CLI disposal this value is NULL and cannot
      be stored in the database, since the accordant sys_log.IP
      field does not support NULL values.
      
      Fixes: #54849
      Releases: 6.2
      Change-Id: If6c572c62ab7022a4cab596fa4660dec754aee3c
      Reviewed-on: https://review.typo3.org/26697
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      270a7eaa
    • Michiel Roos's avatar
      [TASK] Cleanup ContentObject\ContentObjectRenderer · 05ba10c3
      Michiel Roos authored and Wouter Wolters's avatar Wouter Wolters committed
      Implement early return for many methods.
      
      Change-Id: I7e0c8549037f4ab15ee8653d124891bad655db83
      Resolves: #54823
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26687
      Reviewed-by: Oliver Klee
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      05ba10c3
    • Georg Ringer's avatar
      [BUGFIX] Render ext icon in EM only if available · 8042d929
      Georg Ringer authored and Wouter Wolters's avatar Wouter Wolters committed
      Even if the ext icon is required, it can happen that it is still not
      there. Currently this leads to an ugly output which can be easily
      fixed by just checking if the icon is there.
      
      Change-Id: I207a93bb796510fba6096085a86f1dd832100e06
      Resolves: #54838
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26693
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      8042d929
    • Michiel Roos's avatar
      [TASK] Use arrays in str_replace() calls · ff2933b8
      Michiel Roos authored
      Multiple consecutive calls to str_replace can be replaced with a single
      call if the subject is the same.
      
      This will speed up the replacement and in some cases has the benefit of
      being able to return or use the result of the str_replace directly without
      creating an intermediate variable.
      
      Bad:
      $lala = 'something';
      $lala = str_replace('so', 'the', $lala);
      $lala = str_replace('me', ' ', $lala);
      $lala = str_replace('thing', 'other', $lala);
      
      Good:
      $lala = str_replace(
        array('so', 'me', 'thing'),
        array('the', ' ', 'other'),
        'something'
      );
      
      Change-Id: I1a2b99cce1444d3d2191eba8674f74aa2f74f0e8
      Resolves: #54500
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26481
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      ff2933b8
    • Markus Klein's avatar
      [TASK] Improve performance of array_merge_recursive_overrule · 2917b074
      Markus Klein authored
      The method GeneralUtility::array_merge_recursive_overrule()
      always works on a copy of the given array(s). This is highly
      inefficient when it comes to really big arrays and recursion.
      
      This patches moves the functionality into the class ArrayUtility
      and changes the behaviour to use a reference to the
      original array.
      All calls in the core are adjusted accordingly.
      
      Furthermore we deprecate the method in GeneralUtility and
      preserve backward compatibility.
      
      Resolves: #54251
      Releases: 6.2
      Change-Id: I5499905593c2124897de5998be985e546a3d05ee
      Reviewed-on: https://review.typo3.org/25986
      Reviewed-by: Michiel Roos
      Tested-by: Michiel Roos
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      2917b074
    • Ingo Schmitt's avatar
      [TASK] Optimize columns in sys_file_reference · 9e88bf74
      Ingo Schmitt authored
      MySQL up to version 5.5 allows at maximum 64 characters for table- 
      and fieldnames. Other DBMS allow less. Since MySQL is our primary
      database and DBAL could handle specialties.
      
      This patch changes the fields tablenames, fieldname and table_local
      to varchar(64) which currently is considered save.
      
      Resolves: #54726
      Releases: 6.2
      Change-Id: Ic67450a9326dceb413fe694a6233b8c092f70c79
      Reviewed-on: https://review.typo3.org/26625
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      9e88bf74
    • Ingo Schmitt's avatar
      [TASK] Adapt indexes of sys_file_reference · 6335a24a
      Ingo Schmitt authored
      The backend and frontend fire several queries for referenced
      files - files with metadata overlay as used in tt_content for
      images and media field as well as in pages:media.
      Analysing the queries for that some indexed should be added
      to improve the query speed on large installations.
      
      This patch adds indexed for the table/fieldname combination
      as well es the uid of the record the file is attached to.
      
      Resolves: #54725
      Releases: 6.2
      Change-Id: I229e27e382e8d0fdaf9bbc0b6729f90dac019e19
      Reviewed-on: https://review.typo3.org/26626
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      6335a24a
  6. 07 Jan, 2014 4 commits
    • Wouter Wolters's avatar
      [TASK] Superfluous comparison in indexed_search · 15b522c4
      Wouter Wolters authored
      Change-Id: I1934a6201876290b706078519e934e05c28352ab
      Resolves: #54053
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/25740
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Jo Hasenau
      Reviewed-by: Michiel Roos
      Tested-by: Michiel Roos
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      15b522c4
    • Wouter Wolters's avatar
      [TASK] Superfluous comparison in DatabaseRecordList · e36d347f
      Wouter Wolters authored
      Fix superfluous comparison against boolean in
      DatabaseRecordList::getTable
      
      Change-Id: Icdbf78935da4135a7c6b4902b97c87e7ce658eb8
      Resolves: #54049
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/25736
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      e36d347f
    • Francois Suter's avatar
      [TASK] Clean up uses of fe_adminLib properties · 95886120
      Francois Suter authored
      Two Core tables (fe_users and index_config) still use the
      "fe_admin_fieldList" property, which has no effect on the
      Core since the fe_adminLib.inc was moved out of it
      (into the statictemplates extension).
      
      Additionally a deprecation message is logged in method
      ExtensionManagementUtility::addTCAcolumns() when the $addTofeInterface
      argument is set to TRUE.
      
      Resolves: #54613
      Releases: 6.2
      Change-Id: I7c9961c5e92411a78bd355519a0493eb695177e7
      Reviewed-on: https://review.typo3.org/26567
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Oliver Klee
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      95886120
    • Benjamin Rau's avatar
      [BUGFIX] Repository uses wrong property to calc current result page · 9de93a17
      Benjamin Rau authored
      In the IndexedSearchRepository on line 157 an undefined/unused 
      property $this->resultsPerPage is used for the calculation 
      of the current page the visitor is showing on search results.
      
      Instead of using $this->resultsPerPage we have to use 
      $this->numberOfResults which is defined and contains the expected setting.
      
      Change-Id: I37c3a08c1049eb6166704b2b98ba071f03aad243
      Resolves: #54808
      Releases: 6.2, 6.1
      Reviewed-on: https://review.typo3.org/26677
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9de93a17