Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
  1. 19 Dec, 2017 1 commit
  3. 08 Sep, 2017 1 commit
    • Benni Mack's avatar
      [!!!][BUGFIX] Separate sys_history from sys_log db entries · d047b314
      Benni Mack authored 
      Before, the history module fetched info about "modified records" from
sys_history+the authoritive user from a coupled sys_log entry.

Info about "insert" and "delete" was fetched from sys_log solely.

However, when using a scheduled cleanup task to truncate sys_log
then all history information is useless (see bug report).

The patch introduces a new RecordHistoryStore as an abstraction
for adding history entries (currently done solely within DataHandler).

It adds some additional, necessary SQL fields to sys_history to
store all information in there and creates an update wizard
to migrate all coupled sys_history/sys_log entries to a
new sys_history entry itself.

Additionally, the whole existing "RecordHistory" class is
now only necessary for fetching the so-called ChangeLog,
for a page or a specific record, and to do rollbacks, preparing
the history records so they can be worked on.

The whole logic for fetching the GET/POST parameters is moved
into the "ElementHistoryController", everything that is only possible
via Fluid is moved from the RecordHistory object and the
ElementHistoryController into the view.

Referencing from sys_log (Log module) into sys_history is
now done the other way around, storing information about
the corresponding history entry inside sys_log.
As a side-effect, sys_log should load faster.

Abstraction basis:
- sys_history is the only source of truth about the history of a record
- sys_log contains a reference to an history entry now
(inside sys_log.log_data) to link from the backend log module
- RecordHistoryStore exists for tracking changes to records
- RecordHistory is for retrieving, compiling the history/changelog and rollbacks
- ElementHistoryController is doing PSR-7 style request/response
handling and preparing data for the view
- Fluid is handling more view functionality now, removing
the need for doing <f:format.raw> everywhere in the templates.

Sidenotes:
* Data within sys_history is now stored as JSON, not serialized anymore
* Adding/deleting was previously stored in sys_log only, is now within sys_history
* Moving records is now tracked (but not evaluated yet)
* Highlight/Snapshot functionality within the Backend Module
was removed

This functionality is built so it can also be used within Extbase
persistence and in FE in general in a future iteration.

Resolves: #55298
Resolves: #71950
Releases: master
Change-Id: I354317609099bac10c264b9932e331fa908c98be
Reviewed-on: https://review.typo3.org/53195

Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez's avatarAndreas Fernandez <typo3@scripting-base.de>
Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer's avatarJoerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer's avatarJoerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      d047b314
  5. 28 Mar, 2017 1 commit
    • Wouter Wolters's avatar
      [TASK] Streamline return tags in phpdocs · eb049dba
      Wouter Wolters authored and Benni Mack's avatar Benni Mack committed 
      The TYPO3 Core currently has no guidline how to handle phpdoc
comments regarding @return annoations related to "void" and "null".

In practice, these annotations have no additional value if no additional
documentation is given.

With this change, the php-cs-fixer will remove any unnecessary linebreaks
within the comments above the @return annotation, as well as remove completely
empty phpdoc comments because the @return annotation is removed.

Please be aware, that once PSR-5 is accepted, this coding standard
within the TYPO3 Core will change again, where there are currently
some further proposal details like inheritance information.

Resolves: #80454
Releases: master
Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
Reviewed-on: https://review.typo3.org/51686

Reviewed-by: Nicole Cordes's avatarNicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes's avatarNicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      eb049dba
  7. 11 Jan, 2017 1 commit
  9. 30 Aug, 2016 1 commit
  11. 07 Jul, 2016 1 commit
  13. 08 Oct, 2015 1 commit
  15. 23 Sep, 2015 1 commit
  17. 15 Jul, 2015 1 commit
  19. 19 Dec, 2014 2 commits
  21. 13 Dec, 2014 1 commit
  23. 06 Dec, 2014 1 commit
  25. 21 Nov, 2014 1 commit
  27. 13 Nov, 2014 1 commit
  29. 03 Nov, 2014 1 commit
  31. 02 Nov, 2014 1 commit
  33. 28 Oct, 2014 1 commit
  35. 25 Oct, 2014 2 commits
  37. 22 Jun, 2014 1 commit
    • Michael Schams's avatar
      [TASK] Re-work/simplify copyright header in PHP files - Part 7 · 47a9bb03
      Michael Schams authored 
      This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59783 for further details.

Resolves: #59783
Releases: 6.3, 6.2
Change-Id: I0e2f68990217f7442abe5b940fd769250c37aec0
Reviewed-on: https://review.typo3.org/31028
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
      47a9bb03
  39. 01 Feb, 2014 1 commit
    • Jo Hasenau's avatar
      [TASK] Use (int) instead of intval() or (integer) · 9646d26b
      Jo Hasenau authored 
      This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014

Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
      9646d26b
  41. 13 Jan, 2014 1 commit
  43. 09 Jan, 2014 1 commit
    • Steffen Müller's avatar
      [BUGFIX] Allow empty values in start/stop filter of belog · beb80664
      Steffen Müller authored and Wouter Wolters's avatar Wouter Wolters committed 
      One can limit records in the backend log module to a custom period
of time using the "User defined" mode and a start and stop field.

Leaving these fields empty is now supported in the corresponding
domain model setters by adding default values to the DateTime
arguments.

Resolves: #53975
Releases: 6.1, 6.2
Change-Id: I944322bb3747a29fab33c3d32e17dd070c7cb6db
Reviewed-on: https://review.typo3.org/26723
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
      beb80664
  45. 01 Oct, 2013 1 commit
  47. 19 Mar, 2013 1 commit
    • Wouter Wolters's avatar
      [TASK] Update copyright year to 2013 · 4d463976
      Wouter Wolters authored and Christian Kuhn's avatar Christian Kuhn committed 
      In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.

Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      4d463976
  49. 16 Feb, 2013 1 commit
    • Wouter Wolters's avatar
      [TASK] Cleanup "belog" sysext · 4c15ae09
      Wouter Wolters authored and Oliver Hader's avatar Oliver Hader committed 
      Reformats the code, fixes indents and removes extra empty lines. This is
not a functional change but a visual clean up.

Change-Id: I0d11dd7c43eee5d181c4bc0565c85d651c5c29e1
Resolves: #45392
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18207
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
      4c15ae09
  51. 10 Feb, 2013 1 commit
  53. 25 Jan, 2013 1 commit
  55. 16 Nov, 2012 1 commit
  57. 12 Sep, 2012 1 commit
    • Christian Kuhn's avatar
      [TASK] Clean up some ext:belog details and activate tests in travis · 22ff3b64
      Christian Kuhn authored 
      Cleans up ext:belog and activates the test suite:
* Fix some annotations
* Move a test that was put to a wrong location
* Minor CGL and readability changes
* Remove namespace compat layer of new 6.0 classes
* Change module registration and viewhelper to namespace

Change-Id: Ia31b5fcd52b76c40dbc6215c9820fa8c83a8ab86
Resolves: #40871
Related: 6.0
Reviewed-on: http://review.typo3.org/14557
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      22ff3b64
  59. 23 Aug, 2012 1 commit
  61. 01 Aug, 2012 1 commit
  63. 03 Jul, 2012 1 commit
  65. 10 Apr, 2012 1 commit