This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 19 Dec, 2017 1 commit
-
-
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 16 Jun, 2017 1 commit
-
-
Benni Mack authored
There are several places where mb_* methods are still not used, although they are even better to use instead of the $csConv->parseCharset() method for instance, as it has more aliases defined already. Same goes for "entities_to_utf8" which is a PHP user-space implementation of html_entity_decode() dated back to Kaspers' change in 2003. Using native PHP methods should also increase performance marginally. Resolves: #81575 Releases: master, 8.7 Change-Id: I5e97881cc7107883a5ff53d534161a7ec17e1ee5 Reviewed-on: https://review.typo3.org/53208 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 17 Feb, 2017 1 commit
-
-
Resolves: #79880 Releases: master Change-Id: Ia4b240614ee2c1c1a220fcea7d0f7d13ad518acb Reviewed-on: https://review.typo3.org/51734 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- 01 Feb, 2017 1 commit
-
-
Change string comparison for string checks. Checks which could lead to false positives like comparing with '0' or '' are excluded. RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+') Resolves: #79540 Resolves: master Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9 Reviewed-on: https://review.typo3.org/51462 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- 18 Nov, 2016 1 commit
-
-
This allows to configure the ordering cirteria for suggest wizard search results. Resolves: #78523 Releases: master Change-Id: I4bbcbeab765b037ba3b3457a2bc9ca3323f95f59 Reviewed-on: https://review.typo3.org/50460 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- 26 Oct, 2016 1 commit
-
-
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- 03 Aug, 2016 2 commits
-
-
DatabaseConnection uses plain PHP code under the hood, so the code can be used directly. Resolves: #77392 Releases: master Change-Id: I8b64414a538dc68cb4594751c393009c54b499c6 Reviewed-on: https://review.typo3.org/49361 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
-
selectClause and addWhere properties are removed from class signature as they are not needed after the Doctrine refactoring Resolves: #77049 Releases: master Change-Id: Id7a28902443067d2e56ee2aab9deac2962ddef81 Reviewed-on: https://review.typo3.org/48924 Tested-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
-
- 31 Mar, 2016 1 commit
-
-
The callUserFunction() method is called in various places with wrong arguments (parameter 4 and 5). The patch streamlines the calls. Resolves: #75339 Releases: master Change-Id: I05896369fa0cbf3bf5da95dd99b919e671ca06a6 Reviewed-on: https://review.typo3.org/47465 Reviewed-by:
-
- 16 Feb, 2016 1 commit
-
-
The CharsetConverter object is agnostic of charset and environment, and a singleton on top. There are still several calls in the TYPO3 core that tries to fetch csConv from TSFE or LANG which relies heavily on the environment. The calls are replaced with simple instance calls where possible. Resolves: #73441 Releases: master Change-Id: I098f17b1cdbcc1ebbbb7359cfec518c93597aad4 Reviewed-on: https://review.typo3.org/46627 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
- 12 Feb, 2016 1 commit
-
-
Benni Mack authored
The TYPO3 Backend is utf-8 by default since TYPO3 4.5, but certain places read the value still from $GLOBALS['LANG']->charSet, which is now always "utf-8". All occurrences are replaced by "utf-8" for now. Future cleanups will further simplify these code changes. Resolves: #73194 Releases: master Change-Id: I4b68a168ee7f2468b196cd3ccd1336cf6ba8a1df Reviewed-on: https://review.typo3.org/46545 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 28 Dec, 2015 1 commit
-
-
Resolves: #72451 Releases: master Change-Id: Ie7c8309800304b68c2d345636ba0ecc6ba6cf872 Reviewed-on: https://review.typo3.org/45452 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
- 09 Oct, 2015 1 commit
-
-
Resolves: #70550 Releases: master Change-Id: I55bc6c2396688db1fa26b8662b82d0c2b43b2226 Reviewed-on: http://review.typo3.org/43834 Reviewed-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 22 Sep, 2015 1 commit
-
-
Deprecate the IconUtility class from EXT:backend and handle its calls using the new IconFactory from EXT:core. Kudos to Benjamin Kott, Stephan Großberndt, Andreas Fernandez and Frans Saris for the great support on this big project. Resolves: #69057 Releases: master Change-Id: I27a045b7a3b9d31e6e3e915e1452d44af56b0cee Reviewed-on: http://review.typo3.org/42613 Reviewed-by:
Benjamin Kott <info@bk2k.info> Tested-by:
Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by:
-
- 20 Sep, 2015 1 commit
-
-
Implement replacement and replace all core usages of IconUtility::getSpriteIconForRecord() with IconFactory->getIconForRecord(). Register and fix several icon definitions for core tables. Resolves: #69754 Releases: master Change-Id: I5adf4f58a0331c77458049e19c7c8ca441b9e4cf Reviewed-on: http://review.typo3.org/43272 Reviewed-by:
-
- 19 Jul, 2015 1 commit
-
-
Resolves: #68290 Releases: master Change-Id: Ib67ed25c8e4a787302582fffe8006879fcd51f08 Reviewed-on: http://review.typo3.org/41587 Reviewed-by:
-
- 15 Jul, 2015 1 commit
-
-
@author information can be found in version control. Cluttering our code with these tags does not make much sense and they are outdated by definition or would sum up to impressive lists. As decided on acme 2015, we drop them now. Releases: master Resolves: #68152 Change-Id: Iec1ea0f873b44ab6027c94ba8353a9fdb5477bdd Reviewed-on: http://review.typo3.org/41264 Reviewed-by:
-
- 04 Jul, 2015 1 commit
-
-
Replace occurences of count() with matching empty() pendants. Resolves: #67774 Releases: master Change-Id: Ie75551a9410affe8840b521e15a0daf68655ba2a Reviewed-on: http://review.typo3.org/40683 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Sommer <markussom@posteo.de> Tested-by:
-
- 16 Jun, 2015 1 commit
-
-
The method IconUtility::getIcon was used for returning overlaid icons before TYPO3 CMS 4.4, based on raw icons inside gfx/i/ and created temporary icons when not present. The left-over function calls are replaced with sprite icon calls. Additionally, in order to thin out typo3/gfx/, all icons which have always been overlaid with t3skin already have been removed. All other files from typo3/gfx/i/ are moved to EXT:t3skin to stay compatible. With TYPO3 CMS 8, the folder EXT:t3skin/icons/gfx/i/ will be completely removed with the function itself. Resolves: #67506 Releases: master Change-Id: Idc20fadd36ffeb26782d8d54e27802a0412f9516 Reviewed-on: http://review.typo3.org/40305 Reviewed-by:
Frederic Gaus <frederic.gaus@flagbit.de> Tested-by:
-
- 28 Apr, 2015 1 commit
-
-
Christian Kuhn authored
This patch introduces a structural code refactoring to the FormEngine class and its related friend classes. FormEngine used to call itself over and over again with itself and sub classes writing to public properties of FormEngine keeping a global state that is then magically merged to sometimes working output. The patch introduces a tree approach with lots of small containers doing an encapsulated part of the rendering process and calling sub containers for inner details. As main construct a "globalOptions" array is modified in containers and given down to sub containers (tree knots) or elements (leaves), while sub structures always return a defined array that is merged by the parent and accumulates the full result. Goal is to have a better encapsulated code structure with better visible impact on changes done to this system. The patch creates this main structure. There is still a lot of mess around and additional patches can further improve the overall situation with smaller changes. Change-Id: I56b898dc0eaae8de4d31016997cfefe8d14ec53e Releases: master Resolves: #63846 Resolves: #63854 Resolves: #63856 Resolves: #63858 Resolves: #63859 Resolves: #63860 Resolves: #63861 Resolves: #63862 Resolves: #63863 Resolves: #63865 Resolves: #63876 Resolves: #63881 Resolves: #63882 Resolves: #63883 Resolves: #63893 Reviewed-on: http://review.typo3.org/38433 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
- 28 Feb, 2015 1 commit
-
-
This patch improves the separation of FormEngine and its sub classes. Currently, all sub classes like single element and wizard classes get an instance of the parent object to call various methods and properties on them. This is very hard to refactor and the mesh of call trees must be simplified to ease further refactoring and improve maintainability of code. This patch follows a divide & conquer approach: * Methods only used by sub elements are moved to AbstractFormElement * Properties FormEngine "knows" that are needed by element classes are given down in a data array during element instatiation to have a clear definition of what element classes know. * Methods used by both FormEngine and sub classes that do not need an instance of FormEngine are moved to a static helper for now to reduce the amount of code in FormEngine and to mark certain areas as stateless. * Class instances are not created on a global level anymore but created only in the scope where they are used * Class instances injected by outer code are created internally for enabling the using code to be moved around. All in all, this patch is mostly a preparation of defining a fully separated structure with defined concerns for every sub class. Most methods are moved around "as is" without changing functionality. The only area that is refactored codewise is renderWizards(). There is still a nasty circular dependency between FormEngine, FlexFormElement and InlineElement. This is not resolved by the patch, but the surrounding code is now separated enough that this structure could be refactored to a tree. This may follow with other patches. This patch evolved on catharsis in branch formengine with 53 single patches. Details can be looked up there, all single patches are prefixed with [FormEngine]. https://github.com/lolli42/TYPO3.CMS-Catharsis/tree/formengine Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f Releases: master Resolves: #65357 Resolves: #63848 Resolves: #63849 Resolves: #63851 Resolves: #63853 Resolves: #63855 Resolves: #63857 Resolves: #63867 Resolves: #63868 Resolves: #63869 Resolves: #63870 Resolves: #63871 Resolves: #63872 Resolves: #63873 Resolves: #63874 Resolves: #63875 Resolves: #63877 Resolves: #63879 Resolves: #63880 Resolves: #63884 Resolves: #63885 Resolves: #63886 Resolves: #63887 Resolves: #63888 Resolves: #63890 Resolves: #63892 Reviewed-on: http://review.typo3.org/37265 Reviewed-by:
-
- 18 Jan, 2015 1 commit
-
-
Markus Klein authored
It is faster to compare a string with === '' to find out if it's empty than to run strlen() on it. The replacement rules are applied as follows: * if (strlen($str)) => if ((string)$str !== '') * if (!is_string($str) || strlen($str) === 0) => if (!is_string($str) || $str === '') * If it can be seen easily that $str is a string, the typecast is omitted. Change-Id: I888d70e42f925bd57ad23b873b72d6a38acb39ef Resolves: #54091 Releases: master Reviewed-on: http://review.typo3.org/27794 Reviewed-by:
-
- 29 Dec, 2014 1 commit
-
-
Wouter Wolters authored
Resolves: #64051 Releases: master Change-Id: I7a36da752fb72d30b5504003cc494feb835a8592 Reviewed-on: http://review.typo3.org/35661 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
- 16 Dec, 2014 1 commit
-
-
Most of TYPO3's PHP files have an empty line before a class' closing curly brace. This commit adds this empty line (if it is missing) before a class' closing curly brace. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (}\n)(}) Replace: $1\n$2 Resolves: #63942 Release: master Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7 Reviewed-on: http://review.typo3.org/35527 Reviewed-by:
-
- 15 Dec, 2014 1 commit
-
-
This patch deprecates FormEngine::sL() and removes the dependency from all form element classes. Resolves: #63855 Releases: master Change-Id: I58a596c9c8c09f18f5129cd64dd1e76296d37f3f Reviewed-on: http://review.typo3.org/35466 Reviewed-by:
-
- 13 Dec, 2014 1 commit
-
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- 03 Nov, 2014 1 commit
-
-
Wouter Wolters authored
Resolves: #62664 Releases: master Change-Id: Ib8e0695fc234ab67a2f73a65737e07cf9a2d19c6 Reviewed-on: http://review.typo3.org/33757 Reviewed-by:
-
- 02 Nov, 2014 1 commit
-
-
Wouter Wolters authored
Use "int" or "bool" in @var notation instead of "interger" or "boolean". Resolves: #62571 Releases: master Change-Id: Icc17d2a7806a4632da2c4684c57f1f6d619878a3 Reviewed-on: http://review.typo3.org/33632 Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- 28 Oct, 2014 1 commit
-
-
Wouter Wolters authored
* Use bool in @return * Use int in @return * Use bool in @param * Use int in @param * Remove extra tabs and spaces in @param Resolves: #62506 Releases: master Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2 Reviewed-on: http://review.typo3.org/33577 Reviewed-by:
-
- 25 Oct, 2014 1 commit
-
-
Wouter Wolters authored
Resolves: #62467 Releases: master Change-Id: I927a16b0fa89c5b859b56a7549548102ac04037f Reviewed-on: http://review.typo3.org/33522 Reviewed-by:
-
- 22 Jun, 2014 1 commit
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59782 for further details. Resolves: #59782 Releases: 6.3, 6.2 Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd Reviewed-on: https://review.typo3.org/31027 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- 23 Feb, 2014 2 commits
-
-
Stefan Neufeind authored
This reverts commit de27a20a Change-Id: I078d2f7bbff605c91d83a9853e8feb9c31d57ccc Reviewed-on: https://review.typo3.org/27792 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
It is faster to compare a string with === '' to find out if it's empty than to run strlen() on it. The replacement rules are applied as follows: * if (strlen($str)) => if ((string)$str !== '') * if (!is_string($str) || strlen($str) === 0) => if (!is_string($str) || $str === '') * If it can be seen easily that $str is a string, the typecast is omitted. Resolves: #54091 Releases: 6.2 Change-Id: I59c5cbccea4f98b8f282377e6aa67d970859a457 Reviewed-on: https://review.typo3.org/27091 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 01 Feb, 2014 1 commit
-
-
Jo Hasenau authored
This patch replaces most of around 1600 occurrences of intval() and every (integer) in the whole core. Additionally it changes GeneralUtility::intExplode to use references and typecasting as well. Some occurrences of strstr() together with intval() have been replaced with strpos() as well. And some superfluous intval calls have been removed or reduced to a single one i.e. for protected variables or before loops. Patch updated after Core CGL decision from 30.01.2014 Resolves: #54265 Releases: 6.2 Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8 Reviewed-on: https://review.typo3.org/26740 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 30 Jan, 2014 1 commit
-
-
Shorten some constructs, make them easier to read and less error-prone. Resolves: #46400 Releases: 6.2 Change-Id: I7b0126ccfeaefdfdb89321d7287c6347d8aee050 Reviewed-on: https://review.typo3.org/19007 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- 13 Jan, 2014 1 commit
-
-
Roland Waldner authored
"textfile" will be replaced by "text file" Resolves: #54893 Releases: 6.2 Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b Reviewed-on: https://review.typo3.org/26736 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
