This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
  1. 19 Dec, 2017 1 commit
  2. 16 Jun, 2017 1 commit
  3. 12 May, 2017 1 commit
  4. 28 Mar, 2017 1 commit
    • Wouter Wolters's avatar
      [TASK] Streamline return tags in phpdocs · eb049dba
      Wouter Wolters authored and Benni Mack's avatar Benni Mack committed
      The TYPO3 Core currently has no guidline how to handle phpdoc
      comments regarding @return annoations related to "void" and "null".
      
      In practice, these annotations have no additional value if no additional
      documentation is given.
      
      With this change, the php-cs-fixer will remove any unnecessary linebreaks
      within the comments above the @return annotation, as well as remove completely
      empty phpdoc comments because the @return annotation is removed.
      
      Please be aware, that once PSR-5 is accepted, this coding standard
      within the TYPO3 Core will change again, where there are currently
      some further proposal details like inheritance information.
      
      Resolves: #80454
      Releases: master
      Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
      Reviewed-on: https://review.typo3.org/51686
      
      Reviewed-by: Nicole Cordes's avatarNicole Cordes <typo3@cordes.co>
      Tested-by: Nicole Cordes's avatarNicole Cordes <typo3@cordes.co>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      eb049dba
  5. 17 Feb, 2017 1 commit
  6. 01 Feb, 2017 1 commit
  7. 18 Nov, 2016 1 commit
  8. 26 Oct, 2016 1 commit
  9. 30 Aug, 2016 1 commit
  10. 03 Aug, 2016 2 commits
  11. 31 Mar, 2016 1 commit
  12. 16 Feb, 2016 1 commit
  13. 12 Feb, 2016 1 commit
  14. 28 Dec, 2015 1 commit
  15. 09 Oct, 2015 1 commit
  16. 08 Oct, 2015 1 commit
  17. 22 Sep, 2015 1 commit
  18. 20 Sep, 2015 1 commit
  19. 19 Jul, 2015 1 commit
  20. 15 Jul, 2015 1 commit
  21. 04 Jul, 2015 1 commit
  22. 16 Jun, 2015 1 commit
  23. 28 Apr, 2015 1 commit
    • Christian Kuhn's avatar
      [!!!][TASK] House of forms · 736cbfc9
      Christian Kuhn authored
      This patch introduces a structural code refactoring to the
      FormEngine class and its related friend classes.
      
      FormEngine used to call itself over and over again with itself
      and sub classes writing to public properties of FormEngine keeping
      a global state that is then magically merged to sometimes working
      output.
      
      The patch introduces a tree approach with lots of small containers
      doing an encapsulated part of the rendering process and calling
      sub containers for inner details.
      As main construct a "globalOptions" array is modified in containers
      and given down to sub containers (tree knots) or elements (leaves),
      while sub structures always return a defined array that is
      merged by the parent and accumulates the full result.
      Goal is to have a better encapsulated code structure with better
      visible impact on changes done to this system.
      
      The patch creates this main structure. There is still a lot of
      mess around and additional patches can further improve the overall
      situation with smaller changes.
      
      Change-Id: I56b898dc0eaae8de4d31016997cfefe8d14ec53e
      Releases: master
      Resolves: #63846
      Resolves: #63854
      Resolves: #63856
      Resolves: #63858
      Resolves: #63859
      Resolves: #63860
      Resolves: #63861
      Resolves: #63862
      Resolves: #63863
      Resolves: #63865
      Resolves: #63876
      Resolves: #63881
      Resolves: #63882
      Resolves: #63883
      Resolves: #63893
      Reviewed-on: http://review.typo3.org/38433
      
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Reviewed-by: default avatarMarkus Klein <klein.t3@reelworx.at>
      Tested-by: default avatarMarkus Klein <klein.t3@reelworx.at>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      736cbfc9
  24. 28 Feb, 2015 1 commit
    • Christian Kuhn's avatar
      [!!!][TASK] Improve FormEngine and sub classes separation · 212b9dbf
      Christian Kuhn authored and Anja Leichsenring's avatar Anja Leichsenring committed
      This patch improves the separation of FormEngine and its sub
      classes. Currently, all sub classes like single element and wizard
      classes get an instance of the parent object to call various methods
      and properties on them. This is very hard to refactor and the mesh
      of call trees must be simplified to ease further refactoring and
      improve maintainability of code.
      
      This patch follows a divide & conquer approach:
      * Methods only used by sub elements are moved to AbstractFormElement
      * Properties FormEngine "knows" that are needed by element classes
        are given down in a data array during element instatiation to have
        a clear definition of what element classes know.
      * Methods used by both FormEngine and sub classes that do not need
        an instance of FormEngine are moved to a static helper for now to
        reduce the amount of code in FormEngine and to mark certain areas
        as stateless.
      * Class instances are not created on a global level anymore but
        created only in the scope where they are used
      * Class instances injected by outer code are created internally
        for enabling the using code to be moved around.
      
      All in all, this patch is mostly a preparation of defining a
      fully separated structure with defined concerns for every sub class.
      
      Most methods are moved around "as is" without changing functionality.
      The only area that is refactored codewise is renderWizards().
      
      There is still a nasty circular dependency between FormEngine,
      FlexFormElement and InlineElement. This is not resolved by the patch,
      but the surrounding code is now separated enough that this structure
      could be refactored to a tree. This may follow with other patches.
      
      This patch evolved on catharsis in branch formengine with 53 single
      patches. Details can be looked up there, all single patches are
      prefixed with [FormEngine].
      https://github.com/lolli42/TYPO3.CMS-Catharsis/tree/formengine
      
      Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f
      Releases: master
      Resolves: #65357
      Resolves: #63848
      Resolves: #63849
      Resolves: #63851
      Resolves: #63853
      Resolves: #63855
      Resolves: #63857
      Resolves: #63867
      Resolves: #63868
      Resolves: #63869
      Resolves: #63870
      Resolves: #63871
      Resolves: #63872
      Resolves: #63873
      Resolves: #63874
      Resolves: #63875
      Resolves: #63877
      Resolves: #63879
      Resolves: #63880
      Resolves: #63884
      Resolves: #63885
      Resolves: #63886
      Resolves: #63887
      Resolves: #63888
      Resolves: #63890
      Resolves: #63892
      Reviewed-on: http://review.typo3.org/37265
      
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
      Reviewed-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
      Tested-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
      212b9dbf
  25. 18 Jan, 2015 1 commit
  26. 29 Dec, 2014 1 commit
  27. 16 Dec, 2014 1 commit
  28. 15 Dec, 2014 1 commit
  29. 13 Dec, 2014 1 commit
  30. 03 Nov, 2014 1 commit
  31. 02 Nov, 2014 1 commit
  32. 28 Oct, 2014 1 commit
  33. 25 Oct, 2014 1 commit
  34. 22 Jun, 2014 1 commit
    • Michael Schams's avatar
      [TASK] Re-work/simplify copyright header in PHP files - Part 6 · 526c060f
      Michael Schams authored
      This patch replaces the copyright/license header in PHP files with a
      new, simplified one. The new header does not show the year figure, nor
      an author name, and refers to the LICENSE.txt file for the full
      copyright information. License is: GPL2 or any later version.
      
      This is a multi-part commit due to the huge number of changed files.
      See issue #59782 for further details.
      
      Resolves: #59782
      Releases: 6.3, 6.2
      Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd
      Reviewed-on: https://review.typo3.org/31027
      Reviewed-by: Krzysztof Adamczyk
      Tested-by: Krzysztof Adamczyk
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      526c060f
  35. 23 Feb, 2014 2 commits
  36. 01 Feb, 2014 1 commit
    • Jo Hasenau's avatar
      [TASK] Use (int) instead of intval() or (integer) · 9646d26b
      Jo Hasenau authored
      This patch replaces most of around 1600 occurrences of
      intval() and every (integer) in the whole core.
      Additionally it changes GeneralUtility::intExplode to use references
      and typecasting as well.
      Some occurrences of strstr() together with intval() have been replaced
      with strpos() as well.
      And some superfluous intval calls have been removed or reduced
      to a single one i.e. for protected variables or before loops.
      Patch updated after Core CGL decision from 30.01.2014
      
      Resolves: #54265
      Releases: 6.2
      Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
      Reviewed-on: https://review.typo3.org/26740
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      9646d26b
  37. 30 Jan, 2014 1 commit
  38. 13 Jan, 2014 1 commit