This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 19 Dec, 2017 1 commit
-
-
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 29 Nov, 2017 1 commit
-
-
The last place in TYPO3 Core to use internal_type=file (backend_layout.icon) is now moved to FAL with sys_file_reference. An upgrade wizard is in place to migrate existing icons from uploads/media to sys_file. FormEngine is migrated to also allow to use sys_file_references for the TCA ctrl property "selicon_field". With this change, a followup could be integrated to deprecate "old-style" internal_type=file code, and also to not create the uploads/ folder at all anymore within TYPO3 installations. Additionally, the functionality of "selicon_field_path" should be deprecated in the future. Resolves: #83153 Releases: master Change-Id: I578fd68b7e1f7bc6a1991b90e7750b903d3ec28b Reviewed-on: https://review.typo3.org/54830 Tested-by:
Sebastian Hofer <sebastian.hofer@marit.ag> Tested-by:
Pawel Cieslik <p.cieslik@macopedia.pl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 16 Nov, 2017 1 commit
-
-
TSConfig properties keepItems and removeItems are checked with a weak in_array() test (third argument not set to true), which leads to the situation, that arbitrary string values are treated equal to integer 0 This is now fixed by flipping the array and check for the array index. This works nicely because PHP silently converts strings which look like integer to integer for the keys. Tests are added which cover these cases and demonstrate the failure before the change. Resolves: #82980 Releases: 8.7, master Change-Id: I544a221674fa89d302cb6c1bcca506847c6f7f0f Reviewed-on: https://review.typo3.org/54623 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 08 Nov, 2017 1 commit
-
-
Benni Mack authored
The patch migrates all data from pages_language_overlay into pages, and moves all API calls to overlay pages. The following restrictions are set: * Backend is always showing pages only for "sys_language_uid=0" for the page tree, element browser (e.g. "linking to default language page"), except where explicitly requested like the Page Module => Languages view. * pid and sorting are always the same for all translations and their default language page * Elements on a page are always keeping the field "pid" to the default language page (no change) * Permission checks for Backend users are always made against the default language page (perms_* fields and webmounts) Resolves: #82445 Releases: master Change-Id: I62536e21d7110fa434c75fbd4470a3f53b79d260 Reviewed-on: https://review.typo3.org/51272 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- 30 Oct, 2017 1 commit
-
-
Unpack the array elements before passing them on Resolves: #82159 Releases: master, 8.7 Change-Id: I6a094927f595d42fc15bb96a9dbc1d313a7808b0 Reviewed-on: https://review.typo3.org/54473 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 26 Oct, 2017 1 commit
-
-
Add the ’s’ (PCRE_DOTALL) modifier to regular expressions. Resolves: #82854 Releases: master, 8.7 Change-Id: Ib5feaba0272e45dce1bc0b4cfedb11f5eb0b10c2 Reviewed-on: https://review.typo3.org/54474 Tested-by:
-
- 22 Sep, 2017 1 commit
-
-
Resolves: #82512 Releases: master, 8.7 Change-Id: Ibfbd1a8e347f5b25871f5d073994bdb2af264051 Reviewed-on: https://review.typo3.org/54174 Tested-by:
-
- 08 Sep, 2017 1 commit
-
-
The explicit allow/deny section of backend user groups (be_groups) render separators (--div--) in the backend which need to be skipped. Change-Id: Iac578d43a7a561618d095819b9d667c613621f2b Resolves: #82379 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54009 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- 05 Sep, 2017 1 commit
-
-
If a user creates a sys_file_collection record, only those storage records must be shown which are allowed for the user. Resolves: #82029 Releases: master, 8.7, 7.6 Security-Commit: 45cdfccd52a224d8128e537214606848c717d8e7 Security-Bulletin: TYPO3-CORE-SA-2017-005 Change-Id: Iee94cd84f07ee0dc0730fe1ce84d228dad2f75a2 Reviewed-on: https://review.typo3.org/53902 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- 23 Aug, 2017 1 commit
-
-
Change a series of cgl details after update of php-cs-fixer from 1.0 to 1.4. Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f Resolves: #82171 Related: #82164 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53776 Tested-by:
-
- 02 Jun, 2017 1 commit
-
-
Resolves: #81421 Releases: master Change-Id: I7639eb080cd40397d1199b29a9c7abb160915767 Reviewed-on: https://review.typo3.org/53038 Tested-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 21 Apr, 2017 1 commit
-
-
Resolves: #80718 Releases: master Change-Id: I632b36b4b14cc354a6da1a060baf4801d5231766 Reviewed-on: https://review.typo3.org/52531 Reviewed-by:
-
- 20 Apr, 2017 1 commit
-
-
Christian Kuhn authored
Resolves: #80913 Releases: master Change-Id: I151fbf7a02df3e4713d623eb1659ac35ae2cb35a Reviewed-on: https://review.typo3.org/52490 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- 26 Feb, 2017 1 commit
-
-
Nicole Cordes authored
The patch adds the current database row to the data passed to the select field rendered by foreign_selector of IRRE. This data is necessary to properly resolve the ###CURRENT_PID### marker in a foreign_table_where clause. Resolves: #78960 Releases: master, 7.6 Change-Id: I17f6b4a78d20c101ef7caab227d23c87f138e8ce Reviewed-on: https://review.typo3.org/50934 Reviewed-by:
Jasmina Ließmann <code@frauliessmann.de> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 21 Feb, 2017 1 commit
-
-
Fix for issue #78628 fixed "addItems" for TCA trees, but broke them for select drop downs. Juggle icon providing around a bit to fix. Change-Id: I3a1077992a7db0d72bc2d7d0247292763cc25958 Resolves: #78747 Related: #78628 Releases: master Reviewed-on: https://review.typo3.org/51766 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- 01 Feb, 2017 1 commit
-
-
Change string comparison for string checks. Checks which could lead to false positives like comparing with '0' or '' are excluded. RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+') Resolves: #79540 Resolves: master Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9 Reviewed-on: https://review.typo3.org/51462 Reviewed-by:
-
- 03 Jan, 2017 1 commit
-
-
The patch adapts a series of nasty form engine areas to more solid code. The evaluate condition code is rewritten and works much better in flex form scenarios. The suggest wizard and svg tree are much more solid in flex forms. The group element is rewritten towards a better readable and easier to refactor code, dropping method dbFileIcons(). A bunch of issues is resolved along the way. * TCA "default" now works in flex form section container elements * The "displayCond" parser is now strict and throws exceptions on invalid syntax and wrong referenced fields to help debugging faulty display conditions * TCA displayCond on flex fields can now be prefixed with the sheet name and can reference field values from neighbor sheets * TCA displayCond now works with flex section containers * TCA flex section container now throw an exception if select or group fields configure a MM relation - this is not supported * TCA ctrl requestUpdate field is dropped, onChange=reload is now allowed not only on flex form fields, but also on normal columns fields * TCA tree now works as section container element and initializes correctly on new records and new containers * GroupElement rewrite to drop dbFileIcons() * config option maxitems now optional for type=group and type=select and defaults to "many items allowed" * inline now works in "fancy" flex situations with "new" records by handing the final dataStructureIdentifier around * FormEngine no longer loads extJS Change-Id: Id1d081627529cc1502bb198389e5bd69372815cd Resolves: #78899 Resolves: #72307 Resolves: #75646 Resolves: #76637 Resolves: #72106 Resolves: #78824 Resolves: #76793 Resolves: #68247 Resolves: #69715 Related: #78460 Related: #67198 Related: #72294 Releases: master Reviewed-on: https://review.typo3.org/50879 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 07 Dec, 2016 1 commit
-
-
Christian Kuhn authored
The patch changes the ajax result that delivers TCA tree items to the SVG tree from a nested list of items to a sorted flat list having a 'depth' argument to indicate the nesting level. This "flat" list is the native mode of the d3 tree, with this change the JS side can be streamlined quite a bit. Along the way, the item providing on PHP side is streamlined, documented much better and easier to understand now within the data provider of FormEngine. The main tree data backend is still a huge, convoluted, slow and insane mess that will eventually fully substituted with a much straighter and quicker approach later. Changes in this area are kept to a minimum for now. Change-Id: Ib64b7277f671b632be3977218e5465b534618d63 Resolves: #78905 Related: #76108 Releases: master Reviewed-on: https://review.typo3.org/50813 Reviewed-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
-
- 02 Dec, 2016 1 commit
-
-
The new flex form data structure handling in more picky and throws exception if a given data structure identifier can not be resolved. The FormEngine logic that displays exclude fields of flex forms has to do some guess work to find possible data structures. This may fail, resulting in an exception. The patch changes the according general exception to a specific one, catches it in the find flex form access rights logic, and adds more docu on what exactly is happening in this code. Change-Id: I2b808cbe804ba4ab967c8d95b17c0a12ec65ffd4 Resolves: #78852 Related: #78581 Releases: master Reviewed-on: https://review.typo3.org/50820 Tested-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Alexander Rothmund <alexander@rothmund.ch> Tested-by:
-
- 01 Dec, 2016 1 commit
-
-
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
-
- 18 Nov, 2016 1 commit
-
-
If an invalid extension name is passed to a 'EXT:...' path, the GeneralUtility::getFileAbsFileName function returns an empty string. This results in a scan of '\' in the first place, and the resulting error is not helpful for finding the source of the missing icons in the TCA select box. A check for a valid directory name and an exception in case of failure will help the situation. Resolves: #78737 Releases: master, 7.6 Change-Id: I9d5159eac9b511e879144789eecb40eafcc0288c Reviewed-on: https://review.typo3.org/50699 Reviewed-by:
-
- 13 Nov, 2016 1 commit
-
-
Adding items for type selectTree with pageTsConfig does not work as documented. The TCA tree needs multi-root handling to handle that. Additionally, some slight changes in the order of elements when items are calculated are needed. Resolves: #78628 Releases: master Change-Id: Iecf0225c0eeaab8ea661997cad26e68d255d8460 Reviewed-on: https://review.typo3.org/50565 Tested-by:
-
- 07 Nov, 2016 1 commit
-
-
Method BackendUtility::getFlexFormDS() does two things at once: It finds a data structure by given data (TCA, row, ...) and then parses it. This construct gives tons of headaches, since the methods never exposes where a specific data structure came from and the lookup mechanism is complex. Especially if a flex form is used in combination with ajax requests later, the core has massive issues since the location can not be found out later again. To solve that, the patch splits getFlexFormDS() into two methods: First method "FlexFormTools->getDataStructureIdentifier()" gets TCA and row and locates a specific structure. It returns an "identifier" that points to that unique data structure. This identifier can be later hand around easily. The second method "FlexFormTools->parseDataStructureByIdentifier()" then gets this identifier again, fetches the data structure the identifier points to, and parses it. Change-Id: I38264e8a4a6f956c12e9e50f6039d3d09af0f03a Resolves: #78581 Releases: master Reviewed-on: https://review.typo3.org/48212 Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- 31 Oct, 2016 1 commit
-
-
The icon rendering of custom page options was lost during refactoring of the ItemProviders. Resolves: #77075 Releases: master, 7.6 Change-Id: Iae6415525d94fc56c48332de9e5bc3980344fbc2 Reviewed-on: https://review.typo3.org/48967 Tested-by:
-
- 26 Oct, 2016 1 commit
-
-
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- 09 Oct, 2016 1 commit
-
-
Resolves: #77819 Releases: master Change-Id: If39540863a1114ce5ce3e57289da54bdfdffc4f2 Reviewed-on: https://review.typo3.org/49764 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Reviewed-by:
-
- 08 Oct, 2016 1 commit
-
-
If the 'multiple' field in the fieldConfig is set the $newDatabaseValueArray is returned as is, with duplicate entries. If this is not the case $newDatabaseValueArray is returned as before, being modified with the array_unique function. Resolves: #76918 Releases: master, 7.6 Change-Id: Id8ddac95162a929aeb1b5d7bae33a460317b46cb Reviewed-on: https://review.typo3.org/49981 Tested-by:
Karol Lamparski <klamparski@gmail.com> Tested-by:
-
- 03 Sep, 2016 1 commit
-
-
Change-Id: I010ebf2811075e2f92ce790afc45fec3144c4b56 Resolves: #77832 Releases: master Reviewed-on: https://review.typo3.org/49842 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
-
- 30 Aug, 2016 2 commits
-
-
Resolves: #77701 Releases: master Change-Id: Id5f32eb76ac3adddd834160bc79828fefd0ce63c Reviewed-on: https://review.typo3.org/49665 Tested-by:
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 28 Jul, 2016 1 commit
-
-
Resolves: #77291 Releases: master Change-Id: Ide336171ccfabb2d347dbad0a7e2f801c062f4e3 Reviewed-on: https://review.typo3.org/49252 Tested-by:
Frederic Gaus <frederic.gaus@flagbit.de> Reviewed-by:
-
- 25 Jul, 2016 1 commit
-
-
This patch removes default record title escaping in resolved DataProvider data and adds proper escaping where html output is generated. Resolves: #76399 Resolves: #76668 Resolves: #76900 Releases: master, 7.6 Change-Id: I03cf41c5200e920088116d1a67a2e342e46142d3 Reviewed-on: https://review.typo3.org/48779 Tested-by:
Susanne Moog <typo3@susannemoog.de> Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
- 13 Jul, 2016 1 commit
-
-
Apply proper constraints in the case of rootlevel == 1 or rootlevel == -1 Change-Id: I92a8edc800bab6320f0e10ad4f63a5f53b27df06 Resolves: #77045 Related: #75650 Releases: master Reviewed-on: https://review.typo3.org/48913 Tested-by:
-
- 07 Jul, 2016 1 commit
-
-
Manuel Selbach authored
Convert all SQL statements in backend utility class to the new Doctrine DBAL based API. Change-Id: I8febf022d8a5c40756baf051496521885bed1ab1 Releases: master Resolves: #75650 Reviewed-on: https://review.typo3.org/48040 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 06 Jul, 2016 1 commit
-
-
Replace ###CURRENT_PID### in FlexForm context with values from database. Within FlexForm context these values need to be retrieved from the key flexParentDatabaseRow. Resolves: #76888 Releases: master, 7.6 Change-Id: I5fd3cb0a18e41ae0d15cbb44556d05d88506a093 Reviewed-on: https://review.typo3.org/48749 Reviewed-by:
Ralf Merz <info@merzilla.de> Reviewed-by:
Sebastian Fischer <typo3@evoweb.de> Tested-by:
-
- 27 Apr, 2016 1 commit
-
-
Christian Kuhn authored
PAGE_TSCONFIG_ID, PAGE_TSCONFIG_IDLIST and PAGE_TSCONFIG_STR to replace markers in foreign_table_where fields could only be set for flex forms on a global level in the past: TCEFORM.tt_content.pi_flexform.PAGE_TSCONFIG_ID = 42 This has the negative side effect that also fields from potentially foreign plugins could have been affected by that. With the FormEngine rewrite, this change only worked if restricted to specific elements of a specific data structure: TCEFORM.tt_content.pi_flexform.news.sDEF.settings\.categories.PAGE_TSCONFIG_ID = 42 The former "global" setting was broken and is fixed by the patch with a hack. For master, this very hack is deprecated now and only the specific version is allowed, for 7.6 both versions work with the patch. Note there is no setting for those foreign_table_where clauses for section container elements anymore that is not deprecated. Change-Id: I3f7bede86007f7ea1703f2bc569e0152e67802e6 Resolves: #73209 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/47924 Reviewed-by:
-
- 24 Apr, 2016 1 commit
-
-
A select field with renderType selectSingle can point to a foreign_table. If on the foreign_table TCA the ctrl keys selicon_field and selicon_field_path are set, a single foreign row can have an "icon" field that is shown to represent this row. The patch fixes a bug where selicon_field of the own table instead of the foreign table was used. Additionally, in master the icon path resolving changed with #74157 leading to broken icon path in this case. This is fixed along with a similar change in backend layout code. Resolves: #75577 Related: #74157 Releases: master, 7.6 Change-Id: I50bac28018b17a61a334aac7d241bcdd96663656 Reviewed-on: https://review.typo3.org/47648 Reviewed-by:
-
- 22 Apr, 2016 1 commit
-
-
Frank Nägler authored
Resolves: #75859 Releases: master, 7.6 Change-Id: I43f786c349a096e752e5fdeb50b815b19e548924 Reviewed-on: https://review.typo3.org/47844 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
-
- 14 Apr, 2016 1 commit
-
-
Change-Id: I6fb8b355ceb4f734e4df5aaf2954c624693c11ad Reviewed-on: https://review.typo3.org/47677 Reviewed-by:
-
