This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 19 Dec, 2017 1 commit
-
-
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 15 Dec, 2017 1 commit
-
-
To prevent timing-attacks on hash-comparions it is advised to use hash_equals. Resolves: #83329 Releases: master, 8.7 Change-Id: I7539ed27538d7d81767bfce582d568cff09d1610 Reviewed-on: https://review.typo3.org/55074 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io> Tested-by:
-
- 14 Dec, 2017 1 commit
-
-
Fix some foreach loops so as not to run into potentially empty elements. Use the ?? operator to accomplish that. Change-Id: Id6306cea0546dfd4a20ba98c170335966cc2ae40 Resolves: #83322 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55066 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 09 Dec, 2017 1 commit
-
-
Some classes regarding ExtJS data providing the tree can now safely be removed, as they are not in use anymore. Resolves: #82426 Releases: master Change-Id: Ic35743154cb8e35b0ddc5a32cd0ec60e68832e0f Reviewed-on: https://review.typo3.org/55004 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 30 Nov, 2017 3 commits
-
-
The table and column name quoting method {#tableName}.{#columnName} introduced for TypoScript in issue #80506 is now used to quote identifiers in TCA column definitions known to possibly contain SQL fragments. Missing quotes for identifiers containing e.g. uppercase letters lead to exceptions when performing a query in PostgreSQL. In order to achieve this a new Class TcaPreparation is added as this is not a typical TcaMigration. Releases: master, 8.7 Resolves: #81751 Related: #80506 Change-Id: I230be317c7088e5de5343634fac507b4ab994b28 Reviewed-on: https://review.typo3.org/53360 Reviewed-by:Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
When a parent record (e.g. tt_content) has inline relations (e.g. sys_file_reference)and these relations show a placeholder for records related to them (e.g. sys_file and sys_file_metadata) then we need to pass the context of the language so that the placeholders are shown in the correct language. We now do so by putting the value of the language field of the parent record into the data set and update it in case child records are also translatable. This way when going down the list of children, we always know the language id of the last applicable parent element, even if one element in between was not translatable (e.g. sys_file) If we know the language, we can pick the correct record uid out of the list of possible related uids, instead of just picking the first one. Furthermore the language field for sys_file_metadata is removed from editor form as the language is set by GET parameter already. Change-Id: I64c97c8080196599e85b95e09e7eb89701670fa4 Resolves: #75040 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54831 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
The new PSR-7-based solution since TYPO3 v7 should be used everywhere instead of "BackendUtility::getModuleUrl()". This is possible because modules can be addressed via the "route" GET parameter instead of the "M" parameter since a few months. The patch changes all occurrences within TYPO3 Core to use the new API. Resolves: #83172 Releases: master Change-Id: Iec40e8ae00f1d900d7479b84a3a62827ddba653b Reviewed-on: https://review.typo3.org/54755 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- 29 Nov, 2017 3 commits
-
-
The FlexFormTools class tries to resolve the datastructure of flex fields by the given TCA configuration. The flexform definition can either be set directly in the TCA or it is fetched from another record. Example: TemplaVoilà fetches the data structure from the table tx_templavoila_datastructure. When trying to resolve the data structure from another table and the identifier is invalid (e.g. empty or does not point to a valid record), several exceptions are thrown that need to be caught at several points to keep the user interface accessible. Other than these mentioned exceptions there are ones that indicate that the TCA configuration is simply wrong. These ones are not caught and will still bubble up. Releases: master, 8.7 Fixes: #79101 Change-Id: I9be921e1425076897a86ebb0b997a998fda7f373 Reviewed-on: https://review.typo3.org/51061 Reviewed-by:
-
The last place in TYPO3 Core to use internal_type=file (backend_layout.icon) is now moved to FAL with sys_file_reference. An upgrade wizard is in place to migrate existing icons from uploads/media to sys_file. FormEngine is migrated to also allow to use sys_file_references for the TCA ctrl property "selicon_field". With this change, a followup could be integrated to deprecate "old-style" internal_type=file code, and also to not create the uploads/ folder at all anymore within TYPO3 installations. Additionally, the functionality of "selicon_field_path" should be deprecated in the future. Resolves: #83153 Releases: master Change-Id: I578fd68b7e1f7bc6a1991b90e7750b903d3ec28b Reviewed-on: https://review.typo3.org/54830 Tested-by:
Sebastian Hofer <sebastian.hofer@marit.ag> Tested-by:
Pawel Cieslik <p.cieslik@macopedia.pl> Tested-by:
-
This patch introduce a new key "time" to the TCA property "dbType" to allow using native SQL time column type. Resolves: #80557 Releases: master Change-Id: Id03045ccf219a9a7e9d851b2f4501bed60ab4ea0 Reviewed-on: https://review.typo3.org/52250 Tested-by:
-
- 28 Nov, 2017 5 commits
-
-
Due to the change of the pages_language_overlay migration, a lot of hard-coded "l10n_parent" and "sys_language_uid" fields for pages have been introduced. This should be changed into a common function in DataHandler and the TCA option should be used instead. Resolves: #83013 Releases: master Change-Id: I43a33aac1015436109d1ca7b3ea200c78d2a2fb9 Reviewed-on: https://review.typo3.org/54664 Reviewed-by:
-
Christian Kuhn authored
This reverts commit 5be3ec13. Further issues popped up in the master patch. Reverts: #75040 Releases: master Change-Id: I8ed284060b9b8ef018f4097c772032e81e3e885b Reviewed-on: https://review.typo3.org/54826 Tested-by:
-
We properly escape some characters of "dropzone-target" data attribute, since it is being used as a CSS selector to insert the dropzone in our DOM. The "dropzone-target" might contain characters that have a special meaning in CSS, like for example a dot. Especially the dot is typical for cases like flexforms fields. This allows drag and drop file uploads even on such cases (like for example working drag and drop file uploads in DCE content elements). Resolves: #81812 Releases: master, 8.7 Change-Id: Ib1f5b5063e390f08436fd3a51978842754b698ef Reviewed-on: https://review.typo3.org/53416 Tested-by:
-
This avoids an error in case file metadata is edited through a file reference and there is no file metadata translation for the current language. Resolves: #76262 Resolves: #82178 Releases: master, 8.7 Change-Id: Ifecf659637773c5f3773fc3439b09df9c030cb3f Reviewed-on: https://review.typo3.org/54778 Tested-by:
-
When a parent record (e.g. tt_content) has inline relations (e.g. sys_file_reference)and these relations show a placeholder for records related to them (e.g. sys_file and sys_file_metadata) then we need to pass the context of the language so that the placeholders are shown in the correct language. We now do so by putting the value of the language field of the parent record into the data set and update it in case child records are also translatable. This way when going down the list of children, we always know the language id of the last applicable parent element, even if one element in between was not translatable (e.g. sys_file) If we know the language, we can pick the correct record uid out of the list of possible related uids, instead of just picking the last one. Resolves: #75040 Releases: master, 8.7 Change-Id: Iff1b5350138d3043df470d2bdbdfebc83ec8cc5a Reviewed-on: https://review.typo3.org/54722 Tested-by:
-
- 27 Nov, 2017 5 commits
-
-
The position of the buttons aside the wizard are not correct. Releases: master, 8.7 Resolves: #83072 Change-Id: Ib60a4015b6a51997ee56381ec63fea79605b16c1 Reviewed-on: https://review.typo3.org/54730 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Several hundred function calls and vast numbers of indentations can be saved by using the null coalesce operator instead of checking empty/array. Change-Id: I38f2ce2de83a454aaa0d16c771014b6de84b3f7a Releases: master Resolves: #80812 Reviewed-on: https://review.typo3.org/52416 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
As the Exception says: It is not allowed to have a section without a type OR a type without a section. So it is not allowed to have one without the other, but it's allowed to have both or none of them. --> This is a EXCLUSIVE OR situation. Releases: master Resolves: #81985 Change-Id: I00594b75c99b02d1950be106dc4c3389709af231 Reviewed-on: https://review.typo3.org/53610 Tested-by:
Jonathan IROULIN <joniroutypo3@gmail.com> Reviewed-by:
-
This patch applies the phpdoc_types_order rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types_order Releases: master, 8.7 Resolves: #83109 Change-Id: I57291fb0b113ad01e2a171c1cfd6a9943d6302ad Reviewed-on: https://review.typo3.org/54779 Reviewed-by:
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- 22 Nov, 2017 1 commit
-
-
Add for/id so clicking the label toggles the checkbox. Resolves: #83040 Releases: master, 8.7, 7.6 Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326 Reviewed-on: https://review.typo3.org/54715 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 16 Nov, 2017 1 commit
-
-
TSConfig properties keepItems and removeItems are checked with a weak in_array() test (third argument not set to true), which leads to the situation, that arbitrary string values are treated equal to integer 0 This is now fixed by flipping the array and check for the array index. This works nicely because PHP silently converts strings which look like integer to integer for the keys. Tests are added which cover these cases and demonstrate the failure before the change. Resolves: #82980 Releases: 8.7, master Change-Id: I544a221674fa89d302cb6c1bcca506847c6f7f0f Reviewed-on: https://review.typo3.org/54623 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
-
- 15 Nov, 2017 1 commit
-
-
When doing translations with pages and inline elements (e.g. pages.media), there is an inconsistency when an additional inline element is added to the TRANSLATED page (e.g. language=1). Current (wrong) when adding a translation to a page - localized IRRE children get pid = default page ID (correct) - localized IRRE children only localization get parentid = default page ID (should be translated page ID) Current (wrong) behaviour when adding a IRRE child only available in a translation: - parentid gets localized page => correct - pid gets set to localized page => must be default language The patch corrects this behaviour by always set - the relation (parentid) to the localized page ID - the page ID (pid) to the default language page ID Additionally, when adding an Inline element (IRRE) via AJAX on page properties, the PID gets resolved correctly to be sent to DataHandler. Resolves: #82983 Releases: master Change-Id: Id8bf39524ee608acf452e2b7103087d4299c1e28 Reviewed-on: https://review.typo3.org/54632 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
- 08 Nov, 2017 1 commit
-
-
Benni Mack authored
The patch migrates all data from pages_language_overlay into pages, and moves all API calls to overlay pages. The following restrictions are set: * Backend is always showing pages only for "sys_language_uid=0" for the page tree, element browser (e.g. "linking to default language page"), except where explicitly requested like the Page Module => Languages view. * pid and sorting are always the same for all translations and their default language page * Elements on a page are always keeping the field "pid" to the default language page (no change) * Permission checks for Backend users are always made against the default language page (perms_* fields and webmounts) Resolves: #82445 Releases: master Change-Id: I62536e21d7110fa434c75fbd4470a3f53b79d260 Reviewed-on: https://review.typo3.org/51272 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- 06 Nov, 2017 1 commit
-
-
Fixes missing labels in the svg category tree toolbar. Releases: master Resolves: #82934 Change-Id: Iac29bc35b40894630599b3fbec48daf870a8777a Reviewed-on: https://review.typo3.org/54571 Reviewed-by:
-
- 03 Nov, 2017 1 commit
-
-
If an inline child, opened via ajax request, generates links leaving the current records and opening a different one, on closing that record the returnUrl is wrong and points to the url of the inline ajax request. The original return url of the main record is lost in the compile chain. The returnUrl data provider sets $data['returnUrl'] to current url if not otherwise given. The patch hands over the original return url to the inline ajax controller and lets it 'sink down' in the data compile chain to inline children so the original return url is available when container or elements generate urls. Additionally some broken 'returnURL' handling in InlineRecordContainer and jsfunc.inline.js is cleaned up and removed. Change-Id: Ia47dc8cee068fc9c4d1c5e16c1960b1a58fcb2f5 Resolves: #82525 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54543 Tested-by:
Kjeld Schumacher <k.schumacher@familie-redlich.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 02 Nov, 2017 1 commit
-
-
Some methods are called with default arguments, which can be omitted when calling the methods. Additionally, some PHPdoc comments was wrongly defined, which were modified. No change of behaviour. Resolves: #82897 Releases: master Change-Id: I1a22e7e3c4aff74f32c67bacb406a6a97d96b0d0 Reviewed-on: https://review.typo3.org/54524 Tested-by:
-
- 01 Nov, 2017 1 commit
-
-
In the modal view of "Add media by URL" the possible sources from where media can be embedded are now shown. Resolves: #82545 Releases: master, 8.7 Change-Id: I07ffedcf074b6af1e03113375f3d110916e3b034 Reviewed-on: https://review.typo3.org/54437 Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
-
- 30 Oct, 2017 3 commits
-
-
Catch another exception to avoid a breaking backend. Resolves: #82850 Releases: master, 8.7 Change-Id: I349aae21932beb5d45c1cec1b1211d3400d1d969 Reviewed-on: https://review.typo3.org/54469 Reviewed-by:
-
Unpack the array elements before passing them on Resolves: #82159 Releases: master, 8.7 Change-Id: I6a094927f595d42fc15bb96a9dbc1d313a7808b0 Reviewed-on: https://review.typo3.org/54473 Tested-by:
-
Using brackets in flexform elements caused the javascript to be disabled for the element. While using a custom form id that can be used as HTML id="" this is bypassed and fixes all javascript interaction. Releases: master, 8.7 Resolves: #80908 Change-Id: I91f39b2fed61076b7139603fedc7b268546d64cd Reviewed-on: https://review.typo3.org/52771 Reviewed-by:
-
- 26 Oct, 2017 1 commit
-
-
Add the ’s’ (PCRE_DOTALL) modifier to regular expressions. Resolves: #82854 Releases: master, 8.7 Change-Id: Ib5feaba0272e45dce1bc0b4cfedb11f5eb0b10c2 Reviewed-on: https://review.typo3.org/54474 Tested-by:
-
- 20 Oct, 2017 1 commit
-
-
Allow 'label' within the 'palettes' array in TCA next to 'showitem'. This defines a default label rendered as the palette label in FormEngine if not overridden in a 'types' definition like '--palette--;labelReference;thePalette'. The patch introduces this feature in PaletteAndSingleContainer of FormEngine code and adapts core TCA definitions to introduce the default labels for palettes. This makes the 'types' definitions shorter and much better readable and gives the core an opportunity to steer the labels for palettes which are often re-used by extension authors. Change-Id: I185340d4e037d713eebbb6cd676287e6fe85705b Resolves: #82826 Releases: master Reviewed-on: https://review.typo3.org/54449 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- 04 Oct, 2017 2 commits
-
-
The native PHP way of triggering deprecations by a framework or applications is done via `trigger_error($deprecationMessage, E_USER_DEPRECATED)`. Previously, TYPO3 used `GeneralUtility::deprecationLog()` and similar methods to generate a custom deprecation log, however it's more flexible to use native logging through TYPO3's ErrorHandler. This solution centralizes the way to configure the place if and how deprecation logs should be written to various log destinations. This also changes the way how deprecated methods, arguments and classes are handled. The new way to deprecate code in TYPO3 is done via `trigger_error()`, the @deprecated annotation within a method only exists now for IDE support, but is not reflected anymore for the logging message. That's why the @deprecated annotation does not contain a description anymore. The methods GeneralUtility::logDeprecatedFunction() GeneralUtility::deprecationLog() GeneralUtility::getDeprecationLogFileName() GeneralUtility::logDeprecatedViewHelperAttribute() are marked as deprecated from now on. The configuration option $TYPO3_CONF_VARS[SYS][enableDeprecationLog] is removed. Deprecation messages can now be activated by adding the E_USER_DEPRECATED constant to the respective values in $TYPO3_CONF_VARS[SYS][errorHandlerErrors] (so exceptions are handled by the TYPO3 error handler) $TYPO3_CONF_VARS[SYS][syslogErrorReporting] (so exceptions are put into GeneralUtility::sysLog) $TYPO3_CONF_VARS[SYS][belogErrorReporting] (so exceptions are put into sys_log DB table) $TYPO3_CONF_VARS[SYS][exceptionalErrors] (so exceptions are thrown on a deprecation) Deprecations will still go into GeneralUtility::devLog(), if deprecations are activated via the "errorHandlerErrors" option. Tests which test explicitly for deprecated code is moved into Tests/UnitDeprecated, to ensure that the deprecated code is not throwing an exception. Resolves: #82438 Releases: master Change-Id: I6ef9a642d179001f0484c4c7678e0bec12284faf Reviewed-on: https://review.typo3.org/54015 Reviewed-by:
-
Drop the TCA inline releated localizationMode settings. This one has been deprecated with v8 including an automatic TCA migration. Change-Id: Ibb73721b188368605dd3cd75a29d2b7a8986966e Releases: master Resolves: #82634 Related: #80700 Reviewed-on: https://review.typo3.org/52496 Tested-by:
-
- 29 Sep, 2017 1 commit
-
-
Resolves: #20705 Releases: master Change-Id: I3476f6945b645a3b906e49efbdeaa385411c50ea Reviewed-on: https://review.typo3.org/47491 Tested-by:
-
- 22 Sep, 2017 1 commit
-
-
Resolves: #82512 Releases: master, 8.7 Change-Id: Ibfbd1a8e347f5b25871f5d073994bdb2af264051 Reviewed-on: https://review.typo3.org/54174 Tested-by:
-
- 18 Sep, 2017 1 commit
-
-
The function GeneralUtility::sysLog() is deprecated and all calls are replaced with direct calls to according Logging API methods. The usual configuration options of the Logging API allows to define all sorts of destinations for log entries, including the syslog facility as well as file targets. Resolves: #82430 Releases: master Change-Id: Ief3f3f14fd10a3ae90b9df4a5e4e7456c2f7619c Reviewed-on: https://review.typo3.org/54090 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
- 11 Sep, 2017 1 commit
-
-
The `type` field is configured via TCA and that configuration must be used instead of hardcoding the fieldname. Also change arrangement of the DataProvider load order to load InitializeProcessedTca directly after ReturnUrl. This avoids the need of accessing $GLOBALS['TCA']. Resolves: #79954 Releases: master, 8.7 Change-Id: I67cbab00f6f0157c48c749cd8fbcd6cbc0ce1644 Reviewed-on: https://review.typo3.org/53749 Reviewed-by:
-
- 10 Sep, 2017 1 commit
-
-
There was one leftover place, where an attributes string was concatenated instead using the helper function. Resolves: #77824 Releases: master Change-Id: I0d01a5bde47b333dc11d25f6dd28bde9e7810696 Reviewed-on: https://review.typo3.org/49819 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
