This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 19 Dec, 2017 1 commit
-
-
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 09 Dec, 2017 1 commit
-
-
If the access to the element information is not allowed, show some information to the user instead of returning an empty string. Resolves: #83067 Releases: master, 8.7 Change-Id: Ie4ca3ba41556813a44802fc60befe164a17c4178 Reviewed-on: https://review.typo3.org/54811 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- 30 Nov, 2017 1 commit
-
-
The new PSR-7-based solution since TYPO3 v7 should be used everywhere instead of "BackendUtility::getModuleUrl()". This is possible because modules can be addressed via the "route" GET parameter instead of the "M" parameter since a few months. The patch changes all occurrences within TYPO3 Core to use the new API. Resolves: #83172 Releases: master Change-Id: Iec40e8ae00f1d900d7479b84a3a62827ddba653b Reviewed-on: https://review.typo3.org/54755 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- 29 Nov, 2017 1 commit
-
-
Releases: master Resolves: #83023 Change-Id: I9fe436f94a1223020b5fd0c308fa5bdb1b81ec39 Reviewed-on: https://review.typo3.org/54671 Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- 27 Nov, 2017 2 commits
-
-
Several hundred function calls and vast numbers of indentations can be saved by using the null coalesce operator instead of checking empty/array. Change-Id: I38f2ce2de83a454aaa0d16c771014b6de84b3f7a Releases: master Resolves: #80812 Reviewed-on: https://review.typo3.org/52416 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- 16 Nov, 2017 1 commit
-
-
TSConfig properties keepItems and removeItems are checked with a weak in_array() test (third argument not set to true), which leads to the situation, that arbitrary string values are treated equal to integer 0 This is now fixed by flipping the array and check for the array index. This works nicely because PHP silently converts strings which look like integer to integer for the keys. Tests are added which cover these cases and demonstrate the failure before the change. Resolves: #82980 Releases: 8.7, master Change-Id: I544a221674fa89d302cb6c1bcca506847c6f7f0f Reviewed-on: https://review.typo3.org/54623 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 09 Nov, 2017 1 commit
-
-
Because users have no access to deleted pages, the access check always fails, leading to delete page actions not being shown in the history despite being properly tracked. We now check this case and do a more lightweight check so that we still have the permissions checked, but can show deleted pages without disclosing unwanted information. Resolves: #45056 Releases: 7.6, 8.7, master Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c Reviewed-on: https://review.typo3.org/54580 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- 06 Oct, 2017 1 commit
-
-
The internal / experimental class ext:backend/Module/AbstractModule doesn't do much useful stuff: It only instantiates ModuleTemplate in it's constructor which forces all inheriting classes to call parent::__construct(). The processRequest() method with its dispatcher code is never used in core, but superseeded by routing configuration via Configuration/Backend/Routes.php. The patch removes given AbstractModule usages and markes the class as deprecated. The patch is slightly breaking in cases an extension extends AbstractWizardController and additionally uses the initialized moduleTemplate property. Change-Id: Iee36e1787a6dc2a1affb3625983ccb6450589481 Resolves: #82689 Releases: master Reviewed-on: https://review.typo3.org/54312 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- 26 Sep, 2017 1 commit
-
-
The uid of a record is an important information and should be provided as well. Resolves: #82526 Releases: master, 8.7 Change-Id: Ic44ca6a24e21c09ced78203ed4a73907906bf568 Reviewed-on: https://review.typo3.org/54187 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Reviewed-by:
Sascha Rademacher <s.rademacher@neusta.de> Reviewed-by:
-
- 08 Sep, 2017 1 commit
-
-
Benni Mack authored
Before, the history module fetched info about "modified records" from sys_history+the authoritive user from a coupled sys_log entry. Info about "insert" and "delete" was fetched from sys_log solely. However, when using a scheduled cleanup task to truncate sys_log then all history information is useless (see bug report). The patch introduces a new RecordHistoryStore as an abstraction for adding history entries (currently done solely within DataHandler). It adds some additional, necessary SQL fields to sys_history to store all information in there and creates an update wizard to migrate all coupled sys_history/sys_log entries to a new sys_history entry itself. Additionally, the whole existing "RecordHistory" class is now only necessary for fetching the so-called ChangeLog, for a page or a specific record, and to do rollbacks, preparing the history records so they can be worked on. The whole logic for fetching the GET/POST parameters is moved into the "ElementHistoryController", everything that is only possible via Fluid is moved from the RecordHistory object and the ElementHistoryController into the view. Referencing from sys_log (Log module) into sys_history is now done the other way around, storing information about the corresponding history entry inside sys_log. As a side-effect, sys_log should load faster. Abstraction basis: - sys_history is the only source of truth about the history of a record - sys_log contains a reference to an history entry now (inside sys_log.log_data) to link from the backend log module - RecordHistoryStore exists for tracking changes to records - RecordHistory is for retrieving, compiling the history/changelog and rollbacks - ElementHistoryController is doing PSR-7 style request/response handling and preparing data for the view - Fluid is handling more view functionality now, removing the need for doing <f:format.raw> everywhere in the templates. Sidenotes: * Data within sys_history is now stored as JSON, not serialized anymore * Adding/deleting was previously stored in sys_log only, is now within sys_history * Moving records is now tracked (but not evaluated yet) * Highlight/Snapshot functionality within the Backend Module was removed This functionality is built so it can also be used within Extbase persistence and in FE in general in a future iteration. Resolves: #55298 Resolves: #71950 Releases: master Change-Id: I354317609099bac10c264b9932e331fa908c98be Reviewed-on: https://review.typo3.org/53195 Reviewed-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
- 23 Aug, 2017 2 commits
-
-
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Change a series of cgl details after update of php-cs-fixer from 1.0 to 1.4. Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f Resolves: #82171 Related: #82164 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53776 Tested-by:
-
- 19 Jul, 2017 1 commit
-
-
Move language files to the proper extensions instead of misusing EXT:lang. Resolves: #81888 Releases: master Change-Id: I0ea028bc93843acf9a0381aad742377445efd95a Reviewed-on: https://review.typo3.org/53528 Tested-by:
-
- 12 May, 2017 2 commits
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
If the title is too long, it gets cropped. Then, the link title must contain the whole string in order to provide a proper tooltip. Resolves: #81124 Releases: master, 8.7 Change-Id: I55b4784c431b4a495dc4089ab954eb3c7e1ca435 Reviewed-on: https://review.typo3.org/52692 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Elmar Hinz <t3elmar@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 27 Apr, 2017 1 commit
-
-
This function now does the same as makeInstance() except for an if() clause, since the API should be unified this method should be considered as dropped, allowing to use callUserFunction() and makeInstance() as the only two proper ways to call custom classes / methods. Resolves: #80993 Releases: master Change-Id: I0c2042dbe6c83a86f211bab4eaf64d75e6424232 Reviewed-on: https://review.typo3.org/52518 Reviewed-by:
-
- 28 Mar, 2017 2 commits
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
-
There are some places where PHP comments have been done wrong (using doccomments) or where there is no comment at all. Resolves: #80503 Releases: master Change-Id: Ib12d3b82755d801abcbefe7127f1189239f766af Reviewed-on: https://review.typo3.org/52200 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 25 Mar, 2017 1 commit
-
-
Fluid escapes the header already, therfore there is no need to do it before in the controller. Resolves: #80288 Releases: master Change-Id: I7f16fb2aa1319cdfbc3a8c9226a86e98a8e8457a Reviewed-on: https://review.typo3.org/52147 Tested-by:
-
- 15 Mar, 2017 1 commit
-
-
Resolves: #79551 Releases: master, 7.6 Change-Id: I76bf3996b3f76b18f9ff9cc95b70b2e41bbc4143 Reviewed-on: https://review.typo3.org/51469 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- 07 Feb, 2017 1 commit
-
-
This change unifies the ClickMenu functionality of the pagetree (ExtJS) with the ClickMenu code given in other areas of the TYPO3 Backend. The following changes are made: * Unify the naming, it's "ContextMenu" not "ClickMenu" anymore * Configuration for record types are unified, the clickmenu shows the same entries in the same order in any place. * ExtJS-based ContextMenu is removed, all based on the new ContextMenu functionality. * A new way for extending the items inside the ContextMenu is handled via ItemProviders, which can easily be extended. * Configuring clickmenu items is not done based on PageTS (as it was handled with the ExtJS pagetree), however certain items can be disabled via PageTS. Resolves: #78192 Releases: master Change-Id: I380ac73ced10fdc7b1fdec7261e2d56da3d7d938 Reviewed-on: https://review.typo3.org/50124 Reviewed-by:
-
- 01 Feb, 2017 1 commit
-
-
Change string comparison for string checks. Checks which could lead to false positives like comparing with '0' or '' are excluded. RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+') Resolves: #79540 Resolves: master Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9 Reviewed-on: https://review.typo3.org/51462 Reviewed-by:
-
- 11 Jan, 2017 1 commit
-
-
The file info modal now contains the width and height of images Resolves: #65822 Releases: master, 7.6 Change-Id: Iadb64ae3db4558bf74f15aaeac1fe29848120563 Reviewed-on: https://review.typo3.org/51052 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
- 02 Dec, 2016 1 commit
-
-
Moved all HTML from PHP code to an own Fluid template. Resolves: #78644 Releases: master Change-Id: I5351ce114618c4f9a56070e51df7ebe9de983a21 Reviewed-on: https://review.typo3.org/50642 Reviewed-by:
Daniel Windloff <daniel.jc.windloff@googlemail.com> Tested-by:
Valentin Funk <valentin.funk@computerfabrik.de> Reviewed-by:
-
- 01 Dec, 2016 2 commits
-
-
Moved all HTML from PHP code to an own Fluid template. Resolves: #78688 Releases: master Change-Id: If91b2e76d13679c852fdb397848bb1108e37ba48 Reviewed-on: https://review.typo3.org/50655 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Gleb Levitin <gleb.levitin@dkd.de> Tested-by:
-
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
-
- 26 Oct, 2016 1 commit
-
-
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- 17 Oct, 2016 1 commit
-
-
This patch fixes the icon color on the "info" popup (Filelist > Info). The icon in the "show" button now has the correct color. Resolves: #78271 Releases: master Change-Id: Ia0be9433b760c54904589efcf24f2bfe10bad593 Reviewed-on: https://review.typo3.org/50242 Reviewed-by:
-
- 08 Oct, 2016 1 commit
-
-
Use the following icons to indicate different kinds of "edit actions": * actions-open: single edit action * actions-document-open: multi edit action * actions-page-open: edit page properties Resolves: #77963 Releases: master Change-Id: I2d3198b56755eef5eb715058caf5d8574124c9ca Reviewed-on: https://review.typo3.org/49946 Tested-by:
Tomasz Stępniak <stempl88@gmail.com> Reviewed-by:
-
- 07 Oct, 2016 1 commit
-
-
Additionally an unused variable was removed and some variables have been renamed to a more speaking name. Resolves: #77801 Releases: master Change-Id: I242a9f32c80c8702097a2b20ed577db44766902b Reviewed-on: https://review.typo3.org/49808 Reviewed-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Reviewed-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
- 08 Sep, 2016 1 commit
-
-
All elements should be shown if the asterisk is part of the show configuration. Due to different configuration possibilities it can happen that the asterisk is not the only value of this configuration. Resolves: #77877 Releases: master, 7.6, 6.2 Change-Id: I5439f76ec40788cdaed14012e7b83b18e2b56d18 Reviewed-on: https://review.typo3.org/49875 Tested-by:
Peter Linzenkirchner <info@lisardo.de> Tested-by:
-
- 30 Aug, 2016 2 commits
-
-
Resolves: #77701 Releases: master Change-Id: Id5f32eb76ac3adddd834160bc79828fefd0ce63c Reviewed-on: https://review.typo3.org/49665 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 11 Jul, 2016 1 commit
-
-
Migrate the first part of DB calls of EXT:backend Resolves: #76624 Releases: master Change-Id: Iac323bed36af22e5c38eb4fb8a0e0f72bbee6d93 Reviewed-on: https://review.typo3.org/48574 Tested-by:
-
- 08 Jun, 2016 1 commit
-
-
Fix the behavior of keepItems in the NewContentElementWizard to only remove invalid items based on the CType key. Without this patch any invalid value in tt_content_defValues would result in the content element being invisible in the wizard. Resolves: #76242 Related: #61114 Releases: master, 7.6 Change-Id: I31af8e8e7f095d3af01740165900474d7e05a9a5 Reviewed-on: https://review.typo3.org/48226 Reviewed-by:
-
- 06 Jun, 2016 1 commit
-
-
The ElementInformationController must show the creator user and not the current one. Resolves: #76461 Releases: master, 7.6 Change-Id: Ibeae9970783aa6d0fc3b0e190956140c872a9ac9 Reviewed-on: https://review.typo3.org/48456 Reviewed-by:
-
- 28 May, 2016 1 commit
-
-
Remove the second parameter of getLL and replace it with htmlspecialchars directly in the code. Resolves: #76321 Related: #71917 Releases: master Change-Id: I71ed4d93c48731cad8cf88cc1de002190f38ba9a Reviewed-on: https://review.typo3.org/48350 Reviewed-by:
Valentin Despa <info@vdespa.de> Tested-by:
-
- 27 May, 2016 2 commits
-
-
Valentin Despa authored
Remove the second parameter of sL and replace it with htmlspecialchars directly in the code. Resolves: #76325 Related: #71917 Releases: master Change-Id: I6267c45daeddf9a652ad63acb014c824721df25f Reviewed-on: https://review.typo3.org/48338 Reviewed-by:
-
Remove the second parameter of getLL and replace it with htmlspecialchars directly in the code. Resolves: #76321 Related: #71917 Releases: master Change-Id: Ieabcf550883ebcf85fe13232caab249b0f37e4b1 Reviewed-on: https://review.typo3.org/48330 Reviewed-by:
-
