A link is not a directory.

This reverts commit d28bb427.

Change-Id: I0d8d33bae922a94dbb525e1fd575defcfb95074f
Resolves: #57706
Releases: master
Reviewed-on: http://review.typo3.org/41404


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Georg Ringer authored Jul 16, 2015 and Andreas Fernandez committed Jul 16, 2015

If a directory is expected but it is actual a link,
check the linked resource. If this is a directory, allow that
as well.

Change-Id: I85b98a683c987d36a67536050ee595848c7a3b8e
Resolves: #57706
Releases: master
Reviewed-on: http://review.typo3.org/41383


Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>

Stephan Großberndt authored Dec 29, 2014 and Anja Leichsenring committed Jan 19, 2015

Create TYPO3\CMS\Core\Tests\BaseTestCase->getUniqueId() as a wrapper to
all uniqid()-calls from tests. This fixes fatal errors on tests in
Windows because multiple calls to uniqid() without parameters within
one second will return the same value.

TYPO3\CMS\Core\Tests\Functional\DataHandling\Framework\ActionService
does not inherit from BaseTestCase and thus gets its own implementation
for now.

Resolves: #64055
Releases: master, 6.2
Change-Id: I15536c0f1766ad89a3d8daf7260b0dbe81ef82f8
Reviewed-on: http://review.typo3.org/35665


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>

Roland Waldner authored Dec 16, 2014 and Christian Kuhn committed Dec 17, 2014

Most of TYPO3's PHP files have an empty line before a class' closing curly
brace. This commit adds this empty line (if it is missing) before a class'
closing curly brace.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
(}\n)(})

Replace:
$1\n$2

Resolves: #63942
Release: master
Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7
Reviewed-on: http://review.typo3.org/35527


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Roland Waldner authored Dec 06, 2014 and Christian Kuhn committed Dec 13, 2014

This regular expression was used to replace PHPDoc style comments
with ordinary comments:

Search:
/\*\*(\n \* This file is part of the TYPO3 CMS project.)

Replace with:
/*$1

Resolves: #63328
Releases: master
Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8
Reviewed-on: http://review.typo3.org/35103


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>

Markus Klein authored Dec 06, 2014 and Alexander Opitz committed Dec 08, 2014

(miscellaneous)

Use name-resolution with ...::class instead of strings where possible.
(needs PHP 5.5, which is meanwhile required for master)

Change-set Iedbb896607adddce2b23ab67f990fa2296c0d1bb first introduced
usage of ::class in master. We now add it in various more places.

Resolves: #63477
Releases: master
Change-Id: Ifa4022cefef28dcfc4fae18e8aa003f6ade21cb3
Reviewed-on: http://review.typo3.org/35091


Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>

(part for EXT:install)

Use name-resolution with ...::class instead of strings where
possible.
(needs PHP 5.5, which is meanwhile required for master)

Change-set Iedbb896607adddce2b23ab67f990fa2296c0d1bb
first introduced usage of ::class in master. We now add it
in various more places.

Change-Id: I929357c1d64de02eddb17a579ab5f48dac91d491
Resolves: #63477
Releases: master
Reviewed-on: http://review.typo3.org/34863


Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>

Anja Leichsenring authored Jul 05, 2014 and Christian Kuhn committed Sep 14, 2014

In order to unify removal of files and directories created by unit
tests, the basic UnitTestCase class get a property to register
created files and directories. Removing those files is
implemented in tearDown().

Tests now just need to add created files to $this->testFilesToDelete
to get the automatically cleaned up after test run. The method is
constructed to only remove stuff within typo3conf/ext and typo3temp
to reduce the risk of removing too, it throws an exception if this
rule is not followed.

Change-Id: Ibca2b3a006432f2335fff8f0b0c05c62e363878c
Resolves: #60123
Releases: 6.3
Reviewed-on: http://review.typo3.org/31359


Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59778 for further details.

Resolves: #59778
Releases: 6.3, 6.2
Change-Id: I155df27e66ec103a4f83356adef7dc441585b54a
Reviewed-on: https://review.typo3.org/31023
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Christian Kuhn authored Mar 21, 2014 and Philipp Gampe committed Mar 21, 2014

Fix a failing unit test after change c23414d5

Change-Id: I427663a1a528b24a0e63d2fc9ed2a6371902a4f4
Resolves: #57159
Related: #57152
Releases: 6.2
Reviewed-on: https://review.typo3.org/28611
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe

Markus Klein authored Mar 18, 2014 and Christian Kuhn committed Mar 20, 2014

The tests have not been adjusted when
http://forge.typo3.org/issues/52668
was merged.

Resolves: #57055
Releases: 6.2
Change-Id: I259c7b5462d372f3244ee4c2e89a96cef0780478
Reviewed-on: https://review.typo3.org/28513
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

* Adjust default permissions back to "world readable" (775/664)
* Do not attempt to fix permissions on an existing folder structure
* Streamline the separation of Notices, Warnings and Errors
* Cosmetical optimizations in the "Folder Structure" item
* Also report if the default permissions are too insecure (i.e.
  world writeable / readable).

Note that the new defaults (775/664) are set to make the system work
by default on almost most scenarios, but the recommended secure setup
is still 770/660. This is on purpose to make the administrator aware
of it but will require manual intervention (i.e. "thinking") if this
setup will work or not (we cannot detect that automatically).

Resolves: #52668
Releases: 6.2
Change-Id: I77c72617fa58fd808ebc5fd818e94b48c2644102
Reviewed-on: https://review.typo3.org/25416
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Running the whole unit test suite on cli can eat up a significant
amount of memory. Most of that can not be mitigated due to phpunit
itself, but we can at least hint the PHP garbage collection by
unsetting test class properties in tearDown().

The patch introduces a generic tearDown() method that reflects the
test class and unsets all temporary properties of the class. In
effect, tests do not need to take care of unsetting properties.

The patch removes all tearDown() methods that only unset() stuff
and keeps others that do additional things but adds a call to
parent::tearDown(). Private properties are changed to protected,
so parent::tearDown can reach them. The additional computing
effort of the reflection is insignificant, the suite is nearly as
fast as before.

Results:
php 5.3: 1056MB -> 851MB
php 5.4: 870MB -> 670MB
php 5.5.: 876MB -> 674MB

Resolves: #55850
Related: #51436
Releases: 6.2
Change-Id: Ie665c53a3ab35e4808677e483d2099e0511c393f
Reviewed-on: https://review.typo3.org/27528
Reviewed-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Christian Kuhn authored Oct 01, 2013 and Anja Leichsenring committed Oct 01, 2013

Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Ernesto Baschny authored Sep 30, 2013 and Wouter Wolters committed Sep 30, 2013

The Install Tool checks for permissions in it's folder structure.  A
folder (typo3temp, uploads, fileadmin) not being writeable now is an
Error and not only a Warning thus displaying a red badge in the Install
Tool main menu.

Resolves: #52407
Releases: 6.2
Change-Id: I6de5f2eace4ecdf089848efbf063a82302aea093
Reviewed-on: https://review.typo3.org/24180
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The document root folder may not have correct permissions and
they can not be fixed if the owner is not the executing webserver
user.

This is a common issue during installation, currently the first
step breaks if permission on document root are not 2770 and the
folder is not owned by the executing webserver user.

The patch adds a new option "targetPermissionRelaxed" to
DirectoryNodes and uses it on the RootNode to lower the severity
if permissions are not correct. The installation will proceed
then as long as sub folders can be created.

Change-Id: Ibde9f7ff0dde14502ac24fdb73c0a2ed384119a6
Resolves: #52356
Releases: 6.2
Reviewed-on: https://review.typo3.org/24130
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Some methods within FolderStructure class hierachy are public
but should be used internally only. The patch protects them.

Change-Id: I273f829f29ca4f5a6da1d03f028be7a8500e222b
Resolves: #52354
Releases: 6.2
Reviewed-on: https://review.typo3.org/24123
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Main features:
* The god class "Installer" is gone and split into two major parts.
A step controller handling major upgrade and install tasks, and a
tool controller handling the known install tool actions.

* The step controller is designed to be always called prior to the
tool controller, if a step needs execution, it comes up, otherwise
the tool controller will be executed.

* The entry point typo3/install/index.php is gone and substituted
by typo3/sysext/install/Start/Install.php. The file contains a
lengthy comment to document the main request flow and used GET/POST
parameters.

* Most parts of the install tool do not bootstrap the whole system
anymore, in general only the base bootstrap, dbal (if loaded),
extbase and fluid ext_localconf.php are loaded. This makes sure
the install tool can not fatal if some extensions ext_localconf
is broken. The whole install tool runs without any caching, so a fatal
in some cache file can not kill the install tool execution.

* Installing TYPO3 CMS on a dbal enabled system is now handled in
the step installer directly to make the according code easier to
understand.

* Rendering is done with a simplified fluid standalone view.

* All install tool forms are CSRF protected.

* A new and fully unit tested class structure is introduced, designed
to take care of the basic file and folder structure of the instance.
It is used during installation to create the needed structure and
can be called in the install tool to compare and fix the current
instance structure with the expected structure. In effect, the
"dummy" package is obsolete. An instance can be created by just
linking index.php, typo3_src/ and typo3/ within the document root,
the installer takes care of creating everything else.

* The installation procedure is released from the package handling.
Packages will be handled by the extension manager after initial
installation with another patch.

Loose ends:
* The whole package handling needs to be implemented in the
extension manager.

* Not all upgrade wizards work, this code area needs some love.

* A 'core' auto updater could be implemented now. A GSoC project
is currently running to realize this.

* The SQL schema migration API is a mess and should be refactored.
For now, another helper class is introduced to encapsulate some
of the nasty details.

* An auto configuration and configuration suggestion system is
planned and needs to be done. It should suggest best configuration
options in the install tool, and should auto configure the system
during installation in the last install step.

* If the backend or frontend fatals due to some extension that
triggers a fatal in ext_localconf or ext_tables (for example
due to a require() of a no longer existing file), a small helper
action in the install tool could find those extensions and suggest
to unload them.

Change-Id: Ice3248caa903449ad6a83ea4f234c7bd125bdb66
Resolves: #49162
Releases: 6.2
Reviewed-on: https://review.typo3.org/21468
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Alexander Opitz
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn