This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 23 Jul, 2021 1 commit
-
-
Christian Kuhn authored
With all non-legacy usages of ObjectManager being gone, this final patch adds a series of @deprecation annotations throughout the core, adapts some comments, and finally adds a trigger_error() to ObjectManager->get(). Resolves: #94619 Related: #90803 Releases: master Change-Id: Iaa65f7dee4e5aa9eb4e2c217e76105b0263dc6dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70054 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 12 Jul, 2021 1 commit
-
-
Added fallback value for array undefined keys for filelist as well as for impexp because it is part of the current clipboard fuctionality. Introduced new tests for clipboard and file upload. Resolves: #94509 Releases: master Change-Id: Ibed7c53f49665c4502aaa05dbe78f468d354f3a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69771 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 16 Jun, 2021 1 commit
-
-
PSR-3 has specific rules around interpolation: Messages may provide placeholders like {foo} and writers should substitute these in the messages if a context array with such a key is provided. Let's use placeholders correctly. Resolves: #94315 Related: #94356 Releases: master Change-Id: I2c285e84f1832c80828861369e99af9aff6cd267 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69425 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 14 Jun, 2021 1 commit
-
-
This fixes a bunch of PHP 8.0 warnings found by acceptance testing. image processing and ext:scheduler are affected for the main part. This makes the ac test suite green with PHP 8.0. The gitlab activation and another testing-framework raise will follow with dedicated patches. The patch brings an additional acceptance test for install tool 'Environment->Image Processing' since this worked well to nail lots of issues with GifBuilder and friends. Change-Id: Id22c7636da76778b75f087d20d7b7260cd2637ee Resolves: #94333 Related: #94057 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69476 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 11 Jun, 2021 2 commits
-
-
GeneralUtility::rmFromList is unused since v10. If at all, this method would better belong to StringUtility. Therefore, it's now deprecated in GeneralUtility, but could be reimplemented in a more performant way in StringUtility, when needed again. Resolves: #94311 Releases: master Change-Id: I2ea5ec57143d70fa2a0de2d2c34230764d3ce204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69459 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
GeneralUtility::stdAuthCode is unused since at least v9. As more appropriate methods for generating hashes, e.g. GeneralUtility::hmac() exists nowadays, the method is deprecated. Resolves: #94309 Releases: master Change-Id: I3d3678cd8c8c76462cc74b28f629b6679a4aea93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69458 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 10 Jun, 2021 1 commit
-
-
Manual testing found a bunch more cases of undefined variables that need to be addressed. Resolves: #94057 Releases: master Change-Id: I0f602d2de5fcfdc8b41545eafacc5ff79bbfdf86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69393 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 03 Jun, 2021 1 commit
-
-
To reduce usages of GeneralUtility::_GP(), GeneralUtility::compileSelectedGetVarsFromArray() is deprecated. Its only usage in the core is adjusted by accessing the PSR-7 Request instead. Side note: Actually also the method name is misleading. Since _GP() is used internally, also POST data are checked. Resolves: #94252 Releases: master Change-Id: Ia3d569dbc9bdb21770e6d5981752f40b2fe59d0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69362 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 20 May, 2021 2 commits
-
-
Oliver Bartsch authored
The mentioned variable $onlyNonEmptyValues does not exist. It has to be $removeEmptyValues. Resolves: #94175 Releases: master, 10.4 Change-Id: I18983ef7c62e0f3c7e8d98710d5445b7376bc02d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69217 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Make the code a bit more declarative and compact. This also improves the documentation to make clear the actual behavior, which was previously not self-evident. Resolves: #94074 Releases: master, 10.4 Change-Id: I062d75c174ddea8fe1a3010f12831520ada8dafe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69185 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 19 May, 2021 1 commit
-
-
Benjamin Franzke authored
The HTTP_HOST verification failed if the proxy server port was different to the local webserver port, due to an assumption in hostHeaderValueMatchesTrustedHostsPattern() that concluded that the local webserver port needs to match the default port of the proxy server. In case a HTTPS termination proxy is used, that assumption can not be made, as it is common practice to use HTTP backends behind a HTTPS proxy in private networks. Therefore the port is now verified against the default port of the current webserver, not a possible proxy server. Scenario: * Proxy Server HTTPS (SSL termination) => Port 443 * Application Server HTTP => Port 80 * Default trustedHostsPattern setting It was previously required to configure a (slow) trustedHostsPattern to circumvent this issue. Releases: master, 10.4 Resolves: #94113 Change-Id: I294b87164aee834d8c0b5e0a75da3e19051fe592 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66613 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 14 May, 2021 1 commit
-
-
PHP 8 promotes a lot of notices (previously ignored) to warnings. That means they can no longer be ignored. Resolves: #94057 Releases: master Change-Id: I37de1b7e8e31eb2be78b8e90af015bc88e121791 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 May, 2021 1 commit
-
-
Releases: master Resolves: #94073 Change-Id: I2a17bfd5d9cf4fce0915e466dd48e266dc6485b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69035 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 07 May, 2021 1 commit
-
-
Using direct calls and variadics is slightly faster, and usually cleaner to read. I left in the instant-call call_user_func() instances in the entry point files, as that's only a single call and is arguably at least no worse than (function() {})(). Resolves: #94060 Releases: master Change-Id: I95988feadf8522d8d936a273608e0ef2d5ce75b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69017 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 29 Apr, 2021 2 commits
-
-
Resolves: #93996 Releases: master Change-Id: I1071d8aa69e92beb4ff8ee12e4c75535a11bb8af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68886 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Riny van Tiggelen authored
When TYPO3 is in composer mode (var is outside public path), GeneralUtility::writeFileToTypo3tempDir now returns NULL for successful operation as stated in the docblock. Resolves: #90063 Releases: master, 10.4 Change-Id: I670503e68275047f511f3821f97b1b56d62bb7f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68721 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl>
-
- 27 Apr, 2021 2 commits
-
-
Since PHP 7.4 the core can use the Intl function directly. Resolves: #93900 Releases: master Change-Id: I2428fc9765bec2cd39f458febfe5d59231925d53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68759 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
With multiple registered email validators, stop as soon as the first one fails. Resolves: #93890 Releases: master Change-Id: I1e9e20a57ddb5538595aa0a9dea2888d547bc78e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68879 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 20 Apr, 2021 1 commit
-
-
Resolves: #93704 Releases: master Change-Id: I24067c4b705c671b87a9bbdfed30535a39528879 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68359 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 16 Mar, 2021 1 commit
-
-
A missing check in GeneralUtility::sanitizeLocalUrl() resulted in an url starting with `//` to be considered as a local url. This change ensures, that urls starting with `//` are not considered local. Corresponding unit tests are fixed and extended, since they need a full environment to process correctly. Resolves: #92891 Releases: master, 11.1, 10.4, 9.5 Change-Id: I41eb16776742b3e0d2cffd064dd0408e4faa7c78 Security-Bulletin: TYPO3-CORE-SA-2021-001 Security-References: CVE-2021-21338 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68434 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 02 Mar, 2021 1 commit
-
-
Change-Id: Ib1e08417a716882e8c354da92d090efdb6924dc7 Resolves: #93632 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68160 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 04 Jan, 2021 1 commit
-
-
Because the method (finally) is deprecated in PHP 8, all calls in TYPO3 Core are wrapped in if statements to avoid deprecation warnings. PHP 8 effectively is more secure by default, which is a good thing, but we need to consider this in our code base, which still supports PHP 7 as well. Resolves: #93204 Releases: master, 10.4 Change-Id: I18d7e76e3de5cf48cd4c3cab0d68dea4e518f674 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67329 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 30 Nov, 2020 1 commit
-
-
Drop all usages of TYPO3_MODE and TYPO3_REQUESTTYPE by using the ApplicationType helper class when frontend or backend is detected, and by directly using the applicationType attribute of the request object in a couple of special cases that check for backend ajax or install tool. Resolves: #92953 Related: #92951 Related: #92947 Releases: master Change-Id: I98c9d5ef0e7a6409b01188ddd0bbcf94f159cbcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66895 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Oct, 2020 2 commits
-
-
Since over a decade (according to the timestamp), GeneralUtility::uniqueList() does not allow an array as first argument and furthermore doesn't use the second parameter anymore. Since then, both have thrown an `InvalidArgumentException`. Furthermore, this method does not belong to GeneralUtility at all. Therefore this method is now deprecated and a new one, using proper type hints, a return type, no second argument and a correct PHPDoc is added to StringUtility. All usages in the core are replaced with the new method, ensuring proper types. Resolves: #92607 Releases: master Change-Id: Ibca5c2c312258dfc63c74f0ff11408d11226f7b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66190 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
The method :php`\TYPO3\CMS\Core\Utility\GeneralUtility::validEmail` is used to validate a given email address through the core and TYPO3 extensions. The validation can now be configured by providing the used validators to be used in the LocalConfiguration.php or AdditionalConfiguration.php. Example: $GLOBALS['TYPO3_CONF_VARS']['MAIL']['validators'] = [ \Egulias\EmailValidator\Validation\RFCValidation::class, \Egulias\EmailValidator\Validation\DNSCheckValidation::class' ]; The RFCValidation validator is still be used as default. Furthermore, following validators are available: - Egulias\EmailValidator\Validation\DNSCheckValidation - Egulias\EmailValidator\Validation\SpoofCheckValidation - Egulias\EmailValidator\Validation\NoRFCWarningsValidation It is also possible to provide own validators which must implement the Egulias\EmailValidator\Validation\EmailValidation interface. If multiple validators are provided, each validator must return TRUE. Resolves: #92531 Releases: master Change-Id: I9c5a0573c2f9bff56bf869dc221a2c0ffd75417b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66179 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 15 Oct, 2020 1 commit
-
-
This also deprecates two GeneralUtility methods which do not belong in this class, and makes the API more understandable and better documented. Resolves: #92551 Releases: master Change-Id: Ibb8b02ae11c76f3f7f65bf0a3eb22c82e94127e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65749 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 06 Oct, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92279 Change-Id: I469892a56334a13ab19df17aeaa39a68226b7510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65679 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 09 Jul, 2020 1 commit
-
-
This change removes deprecated functionality: - ReferenceIndex->updateIndex() is now either ProgressListenerInterface or null - ExtensionManagementUtility->findService() expects an array as third argument - BasicFileUtility->setFileExtensionPermissions() removed - GeneralUtility->callUserFunction now expects object or null as third argument - DataMapper->__construct does not expect $query to be set anymore - ObjectAccess->setProperty - fourth argument removed Resolves: #91613 Related: #91473 Releases: master Change-Id: I39fa30f84201b0ed837f6ac0e6d27e1ddb15376d
-
- 04 Jun, 2020 1 commit
-
-
Benni Mack authored
Common URLs like typo3.org, tools.ietf.org or php.net are nowadays available as HTTPS, however some places in TYPO3 still use http:// as reference. This should be streamlined to resemble https:// everywhere. Resolves: #91581 Releases: master, 10.4 Change-Id: I76b5211f7e14cab0c6d190059d2be761bc664b53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64733 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 29 May, 2020 1 commit
-
-
The following deprecated methods are now removed: - \TYPO3\CMS\Core\Utility\GeneralUtility::compressIPv6 - \TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory - \TYPO3\CMS\Core\Utility\GeneralUtility::getApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::idnaEncode - \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Hex2Bin - \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Bin2Hex - \TYPO3\CMS\Core\Utility\GeneralUtility::isRunningOnCgiServerApi - \TYPO3\CMS\Core\Utility\GeneralUtility::linkThisUrl - \TYPO3\CMS\Core\Utility\GeneralUtility::milliseconds - \TYPO3\CMS\Core\Utility\GeneralUtility::presetApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::resetApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::verifyFilenameAgainstDenyPattern In addition, makeInstanceService requires the third parameter to be array instead of string or array. The method "getUrl()" now only accepts one argument. In addition, the testing framework is raised to 6.3.1 to not use the unneeded methods anymore. Resolves: #91513 Releases: master Change-Id: I124b6f531fed61a93f5ed03391e1d4b6cf7a08ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64593 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 12 May, 2020 1 commit
-
-
HTML entities being used in link tags created with `typolink` have to be encoded correctly again after entities have been decoded for internal processing. Resolves: #91161 Releases: master, 9.5 Change-Id: Ifc4d2da669aab01f2b3041bb32c0a24a727634b4 Security-Bulletin: TYPO3-CORE-SA-2020-003 Security-References: CVE-2020-11065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64467 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 06 May, 2020 1 commit
-
-
The third argument of `GeneralUtility::callUserFunction` must be either an object or null. Ensure the argument is always null instead of false to avoid triggering a deprecation log entry. Resolves: #91184 Releases: master Change-Id: I5ee0a58d812de737bd631e5c1986895e69c158af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64415 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 28 Apr, 2020 1 commit
-
-
The check for the constant TYPO3_PATH_WEB was an experiment, to allow a document root with public assets only, but this never worked out and was never really used. The check can safely be removed, as it won't do anything useful anyway. Also adapt a comment in SystemEnvironmentBuilder which still refers to this variable/constant and its usage in the helhum/typo3-secure-web package. This statement can be removed as helhum/typo3-secure-web is not actually using that constant/envvar. Resolves: #91215 Related: #63025 Releases: master Change-Id: I1b44ba97f4654d1e4e200d7ad1a7c228dba48c25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64330 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Josef Glatz <josefglatz@gmail.com>
-
- 22 Apr, 2020 1 commit
-
-
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. * adjusts invocations of top.TYPO3.InfoWindow.showItem * adjusts low-level inline `onchange` and `onclick` events Both JavaScript modules `TYPO3/CMS/Backend/GlobalEventHandler` and `TYPO3/CMS/Backend/ActionDispatcher` are required to actually handle these new triggers and correpsonding events - that's why they are loaded in `ModuleTemplate` and deprecated `DocumentTemplate`. Resolves: #91117 Releases: master Change-Id: Ie7012445d09c3aee253548cb3057c8e9e4b86809 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 19 Apr, 2020 1 commit
-
-
Having PHPDoc parameter and return type annotations like "string[]" instead of the generic "array" will help both static code analysers as well as human readers. Resolves: #91065 Releases: master, 9.5 Change-Id: I7d39241d81ce607e9ca6050cc82126420e1e756e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64203 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 15 Apr, 2020 2 commits
-
-
GeneralUtility is a class with only static methods and a class comment stated for years not to instantiate it. Since there is a possibility to prevent instantiations of classes with private constructors, one has added to this class and on top is has been marked final. Releases: master Resolves: #91043 Change-Id: I15e2dfa98b2a30149f9f0efed31281d5d01d4efa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64181 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org>
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 12 Apr, 2020 1 commit
-
-
Some methods in GeneralUtility nowadays are wrappers to native PHP methods. We encourage people to use the PHP API directly. * GeneralUtility::IPv6Hex2Bin() * GeneralUtility::IPv6Bin2Hex() * GeneralUtility::compressIPv6() * GeneralUtility::milliseconds() In addition, these methods are unused by Core * GeneralUtility::linkThisUrl() * GeneralUtility::flushDirectory() Reasoning: In order to make our code less coupled, TYPO3 Core should use native PHP where it makes sense, instead of relying on GeneralUtility in all places. Resolves: #91001 Releases: master Change-Id: I9e3a2f4a4bb42facad2d79f959b36482dba23ec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64091 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 06 Apr, 2020 1 commit
-
-
In times of PSR-7, TYPO3's RequestFactory API and the underlying Guzzle HTTP library, the wrapper method GeneralUtility::getUrl() is merely a lazy short-hand method for fetching the contents. It is recommended to use TYPO3's RequestFactory API for fetching remote URLs. For now, however, the additional arguments (sending alternative headers, only fetching HEAD requests and return headers or headers + content, fetching a report of what happened) are deprecated, as they have proven to be inflexible nowadays. Resolves: #90956 Releases: master Change-Id: Ic7631ccf61000d0853007cf9278db6e1bab09335 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64012 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-