This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
- 18 Sep, 2020 1 commit
-
-
The toggleContainerControls method of InlineControlContainer.ts now only toggles its immediate controls. Furthermore, the new record link control for creating inline records has gotten the required class to toggle its visibility, when reaching maxitems limit. Resolves: #91808 Releases: master, 10.4 Change-Id: Ic8988943c349c874b6d9b7427a42c224dca1ded1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65058 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 17 Sep, 2020 6 commits
-
-
The database fields "be_users.options" ("Mount from groups") and "be_users.workspace_perms" (Allow editing on live workspace) use the Page Permission class for checks, which is semantically incorrect. The patch adapts the according changes in BackendUserAuthentication. Resolves: #92208 Releases: master Change-Id: Iec805fbc3ff3a72cfcdbdb67e6868c4389e8e688 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65586 Tested-by:Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
While introducing symfony/property-access, method isPropertyGettable of class ObjectAccess had been adjusted in a manner which made the mixed usage of array access and regular property access impossible. If an object implemented ArrayAccess and used regular properties, all of those properties were reported inacessible/non-gettable which is not true. With this patch, regular properties and those defined magically via ArrayAccess are detected correctly as gettable. Releases: master, 10.4 Resolves: #91784 Change-Id: If523943f679beabf40ad5d71c0e0d1d0fef8db4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65234 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Resolves: #92327 Releases: master, 10.4 Change-Id: I375f8002ef1a57a5653a17691bd258c2ea971ec7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65753 Tested-by:
-
A varchar length of 30 seems not enough for uncommon search words. This limit gets hit quite frequently - especially when the word contains one or multiple UTF-8 escape sequences. Increase it to allow up to 50 characters - keep safe with index length. Resolves: #92323 Releases: master, 10.4, 9.5 Change-Id: Ie2a27bedd1a45f21cbf92d244b3df395fb2b2423 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65747 Reviewed-by:
Bernhard Berger <bernhard.berger@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Reviewed-by:
-
The classes `firstcol` and `lastcol` for the first and last row of a table were not used anymore. Therefore, they have been removed. As the property `totalRowCount` was only used to set the class `lastcol`, it also has been removed. Releases: master Resolves: #92302 Change-Id: I12873b4604a165743a83019a123a72eb75b039a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65732 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
The methods * BackendUtility::versioningPlaceholderClause() * BackendUtility::getWorkspaceWhereClause() can be removed, as this is all done via Doctrine DBAL Restrictions. Resolves: #92315 Releases: master Change-Id: I5e90b63514b326900a472ab14260b7706c13b3fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65745 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 16 Sep, 2020 2 commits
-
-
This change introduces functional tests for the rootline utility. For now, this patch ensures the validity of Workspace Overlays when reading a given page tree / rootline. Covered tests: * Live workspace (no overlays) * New record in workspace * Modified record in workspace * Deleted record in workspace * Moved record in workspace Adding such a test class helps to extend coverage for language overlays and MountPoints in conjunction with workspaces in the future. Resolves: #92311 Releases: master, 10.4 Change-Id: Ie8a746253e4b10f98c05a448d736a5d00d59d3fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65741 Tested-by:
-
Since #83461 the name of the field is rendered next to the label for administrator users if debug mode is enabled. Now also the name of flexform fields is rendered. Resolves: #92283 Releases: master, 10.4 Change-Id: I90f7452808f08f5cbf77713f3416a4a1c02b1e6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65738 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 15 Sep, 2020 3 commits
-
-
Since the change of platform.php in the composer.json to 7.2.5 according to Symfony 5.x composer does not install the lowest dependencies for sure. This patch enforces the change of the platform before running composer update --prefer-lowest Resolves: #92251 Releases: master, 10.4, 9.5 Change-Id: I6b0fce76a2995c39215caf04d355154c87cfe3fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65692 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
The field ´filelink_sorting` of the DB table tt_content contains the sorting field. Its size should be set to 64 characters to be able to use any column name for sorting. Resolves: #92294 Releases: master, 10.4 Change-Id: Iea9f7fcc42902222f6ea2683483bb4bddf5d25e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65737 Tested-by:
-
Benni Mack authored
In contrast to the actual documentation in the code, when using RDBMS native DATE / TIME / DATETIME fields, the RDBMS does not adjust these field's values for time zone. Independent of the actual time zone the DMBS (or the current session) is using, the data is stored and retrieved "as is". The only thing that matters is the TZ of PHP, which must be identical for storing and retrieving the data, otherwise data is modified. TYPO3 works just fine like that in Backend, however Extbase' DataMapper considered the timezone of these fields as "UTC-stored", which is wrong. This patch corrects this behaviour to match the rest of the Core. Resolves: #91240 Releases: master Change-Id: Idb8e0a6f241aa0ed4e8d4a66129b58e34b9b3292 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64053 Tested-by:
Thorben Kapp <thorben@webcoast.dk> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- 14 Sep, 2020 1 commit
-
-
Extracts CSS path fixing functionality of ResourceCompressor to a separate class in order to be used in other contexts. PageRenderer uses the new object. Resolves: #91935 Releases: master, 10.4 Change-Id: Icba71dcd0ceb110fb2398b2839310fb1952d0601 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65395 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 12 Sep, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92110 Change-Id: I41e6959173e28db5aaa2310c5956296fdd8e4525 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65685 Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
- 11 Sep, 2020 14 commits
-
-
Due to the removal of branch-based versioning in TYPO3 v8, there are two methods that can be removed now (as they have been marked as internal in TYPO3 v10). * BackendUserAuthentication->workspaceAllowLiveRecordsInPID * BackendUserAuthentication->workspaceCreateNewRecord Resolves: #92290 Releases: master Change-Id: I634fd509847c29b17ad0c9f366557f34222bd5dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65702 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Since "pid=-1" is gone in TYPO3 v10, the "_REAL_PID" value is not needed anymore and can be removed in Workspace-related code. Resolves: #92291 Releases: master Change-Id: Iad882f43f7a07015af65eecd516bc983ae98ce5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65703 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Resolves: #92250 Releases: master, 10.4 Change-Id: Ia9e0caefa6d5b4e198f4af80f97e96117a583dc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65689 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92260 Change-Id: I9d0a9e546f0de5d12cf5dfdc4fe4c64550407e4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65655 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
The workaround in AbstractUserAuthentication targets versions of Internet Explorer 6, which are not supported by TYPO3 nor by Microsoft any more. Resolves: #91992 Releases: master Change-Id: I93007efbbaf044922e8d916a7552b9e1bea4ee96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65312 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: -
Benni Mack authored
The option $TYPO3_CONF_VARS[SYS][cookieSecure] is removed in favor of always setting a secure cookie on HTTPS requests. This leads to errors when a page would be available in HTTP and HTTPS which is normally not the case when using a full site base in Site Handling anymore, and making TYPO3 more secure out-of-the-box. Resolves: #87301 Releases: master Change-Id: Iba90c19456af6a82feb9c53fea52228fbff516be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65695 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Resolves: #92267 Releases: master, 10.4 Change-Id: I2bc6a6ee2f97c880dd370cae08b2ac74a988ff1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65662 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92269 Change-Id: If10d8b49d817e23f5b35dc02d641a398983db78e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65659 Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: -
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92254 Change-Id: I3c5d0625a497acd10696b8ce6ea58a9fa891bc18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65671 Tested-by:
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92255 Change-Id: Ib00584487fe1e963c3fd13e3284fd372bc0c4752 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65683 Tested-by:
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92252 Change-Id: I2026aa5a66851f4734a15348cb0a14931773ed06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65677 Tested-by:
-
A new scheduler task and CLI command to clean up existing redirects periodically under given conditions are added with this patch. Resolves: #91712 Releases: master Change-Id: Ib07145eac700fb4af1ba59589a09987c55f221ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64939 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
During the install process, the user has to choose a database in step 3 from a list of available databases. If the database user has read access but no write access to the database, the install tool used to throw an exception. Now the system catches this exception, calculates permissions more accurately and also provides more meaningful messages to the user. Resolves: #78885 Releases: master, 10.4 Change-Id: Ib9aa632e8ca161acf2de628806386bd6607afd74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64564 Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Previously, some URLs could result in errors which were not caught and caused the link checking task to abort. ExternalLinktype::preprocessUrl() now returns original URL in case of any error, catches errors and exception and does some sanity checking of parsed URLs before using the results. Resolves: #92230 Releases: master, 10.4 Change-Id: I60c73f9081e7ecd7b67c3c726d3d759d9d9baa1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65636 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 10 Sep, 2020 2 commits
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92253 Change-Id: Ibbf42d227458a4480fffc5993034f8c36d9bae3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65674 Tested-by:
-
The workspace 'publish' process is encapsulated in a lock file to prevent dupblicate publish of the same record at the same time. This is bogus: * Other operations like modify or discard are not covered * A stalled lock file can only happen if a process crashes * Nothing else in the DataHandler has similar locking strategies * The only way to recover from a stalled lock file is "ask your admin", which is not helpful in any way. If the DataHandler (and with that the workspace operations) should have locking, it needs to be implemented in the DataHandler at a central place and not within a fraction of the workspace sub set. The patch drops the publish process locking. Change-Id: I4004f46eb3dc47bb62347f5bf45a9ed0c6f5da1e Resolves: #92240 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65647 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 09 Sep, 2020 6 commits
-
-
Benjamin Franzke authored
With the introduction of symfony/event-dispatcher-contracts in https://git.typo3.org/Packages/TYPO3.CMS.git/commit/e4a1ae8762ee99712 we forced usage of symfony5 in composer-based installations where installation with symfony4 was possible before. This is because event contracts v2 is only compatible with symfony v5, but contracts v1 needs to be supported for symfony4 compatibility. Note: although non-composer-based installations used symfony5 bundled already, composer mode could still use symfony v4 if needed. We now add a new intermediate composer package that is available in two different versions, and offers a compatible symfony event dispatcher adapter for the respective interfaces in symfony v4 and symfony v5 in each of these version. typo3/cms-core allows to install both versions which means we can provide a compatible adapter for both, symfony v4 and v5. This change allows composer-based installations to support both versions (v5/v4) again, so extensions like EXT:solr (which requires a package called solarium) to work with the dependency constraints of TYPO3 Core. Commands used: composer require --no-update --working-dir=typo3/sysext/core \ "symfony/event-dispatcher-contracts:^1.1 || ^2.0" \ "typo3/symfony-psr-event-dispatcher-adapter:^1.0 || ^2.0" composer require --no-update \ "symfony/event-dispatcher-contracts:^1.1 || ^2.0" \ "typo3/symfony-psr-event-dispatcher-adapter:^1.0 || ^2.0" composer update --lock Resolves: #92229 Releases: master, 10.4 Change-Id: I4ff6c6589833cbfea3c4b327a8580fd5fbf45468 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65644 Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: -
The underling JavaScript of the Drag&Drop functionality in the page module passes the columns language, the element is dropped in, to the DataHandler. This results in L=-1 elements gets changed to L=0 when moved around in their column. This is now fixed by using the language uid of the dragged element instead of the column if elements language is -1. Resolves: #87148 Releases: master, 10.4 Change-Id: I6663341daadc228480b6dc8ac935b71f117dbfd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65614 Tested-by:
-
Replace ObjectManager->get() with GeneralUtility::makeInstance() Releases: master Resolves: #92244 Change-Id: I76ebcb67ba7e9e6cb1bd3a5ef3d8d793ed46af2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65652 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Benjamin Franzke authored
This reverts commit e2b1148c. Our Event dispatcher adapter is currently not compatible with symfony/event-dispatcher-contracts:v1 (type declaration mismatch) and therefore results in a runtime fatal error with symfony v4. Compatibility with symfony v4 will be added in a new revision of the reverted patch. Releases: master, 10.4 Reverts: #92229 Resolves: #92239 Change-Id: Ifc920b839cb1cdaaf90f3afcfa0c961b59c0f343 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65648 Tested-by:
-
* Namespace should be "Command" * Removed superfluous comma Resolves: #92233 Releases: master, 10.4 Change-Id: I6bcdeb0528ef6d1fc3d6f129572f18b7979d7fe5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65642 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92112 Change-Id: Iecb483c2575bd479ee9126034e7390691c954d13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65467 Tested-by:
-
- 08 Sep, 2020 4 commits
-
-
The results of the hook in PageRepository->enableFields and of PageRepository->getMultipleGroupsWhereClause may be different, depending on the Context state for usergroups. In TYPO3 v9, PageRepository was also used when resolving pages during Routing (where there is no user / group resolved yet), which is why we may face different states of usergroups in PageRepository. Resolves: #91714 Releases: master, 10.4, 9.5 Change-Id: If6c535efce27e2a07b803ac101d59b8baa5bbd51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65276 Tested-by:
-
TYPO3 now uses eslint instead of tslint to lint Typescript files in the core. Resolves: #92223 Releases: master, 10.4 Change-Id: Ie8adc13d738b81b2971332fa73be15266aec7d1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65637 Tested-by:
-
Streamline translation fetching: To get a better overview, the fetching of the translations for each record has been moved to the `getTable()` method. Therewith, the main translation related queries are together, as the workspace overlay is already there. The translations are now handed over to the methods that render the list of records. This allows to remove the properties `translations` and `selFieldList` as the fields to select are already in the `getTable()` method and the translation must no longer be transferred back to the `getTable()` from the `makeLocalizationPanel()` method. Furthermore, this also avoids a db query for each translated record (in strict translation mode). Previously, a query with an always empty result set was in place. Streamline localization (all records excluding pages): The localization of each record (excluding pages) depends on the available languages of the site configuration and the already translated pages. This information is collected in the `getPossibleTranslations()` method, which depends on the current page uid and replaces the `initializeLanguages()` method. It is used to set the possible translations to the `possibleTranslations` property in the `start()` method. The property `possibleTranslations` replaces the properties `pageOverlays` and `systemLanguagesOnPage`. Streamline localization for pages: The localization of page records does not depend on the translation status of the parent page, because otherwise the first translation of one page would not be possible. The restriction for the page translations is now the same as in the `languageSelector()`. Streamline `makeLocalizationPanel()` method: This method is now only used to create the possible localization buttons. Releases: master Resolves: #92133 Change-Id: Iaf5f9f8cee795c4245d8201b20617df5d95570a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65505 Tested-by:
-
In order to run TYPO3 Core acceptance tests not only in the TYPO3 Core own docker environment but in an arbitrary environment the web server url of the testing environment should be configurable by the environment variable "typo3TestingAcceptanceBaseUrl". For example, having a LEMP stack with an Nginx web server available at http://nginx:8080 you would set the variable "typo3TestingAcceptanceBaseUrl=http://nginx:8080" in the environment of the acceptance tests runner. Resolves: #92205 Releases: master, 10.4 Change-Id: Ia890ed813d1e46af0b9010f325b13f08f9863ab2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65585 Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by:
-
