Skip to content

GitLab

Switch branch/tag
This project is mirrored from git://git.typo3.org/Packages/TYPO3.CMS.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
  1. 02 Aug, 2021 1 commit
    • Christian Kuhn's avatar
      [TASK] Deprecate generic extbase domain classes · 3c78adc6
      Christian Kuhn authored 
      Extbase provides a couple of generic domain repositories
and models, especially frontend / backend users and
groups. Those are flawed by design:

The main issue is that domain models have to be specific
for the domain they are used in. By definition, a generic,
opinionated model can't be "correct" since the domain
it is used in, is unique: It might be that a backend user
email has to be set and the domain does not model
anything but email and firstname?

Many usages don't need backend groups attached to a
backend user model at all, or if they need them, then
maybe in a recursive presentation, or a specific order
or something similar. Having a default group resolution
is thus at least misleading, if not wrong, and can be a
performance issue on top.

A generic model can never foresee its usages. The existing
models thus try to 1:1 adapt the database fields, which
is also misleading since a domain model is not and should
not be a direct representation of a database table. It
would only be by chance if the generic models fit a
specific domain.

Similar issues exist with the repositories: The
CategoryRepository for instance assumes it is a good
idea to set respectStoragePid(false), which is most
likely not the right thing for an extension use.
In the end, whatever extbase delivers here, is most
likely wrong and does not fit the problem domain.

The patch keeps the 'experimental' FAL related models
since those can be actually useful for extensions and
their final fate has not been decided, yet. The other
generic models, especially those with lots of properties
are marked as deprecated with the patch.

Change-Id: I06629fddd0258c517f3fa8bdf2e9c4b342be9678
Resolves: #94654
Related: #83296
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70061

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      3c78adc6
  3. 15 Apr, 2020 2 commits
  5. 14 Apr, 2020 1 commit
  7. 01 Oct, 2018 1 commit
    • Benni Mack's avatar
      [TASK] Streamline phpdoc annotations in EXT:extbase · 65a55111
      Benni Mack authored 
      EXT:extbase uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:extbase: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

On top, all license headers and @license annotations have been streamlined.

This means:
- TYPO3 Core's PHP classes area all public API by default
   unless marked as @internal or an extension class
- @api is not allowed anymore and will be restricted in
   the future from adding.
- @internal should be used for everything that should
   not be explicitly exposed as public API in the future.
- Everything under Tests/ is not part of TYPO3's Public API

Resolves: #86521
Releases: master
Change-Id: I83c5a27d9af001929142d2620600668ad0a84c92
Reviewed-on: https://review.typo3.org/58535

Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein's avatarMarkus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein's avatarMarkus Klein <markus.klein@typo3.org>
      65a55111
  9. 22 Jun, 2018 1 commit
  11. 14 May, 2018 1 commit
  13. 14 Jan, 2018 1 commit
  15. 27 Nov, 2017 1 commit
  17. 20 Apr, 2017 1 commit
  19. 28 Mar, 2017 1 commit
    • Wouter Wolters's avatar
      [TASK] Streamline return tags in phpdocs · eb049dba
      Wouter Wolters authored 
      The TYPO3 Core currently has no guidline how to handle phpdoc
comments regarding @return annoations related to "void" and "null".

In practice, these annotations have no additional value if no additional
documentation is given.

With this change, the php-cs-fixer will remove any unnecessary linebreaks
within the comments above the @return annotation, as well as remove completely
empty phpdoc comments because the @return annotation is removed.

Please be aware, that once PSR-5 is accepted, this coding standard
within the TYPO3 Core will change again, where there are currently
some further proposal details like inheritance information.

Resolves: #80454
Releases: master
Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
Reviewed-on: https://review.typo3.org/51686

Reviewed-by: Nicole Cordes's avatarNicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes's avatarNicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      eb049dba
  21. 11 May, 2016 1 commit
  23. 08 Oct, 2015 1 commit
  25. 16 Dec, 2014 1 commit
  27. 13 Dec, 2014 2 commits
  29. 22 Jun, 2014 1 commit
    • Michael Schams's avatar
      [TASK] Re-work/simplify copyright header in PHP files - Part 7 · 47a9bb03
      Michael Schams authored 
      This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59783 for further details.

Resolves: #59783
Releases: 6.3, 6.2
Change-Id: I0e2f68990217f7442abe5b940fd769250c37aec0
Reviewed-on: https://review.typo3.org/31028
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
      47a9bb03
  31. 05 Mar, 2014 1 commit
    • Thomas Luzat's avatar
      [BUGFIX] Fix executable permissions on files · 023d35ec
      Thomas Luzat authored 
      A large number of files were stored with executable permissions. This
may be a (minor) security risk and can be confusing. The patch removes
the executable permissions on all files but:

* typo3/cli_dispatch.phpsh
* typo3/cleaner_check.sh
* typo3/cleaner_fix.sh

Resolves: #56571
Releases: 6.2
Change-Id: Ib6a9fb19fe716d7d5405d5a7120b50269bdbf5f8
Reviewed-on: https://review.typo3.org/28072
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
      023d35ec
  33. 13 Jan, 2014 1 commit
  35. 06 Nov, 2013 1 commit
  37. 01 Oct, 2013 1 commit
    • Christian Kuhn's avatar
      [TASK] Remove closing PHP tags · 77f29a3c
      Christian Kuhn authored 
      Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
      77f29a3c
  39. 01 Apr, 2013 1 commit
  41. 11 Dec, 2012 2 commits
  43. 21 Nov, 2012 1 commit
    • Alexander Schnitzler's avatar
      [BUGFIX] Remove property item of category model · b07dd194
      Alexander Schnitzler authored 
      Because the mere presence of the property leads
to an SqlException in the Typo3DbBackend it has
to be removed for 6.0. For 6.1 a solution will
be found.

Releases: 6.0
Fixes: #43074
Change-Id: I35850ba3513c48da692f6e1a9d07e7cfbfd7f1b3
Reviewed-on: http://review.typo3.org/16673
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
      b07dd194
  45. 20 Nov, 2012 1 commit
  47. 14 Nov, 2012 1 commit
  49. 31 Oct, 2012 1 commit
  51. 29 Oct, 2012 1 commit
  53. 26 Aug, 2012 2 commits
  55. 17 Oct, 2012 2 commits
  57. 02 Aug, 2012 1 commit
    • Fabien Udriot's avatar
      [TASK] Add Domain Model and Repository to Category · 6c527e10
      Fabien Udriot authored 
      For extension developer's sake, it is convenient to provide a domain
model along with a repository. Both are relying on Extbase.

Change-Id: I7260a57dcc742f217f0ddfe19470673bc91532c9
Resolves: #38719
Releases: 6.0
Reviewed-on: http://review.typo3.org/12793
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Jochen Rau
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
      6c527e10