This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 02 Aug, 2021 1 commit
-
-
Christian Kuhn authored
Extbase provides a couple of generic domain repositories and models, especially frontend / backend users and groups. Those are flawed by design: The main issue is that domain models have to be specific for the domain they are used in. By definition, a generic, opinionated model can't be "correct" since the domain it is used in, is unique: It might be that a backend user email has to be set and the domain does not model anything but email and firstname? Many usages don't need backend groups attached to a backend user model at all, or if they need them, then maybe in a recursive presentation, or a specific order or something similar. Having a default group resolution is thus at least misleading, if not wrong, and can be a performance issue on top. A generic model can never foresee its usages. The existing models thus try to 1:1 adapt the database fields, which is also misleading since a domain model is not and should not be a direct representation of a database table. It would only be by chance if the generic models fit a specific domain. Similar issues exist with the repositories: The CategoryRepository for instance assumes it is a good idea to set respectStoragePid(false), which is most likely not the right thing for an extension use. In the end, whatever extbase delivers here, is most likely wrong and does not fit the problem domain. The patch keeps the 'experimental' FAL related models since those can be actually useful for extensions and their final fate has not been decided, yet. The other generic models, especially those with lots of properties are marked as deprecated with the patch. Change-Id: I06629fddd0258c517f3fa8bdf2e9c4b342be9678 Resolves: #94654 Related: #83296 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70061 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 15 Apr, 2020 2 commits
-
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/extbase/Classes bin/rector process --set=php53 typo3/sysext/extbase/Tests Releases: master Resolves: #91047 Change-Id: Idcd1e10e5bf6dd5fa504873e450e31a980fab9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de>
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 01 Oct, 2018 1 commit
-
-
EXT:extbase uses @api and @internal phpDoc annotations. Going with a cleaner approach with marking code as just @internal, and everything not annotated as @internal is public, is the way to go, also the way PSR-5 is heading. For EXT:extbase: Every PHP class that had nothing marked, is now @internal, everything that was @api is now implicitly part of TYPO3 Core API. On top, all license headers and @license annotations have been streamlined. This means: - TYPO3 Core's PHP classes area all public API by default unless marked as @internal or an extension class - @api is not allowed anymore and will be restricted in the future from adding. - @internal should be used for everything that should not be explicitly exposed as public API in the future. - Everything under Tests/ is not part of TYPO3's Public API Resolves: #86521 Releases: master Change-Id: I83c5a27d9af001929142d2620600668ad0a84c92 Reviewed-on: https://review.typo3.org/58535 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- 22 Jun, 2018 1 commit
-
-
Class properties explicitly initialized with NULL and redundant assignments in constructors are removed. Resolves: #85287 Releases: master Change-Id: I44c565a0b54e7e98ffa6d2d1de5335a6212a5742 Reviewed-on: https://review.typo3.org/57243 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 14 May, 2018 1 commit
-
-
This patch introduces the "TYPO3\CMS\Extbase\Annotation\Validate" annotation that replaces the @validate annotation which is deprecated from now on. Releases: master Resolves: #83167 Change-Id: I9a0a3804cfb7429eaf81ec2b3ffa21c3a3d84c63 Reviewed-on: https://review.typo3.org/54870 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 14 Jan, 2018 1 commit
-
-
Releases: master Resolves: #83520 Change-Id: Idd10aa62692198f7aa20af1492fb9670149d5ac9 Reviewed-on: https://review.typo3.org/55312 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 27 Nov, 2017 1 commit
-
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 20 Apr, 2017 1 commit
-
-
Removes and adapts some classes, methods and parameters which were marked as deprecated. Resolves: #80713 Releases: master Change-Id: Iae9c7035f72e3af0f9b4056cc507515546ecdbf9 Reviewed-on: https://review.typo3.org/52507 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
- 11 May, 2016 1 commit
-
-
Resolves: #75904 Releases: master Change-Id: Ifa27348ae8204af7cac777756282016a88b0be6b Reviewed-on: https://review.typo3.org/48034 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Paul Ilea <paul@target-e.com> Reviewed-by:
Marcin Krzyżanowski <m.krzyzanowski@macopedia.pl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
TYPO3 Release Team <typo3cms@typo3.org>
-
- 16 Dec, 2014 1 commit
-
-
Most of TYPO3's PHP files have an empty line before a class' closing curly brace. This commit adds this empty line (if it is missing) before a class' closing curly brace. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (}\n)(}) Replace: $1\n$2 Resolves: #63942 Release: master Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7 Reviewed-on: http://review.typo3.org/35527 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 13 Dec, 2014 2 commits
-
-
At the moment in some classes you can find an empty line between the copyright comment and the first PHPdoc bock comment. In some other classes there is no such empty line. This commit adds an empty line between those comments if there is no empty line. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: ( \* The TYPO3 project - inspiring people to share!\n \*/\n)(/\*\*\n \*) Replace: $1\n$2 Resolves: #63828 Releases: master Change-Id: I1d921921a3f60a62c29de3300b25b5df36a43b0a Reviewed-on: http://review.typo3.org/35390 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org>
-
- 22 Jun, 2014 1 commit
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59783 for further details. Resolves: #59783 Releases: 6.3, 6.2 Change-Id: I0e2f68990217f7442abe5b940fd769250c37aec0 Reviewed-on: https://review.typo3.org/31028 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- 05 Mar, 2014 1 commit
-
-
Thomas Luzat authored
A large number of files were stored with executable permissions. This may be a (minor) security risk and can be confusing. The patch removes the executable permissions on all files but: * typo3/cli_dispatch.phpsh * typo3/cleaner_check.sh * typo3/cleaner_fix.sh Resolves: #56571 Releases: 6.2 Change-Id: Ib6a9fb19fe716d7d5405d5a7120b50269bdbf5f8 Reviewed-on: https://review.typo3.org/28072 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- 13 Jan, 2014 1 commit
-
-
Roland Waldner authored
"textfile" will be replaced by "text file" Resolves: #54893 Releases: 6.2 Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b Reviewed-on: https://review.typo3.org/26736 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 06 Nov, 2013 1 commit
-
-
Add missing icon property Resolves: #53341 Releases: 6.2 Change-Id: Ib84e60c59a46d6f19adc1426760f177a37ddfe61 Reviewed-on: https://review.typo3.org/25170 Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- 01 Oct, 2013 1 commit
-
-
Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b Resolves: #52360 Releases: 6.2 Reviewed-on: https://review.typo3.org/24212 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- 01 Apr, 2013 1 commit
-
-
Changes "(c) 2010-2012" to "(c) 2010-2013" Releases: 6.1 Resolves: #46840 Change-Id: I0a26a9a05cfc5697eb536016aee946ad970d82b3 Reviewed-on: https://review.typo3.org/19494 Reviewed-by: Alexander Schnitzler Tested-by: Alexander Schnitzler
-
- 11 Dec, 2012 2 commits
-
-
Also adjusted some operators for jenkins Releases: 6.1 Resolves: #43887 Change-Id: I5e6ba540d7d828bd24417356b887182966fb581c Reviewed-on: https://review.typo3.org/17102 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
All files should have the same file comment with the same copyright notice in it. Also there must not be an author any more. Instead the Extbase Team is mentioned as author from now on. Releases: 6.1 Fixes: #43883 Change-Id: Ib61859a2fa853a238907df314f948da51306d7e8 Reviewed-on: https://review.typo3.org/17099 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- 21 Nov, 2012 1 commit
-
-
Because the mere presence of the property leads to an SqlException in the Typo3DbBackend it has to be removed for 6.0. For 6.1 a solution will be found. Releases: 6.0 Fixes: #43074 Change-Id: I35850ba3513c48da692f6e1a9d07e7cfbfd7f1b3 Reviewed-on: http://review.typo3.org/16673 Reviewed-by: Ingo Pfennigstorf Tested-by: Ingo Pfennigstorf Reviewed-by: Wouter Wolters Reviewed-by: Alexander Schnitzler Tested-by: Alexander Schnitzler
-
- 20 Nov, 2012 1 commit
-
-
Alexander Schnitzler authored
* whitespaces, tabs and blank line issues * bool -> boolean * int -> integer * remove @scope and @entity Fixes: #43146 Releases: 6.0 Change-Id: I0ffdde3c918920272e8b1e4d1eab199b7b3e90f3 Reviewed-on: http://review.typo3.org/16600 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 14 Nov, 2012 1 commit
-
-
This fixes the annotation for the item property in the Category model. Resolves: #42970 Releases: 6.0 Change-Id: Ic6e5f54a608f0c8f311a8fd887ce4c9195b1dba8 Reviewed-on: http://review.typo3.org/16442 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- 31 Oct, 2012 1 commit
-
-
Releases: 6.0 Fixes: #42549 Change-Id: I6ff8f42a53e47fe2e5d83a8a3c4baec8753a5291 Reviewed-on: http://review.typo3.org/16071 Reviewed-by: Alexander Schnitzler Tested-by: Alexander Schnitzler
-
- 29 Oct, 2012 1 commit
-
-
Releases: 6.0 Fixes: #42469 Change-Id: I004754cb05d06d2e3b91a41bde5657bb69d0f6b4 Reviewed-on: http://review.typo3.org/16004 Reviewed-by: Alexander Schnitzler Tested-by: Alexander Schnitzler
-
- 26 Aug, 2012 2 commits
-
-
The update script unfortunetly didn't successfully rename all classes in Extbase, so I renamed the remaining ones manually. Change-Id: Ia084593b8e9bf13ba487ab3b430eddf9b254d85e Fixes: #40224 Related: #40095 Releases: 6.0 Reviewed-on: http://review.typo3.org/14112 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
* Cleaned up wrong PHPDoc * Removed unused variables * Added missing fields * Fixed type incompatibility Change-Id: I3ecc49ceb25458dda285cc4e005c5c2d44112100 Fixes: #40224 Releases: 6.0 Reviewed-on: http://review.typo3.org/14106 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- 17 Oct, 2012 2 commits
-
-
Thomas Maroschik authored
Change-Id: I403aee9d244a65e51547b21dac3b1228ffd3478e
-
Thomas Maroschik authored
Change-Id: I916ad5a3a24864a52e945aeb66e6f997b8e6fabd
-
- 02 Aug, 2012 1 commit
-
-
For extension developer's sake, it is convenient to provide a domain model along with a repository. Both are relying on Extbase. Change-Id: I7260a57dcc742f217f0ddfe19470673bc91532c9 Resolves: #38719 Releases: 6.0 Reviewed-on: http://review.typo3.org/12793 Reviewed-by: Oliver Klee Tested-by: Oliver Klee Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Sebastian Michaelsen Reviewed-by: Jochen Rau Reviewed-by: Georg Ringer Tested-by: Georg Ringer Reviewed-by: Mattias Nilsson Tested-by: Mattias Nilsson Reviewed-by: Markus Günther Tested-by: Markus Günther Reviewed-by: Ingo Pfennigstorf Tested-by: Ingo Pfennigstorf
-