Georg Ringer authored Jul 24, 2012 and Christian Kuhn committed Jul 29, 2012

Code of sys_note can be highly improved:
* Use fluid
* Move xlf files to Resources
* Add kind-of repository

Change-Id: Ia89acb29ddbc0919901570f6bdd1575376863c4a
Resolves: #39221
Releases: 6.0
Reviewed-on: http://review.typo3.org/13021
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Susanne Moog authored Jul 01, 2012 and Christian Kuhn committed Jul 29, 2012

The buttons "clear configuration" and "reset
temporary data" are advanced functions and should
therefore be moved to the advanced tab.

Additionally the buttons divert the attention, so that
it is very hard to notice the save button on the
top.

The patch moves the buttons to the advanced tab and
additionally aligns the select box(es) with the
input and button fields.

Change-Id: I5c5552d3a20b68e458b6523bfb5e939000cd4f9a
Related: #632
Releases: 6.0
Resolves: #38523
Reviewed-on: http://review.typo3.org/12504
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

When using the hash-algorithm "blowfish" in saltedpasswords
the hash is 60 chars long - therefore the field length has
been set to 60 characters in SQL, too.
Actually when converting old MD5 passwords to salted
copies, an additional identifer char (M or C) is added to
the hash which results in a 61 character hash.

The result is that login is not possible anymore after
converting the passwords like suggested by the reports
module - the database field has to be increased.

To be safe and because varchar only takes as much space
as really needed increase the field length to 100 chars.

Change-Id: I70646fe7939d41f1a7056376a85c506d10148480
Fixes: #39356
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/13324
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Clean up the class a bit and add unit tests for getRoot().

Change-Id: I9a60c9531bca8683708ddfb7e898926fb2c7d5c5
Releases: 6.0
Resolves: #39348
Reviewed-on: http://review.typo3.org/13320
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

We need to be able to subclass some classes for the unit tests:

a) classes that need to be used with getMock
b) classes that we subclass to overwrite static methods

Change-Id: Ib31bb18a1d90144699bc9c30311f26a2dbb42a7b
Releases: 6.0
Resolves: #39353
Reviewed-on: http://review.typo3.org/13321
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Tick (') must be quoted to \'

Change-Id: I006173f0d5e1e17de1ff8801c71c6167fd96087d
Resolves: #39346
Releases: 6.0
Reviewed-on: http://review.typo3.org/13225
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Problem: When using Firefox, if a copy/cut/paste button is hit and
access to the clipboard is not allowed, installation of Firefox add-on
AllowClipboardHelper should be triggered.

Solution: Report the exception raised by Firefox and take action.

Change-Id: I5eff1f4fba496a5b984db8e26e307f585ac0d985
Resolves: #39338
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/13214
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Wouter Wolters authored Jul 27, 2012 and Christian Kuhn committed Jul 27, 2012

The button to generate a new random key is not updating
anymore due to the refactoring of the localconf.php file

Change-Id: I07b8aeb9921b6e0ecabf3cad5333ace02afaa1ae
Fixes: #39306
Releases: 6.0
Reviewed-on: http://review.typo3.org/13086
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Oliver Hader authored Jul 21, 2012 and Christian Kuhn committed Jul 26, 2012

Calling t3lib_category_Registry::getDatabaseTableDefinition()
for an extension that does not register any categories, will
cause a PHP Warning.

Change-Id: Id44022bcdca4484a2798777bcb9139fe070935e0
Fixes: #39155
Releases: 6.0
Reviewed-on: http://review.typo3.org/12968
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Felix Kopp authored Jul 13, 2012 and Christian Kuhn committed Jul 26, 2012

Adds link to backend module docheader within EXT: viewpage
to open the current page in a new window.

Change-Id: I89c4a6f38bfb61fd9d5456e463840e7c9ecc5c9a
Fixes: #38918
Releases: 6.0
Reviewed-on: http://review.typo3.org/12777
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Tobias Burger authored Apr 10, 2012 and Christian Kuhn committed Jul 26, 2012

Add wincache as a cache backend for TYPO3 installations
running on a windows machine

Change-Id: I3089939f87d2597001120d9d3831f4e9ddb913bd
Resolves: #35818
Releases: 6.0
Reviewed-on: http://review.typo3.org/10204
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I6658c99f426a2ba98a6136b0209dfa208913e6df
Reviewed-on: http://review.typo3.org/13055
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: I99382411aa240f24f3f1554454cbc0ed791f004f
Reviewed-on: http://review.typo3.org/13054
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: Id268247e7fdea9fd857025b3ca7280e39fc5385e
Reviewed-on: http://review.typo3.org/13053
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

The introduction package loads multiple extensions in one go through the
em API enableExtension(). The refreshGlobalExtList() method should reset
the extListArray to new values written to LocalConfiguration to
recognize if many extensions are loaded in one request.

Change-Id: Ieb4481e3d04a4407ba31f3c64f71c5fb5b03e344
Resolves: #39237
Related: #39112
Releases: 6.0
Reviewed-on: http://review.typo3.org/13038
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The main entry points have been refactored, but some places have been
forgotten leading to E_STRICT errors flooding the log.

Refactor all places to use the same code:
error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED));

Change-Id: I5ba40bcefd236d77b21cdb545685bcae40e60f1f
Related: #35154
Fixes: #38691
Releases: 6.0
Reviewed-on: http://review.typo3.org/12689
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Due to the localconf.php refactoring the 
install wizard is broken. This change fixes it.

Change-Id: I1e266a76c5cdbee140df47fd61a09a14c72be9b6
Releases: 6.0
Resolves: #39112
Reviewed-on: http://review.typo3.org/13028
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Anja Leichsenring authored Jul 23, 2012 and Christian Kuhn committed Jul 24, 2012

Due to the removal of allowed class name prefix check, 
all calls to t3lib_div::getUserObject cause a 
debug statement for not found class in BE while editing content. 
The debug statement is therefore removed.

Although silent failing is not nice, there is no other s
olution for now. In the long run we should deprecate 
the whole method in several steps.

Change-Id: I407d5ee6020913b6c0538d1414ccb6514d72c71b
Fixes: #39191
Releases: 6.0
Reviewed-on: http://review.typo3.org/13001
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Oliver Klee
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Whenever a record is not translated, Pootle exports the localization file
with only the "source" element and no "target" element.

Change-Id: Ib4b849abdeff4b045af7a7bcd8550719f814557f
Fixes: #39220
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/13020
Reviewed-by: Helmut Hummel
Reviewed-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Kai Vogel authored Jul 13, 2012 and Christian Kuhn committed Jul 23, 2012

Since the rework of the media content element for TYPO3 4.7, YouTube
videos cannot be played anymore using the Media CE. This patch adds
an autodetection of urls which are handled by a media wizard and sets
correct video renderer type.

Tested with youtube, vimeo, myvideo, liveleak

Change-Id: I600d94eb60a7451873835142e2019ddfd39e8deb
Fixes: #37967
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/12782
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Nikolas Hagelstein
Tested-by: Nikolas Hagelstein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Exclude aggregate functions count(), sum(), max(),
min(), avg() in if statement inside
tslib_cObj::sanitizeSelectPart().

Change-Id: I5d8cd5f00472b417dad3c8790b1cc75f3cfd473a
Fixes: #34152
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/9158
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Alain
Tested-by: Alain
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Anja Leichsenring authored Jul 21, 2012 and Christian Kuhn committed Jul 21, 2012

Change-Id: I9e2b6e154d2f2618adbe5a563723118eebbb8bbe
Reviewed-on: http://review.typo3.org/12983
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Anja Leichsenring authored Jul 21, 2012 and Christian Kuhn committed Jul 21, 2012

Sometimes the core enforces classes to be prefixed with special names
like 'tx_' or 'user_', especially if they are loaded as user functions.
This constraint is in the core for a long time, but was already weakened
by for example the extbase code, and was only required at some arbitrary
points. The constraint itself does not make much sense, and is now
fully removed with this patch.
As an additional advantage, this patch eases the transition to
namespaced class names.

Notes:
- Remove configuration Setting '[sys][additionalAllowedClassPrefixes]'
- Update t3lib_registry to accept every namespace at least 2 chars long
- Adapt tests
- Remove and deprecate calls to t3lib_div::hasValidClassPrefix

Change-Id: I0ba4fd41beb5f05bf87a14d735bb83922d62b247
Resolves: #39164
Releases: 6.0
Reviewed-on: http://review.typo3.org/12976
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: If17c9f726c9b19fae901deca9ebf4f6c6db1e658
Reviewed-on: http://review.typo3.org/12980
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Anja Leichsenring authored Jul 20, 2012 and Christian Kuhn committed Jul 21, 2012

Add more tests to and move the namespace logic to
a more logical place.

Change-Id: I4907fdadfb04f27b74849ae6b42b52d55c6e8bd6
Resolves: #39158
Releses: 6.0
Reviewed-on: http://review.typo3.org/12971
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Anja Leichsenring authored Jul 20, 2012 and Christian Kuhn committed Jul 21, 2012

The autoloader will now recognize classnames with fully
qualified namespaces names. So, it is now possible to
autoload a class called '\Tx\ExtensionName\Foo\Bar' that is
located in 'extPath'/Classes/Foo/Bar.php.

Change-Id: I9b3f130ca201eee94b595c2eee6f64e1c9a63e93
Resolves: #39147
Releases: 6.0
Reviewed-on: http://review.typo3.org/12944
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Wouter Wolters authored Jul 18, 2012 and Christian Kuhn committed Jul 21, 2012

Change all @deprecated annotations to the correct version number.
Replace 4.8 -> 6.0 and 4.9 -> 6.1

Change-Id: Ia0b90f50a52619ff9965d206d2d22c947182cb80
Resolves: #39067
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/12895
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I2597cbec82e2dc61ab247cdff8b4ce9d19b2c231
Reviewed-on: http://review.typo3.org/12942
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

If some prefixes are defined (either base URL or absRefPrefix),
the Media CE will apply such prefix to any Quicktime movie
even if said movie is referenced by an absolute URL.

Change-Id: Ibe8b24da5fdf3689d841987f45e91c750a7a002c
Fixes: #39026
Releases: 6.0,4.7,4.6,4.5
Reviewed-on: http://review.typo3.org/12847
Reviewed-by: Francois Suter
Tested-by: Francois Suter

The XCLASS handling that was changed with #31893 allows to register
XCLASS'es with an entry in ext_autoload. The patch introduced a
compatibility layer to support the old registration by guessing the
needed array key in TYPO3_CONF_VARS. This turns out to not work very
reliable and could only be fixed with a massive organizational and
performance overhead.

Therefore, this patch now drops the complete compatibility layer, so an
extension must be adapted to support the new scheme. This is ok, since
extension authors maintaining extensions with XCLASS'es are aware that
those classes already break frequently in the past, and were already
advised to request hooks in the long run.

Change-Id: I95a8bf986c94c784c69d4c4cc4a9c4645cd3fcc9
Resolves: #39128
Releases: 6.0
Reviewed-on: http://review.typo3.org/12926
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Anja Leichsenring authored Jul 20, 2012 and Christian Kuhn committed Jul 20, 2012

The defined('AF_INET6') in the t3lib_div ipv6 related methods tests
for availability of ipv6 support in php. This is by default enabled
on all platforms since php 5.3.
The fallback layer in t3lib_div did not work anyway and the unit
tests failed in this case. This fallback layer is now removed.

Change-Id: Id2618c33a3ab0d5daa7faa3fd42ec72d51974485
Resolves: #39125
Releases: 6.0
Reviewed-on: http://review.typo3.org/12925
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Some php versions like debian squeeze 5.3.3 do not have proper unicode
support for PCRE enabled. In effect, character classes like [:alnum:]
do not contain unicode characters. Therefore, test
filenamesAreCorrectlyValidated with data set "filename with german
umlauts" fails on those systems.

The patch changes the according regex in t3lib_file_Driver_AbstractDriver
to other, fully supported character classes.

Change-Id: I49c9c2488536577ba77c5065e96a5ef4859e03da
Fixes: #39123
Releases: 6.0
Reviewed-on: http://review.typo3.org/12924
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Currently, if showpic.php requests fail, exceptions are thrown. Those are
usually converted to a HTTP response 500 (internal server error) by the
production exception handler. Crawlers react on 500 by trying to index
the resource again later.

This is changed to now set specific response codes. If the paramters are
incorrect or broken, an 410 (Gone) will be sent, informing users and
crawlers that the resource is not available under this URL. Crawlers
like googleBot will then stop requesting the resource.

In case all parameters are ok, but the image itself is not found, a 404
will be sent to the client. Crawlers will try to index the resource
again only if there are still links pointing to the resource.

Change-Id: I606937fa9953b88be5edf940201e0153223ae0e6
Fixes: #39052
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12867
Reviewed-by: Mario Rimann
Reviewed-by: Ernesto Baschny
Tested-by: Anja Leichsenring
Reviewed-by: Anja Leichsenring
Reviewed-by: Marcus Krause
Tested-by: Marcus Krause
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Felix Kopp authored Jul 20, 2012 and Christian Kuhn committed Jul 20, 2012

Removes the record_list icon from the docHeader in Page module.

This icon links from page to list module but does not bring the
backend to a consistent state. The module bar is e.g. not updated.

The decision to remove the icon was taken at UX sprint 2012.

Change-Id: I754a5840a244017986bcaca2ecd4bf16a63cb85e
Releases: 6.0
Resolves: #38828
Reviewed-on: http://review.typo3.org/12911
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Helge Funk authored Jul 02, 2012 and Christian Kuhn committed Jul 20, 2012

This patch removes the file typo3conf/localconf.php and introduces
a new file called typo3conf/LocalConfiguration.php instead. The file
returns the local overrides of the TYPO3_CONF_VARS default array,
which is merged with the default array during bootstrap.

An upgrade wizard transfers the settings from localconf to the new
file. As an effect, the LocalConfiguration file is now fully under
core control. There must be no additional custom code in it. If an
instance needs such code, it can be added to a second file called
typo3conf/AdditionalConfiguration.php, which is executed as is
during bootstrap after LocalConfiguration was read.

This enables us to store the local configuration as an array,
exports the file with a clear schema.

Furthermore, the list of loaded extensions (extList) is now stored
as an array (extListArray). The old comma separated extList string is
still kept for now, but core usage is adapted to use extListArray. The
old extList string is still written and maintained, but is only kept
for extensions for backwards compatibility.

Important notes:
- Frontend, backend, cli and install tool must still come up, even
  if the upgrade wizard was not run, yet.
- The variables '$typo3_db_*' that where in localconf.php are now
  merged with the TYPO3_CONF_VARS. The upgrade wizard should find
  and transfer them.
- The settings in install tool -> Basic Configuration are currently
  broken. This would have made the patch even bigger, and must be
  fixed with an additional patch.
- It is advised to run the update wizard as soon as possible after
  this patch is merged, it will be the first wizard in the line.
- Some follow ups for dbal and probably workspaces are still needed.
- Currently the 1-2-3 install wizards are broken. The dummy and
  other packages need some love to adapt to the new handling.

If some of the above problems are not solved until 6.0
stabilizes, this patch needs to be reverted again.

Change-Id: I3bf6a176117f501946123b921b6d2f1932627270
Resolves: #38562
Release: 6.0
Reviewed-on: http://review.typo3.org/12519
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

recordList calls t3lib_div::sanitizeLocalUrl twice. 
Store the result in a variable, so that one call is
enough.

Change-Id: I56a2d3b5ff0e75e4409829fbcc7db64ee98bec38
Resolves: #39060
Releases: 6.0
Reviewed-on: http://review.typo3.org/12874
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

FAL introduced an adapterservice to migrate certain
fields to FAL style. The adapterservice uses type hinting
to suggest $row of tslib_content always to be an array.
However, when e.g. calling tslib_content from an
extension or Fluid, it is common to have $row
as NULL or empty, so the additional check
is removed.

Change-Id: I4b5f0231d3c8c2d9f3ec6d2f6a7a3a1b85775673
Resolves: #38977
Reviewed-on: http://review.typo3.org/12813
Reviewed-by: Michael Staatz
Tested-by: Michael Staatz
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht

Oliver Hader authored May 03, 2012 and Benni Mack committed Jul 16, 2012

When using FLUIDTEMPLATE and COA_INT or USER_INT on the same
level and partials are used in the Fluid template, then there
will be Closures. COA_INT and USER_INT are going to serialize
the cObj, which fails when a Closure shall be processed.

Since the Closures have been collected in $cObj->contentObjects
the fix is to use a cloned version of the cObj which does not
contain these contentObjects anymore for COA_INT and USER_INT.

Change-Id: I5c1f9b01caef1df5077955bd7fa6e879e41ca854
Fixes: #36820
Related: #32295
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10979
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Mention jQuery as external library, that is used in the TYPO3
core

Change-Id: Ia6c93c35d27c96d4d8b670ac94417ecf1b46e6ca
Resolves: #38968
Releases: 6.0
Reviewed-on: http://review.typo3.org/12811
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Ingo Renner authored Jul 15, 2012 and Christian Kuhn committed Jul 15, 2012

Since changing the ext_tables.php handling to use the caching
framework $_EXTKEY is not available in global scope anymore.

This leads to issues when f.e. registering custom navigation
components through t3lib_extMgm::addNavigationComponent().

Explicitly setting $_EXTKEY global fixes the bug.

Change-Id: Iec822eb55abdd8c471cb2e13a0d26c099db39849
Fixes: #38964
Releases: 6.0
Reviewed-on: http://review.typo3.org/12807
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn