This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer or owner.
Last successful update .
- 06 May, 2019 1 commit
-
-
If `mod.web_layout.disableNewContentElementWizard=1` is set, the "New Content Element" wizard is skipped and EditDocumentController's FormEngine is called directly. In that case, the modal must not get opened as this doesn't work in combination with FormEngine. Resolves: #88075 Releases: master, 9.5 Change-Id: Idada95f426496b49131463ec1d0e8462df163e70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60627 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- 15 Apr, 2019 1 commit
-
-
Helmut Hummel authored
Resolves: #87687 Releases: master, 9.5 Change-Id: I8113f3fa2facf6b21bc19ee1c445265c5ff4f4b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59872 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
-
- 05 Apr, 2019 2 commits
-
-
This commit fixes a usage of the null coalesce operator within a condition. Resolves: #88092 Related: #84375 Releases: master, 9.5 Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
André Schließer <andy.schliesser@gmail.com>
Tested-by: -
Resolves: #88091 Releases: master, 9.5 Change-Id: I3261190c1214dece4dce5d208a54af2b14b3aa0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60399 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- 15 Mar, 2019 1 commit
-
-
Replace string concatenations like 'abc' . 'def' with 'abcdef'. Resolves: #87004 Releases: master Change-Id: I9c1a610e88dd4bd4e617214989a915b1dafda094 Reviewed-on: https://review.typo3.org/c/60155 Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- 11 Feb, 2019 1 commit
-
-
Used * composer update friendsofphp/php-cs-fixer --with-all-dependencies The new php-cs-fixer is compatible with PHP7.3+ and fixes some more issues configured according to our code style settings. Resolves: #87684 Releases: master, 9.5 Change-Id: Ibb2150eea173ded11495866aa171dd171aca7efd Reviewed-on: https://review.typo3.org/59677 Reviewed-by:
-
- 18 Jan, 2019 1 commit
-
-
The patch pics various smaller places to drop their deprecated code snippets. Additionally some comments are changed slightly to better hint on what needs to be done later in v11. Resolves: #87476 Releases: master Change-Id: Ib7fe5e4ca29b1c41dd02806e25484e99ef9a41ba Reviewed-on: https://review.typo3.org/59475 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- 08 Jan, 2019 1 commit
-
-
`DatabaseRecordList::prepareQueryBuilder()` is able to handle multiple order clauses defined in either `sortby` or `default_sortby`. However, the wrong method for appending the order clause is used, which results in overriding the previous set clause. This patch changes the method to use `addOrderBy()` instead which appends multiple order clauses properly. Resolves: #87352 Releases: master, 9.5 Change-Id: I08f4248d4dc890079715efb9a48b1d270a6b1077 Reviewed-on: https://review.typo3.org/59356 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
featdd <dorndorf@featdd.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 07 Dec, 2018 1 commit
-
-
Disable copy option if setting mod.web_layout.localization.enableCopy = 0 in all cases. As a newly translated page has no copies or translations this variable will be false and this results in $allowCopy = true. To disable the copy mode the initial setting $allowCopy is taken into account. Resolves: #76910 Releases: master Change-Id: I38f16a11038885c1ba0d455d7913d729e9669817 Reviewed-on: https://review.typo3.org/59016 Reviewed-by:
-
- 27 Nov, 2018 1 commit
-
-
A warning is logged if the fluid-based preview template for a content element could not be rendered. The logged warning includes - the UID of the content element - the resulting path to the template file - and the exception message Resolves: #87015 Releases: master, 8.7 Change-Id: I2cd100a5140a07845145b16259b7cbe3e5eed852 Reviewed-on: https://review.typo3.org/58960 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
-
- 14 Nov, 2018 1 commit
-
-
In case a content element is added with TsConfig its label can't be loaded from TCA but the TsConfig must be checked. Resolves: #86909 Releases: master, 8.7 Change-Id: I2de2b73dcd4799a45aece330f377e86bd2bf596f Reviewed-on: https://review.typo3.org/58889 Reviewed-by:
Soren Malling <soren@meteko.dk> Tested-by:
-
- 05 Nov, 2018 1 commit
-
-
Adds a new method HttpUtility::buildQueryString() using http_build_query() instead of reimplementing the encoding-process like the old method GeneralUtility::implodeArrayForUrl() did. As the parameter $rawurlencodeParamName of implodeArrayForUrl() was set to "false" by default and used in several places without manually setting it to "true" using that method could lead to potentially unsafe non-encoded parameter names. Some unit-tests had wrong URLs with non-encoded braces [...], which were adapted to be properly escaped as well. Resolves: #83334 Releases: master Change-Id: Ifbaad912f0d658671356dc7bdf1579dacff272df Reviewed-on: https://review.typo3.org/55079 Reviewed-by:
-
- 02 Nov, 2018 1 commit
-
-
Change cursor type to "move" hovering content elements if you are in page module and in language view. Same as in columns view in page module. Resolves: #86820 Releases: master Change-Id: Ib176fb4b415d8b9a64548c48aa0e9fc6f9077c26 Reviewed-on: https://review.typo3.org/58816 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
- 29 Oct, 2018 1 commit
-
-
In case of paging in any record list, the page browser is rendered in top and on bottom of ther record list. The upper browser now renders the paging correctly by calculating the offset of items of the previous page instead of hard-coding a "1". Resolves: #86787 Releases: master, 8.7 Change-Id: Ib7c8856f248107ea9d17aeabe83a564189f69abf Reviewed-on: https://review.typo3.org/58779 Tested-by:
-
- 27 Oct, 2018 1 commit
-
-
Resolves: #86754 Releases: master Change-Id: I2bb3226595e53ed993e0114130123e4f87f1603b Reviewed-on: https://review.typo3.org/58712 Tested-by:
-
- 01 Oct, 2018 2 commits
-
-
Make sure that in most places any site related exception is handled in a graceful way to avoid negative UX. Resolves: #86522 Releases: master Change-Id: I3b0d7f9ce63351f8dd7bb6b4988704fc8a3d0a9f Reviewed-on: https://review.typo3.org/58537 Reviewed-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Jurian Janssen <jurian.janssen@gmail.com> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:backend (except ViewHelpers) - EXT:beuser - EXT:about - EXT:belog All @api methods have been removed. Resolves: #86505 Releases: master Change-Id: I1fd1e16f7885e81fb994999e5873a1a3a1aa6c3b Reviewed-on: https://review.typo3.org/58524 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- 30 Sep, 2018 1 commit
-
-
This patch streamlines all deprecation messages and follow the following rules. 1. All @deprecated should contain @deprecated since TYPO3 xx, will be removed in TYPO3 v10.0 (not "core v10" or just "v10" 2. trigger_error() - All trigger_error() messages MUST end with a "." (dot). - Never use "This method" but the method name (enjoy the logs otherwise) - "has been deprecated" can be spared - we KNOW it's deprecated once its in the deprecation log. Instead "Will be removed in TYPO3 v10.0" SHOULD be in the log file. - Do not use "__METHOD__" or some other "magic". Resolves: #86488 Releases: master Change-Id: I6a34593ff89ecafe649366d60d725daa3aa6676c Reviewed-on: https://review.typo3.org/58494 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 29 Sep, 2018 1 commit
-
-
The phpDoc comment "@internal" is used in most places during the development of TYPO3 v7, TYPO3 v8 and TYPO3 v9 and denotes that this specific method, class or property is not part of the Public API, and does not even need any notice if it is removed. However, we still have/had various places in TYPO3 core where "@access private" was used. This is now migrated to "@internal". "@access public" is not needed and is removed. Resolves: #86446 Releases: master Change-Id: Iaef206b04aee13c280d62b107dd7eac04a38c700 Reviewed-on: https://review.typo3.org/58462 Reviewed-by:
-
- 20 Sep, 2018 2 commits
-
-
Implement the page ID in pagetree and localization overview. And make it controllable with User TS Config. Resolves: #86269 Releases: master Change-Id: Ie6fc1824aa3ecc781d3386017744c58604fb36e4 Reviewed-on: https://review.typo3.org/58295 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
If user is logged in as admin, the edit buttons are always displayed. Resolves: #86277 Releases: master Change-Id: I80f96df09c2f4fab886e03cf5aa4cb91cb1bf06c Reviewed-on: https://review.typo3.org/58296 Tested-by:
-
- 19 Sep, 2018 1 commit
-
-
This patch calls the paste modal with the severity level "warning" to improve the UX between the page and the list backend module while pasting e.g. a content element record. Releases: master Resolves: #86316 Change-Id: I7f58a3b6e3c5d87fc91b6a4d61457d32e125f118 Reviewed-on: https://review.typo3.org/58334 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- 02 Sep, 2018 2 commits
-
-
Resolves: #86084 Releases: master Change-Id: I6ebbe0756d799a3c04386c854f6e5e385eeac54f Reviewed-on: https://review.typo3.org/58124 Tested-by:
-
strpos will use only CPU resources, substr also needs memory allocation. Resolves: #85477 Releases: master Change-Id: Ic25c99986f7e2e7237c10acaa75be8d0f6289f13 Reviewed-on: https://review.typo3.org/57466 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 30 Aug, 2018 1 commit
-
-
A content element can once again be pasted directly at a specific position with the help of the paste button when in the "languages" mode. Releases: master, 8.7 Resolves: #85911 Change-Id: I08e48361b45c4cffaf83c4b7b92f70303ab8babf Reviewed-on: https://review.typo3.org/57971 Reviewed-by:
-
- 27 Aug, 2018 1 commit
-
-
A series of unused and dead code places are fixed with the patch: * Switch + return + break -> the break is obsolete * A couple of 'too many arguments' when calling methods * Various assignments of variables that are never used Change-Id: I8472597f73a739bce053cf6de772c111ae7044d7 Resolves: #85993 Releases: master Reviewed-on: https://review.typo3.org/58047 Reviewed-by:
-
- 22 Aug, 2018 2 commits
-
-
In order to avoid usages of using PseudoSite objects directly, the following changes have been made: The main entrypoint for finding sites is now encapsulated the SiteMatcher class. * SiteMatcher->matchByPageId($pageId) which consistently checks for Sites and Pseudo Sites. This is now a singleton as it factors PseudoSiteFinder directly. * NullSite for PID=0 (which is a slim version of a PseudoSite and will stay around for longer than the PseudoSite). This marks the last part of the Site API functionality, as TYPO3 is now ready to work with the Site API in all places throughout Frontend and Backend. Resolves: #85930 Releases: master Change-Id: I5e75da22337e126a39b459388e21d7f9fe05e556 Reviewed-on: https://review.typo3.org/57992 Reviewed-by:
-
Instead of rendering all languages, only the ones provided by the site module are now shown in forms of the FormEngine, in the List module, the Info->Translation Overview and the Page module. Fallbacks to pseudo sites are considered if no site configuration for a page / page tree exists. Resolves: #85164 Releases: master Change-Id: I95b394cd3a31773e62f7e2cc40197aceb97705d8 Reviewed-on: https://review.typo3.org/57672 Reviewed-by:
-
- 21 Aug, 2018 1 commit
-
-
Replace _GP, getIndpEnv usages with request related functions. Also deprecate public access to all method except the entry point. Resolves: #84375 Releases: master Change-Id: I8050afe519dcbabfd6381c55844c81713482687e Reviewed-on: https://review.typo3.org/57329 Reviewed-by:
-
- 19 Aug, 2018 1 commit
-
-
Resolves: #85891 Releases: master Change-Id: Ie848059591cb69d9e6fad6c2c6275b9655e6ff87 Reviewed-on: https://review.typo3.org/57948 Tested-by:
-
- 11 Aug, 2018 1 commit
-
-
Resolves: #85802 Releases: master Change-Id: I878bb4552ae8709ed4a1ec32afdfbfd7abaaa2e6 Reviewed-on: https://review.typo3.org/57854 Tested-by:
-
- 26 Jul, 2018 1 commit
-
-
Use same ordering for content elements in the page module for the default language and translations. Resolves: #85631 Releases: master Change-Id: Ibbbb0dd813a5ad9211737bbc07ca84b766a2abfa Reviewed-on: https://review.typo3.org/57673 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- 31 May, 2018 1 commit
-
-
Concerning the usage of Statement::rowCount() the Doctrine DBAL documentation states the following: Returns the number of rows affected by the last DELETE, INSERT, or UPDATE statement executed by the corresponding object. For default configurations using MySQL as platform, rowCount() is returning the expected value for SELECT statements as well. However, on other DBMS this value will be zero as mentioned in the documentation - for instance SQLite is a candidate for that. For retrieving the row count for given criteria, the count() expression has to be used explicitly. Resolves: #78129 Releases: master Change-Id: Id28d72a1a21e8615ec45b63d4aecc100d03a39a3 Reviewed-on: https://review.typo3.org/50083 Reviewed-by:
-
- 17 May, 2018 1 commit
-
-
The localization wizard in the page module offers now a global translate action per page only. With this change, a user isn't anymore able to translate content on column basis. This streamlines the localization process as it lowers the risk of creating broken localization setups (a.k.a "mixed mode") and it will simplify the upcoming "Change mode" wizard that enables to switch between "Free" and "Connected" modes. Resolves: #84877 Releases: master Change-Id: Ibfd4641c5a8d3622c86b5a8657af00b2b3122503 Reviewed-on: https://review.typo3.org/56813 Tested-by:
-
- 16 May, 2018 1 commit
-
-
Christian Kuhn authored
Final patch to de-mess the user / page TSconfig related API. Page TSconfig can be overriden in user TSconfig by prefixing the path with 'page.' in user TSconfig. However, method BackendUtility::getModTSconfig() violated this principle and had a special merge strategy that allowed ommitting the 'page.' prefix. This has been marked as deprecated in the TSconfig docs for various years and has been lately removed in the docs altogether, but the code still existed. The patch moves this merge into BackendUtility::getPagesTSconfig() and properly deprecates this case. Usages of getModTSconfig() are changed to use getPagesTSconfig() directly, dropping the artificial 'properties' and 'value' sub arrays and omitting some rather expensive string operations at the same time. This obsoletes getModTSconfig() and a couple of related methods. Additionally, BackendUserAuthentication->getTSConfig() has been abused frequently to operate on different arrays than it's own userTS. Those usages are dropped with the patch. Handing over arguments to getTSConfig() is now deprecated, effectively reducing the method a getter. This reduces the API down to BackendUtility::getPagesTSconfig($pid) and BackendUserAuhtentiction->getTSConfig() both just returning the entire array. This simplified API can now be documented in the docs. Change-Id: I4bbb066c1d4e2edbc0182f7967897a1558cc3c0d Resolves: #85016 Related: #84982 Releases: master Reviewed-on: https://review.typo3.org/56968 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 13 May, 2018 1 commit
-
-
The patch deprecates BackendUserAuthentication->getTSConfigVal() and ->getTSConfigProp() and adapts usages to rely on getTSConfig() without arguments. The array nesting is done directly within consuming code and is combined with ?? to a fallback value. Advantages: * Expensive and recursive string operations within getTSConfig() are not used anymore. * The weird 'value' / 'property' based sub array juggling is gone. * Full TSconfig path including fallback can be easily seen within consuming code * Notice free array access using null coalescence operator Change-Id: I6d5777ebd533dcfdc6018e0226bfb3e513cfa652 Resolves: #84993 Related: #84982 Releases: master Reviewed-on: https://review.typo3.org/56953 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- 12 May, 2018 1 commit
-
-
The option is meant to show translated content elements alligned with their translation parent element (connected mode). However this also made content elements diasppear, which were added individually in a language (free mode). With this change, elements for a language in free mode are also shown, when the option is set. Resolves: #62550 Releases: master, 8.7 Change-Id: I96f754ecf4ddb98f22d0d8c7d7da6001fa774d6b Reviewed-on: https://review.typo3.org/54654 Reviewed-by:
-
- 25 Apr, 2018 1 commit
-
-
This commit moves any language file of EXT:lang into a proper destination, which renders EXT:lang obsolete. This change requires an update of typo3/testing-framework, done with this command: composer update typo3/testing-framework Resolves: #84680 Releases: master Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d Reviewed-on: https://review.typo3.org/56017 Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
- 04 Apr, 2018 1 commit
-
-
Check if there is actually content provided to build the footer of content elements in the page module. Resolves: #84602 Releases: master, 8.7 Change-Id: Ic2be8eed03b7ed06bc6f048f5e56854e5155615c Reviewed-on: https://review.typo3.org/56550 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- 17 Mar, 2018 1 commit
-
-
Christian Kuhn authored
Class TYPO3\CMS\Recordlist\RecordList is the list module main controller and thus should be rename to TYPO3\CMS\Recordlist\Controller\RecordListController Resolves: #84399 Releases: master Change-Id: I77ca1c2f9841e234bde2dd571d8875db5c0e0b14 Reviewed-on: https://review.typo3.org/56275 Tested-by:
-
