This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 31 Jan, 2017 1 commit
-
-
Remove additional lines around the actual content of a textarea. Resolves: #79573 Releases: master Change-Id: I636afb0ec63d34d4a209caeaa1369bc65727665d Reviewed-on: https://review.typo3.org/51490 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 28 Jan, 2017 1 commit
-
-
Use tooltips instead of ancient JavaScript alerts for locked records. Resolves: #79422 Releases: master Change-Id: Ia9911f8eaad1c55c2af14e366af13e0e9b7b21df Reviewed-on: https://review.typo3.org/51387 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- 27 Jan, 2017 1 commit
-
-
Introduce a new class `OrderedProviderList` which calls providers with dependencies given by setter. Resolves: #79512 Releases: master Change-Id: Icf97e2e6fa5ed88d7b76b7628bb4e9790b615a38 Reviewed-on: https://review.typo3.org/51443 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- 26 Jan, 2017 1 commit
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a pretty huge list of TCA changes and simplifications, all TCA changes are supported by TCA migration, so existing extensions should benefit out of the box and just get deprecations logged. Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab Resolves: #79440 Resolves: #70032 Releases: master Reviewed-on: https://review.typo3.org/51151 Tested-by:
-
- 25 Jan, 2017 1 commit
-
-
With the update of cs-fixer to version 2.0, some checks got minor changes in behaviour. The core follows now in applying those suggested changes. Resolves: #79469 Relates: #79361 Releases: master Change-Id: I5d17b750231dcb386002b3e46b3a89c59eca2989 Reviewed-on: https://review.typo3.org/51428 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- 23 Jan, 2017 1 commit
-
-
Multiline content is displayed in a textarea "as is" by the browser. There is no need to add <br> tags. Resolves: #79399 Releases: master, 7.6 Change-Id: Ia628457231a15318dff4fe36f5d3cd3d990d7dc7 Reviewed-on: https://review.typo3.org/51372 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 18 Jan, 2017 1 commit
-
-
Tags must not be stripped away for creating diffs as those are essential for editors. Otherwise it is not possible to see changed links or changing a header from h1 to h2. Resolves: #78767 Resolves: #79205 Releases: master, 7.6 Change-Id: Icb174f3522354fa8ef5d2b8ccca039e33ef472e7 Reviewed-on: https://review.typo3.org/51220 Tested-by:
-
- 17 Jan, 2017 1 commit
-
-
Configuring a richtext field in TCA with the "defaultExtras" setting (which was formerly the 5th showitem parameter) has been ugly ever since: The DataHandler needed a special _TRANSFORM_ field to trigger required RTE transformations, further config depends on pageTs settings. The patch gets rid of "defaultExtras" for richtext elements and adds a new option "enableRichtext=true" within the config section for type=text TCA fields. This setting can be set via "columnsOverrides" for specific types, too. As an intermediate solution, the configuration class "Richtext" is added to fetch richtext configuration. This will be extended with another patch to provide ckeditor configuration on TCA level. Change-Id: I70f4cb26e2a45629b99680e532d376538afd2b90 Resolves: #79341 Releases: master Reviewed-on: https://review.typo3.org/51311 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- 11 Jan, 2017 1 commit
-
-
The TCA setting "l10n_mode=mergeIfNotBlank" for a single column is removed from the list of values. The functionality was there to use the value of a field of the original record, if the value of the translated record is empty (or trim'ed empty), and is then overlaid. The new behaviour is to duplicate the behaviour during the localize process, and then completely separate. As a result the related TypoScript setting config.sys_language_softMergeIfNotBlank is not required anymore and is removed as well. Resolves: #79243 Releases: master Change-Id: I55f3ebd2fe2ddd8412101d5496a0da3c5ab64c68 Reviewed-on: https://review.typo3.org/51239 Tested-by:
-
- 04 Jan, 2017 1 commit
-
-
The sort top/bottom buttons in group element no longer depend on the number of selected items. This is inconvenient anyway since these sorting buttons only appeared after saving when a bunch of items was selected, but not immediately. The patch additionally fixes a failing acceptance test. Change-Id: Ice0d179e7c74c3a1227c727c672b40844d6852c8 Resolves: #79149 Related: #78899 Releases: master Reviewed-on: https://review.typo3.org/51111 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 03 Jan, 2017 1 commit
-
-
The patch adapts a series of nasty form engine areas to more solid code. The evaluate condition code is rewritten and works much better in flex form scenarios. The suggest wizard and svg tree are much more solid in flex forms. The group element is rewritten towards a better readable and easier to refactor code, dropping method dbFileIcons(). A bunch of issues is resolved along the way. * TCA "default" now works in flex form section container elements * The "displayCond" parser is now strict and throws exceptions on invalid syntax and wrong referenced fields to help debugging faulty display conditions * TCA displayCond on flex fields can now be prefixed with the sheet name and can reference field values from neighbor sheets * TCA displayCond now works with flex section containers * TCA flex section container now throw an exception if select or group fields configure a MM relation - this is not supported * TCA ctrl requestUpdate field is dropped, onChange=reload is now allowed not only on flex form fields, but also on normal columns fields * TCA tree now works as section container element and initializes correctly on new records and new containers * GroupElement rewrite to drop dbFileIcons() * config option maxitems now optional for type=group and type=select and defaults to "many items allowed" * inline now works in "fancy" flex situations with "new" records by handing the final dataStructureIdentifier around * FormEngine no longer loads extJS Change-Id: Id1d081627529cc1502bb198389e5bd69372815cd Resolves: #78899 Resolves: #72307 Resolves: #75646 Resolves: #76637 Resolves: #72106 Resolves: #78824 Resolves: #76793 Resolves: #68247 Resolves: #69715 Related: #78460 Related: #67198 Related: #72294 Releases: master Reviewed-on: https://review.typo3.org/50879 Tested-by:
-
- 20 Dec, 2016 2 commits
-
-
Use the select options label as title instead of an uninitialized variable. Resolves: #79037 Releases: master, 7.6 Change-Id: I690b687f5dd854556ac799d89c8462f4ce9966a4 Reviewed-on: https://review.typo3.org/50997 Tested-by:
-
Adding the root paths to the partials, which aren't autoguessed anymore. Resolves: #78969 Releases: master Change-Id: I578fd21ed0b232198301f73c702569980ed82906 Reviewed-on: https://review.typo3.org/50948 Tested-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- 13 Dec, 2016 1 commit
-
-
The copied methods from ArrayUtility can be removed and be replaced with some PHP native functionality or the equivalent functionality. Resolves: #77732 Releases: master Change-Id: I6c5f4bced77f40f5000d8fb0abb151d54fbc1c8e Reviewed-on: https://review.typo3.org/49696 Tested-by:
-
- 07 Dec, 2016 1 commit
-
-
Christian Kuhn authored
The patch changes the ajax result that delivers TCA tree items to the SVG tree from a nested list of items to a sorted flat list having a 'depth' argument to indicate the nesting level. This "flat" list is the native mode of the d3 tree, with this change the JS side can be streamlined quite a bit. Along the way, the item providing on PHP side is streamlined, documented much better and easier to understand now within the data provider of FormEngine. The main tree data backend is still a huge, convoluted, slow and insane mess that will eventually fully substituted with a much straighter and quicker approach later. Changes in this area are kept to a minimum for now. Change-Id: Ib64b7277f671b632be3977218e5465b534618d63 Resolves: #78905 Related: #76108 Releases: master Reviewed-on: https://review.typo3.org/50813 Reviewed-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
-
- 03 Dec, 2016 2 commits
-
-
This reverts commit 36f8765a. Change-Id: Ida5c32b33e8953bd1172c9886af16b66e3c2297f Reviewed-on: https://review.typo3.org/50878 Reviewed-by:
-
Allow the the method CategoryRegistry->getCategoryFieldItems() to be used as itemsProcFunc for select fields in the TCA in arbitary contexts by introducing a new categoryFieldsTable configuration in the config section of a column in the TCA. This configuration key can either consist of a single string containing the name of the table or a configuration array to define additional conditions that need to be true so that a configured table is used. The condition matching is based on the displayCond functionality of the TCA. To make use of the existing functionality the code for matching the display conditions is extracted from the form data provider to a new DisplayConditionEvaluator utility class. Resolves: #53045 Releases: master Change-Id: I128cbeb6747a8f83e68cdaaaafbc3ab5901353d4 Reviewed-on: https://review.typo3.org/24968 Tested-by:
-
- 02 Dec, 2016 4 commits
-
-
This changes the internal date processing for FormEngine and DataHandler to use ISO-8601 dates including a proper timezone. Dates are converted to ISO-8601 as early as possible and converted back to UNIX timestamps as late as possible. As before, the database values are always values in the server’s timezone, interpreted as UTC. Also, the client side inputs are interpreted as UTC. The main advantage is that once and for all we get rid of the timezone issues that may potentially arise if the server and client use different timezones. Additionally, the values are human readable (which is of course not so much of an issue for hidden fields) and we can directly use Moment.js for all heavy lifting. Another big advantage is that we can make the date formats configurable and decouple displayed dates and internally stored dates (by putting the Moment objects to the input fields). Change-Id: I3461915c2beaa96cd29c52c60e65a2e5005065b7 Resolves: #77702 Releases: master Reviewed-on: https://review.typo3.org/47124 Reviewed-by:
-
IRRE records have to point to their specific localized parent record. This works in general for tables containing records of the default language as well as localizations. For the "pages" table this look-up has to be extended to query from "pages_language_overlay". Change-Id: I84b6ee9304f85222430a5bdf62bd2271aae68fd5 Resolves: #76174 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/48495 Tested-by:
-
The suggest wizard does not work in FormEngine flex form section containers for existing containers. The patch splits the ajax controller action and the FormEngine wizard display into two classes to have a dedicated entry point for the ajax action and refactors the flex form field configuration search logic to find the correct configuration for existing containers, too. Change-Id: Ia870618629943b1f3c665cb3a10a7f3769a02540 Resolves: #78558 Releases: master Reviewed-on: https://review.typo3.org/50839 Tested-by:
Valentin Funk <valentin.funk@computerfabrik.de> Reviewed-by:
-
The new flex form data structure handling in more picky and throws exception if a given data structure identifier can not be resolved. The FormEngine logic that displays exclude fields of flex forms has to do some guess work to find possible data structures. This may fail, resulting in an exception. The patch changes the according general exception to a specific one, catches it in the find flex form access rights logic, and adds more docu on what exactly is happening in this code. Change-Id: I2b808cbe804ba4ab967c8d95b17c0a12ec65ffd4 Resolves: #78852 Related: #78581 Releases: master Reviewed-on: https://review.typo3.org/50820 Tested-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Alexander Rothmund <alexander@rothmund.ch> Tested-by:
-
- 01 Dec, 2016 2 commits
-
-
Remove support for transForeignTable and transOrigPointerTable in TCA. More details in Breaking-78191-RemoveSupportForTransForeignTableInTCA.rst Resolves: #78191 Releases: master Change-Id: Ibd7e1a963fdbf84ca7f4b5926b4a8cd02ba24631 Reviewed-on: https://review.typo3.org/50819 Reviewed-by:
-
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
-
- 18 Nov, 2016 3 commits
-
-
This allows to configure the ordering cirteria for suggest wizard search results. Resolves: #78523 Releases: master Change-Id: I4bbcbeab765b037ba3b3457a2bc9ca3323f95f59 Reviewed-on: https://review.typo3.org/50460 Tested-by:
-
If an invalid extension name is passed to a 'EXT:...' path, the GeneralUtility::getFileAbsFileName function returns an empty string. This results in a scan of '\' in the first place, and the resulting error is not helpful for finding the source of the missing icons in the TCA select box. A check for a valid directory name and an exception in case of failure will help the situation. Resolves: #78737 Releases: master, 7.6 Change-Id: I9d5159eac9b511e879144789eecb40eafcc0288c Reviewed-on: https://review.typo3.org/50699 Reviewed-by:
-
The patch refactors the TCA tree form engine data calculation. The tree now works with "new" (not yet persisted) records, even if the record has types in combination with flex forms. For instance, a new ext:news tt_content element now renders the category tree within flex forms, even in new tt_content records that have not been saved. The TCA tree no longer fetches all items when opening a record initially, but defers that to the ajax request. This gives a massive performance improvement on initial load of a record if the displayed TCA tree is bigger. The ajax request itself now compiles only data of the requested TCA field, also resulting in a significant performance improvement. As example, ext:styleguide "elements select" is now rendered much quicker and the single ajax calls per tree are reduced from about 4 seconds to less than a second each with my test data. Change-Id: If3c4c1779f5fe1510ffc13d1c9f1151bddab13e9 Resolves: #78744 Releases: master Reviewed-on: https://review.typo3.org/50700 Reviewed-by:
-
- 17 Nov, 2016 1 commit
-
-
Move all CSH language files from ext:lang to Resources/Private/Language Resolves: #78648 Releases: master Change-Id: I88102b1291b1628e91a5e0ee9c54d648d0160a51 Reviewed-on: https://review.typo3.org/50585 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- 13 Nov, 2016 1 commit
-
-
Adding items for type selectTree with pageTsConfig does not work as documented. The TCA tree needs multi-root handling to handle that. Additionally, some slight changes in the order of elements when items are calculated are needed. Resolves: #78628 Releases: master Change-Id: Iecf0225c0eeaab8ea661997cad26e68d255d8460 Reviewed-on: https://review.typo3.org/50565 Tested-by:
-
- 12 Nov, 2016 1 commit
-
-
Markus Klein authored
Adding an empty alert message to the fieldChangeFunc array causes the fieldChangeFunc_hash to mismatch when pagination or search is used in the link browser popup. Add a check for an empty value, which is already present in another place in Core. Resolves: #75743 Releases: master, 7.6 Change-Id: I1a15400960d577c1a2a0a905643b56533d957100 Reviewed-on: https://review.typo3.org/50586 Tested-by:
-
- 09 Nov, 2016 1 commit
-
-
Transmitting the full $row in suggest wizard was introduced to find the relevant flex form data structure in the ajax search action to determine the suggest wizard field configuration The patch adds the data structure identifier instead, the searchAction() uses that to fetch the specified flex form data structure directly. Additionally, field values relevant for the ajax call are now signed with hmac and checked in searchAction(). Change-Id: Ibb5004d4d11487fe999072999c7ce2f847aac750 Resolves: #78616 Related: #78581 Releases: master Reviewed-on: https://review.typo3.org/50544 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 08 Nov, 2016 1 commit
-
-
Use the native PHP method strpos instead of StringUtility::beginsWith method. The beginsWith method runtime compared to a simple strpos check is much higher. Resolves: #78602 Releases: master Change-Id: I608ed791ddd770a8de493e0796387a18b22ff2ce Reviewed-on: https://review.typo3.org/50534 Reviewed-by:
-
- 07 Nov, 2016 1 commit
-
-
Method BackendUtility::getFlexFormDS() does two things at once: It finds a data structure by given data (TCA, row, ...) and then parses it. This construct gives tons of headaches, since the methods never exposes where a specific data structure came from and the lookup mechanism is complex. Especially if a flex form is used in combination with ajax requests later, the core has massive issues since the location can not be found out later again. To solve that, the patch splits getFlexFormDS() into two methods: First method "FlexFormTools->getDataStructureIdentifier()" gets TCA and row and locates a specific structure. It returns an "identifier" that points to that unique data structure. This identifier can be later hand around easily. The second method "FlexFormTools->parseDataStructureByIdentifier()" then gets this identifier again, fetches the data structure the identifier points to, and parses it. Change-Id: I38264e8a4a6f956c12e9e50f6039d3d09af0f03a Resolves: #78581 Releases: master Reviewed-on: https://review.typo3.org/48212 Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
- 05 Nov, 2016 1 commit
-
-
The old class name is still in use in the core, replace them with the new name DataHandler. Resolves: #78550 Releases: master Change-Id: I324e7b3037f8bf8df70d5c8db37d62a01ed710a4 Reviewed-on: https://review.typo3.org/50485 Reviewed-by:
-
- 31 Oct, 2016 1 commit
-
-
The icon rendering of custom page options was lost during refactoring of the ItemProviders. Resolves: #77075 Releases: master, 7.6 Change-Id: Iae6415525d94fc56c48332de9e5bc3980344fbc2 Reviewed-on: https://review.typo3.org/48967 Tested-by:
-
- 26 Oct, 2016 3 commits
-
-
Resolves: #78420 Releases: master Change-Id: I2d3ea1c0f3bda176f68da62f5d379e4af0647494 Reviewed-on: https://review.typo3.org/50361 Tested-by:
-
The TCA type "imageManipulation" has a boolean config called "enableZoom". As declared in "ImageManipulationElement" this config will be added to the "ImageManipulationWizard" wizardData in a key called "zoom". But "ImageManipulationWizard" assigns a non existing key "bool". So "enableZoom" set to true or false will always result in false. Releases: master, 7.6 Resolves: #78444 Change-Id: I7580927d4edeec246d71ade32497d34ba107589d Reviewed-on: https://review.typo3.org/50386 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- 24 Oct, 2016 1 commit
-
-
There are two FormEngine data provider for type=select: TcaSelectItems for "normal" renderTypes and TcaSelectTreeItems for renderType="selectTree". While this is hacky in the first place - the data provider should not depend on renderType at all but only on type, this can not be changed easily and a real solution is to make "trees" an own type instead, later. However, if extensions add a new renderType for select at the moment, the normal TcaSelectItems data provider does not kick in since it is restricted to the known renderTypes. This is usually not what an extension wants, typically just the rendering is different while the data providing from TcaSelectItems is used. The patch allows this by now blacklisting "selectTree" in TcaSelectItems instead of whitelisting the known types. Change-Id: Ic71177e22b191a5abee90a7cfb9871167fe4611e Resolves: #78381 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50325 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Mamadou Mbow <mmbow@dfau.de> Tested-by:
-
- 20 Oct, 2016 1 commit
-
-
If the first palette of a form is hidden, a tiny line is append under the tab title. This patch removes it. Resolves: #78327 Releases: master, 7.6 Change-Id: Ibf0f3b9ed243a3d30de9bb726b17ffdec8414c65 Reviewed-on: https://review.typo3.org/50295 Tested-by:
Jérémie Roulin <jeremie@hemmer.ch> Tested-by:
-
- 09 Oct, 2016 1 commit
-
-
Resolves: #77819 Releases: master Change-Id: If39540863a1114ce5ce3e57289da54bdfdffc4f2 Reviewed-on: https://review.typo3.org/49764 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Reviewed-by:
-
