GitLab

Benni Mack authored Mar 10, 2021 and Georg Ringer committed Mar 10, 2021

This patch provides the following changes in order to
have better abstractions and encapsulate the dependencies
of each implementation.

1. SelectTree (Category Tree)

The TreeToolbar is now clearly coupled into the SelectTree
and built as LitElement inside the SelectTreeElement.

SelectTree now contains all relevant functionality
regarding selecting multiple items, and shows settings
(SelectTreeSettings) which were only used in SelectTree.

This is especially relevant for the multiple item selection,
and the exclusiveKey handling.

2. PageTree + FileStorageTree
Obsolete public methods are removed, and visibility is changed.
Filtering is now separated in favor of a non-public property.
By using Types (in e.g. PageTreeDragDrop) the visibility is also adapted
Obsolete wrapper methods are removed.

Resolves: #93692
Releases: master
Change-Id: Ifead098bb80e37d5c7ad5e1d0eabda14aa7087ce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68303

Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

Benni Mack authored Feb 08, 2021 and Georg Ringer committed Feb 09, 2021

This change migrates all left-over components of
* SvgTree
* SelectTree (a.k.a. CategoryTree)
* and PageTree

to TypeScript adding types in various places
to make the code less error-prone.

Resolves: #87678
Resolves: #85400
Releases: master
Change-Id: Ibb4024d365857c44018a7a201c1cf75baa48179a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67662

Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

This change migrate the TreeToolbar (used in FormEngine
Category Tree for example) to TypeScript,
removing effectively one RequireJS call and replacing
it with a native TypeScript component.

Removing the rest of the jQuery will be part of a
separate effort.

Resolves: #93432
Releases: master
Change-Id: I3df66cd1c28d096c0f32982347dbd37c58834e4d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67640

Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>

SelectTreeElement makes use of $.param() without importing
jquery via requireJS. Instead of adding the missing jquery
import, we simply migrate to the native URLSearchParams,
as it is available in all supported browsers.

Furthermore we avoid decoding the datastructureidentifier
json, as it is encoded to json server side. We do this,
because URLSearchParams does not url encode nested objects.

Resolves: #93200
Releases: master
Change-Id: I0da98092da6e09d6576bbdb59112d738086be238
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67323

Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>

Andreas Fernandez authored May 01, 2020 and Daniel Goerz committed May 09, 2020

It's safe to use getElementById() instead of querySelector() in case an
element is fetched by its ID.

Numbers for nerds:
getElementById() is nearly 1.5x faster than querySelector(). To be fair,
both functions are really fast with executing multiple million operations
per second, thus nobody will notice a performance impact.
See https://www.measurethat.net/Benchmarks/ShowResult/106740

Resolves: #91254
Related: #91183
Releases: master
Change-Id: I2ed590d20c9af66ce818f012ac73ec45c5c9fa55
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64384

Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>

Andreas Fernandez authored Mar 23, 2019 and Anja Leichsenring committed Apr 13, 2019

This patch migrates FormEngine's SelectElementTree to TypeScript.
Also, a terrible hack that puts the local tree initialitation callback
into global scope has been removed.

Resolves: #87987
Releases: master
Change-Id: Ib34ae7fe4ac1e197af2183b8890cc72e13a900e9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60316

Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Steffen Frese <steffenf14@gmail.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>