This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 11 Mar, 2021 1 commit
-
-
The MFA TOTP provider is based on a shared secret. Therefore, to set this provider up, the secret has to be exchanged between TYPO3 and the corresponding OTP application or device. This can either be done by: * Scanning the QR code * Entering the shared secret directly While the shared secret does not contain any additional data, the QR code contains the so-called otpauth URL, a common URI scheme, accepted by most OTP applications. This URL features additional information like the issuer and the related account. To improve the usability, the user is now able to also access this URL directly through a new modal with further explanation. Resolves: #93666 Releases: master Change-Id: I27dc805bcca7aeb29d15a5c20223426999277625 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68293 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 10 Mar, 2021 2 commits
-
-
Benni Mack authored
As the temporary mount point functionality is not bound to the actual PageTree, but the navigation component, this code is now moved outside of the PageTree, and using lit-based rendering and proper event handling. The advantages of this change are that the SVG Tree / PageTree component - does not access HTML outside its own wrapper (parentNode) - the mount point information is now rendered via LIT (= automatically updated) - additional setting "temporaryMountPointPath" is not needed inside the PageTree anymore - We also now use <typo3-backend-icon> and the $lll lit helper Resolves: #93697 Releases: master Change-Id: Idaa56f12e6d1444a1abdf23d2a37b71948d47023 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68307 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Daniel Sattler <sattler@b13.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
This patch provides the following changes in order to have better abstractions and encapsulate the dependencies of each implementation. 1. SelectTree (Category Tree) The TreeToolbar is now clearly coupled into the SelectTree and built as LitElement inside the SelectTreeElement. SelectTree now contains all relevant functionality regarding selecting multiple items, and shows settings (SelectTreeSettings) which were only used in SelectTree. This is especially relevant for the multiple item selection, and the exclusiveKey handling. 2. PageTree + FileStorageTree Obsolete public methods are removed, and visibility is changed. Filtering is now separated in favor of a non-public property. By using Types (in e.g. PageTreeDragDrop) the visibility is also adapted Obsolete wrapper methods are removed. Resolves: #93692 Releases: master Change-Id: Ifead098bb80e37d5c7ad5e1d0eabda14aa7087ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68303 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 09 Mar, 2021 2 commits
-
-
Native HTMLElements are more versatile than a the current NavigationComponent interface. All custom actions can be dispatched via events, that means the NavigationComponent interface, as recently introduced in #93672, is removed again. Resolves: #93685 Releases: master Change-Id: I578810ce655d1da3f34bcb456967f62756793b24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68233 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
With the update to Bootstrap 5 the CSS class name for animated progress bars changed from `active` to `progress-bar-animated`. This patch updates the wrong class names accordingly. Resolves: #93682 Releases: master Change-Id: If8f4e388513822f0457afa2a37d88ed440f6d709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68259 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 08 Mar, 2021 2 commits
-
-
If a label is too long, which is especially possible if the field name is shown, it should wrap into new lines. Resolves: #93462 Releases: master, 10.4 Change-Id: I6150e4c62e06b28c952f8b9f4f71115ffedd4401 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68189 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
In order to use the non-iframe navigation component properly, the current ties to "PageTree" (which was de-facto the only possible navigation component to be used until TYPO3 v11 due to heavy coupling) are removed. The TreeInterface, which served as a wrapper for the PageTree Navigation Component is removed, and replaced by the NavigationComponent interface in TypeScript. In addition, loading and initializing (and keeping state) of the used navigation component now solely relies in the NavigationContainer. This in turn, finally allows to e.g. properly re-load the FileStorageTree and PageTree separately (see BackendUtility change) while incorporating some ES6 nullable functionality. In addition, the NavigationContainer is now jQuery-free. Resolves: #93672 Releases: master Change-Id: Ia16a3e789459225b21fa12efd1db6f3b4500cfef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68201 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 03 Mar, 2021 1 commit
-
-
Accessing the workspace module while in live workspace led to a JavaScript TypeError. This is fixed by proper type checking. Resolves: #93625 Releases: master, 10.4 Change-Id: Ief2f484f197ce068660dffc1751618fbc17c0cd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68165 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 02 Mar, 2021 1 commit
-
-
The workspace module features the element information modal, which displays, next to the record history, the current version records' difference to its live record. This difference is now also displayed for new and delete placeholder records. It's not reasonable forcing the user to always open the complete record to have a quick look at the values of e.g. a new record. Since new / delete placeholders basically contain all fields, defined in TCA, they are filtered using the FormDataCompiler to only show the suitable ones. Resolves: #93620 Releases: master, 10.4 Change-Id: Ib58d568664e3aecb13afa023c0e05f188662811d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68156 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 01 Mar, 2021 1 commit
-
-
The component is provided as replacement for the current lit-helper `icon()` which cannot provide support for icon usage inside shadow dom elements. The component renders all icons as inline SVGs. FontawesomeIconProvider is therefore adapted to provide inline rendered SVGs for font-awesome icons. Not that these inline font-awesome SVGs will also be used in areas where 'inline' icons are requested (like information toolbar) but the fallback to 'default' was used before. The component supports all properties of the Icon API via HTML attributes. Colors and custom sizes can be applied to the component via CSS color/font-size property: typo3-backend-icon[identifier=status-dialog-information] { color:#6daae0; /* An explicit font-size will be used as icon width & height */ font-size: 1.2em; } Resolves: #93473 Releases: master Change-Id: I3044c325f122eb0085ecb3f45fb9502bfb314d5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67675 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 28 Feb, 2021 1 commit
-
-
This example configuration was accidentally added by a later commit after it was already removed. Resolves: #93600 Related: #89645, #89740 Releases: master, 10.4 Change-Id: I79bbbf3210e67e0f5425563ba58765115db3cd12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68139 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 24 Feb, 2021 1 commit
-
-
Benni Mack authored
This change cleans up the tooltip initialization where done manually (e.g. in Recordlist it's its own class). Instead, the default initialization for the data-bs-toggle="tooltip" takes over sane delay settings, fixing flaky Acceptance tests (and real visibility bugs in Scheduler). In addition, the FileList module now also uses bootstrap-powered tooltips again. Resolves: #93583 Releases: master Change-Id: Ibff2aae38569caebab9cf45368dd44b03b451cff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68095 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 22 Feb, 2021 3 commits
-
-
Update previous dataset attribute selector from `data-target` to `data-bs-target` in Admin Panel preview. Resolves: #93559 Releases: master Change-Id: Id848a3f0309226c438622f72c572fdcb882f5642 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67992 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Since Bootstrap 5, the legacy.scss is also included in the Admin Panel, which breaks the layout. The change removes the legacy.scss and mixins inclusion, and makes the Admin Panel work again. Resolves: #93183 Releases: master Change-Id: I0b6901be5a97cd77d7920cf641ccb659bd68d7a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67973 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
The changes done in #93453 introduced a CSS change that broke all regular collapsible panels as their carets don't rotate anymore. This bugfix reverts the CSS change and adopts the Flexform code to set the `collapsed` class on a more appropriate element. Resolves: #93537 Related: #93453 Releases: master Change-Id: Iff87fd49a7bf9d3b155674578be7cfd887ad1408 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67960 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 19 Feb, 2021 1 commit
-
-
A new API is introduced, providing multi-factor authentication for the Core. The API is furthermore directly used to add two MFA providers by default: * TOTP (time-based one-time passwords) * Recovery codes Even if the API is designed to allow MFA in both, backend and frontend, it is currently only implemented into the backend. Users can therefore configure their available MFA providers in a new backend module, accessible via their user settings. There are also some configuration options for administrators to e.g. define a recommended provider or to disallow available providers for specific users or user groups. Administration of the users' MFA providers is possible for administrators in the corresponding user records. New providers can be introduced by implementing the MfaProviderInterface and tagging the service with the `mfa.provider` tag. Note that the API is currently marked as internal since changes in upcoming patches are to be expected. Following dependencies are introduced: * bacon/bacon-qr-code "^2.0" * christian-riesen/base32 "^1.5" Possible features that could follow later-on: * MFA frontend integration * Webauthn core provider for FIDO2 and U2F. * Forcing users to set up MFA on login * Password-recovery with active MFA Resolves: #93526 Releases: master Change-Id: I4e902be624c80295c9c0c3286c90a6a680feeb5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67548 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Benni Mack <benni@typo3.org>
-
- 17 Feb, 2021 1 commit
-
-
The file list module now also has a tree component which is not based on an iframe anymore, and now behaves similar to the page tree component. The main benefit is performance, which includes a state-of-the-art rendering component, and an added filter button to search for folder names and filenames (!). The tree component replaces the old "file_navframe" which will eventually be deprecated along its Routes, as well as the possibility to use a frame in the navigation component. Resolves: #93426 Releases: master Change-Id: Iad6c0a4288f1d448298cdaec7b52ff20959dbabf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67578 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 16 Feb, 2021 2 commits
-
-
Resolves: #93518 Releases: master, 10.4 Change-Id: I9a745fc608b1f1ce24af8005910ce776cd00a163 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67931 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
Benni Mack authored
Labels within FormEngine are bold, but due to Boostrap 5 all labels in all places were bold and created margin, making the rendering of the rest of the TYPO3 Backend hard-to-grasp, as well as FormEngine not allowing to have a different view for labels of fields, and labels of actual form elements. This change adapts the margin and font-weight accordingly. Resolves: #93519 Releases: master Change-Id: I3bf0fda432cf43309fe3909a22784609ddeaa904 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67952 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 15 Feb, 2021 4 commits
-
-
This patch refactors the client-side rendering of FlexForm sections. Now, there are two modules in place: - FlexFormSectionContainer This module handles the "outer" part of a section, e.g. to toggle all containers or to revalidate FormEngine if a container is removed. - FlexFormContainerContainer The FlexFormContainerContainer represents an individual container being a child of a section. In order to streamline the UI, the look & feel has been changed to be more similar to IRRE. Resolves: #93453 Releases: master Change-Id: Ica373a6dbed4b470725267eac221bf839b23ec0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67589 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
The system news slider implements the ARIA pattern "carousel" except for the omission of aria-roledescription which has no support in current screen readers. Additionally the contrast of the slider controls has been increased and the click size does not shrink on small screens. Resolves: #93259 Releases: master Change-Id: Ia718184f9b4188c57c08d63f34bb05d80be37ced Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67456 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
Passing jQuery objects to the methods `show()` and `hide()` of the module `TYPO3/CMS/Backend/Tooltip` has been marked as deprecated. The methods now check whether a NodeList or an HTMLElement is passed and handles the tooltip actions accordingly. If a jQuery object is passed, the old behavior is kept and a deprecation is logged in the browser's console. Resolves: #93506 Releases: master Change-Id: I680ae542f616627d3e22262c33cf126abc889d80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67915 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Clean up CSS by removing vendor prefixes that are handled by autoprefixer. The commit also removes SCSS mixins that add vendor prefixes. Releases: master Resolves: #93510 Change-Id: I949671211f5771524863df2062f6554a78b53caf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67918 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 12 Feb, 2021 1 commit
-
-
Avoid JavaScript based offset and height calculations. Position sticky can do that in all supported browsers for us. .module-docheader is additionally adapted to use display:flex in order for the docheader-bar margins to be contained within. (to preserve the position:fixed behaviour, which did the same). While at it, we also avoid jQuery usage within DocumentHeader.ts Releases: master Resolves: #93489 Change-Id: I8c42500c3fb608c7ee8bcfeca0578383814efcb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67691 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 11 Feb, 2021 1 commit
-
-
This fixes step indicators and button margins in the modal footer. Resolves: #93168 Releases: master Change-Id: Ic5e14389dfa4942645c6dc18b4a6355886209515 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67393 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 10 Feb, 2021 2 commits
-
-
Now that jQuery has gone and TypeScript is in place for Tree components, the next step is to consolidate and sort out re-usability. This change prepares the way for allowing multiple trees in the navigation component area (for FileStorageTree). * ContextMenu allows int+number (which is correct) * ContextMenu has all information from the TreeNode (and not the SVG element) - less Markup! * KeyTypeEnums are used throughout SvgTree * Centralized place for error notifications, removing duplicate code * tree.settings.isDragAnDrop is removed in favor of tree.settings.allowDragMove (which already exists) * Unused properties in TreeNode are removed * Since we are now in "TS module land", PageTreeToolbar.ts is removed because the class is only used in the PageTreeElement, so it does not need to be exposed anymore. Resolves: #93481 Releases: master Change-Id: Ia9bff532132dba5aea85352d7e510f6a7f9459c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67683 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
This change splits up Drag+Drop handling in general for SVG-based trees into PageTree specific logic, and common usages. This makes Drag+Drop functionality usable in more places than just the PageTree In addition, all usages of jQuery are removed and proper types were added instead of using "any". Resolves: #93478 Releases: master Change-Id: Ibb17cdd718424760676899b7746cb0828e06fc7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67682 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 09 Feb, 2021 3 commits
-
-
Align the search input to the toolbar icons. Releases: master Resolves: #93476 Related: #93474 Change-Id: I50c8344f2370c32980db247e63fadd3a2f67287c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67679 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
The PageTree toolbar now displays both menu areas ("main menu" and "submenu") all the time and removes the submenu toggles / buttons. This is a request from various UX developers to: * remove buttons for toggling if there is enough space * decouple buttons from the click / drag functionality (some had borders, some did not) * not hide the filter in a submenu (unclear that the left buttons are menu toggles) In itself, the loading area is now clearer (via simpler CSS), and the TypeScript/JS code gains simplicity for building the menu. Resolves: #93474 Releases: master Change-Id: Ie3767e247f28418af949b39b39919e50f13cc48f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67677 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
This change migrates all left-over components of * SvgTree * SelectTree (a.k.a. CategoryTree) * and PageTree to TypeScript adding types in various places to make the code less error-prone. Resolves: #87678 Resolves: #85400 Releases: master Change-Id: Ibb4024d365857c44018a7a201c1cf75baa48179a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67662 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 08 Feb, 2021 3 commits
-
-
renderElement() was added in patchset 2 of #93446. The code was then refactored to use renderHTML, but the method was forgotten to be removed in the final patchset. Now, the intention of the mentioned patchset 2 was to render nodes directly to the DOM in PageTreeDragHandler, instead of rendering to a temporary element, just to export and re-import as HTML string with jQuery/innerHTML. Therefore PageTreeDragHandler is now refactored to a new, (internal) method renderNodes() which allows the returned nodes to be directly attached to the document. Also, while at it, all other lit-helper methods are marked as internal as well, as they are still subject to change: * `renderHTML()` is only needed when mixing traditional jQuery rendering and lit-html (same as for the new `renderNodes()`.) * The `icon()` method could likely be replaced by a custom <typo3-backend-icon> component * `lll()` is only of use for globally available language identifiers (which are added via inline JS) So this is also likely to change when more backend modules start to use lit-html/LitElement. Resolves: #93464 Related: #93446 Releases: master Change-Id: I61ab778e28e32b75b6e7965b75259beedbb10ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67663 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
The Backend LoginRefresh password field now also contains "autocomplete=current-password" just like the login-form. Sidenote: The attribute (also for the username) must be added manually via jQuery as there is a strange bug not allowing "autocomplete". In addition, it fixes a typo for the rsa-encryption to be proper english, and not needing a special handling for LoginRefresh.js anymore. Resolves: #93448 Releases: master Change-Id: Iedf306380a4dbfb5ec31c37f932f8d3b64daf366 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67654 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
The PageTree components for the navigation area consists of: * PageTreeElement (container for rendering the navigation area w. toolbar + dragdrop + tree) * PageTreeToolbar (uses DnD for creating new items) * PageTree (JS, subclass of SvgTree) * PageTreeDragDrop This patch aims to rework the "PageTreeDragDrop" javascript file by moving separate logic into separate classes (as much as possible) and into a more stable API, being a first part. PageTreeDragDrop is a mixed code class currently, and is now split up in various separate classes: * DragDropHandler (interface) * ToolbarDragHandler -> used as the Toolbar Draggable Handler for new pages * PageTreeNodeDragHandler => used for moving/copying and deleting existing pages/nodes * PageTreeDragDrop now acts as a simple wrapper for d3-drag but still has some shared state For Future Reference: It is still up to decide on how to further decouple the code. Idea 1: Putting the d3-drag initialization into the right place and avoiding cross-dependencies. In general "initializeDragForNode" would also be handled via events, and all options / settings would be moved into the PageTreeDragDrop class. Ideally the PageTreeDragDrop contains the status of the current drag+drop action (position, node etc), so the PageTree would not know of anything itself. Idea 2: Another possibility is to use the current "PageTreeDragDrop" as a generic "TreeDragDropManager" because it does not contain any Page-Tree specific code anymore, but could be carried on later-on. The current change is already a good step as it moves all code to TypeScript and minimizes injection via constructors (except for the Tree itself). Resolves: #93446 Releases: master Change-Id: Ibd7a067c1e6a821b138a8cc2971ec8133392b600 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67650 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 06 Feb, 2021 4 commits
-
-
BackendController::generateJavascript() creates the top.fsMod object to provide frameset modules an easy way of storing their state. The FileList module e.g. stores the current folder identifier. Therefore, after switching back to the FileList module, the previously selected folder is used. This behaviour is now restored by replacing the "instanceof" check, which always evaluated to FALSE, with a typeof check. It's furthermore now ensured that the id will always be set, even if recentIds is not yet an object. Resolves: #92811 Releases: master, 10.4 Change-Id: I36227775bfadfca4d43a719b1508f78976b6e342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67628 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Updated styling and javascript to restore styling of the localization wizard after the update to bootstrap 5. Resolves: #93408 Releases: master Change-Id: I6f3dc03af943e3eae240c84a218e8b72dcb8d276 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67627 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
This patch adds the TypeScript declaration for the sortablejs library. Since the imported module has a different naming, the PageRenderer needs both the new module name ("sortablejs") and the old name ("Sortable") as this would be a breaking change, otherwise. In the master patch, the old module name has been declared deprecated. Resolves: #93454 Releases: master, 10.4 Change-Id: Ia8cc7bb4fb57bc7d55aa3601d6ccd1bfe6e0b54d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67658 Tested-by:
core-ci <typo3@b13.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
While updating bootstrap to 5.0.0-beta1 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/67215) The 'a) Carousel "item" to "carousel-item" class migration' was done for the ext:backend 'Wizard' component but not for the 'MultiStepWizard' component. Therefore the 'new form' wizard will not work properly. This patch migrates the usage of 'item' classes to 'carousel-item' within the 'MultiStepWizard' component. Resolves: #93168 Releases: master Change-Id: I4c2a47147b668694c84ccda1dd01b7fe3e3d7808 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67579 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 04 Feb, 2021 2 commits
-
-
This change aims to reduce the overhead by using jQuery in favor of Vanilla JS in various Tree-related JS files in preparation for a TypeScript migration. * SvgTree.js * SelectTree.js * PageTree.js * PageTreeToolbar.ts * PageTreeElement.ts * TreeToolbar.ts Resolves: #93427 Releases: master Change-Id: I57fc8e66415ea4ab6eaf690d925fbf7670d74284 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67583 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
This change migrate the TreeToolbar (used in FormEngine Category Tree for example) to TypeScript, removing effectively one RequireJS call and replacing it with a native TypeScript component. Removing the rest of the jQuery will be part of a separate effort. Resolves: #93432 Releases: master Change-Id: I3df66cd1c28d096c0f32982347dbd37c58834e4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67640 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 03 Feb, 2021 1 commit
-
-
Benni Mack authored
In previous TYPO3 versions (until the Workspace module was refactored in TYPO3 v8) it was possible to manipulate the collapse / expand toggle via Signals (now PSR-14 event), for third-party records with a lot of IRRE records. This change re-introduces the toggle for PSR-14 event listeners to respond to the JavaScript toggle / flag. Resolves: #93404 Releases: master, 10.4 Change-Id: I56408ac52b6491fe7ac79175ff0ab5017905d45d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67585 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-