This project is mirrored from https://git.typo3.org/typo3/typo3.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
  1. 03 Jun, 2015 1 commit
    • Christian Kuhn's avatar
      [!!!][FEATURE] FormEngine: The extendables · 0ee65b8f
      Christian Kuhn authored and Anja Leichsenring's avatar Anja Leichsenring committed
      For details, see the ReST files with examples for new API
      and TCA changes.
      
      * Split TCA config "type" to "type" and "renderType":
        TCA config "type" is a technical debt since it both defines the
        database storage as well as the widget that is used to render
        a certain field in FormEngine. While "type" is kept, the
        render widget is now extracted to a "renderType".
      
      * t3editor uses this "renderType" now. type=text with
        renderType=t3editor will call the new T3editorElement provided
        by ext:t3editor, and falls back to TextElement if t3editor is
        not loaded.
      
      * t3editor is now enabled for "setup" and "constants" of
        sys_template records if opening the whole record.
      
      * t3editor now works when configured in a flex form.
      
      * Introduce an API in FormEngine NodeFactory to register new
        renderType, used by t3editor.
      
      * Introduce a resolver API in FormEngine NodeFactory to change
        the class that renders a widget or container.
      
      * Split TextElement into TextElement that only renders a textarea
        and RichTextElement provided by ext:rtehtmlarea that renders RTE.
        ext:rtehtmlarea uses the new resolver API to route rendering to
        its own class in case RTE is enabled and configured for a field.
      
      * In TCA section "types" a new array "columnsOverrides" is
        introduced that allows overwriting some column configurations
        of fields. Currently, this works for some View/FormEngine related
        settings like renderType and defaultExtras.
      
      * TCA Migration is introduced to dynamically rewrite TCA before
        it is put into cache.
      
      * TCA migration is called a second time in ext:compatibility6 in
        case TCA is still registered via ext_tables.php. This has performance
        penalty since it is done on every frontend and backend call.
      
      * TCA migration is also called dynamically for flex form definitions.
      
      * TCA migration moves configured t3editor wizards to type=text with
        renderType=t3editor.
      
      * TCA migration removes the 5th parameter "style pointer" from
        types showitem
      
      * TCA migration moves the 4th showitem parameter "extra configuration"
        to "defaultExtras" of "columnsOverrides" of given TCA type.
      
      Change-Id: Ia2c2bc16463a01021c7a6be765b4efa872a130fd
      Resolves: #67229
      Releases: master
      Reviewed-on: http://review.typo3.org/39662
      
      
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: default avatarFrank Nägler <typo3@naegler.net>
      Tested-by: default avatarFrank Nägler <typo3@naegler.net>
      Reviewed-by: Markus Klein's avatarMarkus Klein <markus.klein@typo3.org>
      Tested-by: Markus Klein's avatarMarkus Klein <markus.klein@typo3.org>
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      0ee65b8f
  2. 18 May, 2015 2 commits
  3. 11 May, 2015 1 commit
  4. 28 Apr, 2015 1 commit
    • Christian Kuhn's avatar
      [!!!][TASK] House of forms · 736cbfc9
      Christian Kuhn authored
      This patch introduces a structural code refactoring to the
      FormEngine class and its related friend classes.
      
      FormEngine used to call itself over and over again with itself
      and sub classes writing to public properties of FormEngine keeping
      a global state that is then magically merged to sometimes working
      output.
      
      The patch introduces a tree approach with lots of small containers
      doing an encapsulated part of the rendering process and calling
      sub containers for inner details.
      As main construct a "globalOptions" array is modified in containers
      and given down to sub containers (tree knots) or elements (leaves),
      while sub structures always return a defined array that is
      merged by the parent and accumulates the full result.
      Goal is to have a better encapsulated code structure with better
      visible impact on changes done to this system.
      
      The patch creates this main structure. There is still a lot of
      mess around and additional patches can further improve the overall
      situation with smaller changes.
      
      Change-Id: I56b898dc0eaae8de4d31016997cfefe8d14ec53e
      Releases: master
      Resolves: #63846
      Resolves: #63854
      Resolves: #63856
      Resolves: #63858
      Resolves: #63859
      Resolves: #63860
      Resolves: #63861
      Resolves: #63862
      Resolves: #63863
      Resolves: #63865
      Resolves: #63876
      Resolves: #63881
      Resolves: #63882
      Resolves: #63883
      Resolves: #63893
      Reviewed-on: http://review.typo3.org/38433
      
      
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Reviewed-by: default avatarMarkus Klein <klein.t3@reelworx.at>
      Tested-by: default avatarMarkus Klein <klein.t3@reelworx.at>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      736cbfc9
  5. 22 Apr, 2015 1 commit
  6. 28 Feb, 2015 2 commits
    • Benni Mack's avatar
      [BUGFIX] Make edit button in FormEngine wizard work again · dc7fa6a8
      Benni Mack authored and Christian Kuhn's avatar Christian Kuhn committed
      When clicking on the edit button wizard in FormEngine
      (e.g. when editing a be_group inside the be_user record)
      then there is a JS error preventing from opening a popup.
      
      Resolves: #65415
      Relates: #63846
      Releases: master
      Change-Id: Iafac6759054d0e2ce229b34b17b6a5312e1408df
      Reviewed-on: http://review.typo3.org/37359
      
      
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Reviewed-by: default avatarFrank Nägler <typo3@naegler.net>
      Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      dc7fa6a8
    • Christian Kuhn's avatar
      [!!!][TASK] Improve FormEngine and sub classes separation · 212b9dbf
      Christian Kuhn authored and Anja Leichsenring's avatar Anja Leichsenring committed
      This patch improves the separation of FormEngine and its sub
      classes. Currently, all sub classes like single element and wizard
      classes get an instance of the parent object to call various methods
      and properties on them. This is very hard to refactor and the mesh
      of call trees must be simplified to ease further refactoring and
      improve maintainability of code.
      
      This patch follows a divide & conquer approach:
      * Methods only used by sub elements are moved to AbstractFormElement
      * Properties FormEngine "knows" that are needed by element classes
        are given down in a data array during element instatiation to have
        a clear definition of what element classes know.
      * Methods used by both FormEngine and sub classes that do not need
        an instance of FormEngine are moved to a static helper for now to
        reduce the amount of code in FormEngine and to mark certain areas
        as stateless.
      * Class instances are not created on a global level anymore but
        created only in the scope where they are used
      * Class instances injected by outer code are created internally
        for enabling the using code to be moved around.
      
      All in all, this patch is mostly a preparation of defining a
      fully separated structure with defined concerns for every sub class.
      
      Most methods are moved around "as is" without changing functionality.
      The only area that is refactored codewise is renderWizards().
      
      There is still a nasty circular dependency between FormEngine,
      FlexFormElement and InlineElement. This is not resolved by the patch,
      but the surrounding code is now separated enough that this structure
      could be refactored to a tree. This may follow with other patches.
      
      This patch evolved on catharsis in branch formengine with 53 single
      patches. Details can be looked up there, all single patches are
      prefixed with [FormEngine].
      https://github.com/lolli42/TYPO3.CMS-Catharsis/tree/formengine
      
      Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f
      Releases: master
      Resolves: #65357
      Resolves: #63848
      Resolves: #63849
      Resolves: #63851
      Resolves: #63853
      Resolves: #63855
      Resolves: #63857
      Resolves: #63867
      Resolves: #63868
      Resolves: #63869
      Resolves: #63870
      Resolves: #63871
      Resolves: #63872
      Resolves: #63873
      Resolves: #63874
      Resolves: #63875
      Resolves: #63877
      Resolves: #63879
      Resolves: #63880
      Resolves: #63884
      Resolves: #63885
      Resolves: #63886
      Resolves: #63887
      Resolves: #63888
      Resolves: #63890
      Resolves: #63892
      Reviewed-on: http://review.typo3.org/37265
      
      
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
      Reviewed-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
      Tested-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
      212b9dbf
  7. 02 Feb, 2015 1 commit
  8. 19 Dec, 2014 1 commit
  9. 16 Dec, 2014 1 commit
  10. 15 Dec, 2014 1 commit
  11. 13 Dec, 2014 1 commit
  12. 02 Oct, 2014 1 commit