This project is mirrored from https://git.typo3.org/typo3/typo3.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Last successful update .
- 23 Apr, 2021 2 commits
-
-
Will hide all tooltips when scrolling in the page tree panel to avoid multiple tooltips to show up and get stuck on screen Resolves: #87496 Releases: master Change-Id: Ie4be5c0cc9df01b26c658ac02ddcfdf2a2102c77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68839 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
This change re-adds the highlighting of filter results in the Svg Trees, which was present before in the Page Tree before it was built on SVG. Due to the nature of SVG, it is rather complicated to color the actual background of the text than the text itself (using <tspan>), but still, the highlighting is IMHO better than having no highlighting. Resolves: #87743 Releases: master, 10.4 Change-Id: Ie37173149c8f9388194e63a07ae89eb2fc774f30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68835 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 22 Apr, 2021 1 commit
-
-
Benni Mack authored
This change adds a <rect> element inside the icon group for making the icon better clickable. Resolves: #87453 Resolves: #93284 Releases: master Change-Id: I17a70cc0cf6bdf466c710a3599d3ede87fda700d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68800 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Apr, 2021 2 commits
-
-
This change limits the GET request for the PersistentStorage to only "get" and "getAll", where as the others are only working for "post". Since this logic is encapsulated properly in the Persistent JavaScript API, no other parts are affected. Resolves: #93948 Releases: master Change-Id: I965ea4552671c743cabed10c4cd8ad7275532420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68715 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Allow a user to move a folder into a folder on the same level and prevent moving a folder into its child folder. Resolves: #93954 Releases: master Change-Id: I444a87e862075ecd0a3e54ce5afd02314b1931c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68833 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 16 Apr, 2021 2 commits
-
-
The page module is now being reloaded when deleting a content element via the context menu. Side note: Since there are a lot of functionalities in the module, e.g. translation, it isn't sufficient to just remove the element from DOM, like it's done in recordlist. The whole module needs to be reloaded / reinitialized. Resolves: #91394 Releases: master, 10.4 Change-Id: Ibd9dc853ddb356574a0f426244decb6455f54b44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68727 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
This change adds the SVG-based page tree in the record selector and the Page Link picker, replacing decade-old clumsy HTML code for generating trees. This replacement not only unifies the user experience across the navigation trees and the Element Browser / Link Pickers making the whole look + feel very consistent. It also allows to finally use all the features built in the SVG trees: * A filter across the tree built on the browser and automatic refreshing * collapse + expand and post-loading is now built with the same AJAX endpoints as the navigation components, making the general loading much faster * Temporary Mount Points now look exactly the same as in the navigation area. * Keyboard navigation * The Content Area inside the Record Selector and the Link Pickers is replaced via AJAX calls Especially the last feature makes it a breeze to use the new trees to select items much faster. All existing features, such as directly selecting a page or link to a page within the tree is added as so-called SVG-tree "actions" in the right corner when hovering, avoiding the additional "play" icon in the tree. Custom support for Element Browser "mount points" is also kept and included. The SVG tree is added to the following components: * Database Browser / Record Selector (e.g. choosing storagePid in plugins) * File Browser / Record Selector (e.g. selecting an image in the plugin) * Folder Browser / Record Selector * Link Picker for Pages / Content Elements ("link to a page") * Link Picker for Files ("link to a file") * Link Picker for Folders ("link to a folder") * Link Picker for Records (e.g. news record) All link picker functionality is available for typolink fields (e.g. tt_content.header_link) and when linking inside the Rich Text Editor. Some technical details under-the-hood: * The trees are now built as SVG tree / LIT elements * All Element Browser / Link Picker trees are named "Browsable...Tree" * The AJAX endpoints for fetching data are used * The Page Tree now uses a different configuration URL with a "?readonly=1" parameter, with the main difference to initialize EB mountpoints instead * Within the tree: The SVG tree actions is a separate container for elements on the right-hand of the tree * The GET parameter "contentOnly" represents to only load parts of the HTML (the content area) when fetching from AJAX Resolves: #73176 Resolves: #92430 Releases: master Change-Id: I5ef9534076bd6fa297b51c0ed9e90af91035be80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67687 Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Benjamin Franzke <bfr@qbus.de>
-
- 13 Apr, 2021 1 commit
-
-
This patchs adds a new LitElement that invokes the update request of FormEngine if a field's value with such configuration changes. This replaces the current approach of huge onchange/onclick attributes rendered per affected field. A further patch will cleanup the necessity of TBE_EDITOR.fieldChanged(). Resolves: #93899 Releases: master Change-Id: I79aa5b6ab7cca9b555efaafcadabcc623567af64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68756 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 09 Apr, 2021 2 commits
-
-
Benni Mack authored
The search box (accessible via the list module in docheader, and also used inside the Record Selector) is now simplified by having a main select field, and additional settings as dropdown available, making the search box - especially in the record selector - much more easier to understand and to use. In addition, the record selector search now looks similar to the File Selector (FAL relations), as the File Selector uses the same markup now as well. The doc header in the list module does not jump anymore when choosing the search box, as this is also now moved into the main document area, as all other modules (belog etc) use it as well. The search box component is also extracted from the DatabaseRecordList class, making it easier to re-use. As the page module does not have the search anymore, and thus, would rely on EXT:recordlist to just show the button, the button (and thus, the jumpyness) is removed there. Resolves: #93892 Releases: master Change-Id: I64259f54a79d0faaeefb45f9528d0a0d0c7b2c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68753 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change creates a default toolbar for SVG trees to filter, in order to avoid duplicate code (which will be added via the SVG based trees in the next feature again). Resolves: #93886 Releases: master Change-Id: Idb98bab80ca12fba4bafc5a4e4ac367a16bf6e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68752 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 08 Apr, 2021 1 commit
-
-
This change adds a new Lit-based custom HTML component called "<typo3-backend-navigation-switcher>" which moves the current navigation frame resizable feature in a more flexible re-usable way. All RecordLinkHandlers and ElementBrowsers now have a resizable and collapsible navigation area. In addition, all logic is now decoupled from Viewport.ts All ElementBrowser / RecordHandlers now also define an inline style width to avoid jumping of the navigation area within the modal box. Further optimizations in this area: * Remove the media queries for the CSS classes in the element browser? * The newly introduced LIT element could be built as shadow DOM Resolves: #93857 Releases: master Change-Id: I66724086942e0778e05b9c26dd956bb8417af6d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68692 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 07 Apr, 2021 2 commits
-
-
Migrates backend UI component `LiveSearch` to be based on `lit-html`. In order to avoid string based concatenation which relies on the server side to properly escape html – which might not always work, when HTML is used in different contexts (node vs attributes). Resolves: #93101 Releases: master Change-Id: Idf0d588306ddc666a8ba449f96f58b78566a1c39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67178 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
When regenerating a slug value via form engine in the backend user interface, changed states are not addressed anymore. Corresponding JavaScript `change` event has to be triggered for the element that is used to trigger changes for form engine validation. Resolves: #93874 Releases: master Change-Id: I7e78f36f4434009c122717eeb92bc463b9daa1a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68722 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 05 Apr, 2021 1 commit
-
-
The search box is currently available in * Page module (docheader) * List module (docheader) * Record Selector / Element Browser All implementations are different but use the same code base: * The outer wrapper functionality is only needed for the doc header * The page module is not using the Fluid-based snippet Additionally, styling is broken due to Bootstrap 5 upgrade. The change reduces CSS and JS initialization by consolidating the rendering of the search box and removing the buggy showLimit functionality since there is no pagination the placeholder is not used. Ideally, this code would be separated into a separate class as it is only related to a fragment of DatabaseRecordList. This is to be handled with a separate patch. Resolves: #93849 Releases: master Change-Id: I20e406f0ed5bf74503fb45c9ad93cf0e6a91f153 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68667 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 02 Apr, 2021 1 commit
-
-
Benni Mack authored
The Link Picker (RecordLinkHandler) and Element Browser logic has been simplified to avoid jQuery where possible and to reduce HTML rendering. The data-icon information is never evaluated in TypeScript/JavaScript and can be removed from any kind of HTML rendering, making the transferred amount of HTML much smaller. In addition, the insertElement method has been cleaned up to only use the properties that are evaluated. As a small side-effect, the InlineControlContainer does not throw a console.warn if a post message cannot be evaluated (which is typically the case for non-inline references). Resolves: #93850 Releases: master Change-Id: Ie850a3520ba5b448f5a1d0a42aa656b972b8d3a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68668 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 29 Mar, 2021 1 commit
-
-
With #91008 the grouping and sorting feature was introduced to the TCA select type. As a consequence, the select items array key for the help text changed from `3` to `4`. The SelectCheckBox now correctly checks the `4` key for the presence of a description. In v11 the absence of a title value, which is common in this scenario, did furthermore lead to TypeError on rendering the popover. This is fixed by assigning an empty string as default value on initialization of the popover options. Otherwise this option would be initialized as 'undefined' and then trigger the TypeError on sanitizing. Additionally the TCA properties special=table, special=exclude and special=custom are adjusted to add the correct value as help text to the items array. The value is now added directly as string, as there is no need to define the array while only providing the description. As a drive-by-change, the itemsProcFuncs of the dashboard and the MFA component do now also add the description for their access list field. This is done because the dashboard initially defined the description already but had to remove it again due to this bug, see: #91152. The MFA component also just hadn't added it because the bug hadn't been resolved at that time. Resolves: #93331 Resolves: #92383 Releases: master, 10.4 Change-Id: Ie96bcabea88b377490c24b0e60cfca8337e9ec52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68616 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Julian Mair <julian.mair94@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 25 Mar, 2021 1 commit
-
-
In #93810 bootstrap was updated to 5.0.0-beta3, which contains the new "offcanvas" component. In order to use it in TypeScript, we need to update the corresponding type definitions. The new type definition doo not define return types for bootstrap JQuery methods, therefore we simply avoid usage of these. The update additionally revealed one bug in the login screen, where the login-submit button did not longer show a loading indicator as $.button('loading') is no longer available in bootstrap 5. This issue is fixed as a drive-by change. Also @types/jqueryui needs to be patched as the tooltip and button definitions conflict with those from @bootstrap/types. Executed command: yarn add --dev @types/bootstrap yarn patch-package @types/jqueryui Resolves: #93812 Releases: master Change-Id: Ie58f62e0c31b4c77e28d1118ecb7144d4f539903 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68576 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 22 Mar, 2021 2 commits
-
-
This change moves all related drag+drop code for the navigation components into each TypeScript class, making clear that some functionality is only meant to be used in This change: * Removes the DragDrop / Actions files and moves them into the NavigationComponent.ts files * Moves all drag+drop related functionality into proper extended EditablePageTree/EditableFileStorageTree classes. This is a pre-patch to use the actual PageTree/FileStorageTree classes in other contexts (such as Element Browser) and extend them, and only have the functionality that is needed for all places. Resolves: #93785 Releases: master Change-Id: Ifff4ba2888ed498169580b912263d0dc0914886f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68520 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
TCA fields using the 'placeholder' functionality are not initialized in inline 'localize/synchronize' scenarios. tx_styleguide_inline_1n -> inline_1 -> input_3 has been added to show this. Solution is to call the required FormEngine "re-init" in JavaScript at a different point - not only when new inline children are added, but also when synchronizing with default language. Resolves: #93792 Releases: master, 10.4 Change-Id: Ib10826ee9bc4c305436c2474f2bb20b2d367d426 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68527 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 19 Mar, 2021 1 commit
-
-
This change reduces the overhead of the d3 framework by using native CustomEvents on the actual Lit element of the SVG instead of d3-dispatch logic: * typo3:svg-tree:nodes-prepared (enrich node data) * typo3:svg-tree:expand-toggle (expand/collapse) * typo3:svg-tree:node-context (clickmenu) * typo3:svg-tree:node-selected (on-click) As shown in the patch, the actual logic of interacting with the outside framework (Persistent, ContextMenu, window.) is moved to the actual Lit components, making the SVG tree slimmer and easier to maintain. Resolves: #93782 Releases: master Change-Id: I6f5227579eb16ec218bbe67de2aecbcaaabb3fcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68464 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 18 Mar, 2021 2 commits
-
-
The SVG Tree class is now a lit element, allowing for further reduction of d3 usage in favor of native HTML5 APIs. Resolves: #93773 Releases: master Signed-off-by:
Benni Mack <benni@typo3.org> Signed-off-by:
Benjamin Franzke <bfr@qbus.de> Change-Id: I12fef793726f83e872a353901528516a589e48ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68309 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benjamin Franzke authored
Whenever a topbar refresh is triggered, e.g. by activating/deactivating of an extension in the extension manager, or when changing the backend users language, the topbar link events (such as "user settings") need to be re-added. Resolves: #93757 Related: #92704 Releases: master Change-Id: I3580ea1ad890ba9a8dc79903f1f2d43bb212de72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68495 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 15 Mar, 2021 1 commit
-
-
Benni Mack authored
The SVG tree is now building the SVG elements and needed containers ("<g>") via lit-helper. In addition, the update() method is renamed to this.updateVisibleNodes() to easier integrate this as Lit element, as update() is a reserved protected method in lit. The initialize() method is much cleaner, as the event listener registration is now separated in a custom method. Resolves: #93724 Releases: master Change-Id: I945cd620f9900c6ea535dfe5f0d44ee5ced46f89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68367 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Daniel Gorges <daniel.gorges@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Mar, 2021 1 commit
-
-
Releases: master Resolves: #93729 Change-Id: I9dea4a153138e29ae77c9f3e5ae5e202851a09ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68374 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 11 Mar, 2021 2 commits
-
-
In case a TCA column with type=inline does not contain "container controls", e.g. the `languages` column in a site configuration, a TypeError was triggered by the toggleContainerControls() method. This is fixed by proper type checking. Resolves: #93690 Releases: master, 10.4 Change-Id: I6dc0a874adddb6e9c56565087b090072656b54eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68301 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
This change optimizes the SVG Tree implementations (again), this time focussing on using proper constructors for SVG tree and its derivatives (SelectTree, PageTree, FileStorageTree). In addition, the search + filter logic is now moved into the base class, in order to reduce duplicate code, and to re-add features (next steps) that were not implemented in TYPO3 v9 when re-writing the page tree, such as highlighting filtered results. In addition, unused properties and settings are removed. This change marks one of the final changes for reworking the SVG Tree implementation, afterwards allowing us to move towards: * native DOM events in favor of d3-dispatch * custom elements instead of wrapper methods * decouple "top." and "document." based settings into the Container classes Resolves: #93701 Releases: master Change-Id: I55733b8c2d0a84ca263ac6e77d7d0bac30877e25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68332 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 10 Mar, 2021 2 commits
-
-
Benni Mack authored
As the temporary mount point functionality is not bound to the actual PageTree, but the navigation component, this code is now moved outside of the PageTree, and using lit-based rendering and proper event handling. The advantages of this change are that the SVG Tree / PageTree component - does not access HTML outside its own wrapper (parentNode) - the mount point information is now rendered via LIT (= automatically updated) - additional setting "temporaryMountPointPath" is not needed inside the PageTree anymore - We also now use <typo3-backend-icon> and the $lll lit helper Resolves: #93697 Releases: master Change-Id: Idaa56f12e6d1444a1abdf23d2a37b71948d47023 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68307 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Daniel Sattler <sattler@b13.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
This patch provides the following changes in order to have better abstractions and encapsulate the dependencies of each implementation. 1. SelectTree (Category Tree) The TreeToolbar is now clearly coupled into the SelectTree and built as LitElement inside the SelectTreeElement. SelectTree now contains all relevant functionality regarding selecting multiple items, and shows settings (SelectTreeSettings) which were only used in SelectTree. This is especially relevant for the multiple item selection, and the exclusiveKey handling. 2. PageTree + FileStorageTree Obsolete public methods are removed, and visibility is changed. Filtering is now separated in favor of a non-public property. By using Types (in e.g. PageTreeDragDrop) the visibility is also adapted Obsolete wrapper methods are removed. Resolves: #93692 Releases: master Change-Id: Ifead098bb80e37d5c7ad5e1d0eabda14aa7087ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68303 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 09 Mar, 2021 2 commits
-
-
Native HTMLElements are more versatile than a the current NavigationComponent interface. All custom actions can be dispatched via events, that means the NavigationComponent interface, as recently introduced in #93672, is removed again. Resolves: #93685 Releases: master Change-Id: I578810ce655d1da3f34bcb456967f62756793b24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68233 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
With the update to Bootstrap 5 the CSS class name for animated progress bars changed from `active` to `progress-bar-animated`. This patch updates the wrong class names accordingly. Resolves: #93682 Releases: master Change-Id: If8f4e388513822f0457afa2a37d88ed440f6d709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68259 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 08 Mar, 2021 1 commit
-
-
In order to use the non-iframe navigation component properly, the current ties to "PageTree" (which was de-facto the only possible navigation component to be used until TYPO3 v11 due to heavy coupling) are removed. The TreeInterface, which served as a wrapper for the PageTree Navigation Component is removed, and replaced by the NavigationComponent interface in TypeScript. In addition, loading and initializing (and keeping state) of the used navigation component now solely relies in the NavigationContainer. This in turn, finally allows to e.g. properly re-load the FileStorageTree and PageTree separately (see BackendUtility change) while incorporating some ES6 nullable functionality. In addition, the NavigationContainer is now jQuery-free. Resolves: #93672 Releases: master Change-Id: Ia16a3e789459225b21fa12efd1db6f3b4500cfef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68201 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 01 Mar, 2021 1 commit
-
-
The component is provided as replacement for the current lit-helper `icon()` which cannot provide support for icon usage inside shadow dom elements. The component renders all icons as inline SVGs. FontawesomeIconProvider is therefore adapted to provide inline rendered SVGs for font-awesome icons. Not that these inline font-awesome SVGs will also be used in areas where 'inline' icons are requested (like information toolbar) but the fallback to 'default' was used before. The component supports all properties of the Icon API via HTML attributes. Colors and custom sizes can be applied to the component via CSS color/font-size property: typo3-backend-icon[identifier=status-dialog-information] { color:#6daae0; /* An explicit font-size will be used as icon width & height */ font-size: 1.2em; } Resolves: #93473 Releases: master Change-Id: I3044c325f122eb0085ecb3f45fb9502bfb314d5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67675 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 24 Feb, 2021 1 commit
-
-
Benni Mack authored
This change cleans up the tooltip initialization where done manually (e.g. in Recordlist it's its own class). Instead, the default initialization for the data-bs-toggle="tooltip" takes over sane delay settings, fixing flaky Acceptance tests (and real visibility bugs in Scheduler). In addition, the FileList module now also uses bootstrap-powered tooltips again. Resolves: #93583 Releases: master Change-Id: Ibff2aae38569caebab9cf45368dd44b03b451cff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68095 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 22 Feb, 2021 1 commit
-
-
The changes done in #93453 introduced a CSS change that broke all regular collapsible panels as their carets don't rotate anymore. This bugfix reverts the CSS change and adopts the Flexform code to set the `collapsed` class on a more appropriate element. Resolves: #93537 Related: #93453 Releases: master Change-Id: Iff87fd49a7bf9d3b155674578be7cfd887ad1408 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67960 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 19 Feb, 2021 1 commit
-
-
A new API is introduced, providing multi-factor authentication for the Core. The API is furthermore directly used to add two MFA providers by default: * TOTP (time-based one-time passwords) * Recovery codes Even if the API is designed to allow MFA in both, backend and frontend, it is currently only implemented into the backend. Users can therefore configure their available MFA providers in a new backend module, accessible via their user settings. There are also some configuration options for administrators to e.g. define a recommended provider or to disallow available providers for specific users or user groups. Administration of the users' MFA providers is possible for administrators in the corresponding user records. New providers can be introduced by implementing the MfaProviderInterface and tagging the service with the `mfa.provider` tag. Note that the API is currently marked as internal since changes in upcoming patches are to be expected. Following dependencies are introduced: * bacon/bacon-qr-code "^2.0" * christian-riesen/base32 "^1.5" Possible features that could follow later-on: * MFA frontend integration * Webauthn core provider for FIDO2 and U2F. * Forcing users to set up MFA on login * Password-recovery with active MFA Resolves: #93526 Releases: master Change-Id: I4e902be624c80295c9c0c3286c90a6a680feeb5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67548 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Benni Mack <benni@typo3.org>
-
- 17 Feb, 2021 1 commit
-
-
The file list module now also has a tree component which is not based on an iframe anymore, and now behaves similar to the page tree component. The main benefit is performance, which includes a state-of-the-art rendering component, and an added filter button to search for folder names and filenames (!). The tree component replaces the old "file_navframe" which will eventually be deprecated along its Routes, as well as the possibility to use a frame in the navigation component. Resolves: #93426 Releases: master Change-Id: Iad6c0a4288f1d448298cdaec7b52ff20959dbabf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67578 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 15 Feb, 2021 2 commits
-
-
This patch refactors the client-side rendering of FlexForm sections. Now, there are two modules in place: - FlexFormSectionContainer This module handles the "outer" part of a section, e.g. to toggle all containers or to revalidate FormEngine if a container is removed. - FlexFormContainerContainer The FlexFormContainerContainer represents an individual container being a child of a section. In order to streamline the UI, the look & feel has been changed to be more similar to IRRE. Resolves: #93453 Releases: master Change-Id: Ica373a6dbed4b470725267eac221bf839b23ec0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67589 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Passing jQuery objects to the methods `show()` and `hide()` of the module `TYPO3/CMS/Backend/Tooltip` has been marked as deprecated. The methods now check whether a NodeList or an HTMLElement is passed and handles the tooltip actions accordingly. If a jQuery object is passed, the old behavior is kept and a deprecation is logged in the browser's console. Resolves: #93506 Releases: master Change-Id: I680ae542f616627d3e22262c33cf126abc889d80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67915 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 12 Feb, 2021 1 commit
-
-
Avoid JavaScript based offset and height calculations. Position sticky can do that in all supported browsers for us. .module-docheader is additionally adapted to use display:flex in order for the docheader-bar margins to be contained within. (to preserve the position:fixed behaviour, which did the same). While at it, we also avoid jQuery usage within DocumentHeader.ts Releases: master Resolves: #93489 Change-Id: I8c42500c3fb608c7ee8bcfeca0578383814efcb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67691 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 Feb, 2021 1 commit
-
-
Now that jQuery has gone and TypeScript is in place for Tree components, the next step is to consolidate and sort out re-usability. This change prepares the way for allowing multiple trees in the navigation component area (for FileStorageTree). * ContextMenu allows int+number (which is correct) * ContextMenu has all information from the TreeNode (and not the SVG element) - less Markup! * KeyTypeEnums are used throughout SvgTree * Centralized place for error notifications, removing duplicate code * tree.settings.isDragAnDrop is removed in favor of tree.settings.allowDragMove (which already exists) * Unused properties in TreeNode are removed * Since we are now in "TS module land", PageTreeToolbar.ts is removed because the class is only used in the PageTreeElement, so it does not need to be exposed anymore. Resolves: #93481 Releases: master Change-Id: Ia9bff532132dba5aea85352d7e510f6a7f9459c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67683 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-