Commit ffb59e65 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[BUGFIX] Remove unused LanguageService in SlugService

This currently logs a deprecation entry since
LanguageService shouldn't be injected any longer.
The property is unused and can be dropped.

Resolves: #94438
Related: #94414
Releases: master
Change-Id: I2e56982eeb6b33c36de107199293244672b6bf4c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69661


Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Tested-by: Jochen's avatarJochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen's avatarJochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
parent acb8bafd
......@@ -33,7 +33,6 @@ use TYPO3\CMS\Core\DataHandling\Model\CorrelationId;
use TYPO3\CMS\Core\DataHandling\Model\RecordStateFactory;
use TYPO3\CMS\Core\DataHandling\SlugHelper;
use TYPO3\CMS\Core\Domain\Repository\PageRepository;
use TYPO3\CMS\Core\Localization\LanguageService;
use TYPO3\CMS\Core\Page\PageRenderer;
use TYPO3\CMS\Core\Site\Entity\SiteInterface;
use TYPO3\CMS\Core\Site\SiteFinder;
......@@ -57,11 +56,6 @@ class SlugService implements LoggerAwareInterface
*/
protected $context;
/**
* @var LanguageService
*/
protected $languageService;
/**
* @var SiteInterface
*/
......@@ -107,10 +101,9 @@ class SlugService implements LoggerAwareInterface
*/
protected $httpStatusCode;
public function __construct(Context $context, LanguageService $languageService, SiteFinder $siteFinder, PageRepository $pageRepository)
public function __construct(Context $context, SiteFinder $siteFinder, PageRepository $pageRepository)
{
$this->context = $context;
$this->languageService = $languageService;
$this->siteFinder = $siteFinder;
$this->pageRepository = $pageRepository;
}
......
......@@ -22,7 +22,6 @@ use TYPO3\CMS\Core\Configuration\SiteConfiguration;
use TYPO3\CMS\Core\Context\Context;
use TYPO3\CMS\Core\DataHandling\Model\CorrelationId;
use TYPO3\CMS\Core\Domain\Repository\PageRepository;
use TYPO3\CMS\Core\Localization\LanguageServiceFactory;
use TYPO3\CMS\Core\Routing\SiteMatcher;
use TYPO3\CMS\Core\Site\SiteFinder;
use TYPO3\CMS\Core\Utility\GeneralUtility;
......@@ -374,7 +373,6 @@ class SlugServiceTest extends FunctionalTestCase
GeneralUtility::makeInstance(SiteMatcher::class)->refresh();
$this->subject = new SlugService(
GeneralUtility::makeInstance(Context::class),
GeneralUtility::makeInstance(LanguageServiceFactory::class)->create('default'),
GeneralUtility::makeInstance(SiteFinder::class),
GeneralUtility::makeInstance(PageRepository::class)
);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment