Commit fda08488 authored by Mathias Brodala's avatar Mathias Brodala Committed by Christian Kuhn
Browse files

[TASK] Rename ImageManipulationWizard to ImageManipulationController

Change-Id: Ibb5038049780edcf70aae442b9f9933feeed5589
Resolves: #84409
Releases: master
Reviewed-on: https://review.typo3.org/56316

Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
parent f277888f
<?php
declare(strict_types = 1);
namespace TYPO3\CMS\Backend\Form\Wizard;
namespace TYPO3\CMS\Backend\Controller\Wizard;
/*
* This file is part of the TYPO3 CMS project.
......@@ -27,7 +27,7 @@ use TYPO3\CMS\Fluid\View\StandaloneView;
/**
* Wizard for rendering image manipulation view
*/
class ImageManipulationWizard
class ImageManipulationController
{
/**
* @var StandaloneView
......@@ -54,7 +54,7 @@ class ImageManipulationWizard
* @param ServerRequestInterface $request
* @return ResponseInterface $response
*/
public function getWizardAction(ServerRequestInterface $request): ResponseInterface
public function getWizardContent(ServerRequestInterface $request): ResponseInterface
{
if ($this->isSignatureValid($request)) {
$queryParams = json_decode($request->getQueryParams()['arguments'], true);
......@@ -82,7 +82,7 @@ class ImageManipulationWizard
* @param ServerRequestInterface $request the request with the GET parameters
* @return bool
*/
protected function isSignatureValid(ServerRequestInterface $request)
protected function isSignatureValid(ServerRequestInterface $request): bool
{
$token = GeneralUtility::hmac($request->getQueryParams()['arguments'], 'ajax_wizard_image_manipulation');
return hash_equals($token, $request->getQueryParams()['signature']);
......
......@@ -201,7 +201,7 @@ return [
// Open the image manipulation wizard
'wizard_image_manipulation' => [
'path' => '/wizard/image-manipulation',
'target' => \TYPO3\CMS\Backend\Form\Wizard\ImageManipulationWizard::class . '::getWizardAction'
'target' => \TYPO3\CMS\Backend\Controller\Wizard\ImageManipulationController::class . '::getWizardContent'
],
// Save a newly added online media
......
<?php
return [
'TYPO3\\CMS\\Backend\\AjaxLoginHandler' => \TYPO3\CMS\Backend\Controller\AjaxLoginController::class,
'TYPO3\\CMS\\Backend\\Form\\Wizard\\ImageManipulationWizard' => \TYPO3\CMS\Backend\Controller\Wizard\ImageManipulationController::class,
];
......@@ -4,7 +4,19 @@ namespace {
}
namespace TYPO3\CMS\Backend {
/**
* @deprecated since v9, will be removed in v10
*/
class AjaxLoginHandler extends \TYPO3\CMS\Backend\Controller\AjaxLoginController
{
}
}
namespace TYPO3\CMS\Backend\Form\Wizard {
/**
* @deprecated since v9, will be removed in v10
*/
class ImageManipulationWizard extends \TYPO3\CMS\Backend\Controller\Wizard\ImageManipulationController
{
}
}
......@@ -17,7 +17,7 @@ Impact
======
The old class name has been registered as class alias and will still work.
Old class name usage however is discouraged and should be avoided since, the
Old class name usage however is discouraged and should be avoided, the
alias will vanish with core version 10.
......@@ -35,4 +35,4 @@ Migration
Use new class name instead.
.. index:: Backend, PHP-API, FullyScanned, ext:recordlist
\ No newline at end of file
.. index:: Backend, PHP-API, FullyScanned, ext:recordlist
.. include:: ../../Includes.txt
====================================================================================
Deprecation: #84409 - ImageManipulationWizard renamed to ImageManipulationController
====================================================================================
See :issue:`84409`
Description
===========
The PHP class :php:`TYPO3\CMS\Backend\Form\Wizard\ImageManipulationWizard` has been renamed to
:php:`TYPO3\CMS\Backend\Controller\Wizard\ImageManipulationController`.
Impact
======
The old class name has been registered as class alias and will still work.
Old class name usage however is discouraged and should be avoided, the
alias will vanish with core version 10.
Affected Installations
======================
Extensions which use the old class name are affected. The extension scanner will find affected extensions using the old class name.
Migration
=========
Use new class name instead.
.. index:: Backend, PHP-API, FullyScanned
......@@ -17,7 +17,7 @@ Impact
======
The old class name has been registered as class alias and will still work.
Old class name usage however is discouraged and should be avoided since, the
Old class name usage however is discouraged and should be avoided, the
alias will vanish with core version 10.
......@@ -32,4 +32,4 @@ Migration
Use new class name instead.
.. index:: Backend, PHP-API, FullyScanned, ext:t3editor
\ No newline at end of file
.. index:: Backend, PHP-API, FullyScanned, ext:t3editor
......@@ -664,4 +664,9 @@ return [
'Deprecation-84410-CodeCompletionRenamedToCodeCompletionController.rst',
],
],
'TYPO3\CMS\Backend\Form\Wizard\ImageManipulationWizard' => [
'restFiles' => [
'Deprecation-84409-ImageManipulationWizardRenamedToImageManipulationController.rst',
],
],
];
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment