Commit f06e99a0 authored by Benni Mack's avatar Benni Mack Committed by Wouter Wolters
Browse files

[TASK] Move AjaxLoginHandler to AjaxLoginController

The AjaxLoginHandler which does AJAX logic for login timeouts is be moved
to the proper location, as it is a controller.

A class alias is in place.

Resolves: #82805
Releases: master
Change-Id: I6a9fed6236d6d82150dec2ac7c2ce61bd194b8ec
Reviewed-on: https://review.typo3.org/54441


Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <typo3@scripting-base.de>
Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarJoerg Boesche <typo3@joergboesche.de>
Tested-by: default avatarJoerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
parent 69011004
......@@ -70,6 +70,7 @@
"typo3/class-alias-loader": {
"always-add-alias-loader": true,
"class-alias-maps": [
"typo3/sysext/backend/Migrations/Code/ClassAliasMap.php",
"typo3/sysext/core/Migrations/Code/ClassAliasMap.php",
"typo3/sysext/documentation/Migrations/Code/ClassAliasMap.php",
"typo3/sysext/extbase/Migrations/Code/ClassAliasMap.php",
......
......@@ -4,7 +4,7 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file",
"This file is @generated automatically"
],
"content-hash": "39981f9ff5c2b39ddf83a87ac8fc5d15",
"content-hash": "0e757db5e2ea6409800d3e505af4f744",
"packages": [
{
"name": "cogpowered/finediff",
......
<?php
namespace TYPO3\CMS\Backend;
namespace TYPO3\CMS\Backend\Controller;
/*
* This file is part of the TYPO3 CMS project.
......@@ -21,7 +21,7 @@ use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
/**
* This is the ajax handler for backend login after timeout.
*/
class AjaxLoginHandler
class AjaxLoginController
{
/**
* Handles the actual login process, more specifically it defines the response.
......
......@@ -122,27 +122,27 @@ return [
// Log in into backend
'login' => [
'path' => '/login',
'target' => \TYPO3\CMS\Backend\AjaxLoginHandler::class . '::loginAction',
'target' => \TYPO3\CMS\Backend\Controller\AjaxLoginController::class . '::loginAction',
'access' => 'public'
],
// Log out from backend
'logout' => [
'path' => '/logout',
'target' => \TYPO3\CMS\Backend\AjaxLoginHandler::class . '::logoutAction',
'target' => \TYPO3\CMS\Backend\Controller\AjaxLoginController::class . '::logoutAction',
'access' => 'public'
],
// Refresh login of backend
'login_refresh' => [
'path' => '/login/refresh',
'target' => \TYPO3\CMS\Backend\AjaxLoginHandler::class . '::refreshAction',
'target' => \TYPO3\CMS\Backend\Controller\AjaxLoginController::class . '::refreshAction',
],
// Check if backend session has timed out
'login_timedout' => [
'path' => '/login/timedout',
'target' => \TYPO3\CMS\Backend\AjaxLoginHandler::class . '::isTimedOutAction',
'target' => \TYPO3\CMS\Backend\Controller\AjaxLoginController::class . '::isTimedOutAction',
'access' => 'public',
'parameters' => [
'skipSessionUpdate' => 1
......
<?php
return [
'TYPO3\\CMS\\Backend\\AjaxLoginHandler' => \TYPO3\CMS\Backend\Controller\AjaxLoginController::class,
];
<?php
namespace {
die('Access denied');
}
namespace TYPO3\CMS\Backend {
class AjaxLoginHandler extends \TYPO3\CMS\Backend\Controller\AjaxLoginController
{
}
}
......@@ -30,6 +30,11 @@
"partOfMinimalUsableSystem": true
},
"extension-key": "backend"
},
"typo3/class-alias-loader": {
"class-alias-maps": [
"Migrations/Code/ClassAliasMap.php"
]
}
},
"autoload": {
......
.. include:: ../../Includes.txt
========================================================
Deprecation: #82805 - Renamed AjaxLoginHandler PHP class
========================================================
See :issue:`82805`
Description
===========
The PHP class :php:`TYPO3\CMS\Backend\AjaxLoginHandler` is renamed to the proper class name
:php:`TYPO3\CMS\Backend\Controller\AjaxLoginController` as its a controller class with actions.
Impact
======
Using the old PHP class is possible but any usages should be moved to the new class name.
Affected Installations
======================
Any TYPO3 instances using the PHP class directly in an extension.
Migration
=========
A extension scanner already checks for the old class name. A simple renaming of the class name
to the new class :php:`TYPO3\CMS\Backend\Controller\AjaxLoginController` is sufficient.
.. index:: PHP-API, FullyScanned
\ No newline at end of file
......@@ -437,6 +437,11 @@ return [
'Breaking-57594-OptimizeReflectionServiceCacheHandling.rst',
],
],
'TYPO3\CMS\Backend\AjaxLoginHandler' => [
'restFiles' => [
'Deprecation-82805-RenamedAjaxLoginHandlerPHPClass.rst',
],
],
// Removed interfaces
'TYPO3\CMS\Backend\Form\DatabaseFileIconsHookInterface' => [
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment