[TASK] Unify code in FileList
Currently, the Backend module File > FileList has two main views: * The list view * The search result view Both are handled via an Extbase controller, even though no pure Extbase-related feature (validation, type-converting, persistence) is used. Instead, the list view is generated by a PHP-based code "FileList" (similar to DatabaseRecordList), where as the search result view is built on top of Fluid. The latter approach hinders flexibility, and also leads to inconsistencies, due to the nature of using two different approaches. Most notable: - The search result view looks different than the list view, also no additional icons are possible. - The search result view has a clipboard, but does not allow to expand. - The search result view does not respect the listing limit, nor is the pagination displayed. - The search result view changes the module headline to "Search: <word>", removing the context on which folder the search was performed. However, the search result view works with the SearchDemand object which is a clean way to put the query requirements into the File List to render the found files. Therefore, this patch merges both Search Result Fluid view and PHP-based view back into one, more flexible and consistent, view. This also means, FileListController is not longer registered as an Extbase backend module and some internal ViewHelpers and classes were removed. The main benefits: * Exchanging features between DatabaseRecordList and FileList are easier to achieve * Hooks for additional icons also work in the search result view * Numeric Clipboards also work in the search result view * Buttons in each found file row look the same now * The current folder is now also displayed in search result view * Bookmarking also works properly now and additionally also takes a possible searchTerm into account * The search results are now paginated, respecting the listing limit * Invalid folders do not longer lead to an exception in the search result view Resolves: #87974 Resolves: #89867 Resolves: #92247 Resolves: #92747 Resolves: #93185 Releases: master Change-Id: I259fe7f63ef8ea69f6bdf0c787330f4338d4bd5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69718 Tested-by: core-ci <firstname.lastname@example.org> Tested-by: Benni Mack <email@example.com> Tested-by: Jochen <firstname.lastname@example.org> Tested-by: Oliver Bartsch <email@example.com> Reviewed-by: Benni Mack <firstname.lastname@example.org> Reviewed-by: Jochen <email@example.com> Reviewed-by: Oliver Bartsch <firstname.lastname@example.org>
This diff is collapsed.