Commit b856085b authored by Nadir S.'s avatar Nadir S. Committed by Susanne Moog
Browse files

[BUGFIX] Missing "Toggle all" label is added to "Access Rights" tab

Access Right tab has been missing the label for the "toggle all" checkbox.
'<div class="checkbox">' is needed in order to avoid style issues,
when the checkbox is put under accordion element.
Also the title under single-table view is corrected
(check all => toggle all).

Resolves: #76540
Releases: master
Related: #76470

Change-Id: I4ba636e22891157b39b03279906c8f08e9ad7880
Reviewed-on: https://review.typo3.org/48525


Reviewed-by: default avatarJoerg Boesche <typo3@joergboesche.de>
Tested-by: default avatarJoerg Boesche <typo3@joergboesche.de>
Reviewed-by: default avatarSusanne Moog <typo3@susannemoog.de>
Tested-by: default avatarSusanne Moog <typo3@susannemoog.de>
parent 144e625f
......@@ -78,6 +78,13 @@ table {
}
> thead > tr {
background-color: darken(@table-bg, 5%);
th.col-checkbox {
+ th.col-title {
label {
margin-bottom: 0px;
}
}
}
th,
td {
border-bottom: 1px solid @table-border-color;
......
......@@ -147,7 +147,7 @@ class SelectCheckBoxElement extends AbstractFormElement
$tableRows[] = '<td class="col-title">';
$tableRows[] = '<label class="label-block" for="' . $item['id'] . '">' . $item['title'] . '</label>';
$tableRows[] = '</td>';
$tableRows[] = '<td>' . $item['help'] . '</td>';
$tableRows[] = '<td class="text-right">' . $item['help'] . '</td>';
$tableRows[] = '</tr>';
$resetGroup[] = 'document.editform[' . GeneralUtility::quoteJSvalue($item['name']) . '].checked=' . $item['checked'] . ';';
}
......@@ -168,16 +168,17 @@ class SelectCheckBoxElement extends AbstractFormElement
if (is_array($group['header'])) {
$html[] = '<div id="' . $groupId . '" class="panel-collapse collapse" role="tabpanel">';
}
$title = $this->getLanguageService()->sL('LLL:EXT:lang/locallang_core.xlf:labels.toggleall');
$checkboxId = uniqid($groupId);
$title = htmlspecialchars($this->getLanguageService()->sL('LLL:EXT:lang/locallang_core.xlf:labels.toggleall'));
$html[] = '<div class="table-responsive">';
$html[] = '<table class="table table-transparent table-hover">';
$html[] = '<thead>';
$html[] = '<tr>';
$html[] = '<th class="col-checkbox">';
$html[] = '<input type="checkbox" class="t3js-toggle-checkboxes" data-trigger="hover" data-placement="right" data-title="' . htmlspecialchars($title) . '" data-toggle="tooltip" />';
$html[] = '<input type="checkbox" id="' . $checkboxId . '" class="t3js-toggle-checkboxes" data-trigger="hover" data-placement="right" data-title="' . $title . '" data-toggle="tooltip" />';
$html[] = '</th>';
$html[] = '<th class="col-icon"></th>';
$html[] = '<th class="text-right" colspan="2">' . $resetGroupBtn . '</th>';
$html[] = '<th class="col-title" colspan="2"><label for="' . $checkboxId . '">' . $title . '</label></th>';
$html[] = '<th class="text-right">' . $resetGroupBtn . '</th>';
$html[] = '</tr>';
$html[] = '</thead>';
$html[] = '<tbody>' . implode(LF, $tableRows) . '</tbody>';
......
......@@ -10127,6 +10127,9 @@ table {
.table > thead > tr {
background-color: #ededed;
}
.table > thead > tr th.col-checkbox + th.col-title label {
margin-bottom: 0px;
}
.table > thead > tr th,
.table > thead > tr td {
border-bottom: 1px solid #cccccc;
......
......@@ -1952,7 +1952,7 @@ class DatabaseRecordList extends AbstractDatabaseRecordList
<tr>
<th class="col-checkbox checkbox" colspan="2">
<label><input type="checkbox" class="checkbox checkAll" ' . ($checkAllChecked ? ' checked="checked"' : '') . '>
' . htmlspecialchars($lang->sL('LLL:EXT:lang/locallang_core.xlf:labels.checkAll')) . '</label>
' . htmlspecialchars($lang->sL('LLL:EXT:lang/locallang_core.xlf:labels.toggleall')) . '</label>
</th>
</tr>
</thead>
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment