Commit a89d3765 authored by Frank Nägler's avatar Frank Nägler Committed by Benni Mack
Browse files

[TASK] Massive performance improvement for page tree

This patch improves the performance by removing delays.

A single click in the tree loads the page now significantly faster, however,
the page is now loaded also with a doubleclick.

With a tree implementation without ExtJS we can change this behavior again.

Resolves: #63591
Releases: master
Change-Id: I4e32013d2d904e1cc4f91f8c9fa9af165fc8c476
Reviewed-on: http://review.typo3.org/39382


Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez's avatarAndreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
Tested-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
parent 11170b11
......@@ -173,25 +173,23 @@ TYPO3.Components.PageTree.Tree = Ext.extend(Ext.tree.TreePanel, {
listeners: {
// single click handler that only triggers after a delay to let the double click event
// a possibility to be executed (needed for label edit)
click: {
dblclick: {
fn: function(node, event) {
if (this.clicksRegistered === 2) {
this.clicksRegistered = 0;
event.stopEvent();
return false;
}
this.triggerEdit(node);
}
},
this.clicksRegistered = 0;
click: {
fn: function(node, event) {
if (this.commandProvider.singleClick) {
this.commandProvider.singleClick(node, this);
}
},
delay: 400
}
},
// prevent the expanding / collapsing on double click
beforedblclick: {
fn: function() {
fn: function(node, event) {
return false;
}
},
......
......@@ -35,7 +35,7 @@ TYPO3.Components.PageTree.TreeEditor = Ext.extend(Ext.tree.TreeEditor, {
*
* @type {int}
*/
editDelay: 250,
editDelay: 0,
/**
* Indicates if an underlying shadow should be shown
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment