Commit 555e116f authored by Alexander Schnitzler's avatar Alexander Schnitzler Committed by Benni Mack
Browse files

[TASK] Enable phpstan DefaultValueTypesAssignedToPropertiesRule

Releases: master
Resolves: #90893
Change-Id: Icc339442cded9a268fb66fe932b0f13de292e3b7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018


Reviewed-by: Oliver Klee's avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
parent b6aaba14
......@@ -13,7 +13,7 @@ rules:
- PHPStan\Rules\Functions\ReturnTypeRule
- PHPStan\Rules\Generators\YieldTypeRule
# - PHPStan\Rules\Methods\ReturnTypeRule
# - PHPStan\Rules\Properties\DefaultValueTypesAssignedToPropertiesRule
- PHPStan\Rules\Properties\DefaultValueTypesAssignedToPropertiesRule
# - PHPStan\Rules\Properties\TypesAssignedToPropertiesRule
- PHPStan\Rules\Variables\ThrowTypeRule
- PHPStan\Rules\Variables\VariableCloningRule
......
......@@ -345,7 +345,7 @@ class EditDocumentController
/**
* Used internally to disable the storage of the document reference (eg. new records)
*
* @var bool
* @var int
*/
protected $dontStoreDocumentRef = 0;
......
......@@ -92,7 +92,7 @@ abstract class AbstractTreeView
* Needs to be initialized with $GLOBALS['BE_USER']
* Done by default in init()
*
* @var \TYPO3\CMS\Core\Authentication\BackendUserAuthentication
* @var \TYPO3\CMS\Core\Authentication\BackendUserAuthentication|string
*/
public $BE_USER = '';
......
......@@ -25,7 +25,7 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
class ContentCreationPagePositionMap extends PagePositionMap
{
/**
* @var bool
* @var int
*/
public $dontPrintPageInsertIcons = 1;
......
......@@ -77,7 +77,7 @@ class BackendLayout
protected $contentFetcher;
/**
* @var LanguageColumn
* @var LanguageColumn[]
*/
protected $languageColumns = [];
......
......@@ -58,7 +58,7 @@ class LogEntry extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
/**
* Table name
*
* @var string
* @var string|int
*/
protected $tableName = 0;
......@@ -135,7 +135,7 @@ class LogEntry extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
/**
* New ID
*
* @var string
* @var string|int
*/
protected $newId = 0;
......
......@@ -557,7 +557,7 @@ class DataHandler implements LoggerAwareInterface
* Tells, that this DataHandler instance was called from \TYPO3\CMS\Impext\ImportExport.
* This variable is set by \TYPO3\CMS\Impext\ImportExport
*
* @var array
* @var bool
*/
public $callFromImpExp = false;
......
......@@ -23,7 +23,7 @@ class DefaultRestrictionContainer extends AbstractRestrictionContainer
/**
* Default restriction classes.
*
* @var QueryRestrictionInterface[]
* @var string[]
*/
protected $defaultRestrictionTypes = [
DeletedRestriction::class,
......
......@@ -28,7 +28,7 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
class FrontendRestrictionContainer extends AbstractRestrictionContainer
{
/**
* @var QueryRestrictionInterface[]
* @var string[]
*/
protected $defaultRestrictionTypes = [
DeletedRestriction::class,
......
......@@ -27,7 +27,7 @@ use TYPO3\CMS\Core\Messaging\FlashMessage;
class BootstrapRenderer implements FlashMessageRendererInterface
{
/**
* @var string The message severity class names
* @var string[] The message severity class names
*/
protected static $classes = [
FlashMessage::NOTICE => 'notice',
......@@ -38,7 +38,7 @@ class BootstrapRenderer implements FlashMessageRendererInterface
];
/**
* @var string The message severity icon names
* @var string[] The message severity icon names
*/
protected static $icons = [
FlashMessage::NOTICE => 'lightbulb-o',
......
......@@ -28,7 +28,7 @@ use TYPO3\CMS\Core\Messaging\FlashMessage;
class ListRenderer implements FlashMessageRendererInterface
{
/**
* @var string The message severity class names
* @var string[] The message severity class names
*/
protected static $classes = [
FlashMessage::NOTICE => 'notice',
......@@ -39,7 +39,7 @@ class ListRenderer implements FlashMessageRendererInterface
];
/**
* @var string The message severity icon names
* @var string[] The message severity icon names
*/
protected static $icons = [
FlashMessage::NOTICE => 'lightbulb-o',
......
......@@ -82,7 +82,7 @@ class Query implements QueryInterface
protected $statement;
/**
* @var int
* @var int[]
*/
protected $orderings = [];
......
......@@ -25,7 +25,7 @@ class Error extends \TYPO3\CMS\Extbase\Error\Error
protected $message = 'Unknown validation error';
/**
* @var string
* @var int
*/
protected $code = 1201447005;
}
......@@ -47,7 +47,7 @@ class DownloadController extends AbstractController
protected $downloadUtility;
/**
* @var JsonView
* @var string
*/
protected $defaultViewObjectName = JsonView::class;
......
......@@ -48,7 +48,7 @@ class UpdateFromTerController extends AbstractController
protected $extensionRepository;
/**
* @var JsonView
* @var string
*/
protected $defaultViewObjectName = JsonView::class;
......
......@@ -137,7 +137,7 @@ class FileListController extends ActionController implements LoggerAwareInterfac
/**
* BackendTemplateView Container
*
* @var BackendTemplateView
* @var string
*/
protected $defaultViewObjectName = BackendTemplateView::class;
......
......@@ -53,7 +53,7 @@ class FormEditorController extends AbstractBackendController
/**
* Default View Container
*
* @var BackendTemplateView
* @var string
*/
protected $defaultViewObjectName = BackendTemplateView::class;
......
......@@ -60,7 +60,7 @@ class FormManagerController extends AbstractBackendController
/**
* Default View Container
*
* @var BackendTemplateView
* @var string
*/
protected $defaultViewObjectName = BackendTemplateView::class;
......
......@@ -113,7 +113,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
/**
* The type (read-only)
* @var int
* @var int|string
*/
public $type = '';
......@@ -189,7 +189,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
/**
* sys_page-object, pagefunctions
*
* @var PageRepository
* @var PageRepository|string
*/
public $sys_page = '';
......@@ -223,7 +223,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
/**
* The frontend user
*
* @var FrontendUserAuthentication
* @var FrontendUserAuthentication|string
*/
public $fe_user = '';
......@@ -318,7 +318,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
/**
* TypoScript configuration of the page-object pointed to by sPre.
* $this->tmpl->setup[$this->sPre.'.']
* @var array
* @var array|string
*/
public $pSetup = '';
......@@ -357,7 +357,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
/**
* May be set to the pagesTSconfig
* @var array
* @var array|string
* @internal
*/
protected $pagesTSconfig = '';
......@@ -399,7 +399,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
public $additionalCSS = [];
/**
* @var string
* @var string
*/
public $JSCode;
......@@ -593,7 +593,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
/**
* Page content render object
*
* @var ContentObjectRenderer
* @var ContentObjectRenderer|string
*/
public $cObj = '';
......
......@@ -70,7 +70,7 @@ class AdministrationController extends ActionController
/**
* Backend Template Container
*
* @var BackendTemplateView
* @var string
*/
protected $defaultViewObjectName = BackendTemplateView::class;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment