Commit 4c6d1c9a authored by Georg Ringer's avatar Georg Ringer Committed by Oliver Bartsch
Browse files

[TASK] Cleanup code of ext:sys_note

Resolves: #96891
Releases: main
Change-Id: Ib77917f5517499d278e42a4406f81aa0445deaed
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73491

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
parent 476d6ecf
......@@ -26,14 +26,11 @@ use TYPO3\CMS\Core\Database\ConnectionPool;
*/
class SysNoteRepository
{
const SYS_NOTE_POSITION_BOTTOM = 0;
const SYS_NOTE_POSITION_TOP = 1;
public const SYS_NOTE_POSITION_BOTTOM = 0;
public const SYS_NOTE_POSITION_TOP = 1;
protected ConnectionPool $connectionPool;
public function __construct(ConnectionPool $connectionPool)
public function __construct(protected readonly ConnectionPool $connectionPool)
{
$this->connectionPool = $connectionPool;
}
/**
......
......@@ -27,11 +27,8 @@ use TYPO3\CMS\SysNote\Renderer\NoteRenderer;
*/
class InfoModuleHook
{
protected NoteRenderer $noteRenderer;
public function __construct(NoteRenderer $noteRenderer)
public function __construct(protected readonly NoteRenderer $noteRenderer)
{
$this->noteRenderer = $noteRenderer;
}
/**
......
......@@ -28,11 +28,8 @@ use TYPO3\CMS\SysNote\Renderer\NoteRenderer;
*/
final class PageModuleProvider
{
protected NoteRenderer $noteRenderer;
public function __construct(NoteRenderer $noteRenderer)
public function __construct(protected readonly NoteRenderer $noteRenderer)
{
$this->noteRenderer = $noteRenderer;
}
/**
......
......@@ -28,11 +28,8 @@ use TYPO3\CMS\SysNote\Renderer\NoteRenderer;
*/
class RecordListProvider
{
protected NoteRenderer $noteRenderer;
public function __construct(NoteRenderer $noteRenderer)
public function __construct(protected readonly NoteRenderer $noteRenderer)
{
$this->noteRenderer = $noteRenderer;
}
public function __invoke(RenderAdditionalContentToRecordListEvent $event): void
......
......@@ -26,9 +26,9 @@ class NoteVisibleFieldsTest extends FunctionalTestCase
protected array $coreExtensionsToLoad = ['sys_note'];
/**
* @var array
* @var string[]
*/
protected static $noteFields = [
protected static array $noteFields = [
'category',
'personal',
'subject',
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment