Commit 343df1b0 authored by Benni Mack's avatar Benni Mack Committed by Wouter Wolters
Browse files

[TASK] Move FE user intialization into constructor

Certain options are set from outside as public property,
however these options are always set and can be set from within
FrontendUserAuthentication itself.

This way, more "logic" is moved from TSFE into the appropriate
objects themselves.

Resolves: #78827
Releases: master
Change-Id: Iba0d0ff805a885895fafb09b8852679f9870dbe9
Reviewed-on: https://review.typo3.org/50799

Reviewed-by: Mathias Brodala's avatarMathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <typo3@scripting-base.de>
Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
parent b5e6ea74
......@@ -154,6 +154,9 @@ class FrontendUserAuthentication extends AbstractUserAuthentication
$this->sendNoCacheHeaders = false;
$this->getFallBack = true;
$this->getMethodEnabled = true;
$this->lockIP = $GLOBALS['TYPO3_CONF_VARS']['FE']['lockIP'];
$this->checkPid = $GLOBALS['TYPO3_CONF_VARS']['FE']['checkFeUserPid'];
$this->lifetime = (int)$GLOBALS['TYPO3_CONF_VARS']['FE']['lifetime'];
}
/**
......
......@@ -992,9 +992,6 @@ class TypoScriptFrontendController
public function initFEuser()
{
$this->fe_user = GeneralUtility::makeInstance(FrontendUserAuthentication::class);
$this->fe_user->lockIP = $GLOBALS['TYPO3_CONF_VARS']['FE']['lockIP'];
$this->fe_user->checkPid = $GLOBALS['TYPO3_CONF_VARS']['FE']['checkFeUserPid'];
$this->fe_user->lifetime = (int)$GLOBALS['TYPO3_CONF_VARS']['FE']['lifetime'];
// List of pid's acceptable
$pid = GeneralUtility::_GP('pid');
$this->fe_user->checkPid_value = $pid ? implode(',', GeneralUtility::intExplode(',', $pid)) : 0;
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment