Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • T TYPO3.CMS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • accessibilityaccessibility
  • TYPO3.CMS
  • Repository
  • TYPO3.CMS
  • typo3
  • sysext
  • install
  • Classes
  • Controller
  • UpgradeController.php
Find file Blame History Permalink
  • Tizian Schmidlin's avatar
    [BUGFIX] Ensure uniqid calls use more_entropy · e0c0b982
    Tizian Schmidlin authored Jun 02, 2020 and lolli's avatar lolli committed Sep 04, 2020
    Precision of `uniqid()` on Windows systems without passing
    `$more_entropy=true` has only single-second-resolution which will
    lead to non-unique ids on subsequent calls.
    
    In order to mitigate this issue TYPO3 provides the function
    `StringUtility::getUniqueId($prefix = '')` which calls
    `uniqid()` with parameter `$more_entropy` always set to true.
    
    Using `uniqid()`, especially with `$more_entropy` set to true,
    is quite slow, but for the purposes TYPO3 is using it
    (i.e. creating unique field names for backend forms, path
    identifiers in some modules etc.) it is good enough and
    another solution would not provide any measurable benefit.
    
    Resolves: #91553
    Releases: master, 10.4
    Change-Id: Ib4443e72621eee6df2daf5bf23054e1a01325783
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64652
    
    
    Tested-by: default avatarTYPO3com <noreply@typo3.com>
    Tested-by: default avatarJörg Bösche <typo3@joergboesche.de>
    Tested-by: default avatarAlexander Schnitzler <git@alexanderschnitzler.de>
    Tested-by: default avatarOliver Bartsch <bo@cedev.de>
    Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
    Reviewed-by: default avatarJörg Bösche <typo3@joergboesche.de>
    Reviewed-by: default avatarAlexander Schnitzler <git@alexanderschnitzler.de>
    Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
    Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
    e0c0b982