Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • T TYPO3.CMS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • accessibilityaccessibility
  • TYPO3.CMS
  • Repository
  • TYPO3.CMS
  • typo3
  • sysext
  • extbase
  • Classes
  • Http
  • ForwardResponse.php
Find file Blame History Permalink
  • Alexander Schnitzler's avatar
    [BUGFIX] Use ForwardResponse arguments if not null · b6c2a5ea
    Alexander Schnitzler authored Jul 21, 2021 and lolli's avatar lolli committed Jul 22, 2021
    Issue #92815 introduced a regression which triggered an endless
    recursion in case of a validation error.
    
    A bit longer explanation:
    
    Given there is an extbase controller action with an argument
    whose properties have to validated, extbase maps the incoming
    data of the request onto the internally handled arguments
    object which then performs the validation on all given arguments.
    
    In case of an error, extbase tries to redirect to the referring
    request aka the current request with an updated set of arguments.
    The idea is to remove all arguments of the current request to not
    trigger the same validation error again on the next try.
    
    There was a condition in the past which eventually led to the
    overriding of current arguments which was refactored wrong.
    
    The solution is to make the arguments of the ForwardResponse null
    by default and have the same null check like before.
    
    Releases: master
    Resolves: #94457
    Change-Id: I1701001ce0cf55df79b2ed896d69a08659a2902b
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70020
    
    
    Tested-by: default avatarcore-ci <typo3@b13.com>
    Tested-by: default avatarwaldhacker <hello@waldhacker.dev>
    Tested-by: default avatarOliver Bartsch <bo@cedev.de>
    Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
    Reviewed-by: default avatarwaldhacker <hello@waldhacker.dev>
    Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
    Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
    b6c2a5ea