Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • T TYPO3.CMS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • accessibilityaccessibility
  • TYPO3.CMS
  • Repository
Switch branch/tag
  • TYPO3.CMS
  • typo3
  • sysext
  • core
  • Classes
  • Resource
  • File.php
Find file BlameHistoryPermalink
  • Benni Mack's avatar
    [TASK] Replace ResourceFactory::getInstance() with makeInstance · 4ee479d6
    Benni Mack authored Jan 30, 2020 and Oliver Hader's avatar Oliver Hader committed Jan 30, 2020
    The so-called "singleton factory instance" is a wrapper around makeInstance
    which can be used directly anyways.
    
    With Dependency Injection this is not even necessary anymore, and should
    be avoided under all circumstances.
    
    The constructor does not cache anything, so this can be replaced completely.
    
    SingletonInterface + DI should be sufficient already.
    
    Resolves: #90260
    Releases: master
    Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076
    
    
    Tested-by: default avatarTYPO3com <noreply@typo3.com>
    Tested-by: Oliver Hader's avatarOliver Hader <oliver.hader@typo3.org>
    Reviewed-by: Oliver Hader's avatarOliver Hader <oliver.hader@typo3.org>
    4ee479d6