Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • T TYPO3.CMS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • accessibility
  • TYPO3.CMS
  • Repository
Switch branch/tag
  • TYPO3.CMS
  • ..
  • RecordDefault
  • Preview.html
Find file BlameHistoryPermalink
  • Oliver Hader's avatar
    [BUGFIX] Avoid crash due to endless loop in Fluid-based Page Module · 0a24d1e9
    Oliver Hader authored Jun 14, 2021 and Andreas Fernandez's avatar Andreas Fernandez committed Jul 09, 2021
    Page Module partial `PageLayout/Record/Preview` tries to render optional
    `PageLayout/Record/{item.record.CType}/Preview` and falls back to a raw
    representation if that custom partial does not exist.
    
    In case `CType` is empty, this resolves to `PageLayout/Record//Preview`
    which is actually using `PageLayout/Record/Preview.html` again - that's
    the partial again that initiated the process - which will after some
    seconds crash due to an endless loop of that partial.
    
    In order to make things explicit, the defaults are now located in
    their dedicated namespace `RecordDefault` to avoid ambiguity.
    
    * `PageLayout/Record/Preview` -> `PageLayout/RecordDefault/Preview`
    * `PageLayout/Record/Header` -> `PageLayout/RecordDefault/Header`
    * `PageLayout/Record/Footer` -> `PageLayout/RecordDefault/Footer`
    
    Resolves: #94343
    Releases: 10.4, master
    Change-Id: I0c0385a9d89561de2395fc81124e471ee9fed8dd
    Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69493
    
    Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
    Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
    Tested-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
    Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
    Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
    0a24d1e9