[TASK] Remove the broken (and unneeded) no-cache header detection

The hook was registered to the 'tslib_fe-PostPrc' callback.
That callback is run at the end of the TSFE's constructor.
At that time the beUserLogin is not yet filled, but always initialized to NULL.
Cause of that the cache detection will always return FALSE and the hook never clears anything.

Removing this now since we're receiving a cache update in the insertPageIncache anyway
and don't need to check for the headers ourselves.

diff --git a/Classes/Hook/HeaderNoCache.php b/Classes/Hook/HeaderNoCache.php
deleted file mode 100644 (file)
index 54af8cf..0000000
--- a/Classes/Hook/HeaderNoCache.php
+++ /dev/null
@@ -1,43 +0,0 @@
-<?php
-/**
- * Clear the cache if there is a no cache header
- *
- * @package SFC\NcStaticfilecache\Hook
- * @author  Tim Lochmüller
- */
-
-namespace SFC\NcStaticfilecache\Hook;
-
-use SFC\NcStaticfilecache\Utility\CacheUtility;
-use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
-
-/**
- * Clear the cache if there is a no cache header
- *
- * @author Tim Lochmüller
- */
-class HeaderNoCache
-{
-
-    /**
-     * Detecting if shift-reload has been clicked. Will not be called if re-
-     * generation of page happens by other reasons (for instance that the page
-     * is not in cache yet!) Also, a backend user MUST be logged in for the
-     * shift-reload to be detected due to DoS-attack-security reasons.
-     *
-     * @param    array $params : array containing pObj among other things
-     * @param    TypoScriptFrontendController $parent : The calling parent object
-     *
-     * @return    void
-     */
-    public function headerNoCache(array &$params, TypoScriptFrontendController $parent)
-    {
-        $header = [
-            strtolower($_SERVER['HTTP_CACHE_CONTROL']),
-            strtolower($_SERVER['HTTP_PRAGMA'])
-        ];
-        if (in_array('no-cache', $header) && $parent->beUserLogin) {
-            CacheUtility::clearByPageId($parent->id);
-        }
-    }
-}

diff --git a/ext_localconf.php b/ext_localconf.php
index 2cef454..c7acab6 100644 (file)
--- a/ext_localconf.php
+++ b/ext_localconf.php
@@ -22,11 +22,6 @@ $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPo
 // Create cache
 $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['insertPageIncache'][$_EXTKEY] = 'SFC\\NcStaticfilecache\\StaticFileCache';
 
-// Catch Ctrl + Shift + reload (only works when backend user is logged in)
-//     You need the be_typo_user cookie detection enabled in the rewrite rules
-//     for this to work.
-$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-PostProc'][$_EXTKEY] = $hookNamespace . 'HeaderNoCache->headerNoCache';
-
 // Set cookie when User logs in
 $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['initFEuser'][$_EXTKEY] = $hookNamespace . 'InitFrontendUser->setFeUserCookie';
 $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['logoff_post_processing'][$_EXTKEY] = $hookNamespace . 'LogoffFrontendUser->logoff';