From eb042540bda64ae8af518783a3fa024ce1f500d6 Mon Sep 17 00:00:00 2001 From: Christoph Lehmann Date: Tue, 18 Dec 2018 23:23:52 +0100 Subject: [PATCH] [TASK] Do not show error when copying a record was succesful MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit https://review.typo3.org/#/c/32356/ introduced the log message The change was about skipping the direct copyRecord() call for records that will be processed inside another copyRecord() call for the record of the default language Due to https://review.typo3.org/#/c/51070/ $overrideValues contains ['l10n_source' => 0] When an element is copied inside an earlier copyRecord() call the error log message is generated which leads to an error flash message editors see when copying a page, but everything (copying the records once) went fine. A earlier call of copyRecord() can occur when using extension like gridelements when copying a content element laying inside a grid container element. Resolves: #82032 Releases: master, 9.5, 8.7 Change-Id: I0d5be8e8920852a0e0c5a5ee93a67f9a6426e941 Reviewed-on: https://review.typo3.org/59202 Reviewed-by: Marcel Tams Tested-by: Marcel Tams Tested-by: TYPO3com Reviewed-by: Christian Lange Tested-by: Christian Lange Reviewed-by: DANIEL Rémy Reviewed-by: Mathias Brodala Tested-by: Mathias Brodala --- typo3/sysext/core/Classes/DataHandling/DataHandler.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/typo3/sysext/core/Classes/DataHandling/DataHandler.php b/typo3/sysext/core/Classes/DataHandling/DataHandler.php index fbe3434253f9..26f920ff678b 100644 --- a/typo3/sysext/core/Classes/DataHandling/DataHandler.php +++ b/typo3/sysext/core/Classes/DataHandling/DataHandler.php @@ -3559,9 +3559,6 @@ class DataHandler implements LoggerAwareInterface return null; } if ($this->isRecordCopied($table, $uid)) { - if (!empty($overrideValues)) { - $this->log($table, $uid, 1, 0, 1, 'Repeated attempt to copy record "%s:%s" with override values', -1, [$table, $uid]); - } return null; } -- 2.20.1