From 82d2a234889a68ba3b6eb5290defe3ebb447a012 Mon Sep 17 00:00:00 2001 From: Christian Kuhn Date: Thu, 10 Jan 2019 12:27:55 +0100 Subject: [PATCH 1/1] [TASK] Remove unit tests that do not test the subject Some tests in FrontendLoginControllerTest test only GeneralUtility::getIndpEnv(), but not the system under test FrontendLoginController. Remove those. Resolves: #87389 Releases: master Change-Id: I3ea71c15ad8eda16750bfec1367ee4cc439dee2f Reviewed-on: https://review.typo3.org/59397 Tested-by: TYPO3com Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters --- .../FrontendLoginControllerTest.php | 38 ------------------- 1 file changed, 38 deletions(-) diff --git a/typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php b/typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php index a9e6c4bc0f60..728bcee90256 100644 --- a/typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php +++ b/typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php @@ -75,44 +75,6 @@ class FrontendLoginControllerTest extends UnitTestCase $_SERVER['HTTP_HOST'] = $this->testHostName; } - /** - * @test - */ - public function typo3SitePathEqualsStubSitePath() - { - $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_PATH'), $this->testSitePath); - } - - /** - * @test - */ - public function typo3SiteUrlEqualsStubSiteUrl() - { - $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_URL'), ('http://' . $this->testHostName) . $this->testSitePath); - } - - /** - * @test - */ - public function typo3SitePathEqualsStubSitePathAfterChangingInTest() - { - $this->testHostName = 'somenewhostname.com'; - $this->testSitePath = '/somenewpath/'; - $this->setUpFakeSitePathAndHost(); - $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_PATH'), $this->testSitePath); - } - - /** - * @test - */ - public function typo3SiteUrlEqualsStubSiteUrlAfterChangingInTest() - { - $this->testHostName = 'somenewhostname.com'; - $this->testSitePath = '/somenewpath/'; - $this->setUpFakeSitePathAndHost(); - $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_URL'), ('http://' . $this->testHostName) . $this->testSitePath); - } - /** * Data provider for validateRedirectUrlClearsUrl * -- 2.20.1