Packages/TYPO3.CMS.git
4 months ago[RELEASE] Release of TYPO3 8.7.19 77/57977/2 8.7.19 TYPO3_8-7-19 v8.7.19
Oliver Hader [Tue, 21 Aug 2018 07:23:14 +0000 (09:23 +0200)]
[RELEASE] Release of TYPO3 8.7.19

Change-Id: Icebb01597d3d54382f5f79fcdb19cbdbb144ca61
Reviewed-on: https://review.typo3.org/57977
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Revert deprecation introduced by backport 76/57976/2
Anja Leichsenring [Mon, 20 Aug 2018 20:55:52 +0000 (22:55 +0200)]
[TASK] Revert deprecation introduced by backport

Remove trigger_error call and according rst file.

Change-Id: Ie383d7de12b27d6ee8f60881538a79120d5ed899
Releases: 8.7
Resolves: #85913
Relates: #83750
Reviewed-on: https://review.typo3.org/57976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Fix calling checkIncludeLines non statically in BackendLayoutView 68/57968/2
Wouter Wolters [Thu, 16 Aug 2018 21:19:51 +0000 (23:19 +0200)]
[BUGFIX] Fix calling checkIncludeLines non statically in BackendLayoutView

The method checkIncludeLines in TypoScriptParser should be called
statically in the class BackendLayoutView.

Resolves: #85882
Releases: master,8.7
Change-Id: Ib774ee41528741953576acb82f046ed45e7acc75
Reviewed-on: https://review.typo3.org/57968
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
4 months agoRevert "[BUGFIX] Detect current ImageMagick Version 7 for Windows." 66/57966/4
Jigal van Hemert [Mon, 20 Aug 2018 11:01:13 +0000 (13:01 +0200)]
Revert "[BUGFIX] Detect current ImageMagick Version 7 for Windows."

This reverts commit a4340b6c03fd416e8ca2ac2f59e8582a102fcb8c.

Due to the PHP fatal error in TYPO3\CMS\Core\Utility\CommandUtility
"Class TYPO3\CMS\Core\Utility\Environment", the change gets reverted.
TYPO3\CMS\Core\Utility\Environment was first introduced in TYPO3 v9
and thus does not exist in TYPO3 v8.

Resolves: #85908
Related: #80909
Change-Id: I2eba784e0a6fd83d1d9a70db7b57c89c54d29f55
Reviewed-on: https://review.typo3.org/57966
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] Extract metadata for new files in storage 60/57960/2
Andreas Fernandez [Thu, 9 Aug 2018 14:18:03 +0000 (16:18 +0200)]
[BUGFIX] Extract metadata for new files in storage

If files in a remote storage are fetched the first time by FAL, the
metadata of these files is now extracted automatically, if the storage
supports this feature.

Resolves: #85786
Releases: master, 8.7
Change-Id: I4006ea2f39bbbbf0d6fe6a1f2adf2e79cdfbd5c5
Reviewed-on: https://review.typo3.org/57960
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[TASK] Update typo3fluid/fluid to 2.5.4 54/57954/2
Markus Klein [Fri, 17 Aug 2018 21:42:06 +0000 (23:42 +0200)]
[TASK] Update typo3fluid/fluid to 2.5.4

This mainly includes fixes for ternary expressions.

composer command used:
composer update typo3fluid/fluid

Resolves: #85896
Releases: 8.7
Change-Id: Ibcafabdacc62b90ddb38afe527296348d2535310
Reviewed-on: https://review.typo3.org/57954
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[SECURITY] Ensure validity of parameters submitted to ThumbnailController 53/57953/2
Oliver Hader [Fri, 17 Aug 2018 06:49:14 +0000 (08:49 +0200)]
[SECURITY] Ensure validity of parameters submitted to ThumbnailController

Parameters submitted to ThumbnailController via HTTP GET query parameters
can contain arbitrary information. Thus, it has to be verified that those
parameters are valid by signing them with a HMAC.

Prior to that the source code was vulnerable to information disclosure as
well as denial of service attacks due to unsanitized user input. A valid
backend user account was required in order to make use of these flaws.

Since the change which introduced this behavior was not released yet, the
security fixes are handled in public without additional announcements.

Resolves: #85875
Releases: master, 8.7
Change-Id: Ia53ba3756f140b0728b8fd1fb7e0527836639a6b
Reviewed-on: https://review.typo3.org/57953
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Use non-static method getCache in Avatar class 36/57936/2
Wouter Wolters [Thu, 16 Aug 2018 20:28:03 +0000 (22:28 +0200)]
[BUGFIX] Use non-static method getCache in Avatar class

The getCache method is not static but called as static twice.
Use $this->getCache() instead.

Resolves: #85879
Releases: master,8.7
Change-Id: Icfb28989c201894d0bfd2867642d7703426fabc2
Reviewed-on: https://review.typo3.org/57936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Move test file to right location 24/57924/3
Benni Mack [Wed, 15 Aug 2018 17:53:44 +0000 (19:53 +0200)]
[BUGFIX] Move test file to right location

The tests in change https://review.typo3.org/57370/
have been put in the wrong folder and are never
executed by the TYPO3 Core Unit Test suite.

This patch moves the file into the right location.

Resolves: #85868
Related: #81620
Releases: master, 8.7
Change-Id: I8cb95031c3198d1955ee800b2137b770400acde8
Reviewed-on: https://review.typo3.org/57924
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Remove attribute 'selected' if its value is false 14/57814/4
Georg Ringer [Thu, 22 Mar 2018 13:34:13 +0000 (14:34 +0100)]
[BUGFIX] Remove attribute 'selected' if its value is false

If the selected attribute is set to false (or zero), the
attribute itself must not be shown as even if it is empty it would be
meant to set the option to selected.

Resolves: #83229
Releases: master, 8.7
Change-Id: Ic2c87bf7b603eac288a4ce9d38a4ce75c5817f3d
Reviewed-on: https://review.typo3.org/57814
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Improve TS Template module information on root level list 56/57856/6
Joerg Kummer [Sat, 4 Aug 2018 13:52:09 +0000 (15:52 +0200)]
[TASK] Improve TS Template module information on root level list

The template tool on root level, which displays an overview of pages
including templates, now displays instead of the count of templates
all related templates of a page with several informations like:
- title
- state (by icon)
- is root or extend
- direct link to edit (with ID ans site-title as link title)
Pages in rootline, which do not includes templates itself are no longer
linked to the template modul.
Database query has been streamlined, and all render logic of
Html specific output has been moved to FLUID templating.
This offers the possibility to add filter or search to this view.
An issue with page sorting in page tree, when rootline pages does not
contain TS templates has been fixed.

Resolves: #81430
Releases: master, 8.7
Change-Id: I5250c53df1acc4a1a29839ce4a472f3e863ae992
Reviewed-on: https://review.typo3.org/57856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Use params set in db in recordLinkHandler 83/57883/2
Susanne Moog [Mon, 25 Jun 2018 18:39:31 +0000 (20:39 +0200)]
[BUGFIX] Use params set in db in recordLinkHandler

Resolving of links with a custom record link handler is now done
in the following order:

- TypoScriptConfiguration Parameters
- Parameters set in link field in content element
- If param is empty in link field but set in config that is taken into
account as a fallback
- It is _not_ possible to unset a value (class, title, target, link) in
the link field if it _is_ set to a default value in TypoScript

Caveat: Overwriting attributes only works if they are set via parameter
in configuration _not_ if they are set via ATagParams.

Resolves: #81620
Releases: master, 8.7
Change-Id: Ie723e7d7d36a03bac4ec97211749317d7311dd3e
Reviewed-on: https://review.typo3.org/57883
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Use full namespace in a documentation file 74/57874/2
Franz Holzinger [Sat, 11 Aug 2018 15:35:17 +0000 (17:35 +0200)]
[TASK] Use full namespace in a documentation file

Releases: master, 8.7
Resolves: #85817
Change-Id: Ifac7a5545d9467a6973bfef55e264fe263d10396
Reviewed-on: https://review.typo3.org/57874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Use proper phpDoc in PSR-7 implementation 64/57864/2
Benni Mack [Fri, 10 Aug 2018 18:39:47 +0000 (20:39 +0200)]
[BUGFIX] Use proper phpDoc in PSR-7 implementation

This fixes some IDE issues when working with PSR-7 classes within TYPO3.

Resolves: #85811
Releases: master, 8.7
Change-Id: I69b9fed8a603b32ac6bfed57c251907d09dcae19
Reviewed-on: https://review.typo3.org/57864
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Enable localizationStateSelector for selectTreeElement 26/57826/2
Torben Hansen [Tue, 7 Aug 2018 05:21:53 +0000 (07:21 +0200)]
[BUGFIX] Enable localizationStateSelector for selectTreeElement

Follow up of the backport for TYPO3 8.7, where some lines of code
have not been merged.

Enables the localizationStateSelector for the selectTreeElement.

Resolves: #84564
Releases: 8.7
Change-Id: Ie39c52652b5175318694775a9dfa5fbbf33f490c
Reviewed-on: https://review.typo3.org/57826
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Tim Schreiner <schreiner.tim@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Add documentation render directories to .gitignore 57/57857/2
Sybille Peters [Thu, 2 Aug 2018 08:30:49 +0000 (10:30 +0200)]
[TASK] Add documentation render directories to .gitignore

Add directory created by documentation rendering to .gitignore.

Rendering the docs locally is helpful for checking if it will render
correctly on the server. This will create the rendered files in
typo3/sysext/*/Documentation-GENERATED-temp/.

Adding this to .gitignore will prevent accidentally adding the generated
documentation to a patch.

Resolves: #85725
Releases: master, 8.7
Change-Id: Ibcff2570b961e1f1add519ead49e565c671a28ba
Reviewed-on: https://review.typo3.org/57857
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[TASK] Change URL of TYPO3_URL_DONATE constant 48/57848/2
Wouter Wolters [Thu, 9 Aug 2018 14:58:38 +0000 (16:58 +0200)]
[TASK] Change URL of TYPO3_URL_DONATE constant

Resolves: #85791
Releases: master,8.7
Change-Id: Ib90b3a0dcc77ba5f6006232ac8357e5a50ec782a
Reviewed-on: https://review.typo3.org/57848
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Improve readability of 8.x Changelog 41/57841/2
Daniel Siepmann [Tue, 7 Aug 2018 10:55:29 +0000 (12:55 +0200)]
[TASK] Improve readability of 8.x Changelog

Only breaking changes and important changes were adjusted for now.

* Fix rst syntax issues, like missing blank line before list.
* Add roles for highlighting of inline files and code.
* Add link to mentioned issues.
* Prefix PHP Globals with $GLOBALS[] to keep things as they are in real
  world and to keep it the same between all files.
* Use single formats, e.g. always '*' for lists. This will make
  refactorings and other stuff easier.

Resolves: #85771
Releases: master, 8.7
Change-Id: I47f7db732ab1da751c6f84469152d7209e065c19
Reviewed-on: https://review.typo3.org/57841
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Fix wrong changelog information for #82794 40/57840/2
Daniel Siepmann [Thu, 9 Aug 2018 06:29:28 +0000 (08:29 +0200)]
[BUGFIX] Fix wrong changelog information for #82794

The introduced keyword is called pageNotFound and is available for the
existing keyword content_fallback.
"stop" and "fallback" were wrong.

* Fix wrong syntax to allow rendering of list.
* Add roles for syntax highlighting of TS.
* Add styling to inline configuration.

Resolves: #85771
Releases: master, 8.7
Change-Id: I6cb36d2b680527ab402c0fc8cb8245d90c5accd7
Reviewed-on: https://review.typo3.org/57840
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Show speaking exception message if form definition is invalid 87/57487/3
Ralf Zimmermann [Fri, 22 Jun 2018 23:46:48 +0000 (01:46 +0200)]
[TASK] Show speaking exception message if form definition is invalid

Show a speaking exception message within the frontend if the
form definition is invalid.

Change-Id: Ifcb0684c9b5136c5dee5ac6b54732fcde02d82cf
Releases: master, 8.7
Resolves: #85357
Reviewed-on: https://review.typo3.org/57487
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] EXT:form - really disable records overview in redirect finisher 18/57818/2
Mathias Brodala [Wed, 18 Oct 2017 07:38:42 +0000 (09:38 +0200)]
[BUGFIX] EXT:form - really disable records overview in redirect finisher

Resolves: #82786
Releases: master, 8.7
Change-Id: I9cdfbcd5e0f25b832ea546f1b8c70a9f544b31aa
Reviewed-on: https://review.typo3.org/57818
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Adapt TCA signature for customControls to the documentation 17/57817/2
Xavier Perseguers [Tue, 10 Jul 2018 09:41:10 +0000 (11:41 +0200)]
[BUGFIX] Adapt TCA signature for customControls to the documentation

According to the documentation since TYPO3 v4.7, the definition of
"customControls" for "inline" columns should be a numerical array
with at least a "userFunc" key, just as any user function.

Releases: master, 8.7
Resolves: #83750
Change-Id: I2617cc9af9d642715b908296a2d75a3945b86cbb
Reviewed-on: https://review.typo3.org/57817
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Detect current ImageMagick Version 7 for Windows. 13/57813/2
Michael Kersten [Sat, 4 Aug 2018 12:10:55 +0000 (14:10 +0200)]
[BUGFIX] Detect current ImageMagick Version 7 for Windows.

Try to use magick.exe if executable does not exists.

ImageMagick Version 7 for Windows does not use the executables for
identify, convert and combine/composite anymore. Instead the executable
magick.exe is used.

Resolves: #80909
Releases: master, 8.7
Change-Id: I823d399b723077e726b1105192474607b43fa907
Reviewed-on: https://review.typo3.org/57813
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[BUGFIX] Determine default language as origin correctly 00/57700/3
Nicole Cordes [Fri, 27 Jul 2018 11:44:11 +0000 (13:44 +0200)]
[BUGFIX] Determine default language as origin correctly

Resolves: #85638
Releases: master, 8.7
Change-Id: I98ecaef360d5a27e965cbb67c5719729054b9c37
Reviewed-on: https://review.typo3.org/57700
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Remove usage of non core tables in linkvalidator configuration 85/57485/2
Georg Ringer [Sat, 23 Jun 2018 18:34:29 +0000 (20:34 +0200)]
[BUGFIX] Remove usage of non core tables in linkvalidator configuration

To avoid possible errors the non core table tt_news is removed from
the linkvalidator configuration.

Resolves: #85328
Releases: master, 8.7
Change-Id: I47df2adf743197354dfd685a1b259a2c1a5053c7
Reviewed-on: https://review.typo3.org/57485
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Block web access to *.tsconfig files 12/57812/2
Stephan Großberndt [Fri, 3 Aug 2018 08:22:02 +0000 (10:22 +0200)]
[TASK] Block web access to *.tsconfig files

Resolves: #85738
Releases: master, 8.7
Change-Id: I824cdce7c08e5390eafb654e2066b8f61db3c0ac
Reviewed-on: https://review.typo3.org/57812
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Set table cell alignment in Indexing Engine Statistics to top 08/57808/3
Joerg Kummer [Sat, 4 Aug 2018 15:14:45 +0000 (17:14 +0200)]
[TASK] Set table cell alignment in Indexing Engine Statistics to top

Add CSS class "table-vertical-top" to table in template "Statistic"
for controller "Administration" in extension "indexed_search".

Resolves: #79549
Releases: master, 8.7
Change-Id: Iab6309a957340af7f1f0f2959b14da4c1eedc7a4
Reviewed-on: https://review.typo3.org/57808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Replace default value with placeholder in external url link handler 92/57792/3
Joerg Boesche [Tue, 31 Jul 2018 06:48:50 +0000 (08:48 +0200)]
[TASK] Replace default value with placeholder in external url link handler

Use a placeholder attribute instead of a default value.

Resolves: #85689
Releases: master, 8.7
Change-Id: I99398125e16985ba78b3887150157da2b2c01905
Reviewed-on: https://review.typo3.org/57792
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Decouple thumbnail generation from controllers 82/57682/2
Mathias Schreiber [Fri, 20 Apr 2018 19:23:35 +0000 (21:23 +0200)]
[BUGFIX] Decouple thumbnail generation from controllers

Deferred rendering of thumbnails via an external request speed up
the backend performance. This currently works in all places that use
BackendUtility::thumbsCode.

Resolves: #85605
Releases: master, 8.7
Change-Id: Id5635fc9cd340b8bcf21995cd457415aaa1a8926
Reviewed-on: https://review.typo3.org/57682
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Avoid exception for int label column 80/57780/2
Stephan Großberndt [Thu, 2 Aug 2018 11:51:39 +0000 (13:51 +0200)]
[BUGFIX] Avoid exception for int label column

By casting the title column to string for the label of an TCA record an
exception caused by a strict type check is avoided when shortening the
title.

Resolves: #85729
Related: #79440
Releases: master, 8.7
Change-Id: Ie365b92ae73cd766c412d66ff7624eebbbfb3cf7
Reviewed-on: https://review.typo3.org/57780
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Show thumbnail in list module for columns in palettes 44/57744/2
David Gurk [Fri, 27 Apr 2018 13:55:35 +0000 (15:55 +0200)]
[BUGFIX] Show thumbnail in list module for columns in palettes

By replacing the palettes in showitem of types with their content,
the following condition can consider the columns within the palettes.

Resolves: #84885
Related: #26753
Releases: master, 8.7
Change-Id: I6561fc862cb4ed569ee886e4d070e9fba6a1654b
Reviewed-on: https://review.typo3.org/57744
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Correctly render language fields of sys_file_metadata 61/57761/2
Nicole Cordes [Wed, 1 Aug 2018 18:56:17 +0000 (20:56 +0200)]
[BUGFIX] Correctly render language fields of sys_file_metadata

This reverts commit 1a74c8c9d302958dd17b6a35c03e185f13811c4b
("[BUGFIX] Correctly reference sys_file_metadata.language in TCA"),
that replaced the rendering of sys_language_uid and l10n_parent
with the file language field, which was since then rendered twice.

We now correctly render the hidden language palette in the general tab
and remove the language tab, which was empty after the palette has been
hidden.

Resolves: #85711
Related: #84200
Related: #75040
Releases: master, 8.7
Change-Id: I18ab907bc48f81b257d3af42c4278d6688166b2f
Reviewed-on: https://review.typo3.org/57761
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Volkmer <typo3@markusvolkmer.de>
Tested-by: Markus Volkmer <typo3@markusvolkmer.de>
Reviewed-by: Moritz Ngo <moritz.ngo@p2media.de>
Tested-by: Moritz Ngo <moritz.ngo@p2media.de>
Reviewed-by: Dennis Oezet <dennisoezet@gmx.net>
Tested-by: Dennis Oezet <dennisoezet@gmx.net>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[BUGFIX] Allow requirejs modules from wizards in RTE fields 55/57755/3
Helmut Hummel [Wed, 1 Aug 2018 10:42:47 +0000 (12:42 +0200)]
[BUGFIX] Allow requirejs modules from wizards in RTE fields

The RichTextElement must not unset "requireJsModules"
from the result array as this removes previously added
modules.

Resolves: #85705
Releases: master, 8.7
Change-Id: I495732f0a1f16db84b8ec6daa2fd028e4a3a9dee
Reviewed-on: https://review.typo3.org/57755
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[BUGFIX] Send AJAX data in EXT:recycler as POST 51/57751/2
Stephan Großberndt [Tue, 31 Jul 2018 13:37:32 +0000 (15:37 +0200)]
[BUGFIX] Send AJAX data in EXT:recycler as POST

By sending the uids of the records to really delete or recover by POST
instead of GET an HTTP error "414 Request-URI too long" is avoided when
deleting many records at once.

Resolves: #85696
Releases: master, 8.7
Change-Id: Ia8b7d5330a281bdc7916001a6b29a857f91bb986
Reviewed-on: https://review.typo3.org/57751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Use filename with extension for copy to temp test 48/57748/2
Jigal van Hemert [Fri, 6 Jul 2018 17:25:10 +0000 (19:25 +0200)]
[BUGFIX] Use filename with extension for copy to temp test

Since the extension will be added to the temporary file name there
will be an error in Windows if the file name has no extension.
Windows will not create files with a name ending with a dot.

Resolves: #85502
Releases: master, 8.7
Change-Id: I45beb47525681fff314c17f943d77cec55df35c0
Reviewed-on: https://review.typo3.org/57748
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Recycler: disable mass delete/recover if no record is selected 43/57743/2
Josef Glatz [Sun, 29 Jul 2018 20:22:56 +0000 (22:22 +0200)]
[BUGFIX] Recycler: disable mass delete/recover if no record is selected

This patch really disables the mass delete/recover button
functionality of the recycler.

Resolves: #85680
Releases: master, 8.7
Change-Id: I5a6ba4f555cc06b017f3d9ff8deef7d7deac03db
Reviewed-on: https://review.typo3.org/57743
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Allow Error\Error to be translated in form extension 42/57742/2
Daniel Siepmann [Wed, 18 Jul 2018 11:18:28 +0000 (13:18 +0200)]
[BUGFIX] Allow Error\Error to be translated in form extension

Some errors added while processing forms are of Type
TYPO3\CMS\Extbase\Error\Error instead of
TYPO3\CMS\Extbase\Validation\Error as they occur in different places.
E.g. the mime type check is handled inside the TypeConverter and file
uploads can be canceled due to file size.

These errors should not lead to errors when rendered in Fluid.

Resolves: #85586
Releases: master, 8.7
Change-Id: I02eafff4b7d56a661eb956ff107c0eb0476fd6a7
Reviewed-on: https://review.typo3.org/57742
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Set TYPO3 version to 8.7.19-dev 39/57739/2
Oliver Hader [Tue, 31 Jul 2018 08:16:33 +0000 (10:16 +0200)]
[TASK] Set TYPO3 version to 8.7.19-dev

Change-Id: Iac5eb871c8ef09af08f4af1d776d3cecc6d720c0
Reviewed-on: https://review.typo3.org/57739
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[RELEASE] Release of TYPO3 8.7.18 38/57738/2 8.7.18 TYPO3_8-7-18 v8.7.18
Oliver Hader [Tue, 31 Jul 2018 08:15:12 +0000 (10:15 +0200)]
[RELEASE] Release of TYPO3 8.7.18

Change-Id: I454861e99332d17f31efd110f75938ac3a10acc4
Reviewed-on: https://review.typo3.org/57738
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[BUGFIX] The form upgrade wizard must update all plugin settings 31/57731/4
Ralf Zimmermann [Thu, 12 Jul 2018 20:48:42 +0000 (22:48 +0200)]
[BUGFIX] The form upgrade wizard must update all plugin settings

The form definition renaming upgrade wizard renames the persistence
identifier within the form plugin flexform.
As a result, finisher overrides can no longer be properly assigned.
This patch adds an upgrade wizard which will be able to restore these
finisher overrides.

Resolves: #85544
Releases: master, 8.7
Change-Id: Idf1ffd8432fed88431b9a0feb407f42df3304401
Reviewed-on: https://review.typo3.org/57731
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[TASK] Update swiftmailer/swiftmailer to 5.4.10 17/57717/2
Georg Ringer [Fri, 27 Jul 2018 18:29:24 +0000 (20:29 +0200)]
[TASK] Update swiftmailer/swiftmailer to 5.4.10

Update swiftmailer to 5.4.10 to support TLS 1.1 / 1.2.

composer update swiftmailer/swiftmailer

Resolves: #85667
Releases: master, 8.7
Change-Id: Ic4cf3736b3f2c23b6febb138c6405b67d9bd8e12
Reviewed-on: https://review.typo3.org/57717
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Add form framework RequiredValidatorEditor test 16/57716/2
Oliver Hader [Sun, 29 Jul 2018 09:37:44 +0000 (11:37 +0200)]
[TASK] Add form framework RequiredValidatorEditor test

Resolves: #85673
Related: #85608
Releases: master, 8.7
Change-Id: If351dd316c628450e09e579d0cccbe7a7cefe213
Reviewed-on: https://review.typo3.org/57716
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Document integration of PharStreamWrapper 10/57710/2
Oliver Hader [Fri, 27 Jul 2018 12:28:02 +0000 (14:28 +0200)]
[TASK] Document integration of PharStreamWrapper

Resolves: #85658
Releases: master, 8.7, 7.6
Change-Id: I6acdc235dff4b3c0c84a8a6d762d497f8d9664cc
Reviewed-on: https://review.typo3.org/57701
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-on: https://review.typo3.org/57710

5 months ago[TASK] Add scheduler package as suggested if used 07/57707/2
Georg Ringer [Fri, 27 Jul 2018 18:26:39 +0000 (20:26 +0200)]
[TASK] Add scheduler package as suggested if used

If a system extension uses the scheduler it should be added to the suggest section.

Resolves: #85671
Releases: master, 8.7
Change-Id: I2f0f8155c768eb140ef6a900640e2d18ac615d79
Reviewed-on: https://review.typo3.org/57707
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
5 months ago[BUGFIX] Allow "defaultValue" for select form elements 09/57709/2
Ralf Zimmermann [Fri, 20 Jul 2018 20:54:32 +0000 (22:54 +0200)]
[BUGFIX] Allow "defaultValue" for select form elements

Allows the form editor to save the property "defaultValue" for
"Inspector-PropertyGridEditor" inspector editors. This rules for the
form element types "SingleSelect", "RadioButton", "MultiCheckbox"
and "MultiSelect".

Besides that a flaw in JavaScript is solved that truncated values
by one character (e.g. having "propert" instead of "property"), as
well as having a correct representation of objects and arrays when
initializing them in JavaScript.

Resolves: #85608
Resolves: #85670
Releases: master, 8.7
Change-Id: Ia82ee236e6becb36db13fb15e96c7caceab370d1
Reviewed-on: https://review.typo3.org/57709
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Update class names in dynamicReturnTypeMeta.json 78/57678/3
Andreas Fernandez [Wed, 25 Jul 2018 07:49:48 +0000 (09:49 +0200)]
[BUGFIX] Update class names in dynamicReturnTypeMeta.json

Resolves: #85639
Releases: master, 8.7
Change-Id: Ie7bd2b7e446ea0b11386bd77acb38d94320a6d1e
Reviewed-on: https://review.typo3.org/57678
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Provide record's uid to the suggest wizard 91/57691/2
Xavier Perseguers [Thu, 26 Jul 2018 10:20:53 +0000 (12:20 +0200)]
[TASK] Provide record's uid to the suggest wizard

In addition to the query string, having the uid of the record allows
more flexibility when implementing a custom suggest receiver.

Releases: master, 8.7
Resolves: #85655
Change-Id: I8dea34a26b845b0a49b5406880790b55e445d780
Reviewed-on: https://review.typo3.org/57691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[BUGFIX] Do not re-sort IRRE children when sorting parent 23/57623/3
Tymoteusz Motylewski [Mon, 25 Jun 2018 18:59:30 +0000 (20:59 +0200)]
[BUGFIX] Do not re-sort IRRE children when sorting parent

When PID of the parent record has not changed, child records should
not be moved/sorted.

Little background helping reviewing the patch:

The 2 important changes are made in DataHandler.php line 4603
and DataHandlerHook.php around line 346.
In both cases the condition is added checking if the destination PID
of the record is the same as current one.
In that case, processing of the IRRE children is skipped.

All the changes made in the .csv files are reflecting that.
To validate them one can compare the content of the csv files
with LiveDefaultElements.csv datasets.

For example, check that sorting values in file:
core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/changeParentContentSorting.csv
are the same as in the:
core/Tests/Functional/DataHandling/IRRE/CSV/DataSet/LiveDefaultElements.csv

In the Workspaces related datasets, you will see that there
are no move placeholders for IRRE children any more
(and versioned records have 0 instead of 4 in the t3ver_state).

See e.g.:
workspaces/Tests/Functional/DataHandling/FAL/Modify/DataSet/changeContentSorting.csv
or
workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/changeParentContentSorting.csv

This patch also solves the issue that sorting of the LIVE records (IRRE children)
were modified, when sorting parent record in the Workspaces,
see e.g. record tx_irretutorial_1nff_hotel uid 2 and 5 in file:
workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/changeParentContentSorting.csv

Releases: master, 8.7
Resolves: #85304
Change-Id: I44573b334873400af628066beae84705c5af0408
Reviewed-on: https://review.typo3.org/57623
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
5 months ago[BUGFIX] Allow form definitions to be moved or put to recycle folder 88/57688/2
Oliver Hader [Mon, 23 Jul 2018 14:09:27 +0000 (16:09 +0200)]
[BUGFIX] Allow form definitions to be moved or put to recycle folder

After fixing the issue of TYPO3-CORE-SA-2018-003 file commands for
form definitions (those ending with new ".form.yaml" extension) has
been limited. Since the "move" command theoretically would allow to
move and rename a file, it has been denied as well. However, it is
okay to move those files around in case the file extension has not
been changed or when being moved to a recycle folder.

Resolves: #85570
Releases: master, 8.7
Change-Id: Ic1f40d061b330d62138a42be9e868fca77b17187
Reviewed-on: https://review.typo3.org/57688
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Use correct hook name for mime type guessers 80/57680/2
Andreas Fernandez [Wed, 25 Jul 2018 08:53:13 +0000 (10:53 +0200)]
[BUGFIX] Use correct hook name for mime type guessers

Resolves: #85641
Related: #60019
Releases: master, 8.7, 7.6
Change-Id: If9c94c020da6991dc070fa6aa8395042686b2752
Reviewed-on: https://review.typo3.org/57680
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[TASK] Update php-cs-fixer to latest minor 61/57661/2
Christian Kuhn [Mon, 23 Jul 2018 14:16:27 +0000 (16:16 +0200)]
[TASK] Update php-cs-fixer to latest minor

Updates friendsofphp/php-cs-fixer from 2.11.1 to 2.12.2
The 'no_unused_imports' scanner is a bit more picky and
finds another unused import fixed along with the update.

composer update friendsofphp/php-cs-fixer

Change-Id: I40a724371c35ae4202fd8e90f43eafcb1a70c0a9
Resolves: #85621
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Define "label" for tt_content form elements within form setup 42/57642/2
Ralf Zimmermann [Tue, 17 Jul 2018 06:55:18 +0000 (08:55 +0200)]
[BUGFIX] Define "label" for tt_content form elements within form setup

Define the "label" property for tt_content form elements within
the form setup to allow saving tt_content form elements.

Resolves: #85578
Releases: master, 8.7
Change-Id: I490a43692a9f54ef843e9362d0f700a9e5552106
Reviewed-on: https://review.typo3.org/57642
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[BUGFIX] Preserve order of finisher options in Form CE 56/57656/2
Ioulia Kondratovitch [Fri, 29 Jun 2018 19:30:59 +0000 (21:30 +0200)]
[BUGFIX] Preserve order of finisher options in Form CE

In content elements of form_formframework, the order of
finisher options offered for overriding will be
in accordance with the order defined in FormEditorSetup.yaml.

Resolves: #85435
Releases: master, 8.7
Change-Id: Ie506858bc363c62af02a123b27c84cb9754dbda3
Reviewed-on: https://review.typo3.org/57656
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[TASK] Refer to SimpleDataHandlerController instead of tce_db.php 55/57655/2
Tymoteusz Motylewski [Thu, 19 Jul 2018 21:07:00 +0000 (23:07 +0200)]
[TASK] Refer to SimpleDataHandlerController instead of tce_db.php

Update comments in the code not to mention tce_db.php.

The tce_db.php entry point is gone since v8.
The SimpleDataHandlerController is responsible for pushing data
from request to DataHandler.

Resolves: #85600
Releases: master, 8.7
Change-Id: I6d323a9aab77ab67ff811970ff3c0f47dbf84340
Reviewed-on: https://review.typo3.org/57655
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Switch from git.typo3.org to github for testing 44/57644/2
Christian Kuhn [Fri, 20 Jul 2018 15:35:16 +0000 (17:35 +0200)]
[TASK] Switch from git.typo3.org to github for testing

typo3.org git/gerrit show flakiness lately. To not torture
the poor servers with our pesky testing so much we switch
the git clones to github/TYPO3/TYPO3.CMS and hope merges
are mirrored over there more quickly and they sustain our
testing load easily.

Resolves: #85606
Releases: master, 8.7, 7.6
Change-Id: I772d945a3bf697172cb26edb761f01e6cb8da4bf
Reviewed-on: https://review.typo3.org/57644
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Only use SaltedHashingMethods marked as available 27/57627/2
Oliver Hader [Thu, 19 Jul 2018 07:23:16 +0000 (09:23 +0200)]
[BUGFIX] Only use SaltedHashingMethods marked as available

When determining the SaltedHashingMethod of a salted hash check only
SaltedHashingMethods which are marked as available.

Resolves: #85526
Releases: master, 8.7
Change-Id: I72ca88ce35c891dc149d0628543d30b6c4122407
Reviewed-on: https://review.typo3.org/57627
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[BUGFIX] Fix typo in form documentation 26/57626/2
sascha307050 [Wed, 18 Jul 2018 18:46:03 +0000 (20:46 +0200)]
[BUGFIX] Fix typo in form documentation

Releases: master,8.7
Resolves: #85589
Change-Id: I965f559b0307bd477e8f64340a12513a9827842d
Reviewed-on: https://review.typo3.org/57626
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[BUGFIX] Streamline backend module menu and viewport initialization 27/57527/2
Oliver Hader [Tue, 10 Jul 2018 10:46:31 +0000 (12:46 +0200)]
[BUGFIX] Streamline backend module menu and viewport initialization

ModuleMenu and Viewport initialization need to be defered to ensure
that DOM is available in order to apply further behavior in mentioned
client implementation. Besides that, property 'iframe' is extended by
a JavaScript getter - otherwise directly assigning another property of
an undefined object will fail.

Resolves: #80312
Releases: master, 8.7
Change-Id: I9581a7f2164050f73683928b8f2ebe1d69a6d5e7
Reviewed-on: https://review.typo3.org/57527
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
6 months ago[BUGFIX] Add Content-Type to test mail plain part 85/57585/2
Mathias Brodala [Fri, 13 Jul 2018 11:03:25 +0000 (13:03 +0200)]
[BUGFIX] Add Content-Type to test mail plain part

Resolves: #85536
Releases: master, 8.7
Change-Id: Ie1f5c97af1a315eb5b8d7bf4bc7a31872362750d
Reviewed-on: https://review.typo3.org/57585
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[TASK] Bamboo proper passwd mapping 19/57619/2
Anja [Tue, 17 Jul 2018 17:24:16 +0000 (19:24 +0200)]
[TASK] Bamboo proper passwd mapping

The bamboo containers need a better passwd mapping
per agent to set a proper home directory, otherwise
ssh tasks may fail.

Resolves: #85582
Releases: master, 8.7, 7.6
Change-Id: I42b59df7512dd5bd6e00c2c07eee9441cf1aa28c
Reviewed-on: https://review.typo3.org/57619
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Test rendering of translated select MM relations in Extbase 11/57611/3
Tymoteusz Motylewski [Mon, 16 Jul 2018 13:26:03 +0000 (15:26 +0200)]
[TASK] Test rendering of translated select MM relations in Extbase

It's based on tt_content and categories.

Releases: master, 8.7
Resolves: #85493
Change-Id: Ie7222f38ea89536ab463ff46aabb94b8f834d599
Reviewed-on: https://review.typo3.org/57611
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
6 months ago[BUGFIX] Also add doctrine/lexer to typo3/cms-core 08/57608/2
Markus Klein [Sat, 14 Jul 2018 20:57:29 +0000 (22:57 +0200)]
[BUGFIX] Also add doctrine/lexer to typo3/cms-core

Resolves: #85552
Releases: master, 8.7
Change-Id: I1056a5825fd79df4c495894970721713b10728cd
Reviewed-on: https://review.typo3.org/57608
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
6 months ago[TASK] Run tests on new bamboo infrastructure 04/57604/11
Christian Kuhn [Sun, 15 Jul 2018 16:33:59 +0000 (18:33 +0200)]
[TASK] Run tests on new bamboo infrastructure

A new bamboo agent infrastructure has been deployed that
significantly changes how tests are executed: The agent
docker containers are now "stupid" and no longer bundle
specific php versions or daemons. Instead, they can run
own containers to start needed daemons for specific jobs
and execute needed php commands in ad-hoc containers that
provide the required php version.
Daemons needed for single jobs are defined in a
docker-compose.yml file provided by core itself.
This docker-compose.yml file can not be used directly for
local test execution since it has to fiddle quite a bit
with docker volume mounts, networks and executing users
that is specific to the bamboo environment.
However, another yml file can be added later to ease local
test execution in a similar way.
The patch rewrites the bamboo plan pre-merge and nightly
specs of core master to use the new infrastructure and brings
a couple of minor changes to tests that rely on a running
memcached or redis to retrieve the daemon host from an
environment variable.

Patch for core v8 - note the installer acceptance tests
are disabled for now since they need preparation patches
in typo3/testing-framework v8 flavor first.

Change-Id: I65777eeee6e28fca5b3d3d979498293cc91a77af
Resolves: #85563
Resolves: #36934
Releases: 8.7
Reviewed-on: https://review.typo3.org/57604
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Require doctrine/lexer to get removed lexer classes 01/57601/2
Andreas Fernandez [Fri, 13 Jul 2018 18:15:30 +0000 (20:15 +0200)]
[BUGFIX] Require doctrine/lexer to get removed lexer classes

With the release of doctrine/dbal in version 2.8, the class
`Doctrine\Common\Lexer` got removed. To circumvent this issue, the
package `doctrine/lexer` will be used.

Used composer command:

    composer require doctrine/lexer:^1.0

Resolves: #85552
Releases: master, 8.7
Change-Id: I5dd007c3b95be42dfd3305f750606ae4fcabedf2
Reviewed-on: https://review.typo3.org/57601
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir 95/57595/2
Oliver Hader [Fri, 13 Jul 2018 14:45:43 +0000 (16:45 +0200)]
[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir

Including files from Phar archives (e.g. "phar://file.phar/autoload.php")
does not work properly with having PHP setting open_basedir defined. The
reason for that is, that TYPO3's custom PharStreamWrapper tries to find
the appropriate base Phar file using file_exists() calls internally. In
case those files are not part of the open_basedir restriction - which is
the case for everything prefixed with the "phar://" scheme - a PHP
warning is shown.

Resolves: #85547
Releases: master, 8.7, 7.6
Change-Id: I72fdd7f0c016c0a8b1ed56a82b6b4042cac4d930
Reviewed-on: https://review.typo3.org/57595
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Make forms impexp hook php 7.0 compatible 83/57583/2
Ralf Zimmermann [Fri, 13 Jul 2018 05:50:45 +0000 (07:50 +0200)]
[BUGFIX] Make forms impexp hook php 7.0 compatible

Resolves: #85545
Releases: 8.7
Change-Id: I63d5aeab191252982841cfd34c955cc8e075aac8
Reviewed-on: https://review.typo3.org/57583
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[TASK] Set TYPO3 version to 8.7.18-dev 76/57576/2
Oliver Hader [Thu, 12 Jul 2018 11:30:39 +0000 (13:30 +0200)]
[TASK] Set TYPO3 version to 8.7.18-dev

Change-Id: I5aeef34b459d999cd94a62a8a3cd6778e2920d54
Reviewed-on: https://review.typo3.org/57576
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[RELEASE] Release of TYPO3 8.7.17 75/57575/2 8.7.17 TYPO3_8-7-17 v8.7.17
Oliver Hader [Thu, 12 Jul 2018 11:29:13 +0000 (13:29 +0200)]
[RELEASE] Release of TYPO3 8.7.17

Change-Id: I21f8e42feb8a9c5e1b72b36c906c25411b30472e
Reviewed-on: https://review.typo3.org/57575
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[TASK] Remove post-autoload-dump section from composer.json 66/57566/5
Anja [Thu, 12 Jul 2018 08:23:09 +0000 (10:23 +0200)]
[TASK] Remove post-autoload-dump section from composer.json

The included task in not subject to be executed upon each
`composer install`.

Resolves: #85537
Related: #83249
Releases: master, 8.7
Change-Id: I12240cbd7ea571b1872effd6942a3bd65bf37a89
Reviewed-on: https://review.typo3.org/57566
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[BUGFIX] Fix test isolation and pre-requisites 72/57572/3
Susanne Moog [Thu, 12 Jul 2018 10:37:06 +0000 (12:37 +0200)]
[BUGFIX] Fix test isolation and pre-requisites

FormDefinitionValidationServiceTest modified the encryption key in
test data-provider functions. Those functions are executed prior to
actually executing the tests and causes side-effects during running
the test suite.

Resolves: #85539
Releases: master, 9.3, 8.7
Change-Id: I9fbd60905eb37470fa3661225b681476ff9df3c3
Reviewed-on: https://review.typo3.org/57572
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[TASK] Fix CGL issues 67/57567/2
Oliver Hader [Thu, 12 Jul 2018 09:58:10 +0000 (11:58 +0200)]
[TASK] Fix CGL issues

Resolves: #.....
Releases: master, 8.7
Change-Id: Iace5c4d064182c628e9d3b03876c73e19dd725cd
Reviewed-on: https://review.typo3.org/57567
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY][TASK] Remove support for native PHP yaml extension 49/57549/2
Oliver Hader [Thu, 12 Jul 2018 09:32:55 +0000 (11:32 +0200)]
[SECURITY][TASK] Remove support for native PHP yaml extension

Resolves: #85424
Releases: master, 8.7
Security-Commit: d1df0ce67ff83d75a3d4878b2f9cb315c4c23bc1
Security-Bulletin: TYPO3-CORE-SA-2018-004
Change-Id: I56b1c9c91018053cd7bd16b8de297425b7765d1e
Reviewed-on: https://review.typo3.org/57549
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Filter disallowed properties in form editor 48/57548/2
Ralf Zimmermann [Thu, 12 Jul 2018 09:32:45 +0000 (11:32 +0200)]
[SECURITY] Filter disallowed properties in form editor

The form editor save and preview actions now check the submitted
form definition against configured possibilities within the form
editor setup.

Releases: master, 8.7
Resolves: #85044
Security-Commit: bcf5957567fe680866303c0758c37b26afb2c58f
Security-Bulletin: TYPO3-CORE-SA-2018-003
Change-Id: Id3d260681419b992553c98a9a408280094191c27
Reviewed-on: https://review.typo3.org/57548
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[!!!][SECURITY] Deny direct FAL commands for form definitions 47/57547/2
Susanne Moog [Thu, 12 Jul 2018 09:32:31 +0000 (11:32 +0200)]
[!!!][SECURITY] Deny direct FAL commands for form definitions

Before this change, form definitions have been persisted in regular
`.yaml` files. In order to make the meaning and purpose of those
files more explicit, the new file ending `.form.yaml` is introduced.

Invocations of the file abstraction layer API for those form files
have to be allowed explicitly by granting commands individually using
`FilePersistenceSlot::allowInvocation`.

New form definitions are created with the new file ending per default.
An upgrade wizard renames existing form definitions that are stored in
according storage folders (`allowedFileMounts`). In addition references
in FlexForm of content elements are adjusted to the new file names as
well - in case a form definition has been referenced before.

The file list user interface disabled according direct actions for
`.form.yaml` files or redirects those to the according form module.

Using just `.yaml` instead of `.form.yaml` from site packages
is deprecated. Using just `.yaml` instead of `.form.yaml` from
file storages is not allowed anymore.

Resolves: #84910
Releases: master, 8.7
Security-Commit: 8c2f48ad6ef5cf42436e4631ca9bb74bc7206a52
Security-Bulletin: TYPO3-CORE-SA-2018-003
Change-Id: I6b89df8af4910f2d2a01546a873ad10f2329fd66
Reviewed-on: https://review.typo3.org/57547
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Explicitly deny object deserialization 46/57546/2
Oliver Hader [Thu, 12 Jul 2018 09:32:17 +0000 (11:32 +0200)]
[SECURITY] Explicitly deny object deserialization

Resolves: #85385
Releases: master, 8.7, 7.6
Security-Commit: 6a294ad6b15677b41b90d93ad8690b92048404fe
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: I710a0b7d6bfdb425380aebe3cbd7f88e73eb6b21
Reviewed-on: https://review.typo3.org/57546
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Mitigate phar stream wrapper 45/57545/2
Christian Kuhn [Thu, 12 Jul 2018 09:32:06 +0000 (11:32 +0200)]
[SECURITY] Mitigate phar stream wrapper

SoftReferenceIndex throws exceptions on phar streams
LegacyLinkNotationConverter throws exceptions on phar streams

Resolves: #85385
Releases: master, 8.7, 7.6
Security-Commit: f11da6bc371729fd8ab556af8e2b84c9f8501704
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: Iad230e9a0fe876b879eac810b6fa14b6d9f4fcdb
Reviewed-on: https://review.typo3.org/57545
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Introduce PHP stream wrapper for phar:// protocol 44/57544/2
Oliver Hader [Thu, 12 Jul 2018 09:31:53 +0000 (11:31 +0200)]
[SECURITY] Introduce PHP stream wrapper for phar:// protocol

This custom stream wrapper for the phar:// protocol overrides
PHP's native handling. In case Phar bundles shall be loaded from
a valid directory, the custom wrapper falls back to the native PHP
wrapper in order to invoke Phar-related actions.

In case the location is not trustworthy, an according exception
is thrown. The custom stream wrapper is registered in the beginning
of TYPO3's bootstrap class.

Truested locations are those in typo3conf/ext/* - anything else is
denied and not considered as trustworthy.

Releases: master, 8.7, 7.6
Resolves: #85385
Security-Commit: 2af49af902fe57e476d97d49487008557b5dc2bc
Security-Bulletin: TYPO3-CORE-SA-2018-002
Change-Id: I256f5061075b64dd74b3b065b7f9bacda27a63bb
Reviewed-on: https://review.typo3.org/57544
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[SECURITY] Deny authentication bypass using blowfish/md5 encryption 43/57543/2
Oliver Hader [Thu, 12 Jul 2018 09:31:43 +0000 (11:31 +0200)]
[SECURITY] Deny authentication bypass using blowfish/md5 encryption

Using password hashing methods that are related by class inheritance
can lead to authentication bypass by just knowing a valid username.

Resolves: #84703
Releases: master, 8.7, 7.6
Security-Commit: 17853c536776b6a7332b05b1e10385f4d87868ae
Security-Bulletin: TYPO3-CORE-SA-2018-001
Change-Id: If7a13d3699e217d7d853886b93b84b46f7e22b11
Reviewed-on: https://review.typo3.org/57543
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[BUGFIX] Support fragment/section for record links 34/57334/2
Mathias Brodala [Tue, 10 Oct 2017 10:58:20 +0000 (12:58 +0200)]
[BUGFIX] Support fragment/section for record links

This allows for setting fragments e.g. by adding a custom recordlist
RecordLinkHandler.

Resolves: #82717
Releases: master, 8.7
Change-Id: I1535a3bb5e446e2f154cd6214e5665887ae6fd0d
Reviewed-on: https://review.typo3.org/57334
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
6 months ago[BUGFIX] Repair relative path resolvement in ResourceCompressor 86/57386/3
Pascal Rinker [Wed, 25 Apr 2018 09:51:47 +0000 (11:51 +0200)]
[BUGFIX] Repair relative path resolvement in ResourceCompressor

This patch repairs the relative path resolvment when using EXT:
for JavaScript/CSS paths.

Resolves: #84261
Releases: master, 8.7
Change-Id: Ieeb35041bf049728c41465edb617529550629258
Reviewed-on: https://review.typo3.org/57386
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
6 months ago[BUGFIX] Scheduler: Show correct description for ipAnonymization-task 08/57508/2
Stefan Neufeind [Mon, 9 Jul 2018 08:15:13 +0000 (10:15 +0200)]
[BUGFIX] Scheduler: Show correct description for ipAnonymization-task

Resolves: #85512
Releases: master, 8.7, 7.6
Change-Id: I4077fe7481063feb97014048580c3fb1b1ca5e2a
Reviewed-on: https://review.typo3.org/57508
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[BUGFIX] Update complete database after extension installation 86/57486/3
Nicole Cordes [Sun, 1 Jul 2018 14:54:19 +0000 (16:54 +0200)]
[BUGFIX] Update complete database after extension installation

If an extension and its dependencies get installed, the whole
database needs to be updated instead of executing each extensions
SQL on its own.

Resolves: #79094
Releases: master, 8.7
Change-Id: I9a870e0efb6af241eeae563adbaa14af100edaec
Reviewed-on: https://review.typo3.org/57486
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
6 months ago[BUGFIX] Check for exceptions instead of number of affected rows 91/57491/4
Georg Ringer [Sun, 24 Jun 2018 16:22:30 +0000 (18:22 +0200)]
[BUGFIX] Check for exceptions instead of number of affected rows

Saving a scheduler task without any changes leads to 0 affected
rows which must not be interpreted as an error.

Resolves: #85366
Releases: master, 8.7
Change-Id: I474e16478cb09ad4940aaab5fe1d3eb21498c4c4
Reviewed-on: https://review.typo3.org/57491
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Convert date objects to string in SaveToDatabase finisher 90/57490/2
Ralf Zimmermann [Tue, 12 Jun 2018 16:57:56 +0000 (18:57 +0200)]
[BUGFIX] Convert date objects to string in SaveToDatabase finisher

The SaveToDatabase now converts DateTime(Immutable) objects to strings
to make it possible to save values from "Date" or "DatePicker" form elements
into the database.

Resolves: #85246
Releases: master, 8.7
Change-Id: I1533252d462d08bf7b743884d4e8e5fab12f6423
Reviewed-on: https://review.typo3.org/57490
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Use correct HTTP method in GeneralUtility::getUrl 88/57488/2
Markus Klein [Thu, 5 Jul 2018 20:26:14 +0000 (22:26 +0200)]
[BUGFIX] Use correct HTTP method in GeneralUtility::getUrl

When fetching only headers from an URL there is no need
to download the whole content.
This was overlooked when migrating the core to use Guzzle.

Resolves: #85491
Releases: master, 8.7
Change-Id: I6475b405d51135372e022b5e133368f15a917687
Reviewed-on: https://review.typo3.org/57488
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Use unknown OS icon instead of Windows as fallback 62/57362/3
Jan Stockfisch [Wed, 25 Apr 2018 14:38:48 +0000 (16:38 +0200)]
[BUGFIX] Use unknown OS icon instead of Windows as fallback

Resolves: #84870
Releases: master, 8.7
Change-Id: Ia89f4ba0aa70616e185cad6cc29858157ef0e656
Reviewed-on: https://review.typo3.org/57362
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[TASK] Add various Composer scripts 80/57480/2
Mathias Brodala [Thu, 7 Dec 2017 11:05:07 +0000 (12:05 +0100)]
[TASK] Add various Composer scripts

This vastly simplifies running common commands for TYPO3 development.

E.g. executing PHPUnit can be done like this:

    composer test:php:unit

Since Composer uses Symfony Console this can even be shortened:

    composer t:p:u

Also arbitrary arguments can be passed to the executed command:

    composer t:p:u -- --filter unitTestMethodName

Change-Id: I3ef62417227b3c4c1c3d8f8f3662052ca36ed885
Resolves: #83249
Related: #84836
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57480
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[TASK] Use secure deserialization in extension manager 77/57477/2
Oliver Hader [Tue, 3 Jul 2018 14:16:19 +0000 (16:16 +0200)]
[TASK] Use secure deserialization in extension manager

In order to harden the deserialization of scalar and array values
in extension manager unserialize() calls are hardened further to
disallow object reconstitution. The information is retrieved from
the TYPO3 extension repository (TER) where according countermeasures
are in place to protect object injections - that's why this change
is considered as hardening and not as security issue.

Resolves: #85466
Releases: master, 8.7
Change-Id: I65b61d61e08d0c50b27ae9102d7ba4c4518a8788
Reviewed-on: https://review.typo3.org/57477
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
6 months ago[BUGFIX] Fix "orderBy" in DatabaseQueryProcessor example 72/57472/2
Daniel Siepmann [Wed, 4 Jul 2018 15:26:25 +0000 (17:26 +0200)]
[BUGFIX] Fix "orderBy" in DatabaseQueryProcessor example

Releases: master, 8.7, 7.6
Resolves: #85473
Change-Id: Ic0ac284bb8f02c7275e17bde67e79bb20a7fd919
Reviewed-on: https://review.typo3.org/57472
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[BUGFIX] Fixing login logo height in IE 71/57471/2
Roberto Presedo [Fri, 22 Jun 2018 21:41:16 +0000 (23:41 +0200)]
[BUGFIX] Fixing login logo height in IE

Resolves: #78592
Releases: master, 8.7
Change-Id: Ia7b3a25f6af61fce5376a68c1188c9564d603a23
Reviewed-on: https://review.typo3.org/57471
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Improve custom CE explanation in FSC 59/57459/2
Mathias Brodala [Tue, 3 Jul 2018 07:26:53 +0000 (09:26 +0200)]
[TASK] Improve custom CE explanation in FSC

Resolves: #85459
Releases: master, 8.7
Change-Id: I1732782fa920ffa0f7bfd42016a45ac6437bff0a
Reviewed-on: https://review.typo3.org/57459
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[BUGFIX] Ensure extension icon exists before calling ImageInfo 13/57413/2
Nicole Cordes [Thu, 28 Jun 2018 19:11:13 +0000 (21:11 +0200)]
[BUGFIX] Ensure extension icon exists before calling ImageInfo

As the extension icon is not required, this patch prevents warnings
that are triggered because no image size can be fetched.

Resolves: #85363
Releases: master, 8.7
Change-Id: I4c98fbaed385b2f269e940b8531c45e948ab8d36
Reviewed-on: https://review.typo3.org/57413
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
6 months ago[TASK] Synchronize .rst files between core versions 50/57450/2
Christian Kuhn [Mon, 2 Jul 2018 13:16:36 +0000 (15:16 +0200)]
[TASK] Synchronize .rst files between core versions

Resolve some minor differences between v8 and master
according to Changelog/Howto.rst. v7 is ok.

Resolves: #85454
Releases: master, 8.7
Change-Id: I07aba0283b09a5f0c2a2b4336cae4df17bbb46af
Reviewed-on: https://review.typo3.org/57450
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Display documentation changelog files with same issue number 46/57446/2
Anja [Thu, 28 Jun 2018 16:45:33 +0000 (18:45 +0200)]
[BUGFIX] Display documentation changelog files with same issue number

By using a hash instead of the issue number as array key, no file gets
lost any longer due to collision. Same issue numbers for documentation
files are quite common, e.g. when a new feature deprecates replaced code.

Change-Id: I3aef23b3bbc0d63486b1f75c38a54648991633b5
Resolves: #85420
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57446
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Handle missing repository mirrors in Languages module 09/56709/3
Mathias Brodala [Tue, 17 Apr 2018 12:57:11 +0000 (14:57 +0200)]
[BUGFIX] Handle missing repository mirrors in Languages module

If no extension repository mirror is present, properly throw the
(actually advertised) exception which is handled in the
TranslationService already.

Resolves: #83135
Releases: 8.7
Change-Id: Ic24eecd03262ae54d8ef987c4f38143575260fba
Reviewed-on: https://review.typo3.org/56709
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again 39/57439/2
Frédéric Lebel [Wed, 27 Jun 2018 02:57:49 +0000 (02:57 +0000)]
[BUGFIX] Make ckeditor link browser not drop CSS-Classes if editing again

Fix the link browser to not drop the CSS-Class value with multiple classes
if editing the same link.

Resolves: #85182
Releases: master, 8.7
Change-Id: Id7819f25c6a456c379de406816e44d7d1d76157e
Reviewed-on: https://review.typo3.org/57439
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Remove unused Doctrine restriction 37/57437/2
Benni Mack [Sun, 1 Jul 2018 18:13:56 +0000 (20:13 +0200)]
[BUGFIX] Remove unused Doctrine restriction

During the Doctrine DBAL refactoring, an
additional check for $TSFE->sys_page->showHiddenRecords
was introduced.

First of all: This check is not needed
as the restriction container is checking for
the REAL value correctly by using
$TSFE->showHiddenRecords.

Additionally, it checks for an invalid
property on PHP object property, which
is never a good idea.

Resolves: #85446
Releases: master, 8.7
Change-Id: Ib9dd0aa0197ee7d8379110a8067c31eba2ff73e8
Reviewed-on: https://review.typo3.org/57437
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[BUGFIX] Try to translate given help text of select items 83/57283/2
Mathias Brodala [Thu, 21 Jun 2018 10:11:43 +0000 (12:11 +0200)]
[BUGFIX] Try to translate given help text of select items

Use the LanguageService for help texts of select items.
This can be tested with the element 'select_checkbox_3' of the
styleguide extension.

Resolves: #78984
Releases: master, 8.7
Change-Id: Idb6e63547ac480b18fcb1ca997d5d07e4bcb4e81
Reviewed-on: https://review.typo3.org/57283
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
6 months ago[TASK] Streamline FAL pre-emit signals for createFile and setContent 21/57421/2
Oliver Hader [Fri, 29 Jun 2018 13:02:29 +0000 (15:02 +0200)]
[TASK] Streamline FAL pre-emit signals for createFile and setContent

In order to streamline the FAL API the following signals have been added.
The according post-processing signals have been available already before:

+ ResourceStorageInterface::SIGNAL_PreFileCreate
+ ResourceStorageInterface::SIGNAL_PreFileSetContents

Resolves: #85434
Releases: master, 8.7
Change-Id: I41fc07afbc4e1a393c8a26fe02f431a7b62015d8
Reviewed-on: https://review.typo3.org/57421
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
6 months ago[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer 15/57415/4
Daniel Goerz [Fri, 29 Jun 2018 08:36:12 +0000 (10:36 +0200)]
[TASK] Reduce logic in render methods of YouTube and Vimeo Renderer

This patch moves the logic from the render method of the
YouTube and Vimeo Renderer to dedicated methods to keep
the render methods themselves as short, clean and simple as
possible.

Also $options is initialized as an empty array as stated
in the interface.

Functionality, Output and Behavior stay unchanged.

Resolves: #85362
Releases: master, 8.7
Change-Id: I00bfc9d7e3bbf97d8a68fbf825a6cf3dd8b2d3aa
Reviewed-on: https://review.typo3.org/57415
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>