Packages/TYPO3.CMS.git
5 years ago[RELEASE] Release of TYPO3 6.2.4 12/31512/2 6.2.4 TYPO3_6-2-4
TYPO3 Release Team [Tue, 8 Jul 2014 13:04:53 +0000 (15:04 +0200)]
[RELEASE] Release of TYPO3 6.2.4

Change-Id: I2f41d693c2f9b7c0e919e5c1566d3a3fba99178d
Reviewed-on: https://review.typo3.org/31512
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal() 07/31507/2
Markus Klein [Tue, 8 Jul 2014 10:55:07 +0000 (12:55 +0200)]
[BUGFIX] Fix wrong type hint for emitAfterExtensionT3DImportSignal()

Fix a wrong type hint for the second parameter in
InstallUtility::emitAfterExtensionT3DImportSignal(). The parameter is of
type integer and not array.

Resolves: #60179
Releases: 6.3, 6.2
Change-Id: Iccfb7445bd374edaecfd3408380034dbec82e539
Reviewed-on: https://review.typo3.org/31507
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Superfluous SQL queries on copying records 02/31502/2
Oliver Hader [Thu, 3 Jul 2014 11:12:20 +0000 (13:12 +0200)]
[BUGFIX] Superfluous SQL queries on copying records

On copying a page in the backend there are lots of superfluous
SQL queries containing "... WHERE uid=0". The reason for that
is, that DataHandler::recordInfo() is called for each field
which then tries to fetch the database record for the given
uid "NEW...". Casting the new record placeholder to an integer
value ends up with the "uid=0" condition.

In a test with copying a page with some sub-pages, there was a
total of about 1300 SQL queries, 300 of them have been those
superfluous "uid=0" SELECT statements.

Resolves: #58357
Releases: 6.2, 6.3
Change-Id: Ib7006a7ceb52376032df8eaefaa918407718a482
Reviewed-on: https://review.typo3.org/31502
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Followup to read only filemounts 01/31501/2
Helmut Hummel [Tue, 8 Jul 2014 09:57:28 +0000 (11:57 +0200)]
[BUGFIX] Followup to read only filemounts

Fix tests by provide proper mocking of the storage

Resolves: #49391
Resolves: #57979
Releases: 6.2, 6.3
Change-Id: I2cd9e1bcffd082e861a7c8ae2fba6c68b461a8cc
Reviewed-on: https://review.typo3.org/31501
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Re-introduce read-only file mounts 96/31496/2
Lorenz Ulrich [Mon, 23 Jun 2014 13:41:17 +0000 (15:41 +0200)]
[BUGFIX] Re-introduce read-only file mounts

This re-introduces the read-only file mounts that were silently dropped
in TYPO3 6.0.

File mounts can be added by User TSconfig the same way they were added
in TYPO3 4.x. But since FAL added Storages, the storage needs to be
configurable.

options.folderTree.altElementBrowserMountPoints = 3:/test

This adds the folder "test" of storage 3 as read-only mount in the File
List and the Element Browser. The old syntax is still supported:

options.folderTree.altElementBrowserMountPoints = documents

If no storage is configured, it is assumed that the folder is in the
default storage.

Resolves: #49391
Resolves: #57979
Documentation: #59648
Releases: 6.3, 6.2
Change-Id: I648c8ae15d4add98cd55e2f9c27d89d8e49d6152
Reviewed-on: https://review.typo3.org/31496
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Movements pollute colPos value of content elements 92/31492/2
Nicole Cordes [Tue, 8 Jul 2014 07:53:33 +0000 (09:53 +0200)]
[BUGFIX] Movements pollute colPos value of content elements

Due to commit I148ca1b023226f2f99417b3baf238b72346e721f the information
concerning previous and next content elements in one row is messed up.
This patch helps to build information which depends on colPos again and
prevents records being moved to another column.

Resolves: #48939
Resolves: #49055
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I3a15321ee11a1f7d96b58b8b7a5ab14098664b22
Reviewed-on: https://review.typo3.org/31492
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Update phpdoc @return of exec_SELECTgetSingleRow() 90/31490/2
Markus Klein [Tue, 8 Jul 2014 08:12:21 +0000 (10:12 +0200)]
[TASK] Update phpdoc @return of exec_SELECTgetSingleRow()

DatabaseConnection::exec_SELECTgetSingleRow() may return FALSE if no row
is found. This is not reflected in the phpdoc for the return value.

This patch adds the necessary information to the doc header.

Resolves: #60172
Releases: 6.3, 6.2
Change-Id: Ia07868c2a1e8fad5b1d53d89ff0a959c2bcf9e3a
Reviewed-on: https://review.typo3.org/31490
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1 80/31480/2
Alexander Bigga [Fri, 27 Jun 2014 12:57:39 +0000 (14:57 +0200)]
[BUGFIX] TCA: handle select renderMode=tree with minitems=1 AND maxitems=1

Using the TCA select renderMode=tree with the option
minitems=1 AND maxitems=1
leads to two bugs since TYPO3 4.5:

First #48943
* A new table entry won't mark the field selection as required. The yellow
  question mark is missing and you can save the entry.
* Once you select a checkbox in the tree and unselect it again, the
  required-check is working.

Second: #31637
* You load an existing table entry with a selection of e.g. a category
  which has been hidden or deleted. The selected checkbox won't be shown,
  but the required-check fails.
* Even worse: You can't select another category as the form thinks you
  have already selected one item (maxitem=1). You can fix this only by
  manipulating the database directly.

The reason for these bugs can be found in
DataPreprocessor::renderRecord_selectProc(). For maxitems = 1 the
foreign_table element ids for the tree will be fetched by getDataIdList().
These elements won't be checked whether they are valid (hidden/deleted).
This check is done in selectAddForeign() which is used for maxitems > 1.

The patch uses the same procedure as for maxitems > 1 in case
of renderMode = tree.

Resolves: #48943
Resolves: #31637
Releases: 6.3, 6.2, 6.1
Change-Id: I078ff524ea73951f2121d2c233a46bc2ae562952
Reviewed-on: https://review.typo3.org/31480
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix suggest wizard item selection 79/31479/2
Benoit Chenu [Mon, 2 Jun 2014 11:44:36 +0000 (13:44 +0200)]
[BUGFIX] Fix suggest wizard item selection

When selecting an item in a suggest list, the first label is always
taken instead of the clicked one.

Resolves: #55835
Releases: 6.3, 6.2
Change-Id: I7590cb290ee19fd807260ef5767805a23ef088b0
Reviewed-on: https://review.typo3.org/31479
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] LiveSearchToolbarItem not initialized correctly 77/31477/2
Gernot Schulmeister [Mon, 7 Jul 2014 21:33:42 +0000 (23:33 +0200)]
[BUGFIX] LiveSearchToolbarItem not initialized correctly

Initialising the LiveSearchToolbarItem class with two leading
backslashes \\ prevents XClasses of the LiveSearchToolbarItem
to be found by the GeneralUtility:makeInstance() function.

Resolves: #59959
Releases: 6.3, 6.2
Change-Id: Iab6bb31379090fa5770ed20f8fa8113e61071fe0
Reviewed-on: https://review.typo3.org/31477
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix position of buttons in RTE full screen mode 76/31476/2
Markus Klein [Mon, 7 Jul 2014 21:20:49 +0000 (23:20 +0200)]
[BUGFIX] Fix position of buttons in RTE full screen mode

Update the HTML markup for the action buttons in the RTE full screen
view to properly position the buttons there.

Releases: 6.3, 6.2
Resolves: #60119
Change-Id: I0c06dd5fa5a7975a3ddcddb58c3b44d41da2192a
Reviewed-on: https://review.typo3.org/31476
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Refactor extension upload controller 67/31467/2
Nicole Cordes [Fri, 4 Jul 2014 22:17:32 +0000 (00:17 +0200)]
[TASK] Refactor extension upload controller

The upload and install functions are needed by the extension coreapi.
In order to support the extension, the UploadExtensionFileController
is refactored and necessary functions are extracted to public functions.

Resolves: #59999
Releases: 6.2, 6.3
Change-Id: I21e734d1ecae2e7c8e7c3f72e129ef1f57532886
Reviewed-on: https://review.typo3.org/31467
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere 65/31465/2
Julian Hofmann [Wed, 8 Jan 2014 17:22:33 +0000 (18:22 +0100)]
[BUGFIX] Suggest Wizard: support for PAGE_TSCONFIG_*-values in addWhere

Using PAGE_TSCONFIG_*-values in the foreign_table_where-clause limits
the entries. This where clause is also used for the suggest wizard, but
the markers are not replaced there.
PAGE_TSCONFIG_*-values are now supported in the suggest wizard too.

Resolves: #54843
Releases: 6.3, 6.2
Documentation: #60160
Change-Id: Ieb53d48ca0ddf22bbbbc4aed4d1e83220a82ec09
Reviewed-on: https://review.typo3.org/31465
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Move signals to own emit functions 52/31452/2
Nicole Cordes [Mon, 7 Jul 2014 07:49:33 +0000 (09:49 +0200)]
[TASK] Move signals to own emit functions

Two new signals were introduced with the patch
https://review.typo3.org/#/c/27746/. This patch moves the dispatch of
the signals into own functions to improve the tracing of signals.

Resolves: #60133
Releases: 6.3, 6.2
Change-Id: Iecb7ff25ec31556c939dff6b0cf8749ebd3ff997
Reviewed-on: https://review.typo3.org/31452
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Report migration errors in TceformsUpdateWizard 28/31428/2
Steffen Müller [Wed, 2 Apr 2014 20:38:31 +0000 (22:38 +0200)]
[BUGFIX] Report migration errors in TceformsUpdateWizard

TceformsUpdateWizard should report errors if a migration
failed due to a missing source file.

Resolves: #57575
Releases: 6.3, 6.2
Change-Id: I68af9a5155f7d6190a22cc4986ef4a467b747737
Reviewed-on: https://review.typo3.org/31428
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Detect missing files in empty storage 27/31427/2
Robert Vock [Tue, 3 Jun 2014 11:56:15 +0000 (13:56 +0200)]
[BUGFIX] Detect missing files in empty storage

Improve the check for missing files by properly treating
the case when a storage is empty.

Change-Id: I8fba9be2622a4cd742c0065b68a8daf77f8a484a
Resolves: #54414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31427
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Wrong image reference handling during flexform copying 25/31425/2
Alexey Gafiulov [Thu, 19 Jun 2014 16:12:42 +0000 (22:12 +0600)]
[BUGFIX] Wrong image reference handling during flexform copying

References in flexforms having type=inline are not processed correctly
during copy.

Fix this by properly applying the reference field check.

Resolves: #59664
Releases: 6.3, 6.2, 6.1
Change-Id: I1abfa001ba420531ca0c59903e82b1509e0819e0
Reviewed-on: https://review.typo3.org/31425
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Add signal slots to SoftReferenceIndex 23/31423/2
Alexander Stehlik [Mon, 10 Mar 2014 09:42:59 +0000 (10:42 +0100)]
[FEATURE] Add signal slots to SoftReferenceIndex

This patch adds two signal slot dispatch calls to the SoftReferenceIndex
in the getTypoLinkParts() method and the setTypoLinkPartsElement()
methods.

These slots allow third party link handlers to generate their own
soft reference data.

Resolves: #21396
Releases: 6.3, 6.2
Change-Id: If2bbcd1757ed480f31c1bdccd69bba2a77df9a8f
Reviewed-on: https://review.typo3.org/31423
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Optimize invocation of cObj::checkIf 18/31418/2
Oliver Hader [Mon, 20 Jan 2014 15:52:37 +0000 (16:52 +0100)]
[TASK] Optimize invocation of cObj::checkIf

The stdWrap property "if" can be used to allow output only if a
defined criterion is met. However, the checkIf() method gets
called even if the property is not set in TypoScript.

Fix this by adding a quick empty() check to all calls.
Also optimizes the code structure to exit early in case the if
does not evaluate to TRUE.

Resolves: #55173
Releases: 6.3, 6.2
Change-Id: Ie1178a5df2e98fd19b848aa2300c901c1200f555
Reviewed-on: https://review.typo3.org/31418
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suggest wizard doesn't work in page flexforms 21/31421/2
Bernhard Kraft [Wed, 18 Jun 2014 08:04:28 +0000 (10:04 +0200)]
[BUGFIX] Suggest wizard doesn't work in page flexforms

When using the suggest wizard from within a flexform in a page it
doesn't work properly. The $row variable was only set when processing
tables other than pages but is required for proper flexform handling.

Change-Id: I0eec29b3c7266bae809e2753cdee726a4c50b1ab
Resolves: #59642
Releases: 6.3, 6.2, 6.1
Reviewed-on: https://review.typo3.org/31421
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove non-needed URL parameter for standard search 19/31419/2
Tomita Militaru [Tue, 12 Nov 2013 14:57:56 +0000 (16:57 +0200)]
[BUGFIX] Remove non-needed URL parameter for standard search

Removes parameter to prevent duplicate content, speaking
url problems and overloaded urls.

Resolves: #51189
Releases: 6.3, 6.2, 6.1
Change-Id: I076d2f87ac7a1d0d9d831cf3293d060318750c7d
Reviewed-on: https://review.typo3.org/31419
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Support dots in page.meta 06/31406/2
Markus Klein [Sat, 28 Jun 2014 14:56:36 +0000 (16:56 +0200)]
[BUGFIX] Support dots in page.meta

The parsing of the meta tag TypoScript configuration does a too greedy
check on dots and hence breaks support for examples like DC.author.

Fix this by completely refactoring the meta tag generation and add unit
tests.

Resolves: #59890
Releases: 6.3, 6.2
Change-Id: Id534efff30903d96aee1677989d1bd6d3dd1644b
Reviewed-on: https://review.typo3.org/31406
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[CLEANUP] Ensure all variables are set before usage 80/31380/3
Markus Klein [Sun, 22 Jun 2014 00:46:21 +0000 (02:46 +0200)]
[CLEANUP] Ensure all variables are set before usage

This also applies for return values of functions. These are corrected
too if necessary.

Furthermore, some code style updates are done for better readability.

This patch contains no functional changes.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I1e26e0516d79324244948caf091cd836d5f8d3c6
Reviewed-on: https://review.typo3.org/31380
Reviewed-by: Fabien Udriot
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Travis-ci: Disable apc in PHP 5.3 04/31404/2
Christian Kuhn [Sun, 6 Jul 2014 16:23:19 +0000 (18:23 +0200)]
[TASK] Travis-ci: Disable apc in PHP 5.3

apc on cli seems to be flaky, disable this php module for
now to see if that help stabilizing travis-ci builds again.

Change-Id: I7e6caa6c2c2d70a26e217e8fbf10a2d79b01f335
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31404
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[CLEANUP] ext_emconf files 00/31400/2
Christian Kuhn [Sun, 6 Jul 2014 15:19:31 +0000 (17:19 +0200)]
[CLEANUP] ext_emconf files

Quite some keys in ext_emconf are obsolete and can be removed.
See related issue for a list of keys.

Change-Id: Id12c2e3d61569cc1e84226ef75120ae4261922fb
Resolves: #60128
Related: #58365
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31400
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove unused EM_CONF variables 99/31399/3
Benjamin Mack [Wed, 30 Apr 2014 13:36:24 +0000 (15:36 +0200)]
[TASK] Remove unused EM_CONF variables

The ext_emconf.php are created when e.g. an extension
is downloaded from TER. Based on the data from TER the
extension information is built, but not needed anymore.

There are some values that are not in use in the current
6.2 system anymore, and just make ext_emconf.php
more complicated, as the current EM only runs with TER2
anyway.

The patch cleans up values when writing ext_emconf.php
for an extension. As soon as only 6.2+ is supported, the
TER could remove the values to be shipped in the
xml.gz files, thus saving resources (not much but I'm in
favor of a clean system).

Releases: 6.2,6.3
Resolves: #58365
Change-Id: Ic15247f57b557971e9a7c608e4dadd2080e976a3
Reviewed-on: https://review.typo3.org/31399
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] ClearCacheOnLoad camelCased does not work 98/31398/3
Susanne Moog [Sun, 6 Jul 2014 15:10:10 +0000 (17:10 +0200)]
[BUGFIX] ClearCacheOnLoad camelCased does not work

The em_conf setting "clearCacheOnLoad" is both used in
camelCase and lower case but only the latter one is
supported by the extension manager.

Change-Id: I637ace3bef07353b7a44c991f79d01da8e8b5547
Fixes: #60127
Releases: 6.2,6.3
Reviewed-on: https://review.typo3.org/31398
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Replace module token in be shortcut returnUrl 96/31396/2
Frans Saris [Sun, 6 Jul 2014 12:34:46 +0000 (14:34 +0200)]
[BUGFIX] Replace module token in be shortcut returnUrl

During the addition of the token check for mod.php the token
in the BE shortcut url was already replaced (#56359) but
not in the returnUrl parameter that can be present.

This patch makes sure that also the module token is replaced in
the returnUrl param.

Resolves: #59963
Releases: 6.3, 6.2
Change-Id: I12b9d6022240d0399825aade21b0879bfbc7eb6c
Reviewed-on: https://review.typo3.org/31396
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Allow colon in TypoScript key 89/31389/3
Markus Klein [Sat, 28 Jun 2014 15:19:32 +0000 (17:19 +0200)]
[BUGFIX] Allow colon in TypoScript key

The TypoScript parser does not properly parse the := operator.
It searches for : only and hence wrongly breaks a TypoScript key apart.

Fix this by detecting the full operator sequence ":=", do not rely
on ":" only.

Resolves: #59965
Releases: 6.3, 6.2
Change-Id: I6401c87b45432d4d74c4092edeb333d4d9d5914e
Reviewed-on: https://review.typo3.org/31389
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly 87/31387/2
Wouter Wolters [Sat, 18 May 2013 18:55:23 +0000 (20:55 +0200)]
[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly

Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated
correctly in the backend.

Change-Id: Ieda08a1df71117b5ac90f2c68260f5171570ff63
Resolves: #16392
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31387
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Sysext form uses old TCA 85/31385/3
Markus Klein [Tue, 24 Jun 2014 13:38:46 +0000 (15:38 +0200)]
[BUGFIX] Sysext form uses old TCA

Sysext form overrides TCA for tt_content with some completely outdated
configuration.

Fix this to the new TCA of tt_content.

Resolves: #59837
Releases: 6.3, 6.2
Change-Id: Ic2d1d75b767925755160bd337ec6fdfbddc308ab
Reviewed-on: https://review.typo3.org/31385
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Extensionmanager: Dependency errors are not reset 83/31383/3
Nicole Cordes [Fri, 4 Jul 2014 22:34:19 +0000 (00:34 +0200)]
[BUGFIX] Extensionmanager: Dependency errors are not reset

Due to changes in https://review.typo3.org/#/c/29845/ dependency errors
are collected and if one error occurred it is returned for every check
regardless of the key. This patch adds a reset for the error array on
every new dependency check.

Resolves: #60106
Releases: 6.3, 6.2
Change-Id: Id734ba1fe8981ffd270d79d4971ac9de9b72b4b4
Reviewed-on: https://review.typo3.org/31383
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Update ADOdb to 5.19 77/31377/2
Andreas Fernandez [Thu, 26 Jun 2014 15:46:52 +0000 (17:46 +0200)]
[TASK] Update ADOdb to 5.19

Updated ADOdb from 5.18 to 5.19 fixing several bugs.

Resolves: #59911
Releases: 6.3, 6.2
Change-Id: I3173c8b14b3d653f29d4992029dbaa9129200fa2
Reviewed-on: https://review.typo3.org/31163
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/31377

5 years ago[BUGFIX] Missing label for EM "update"-dependency 71/31371/3
Markus Klein [Sat, 5 Jul 2014 14:57:34 +0000 (16:57 +0200)]
[BUGFIX] Missing label for EM "update"-dependency

Add the missing label for "update"-dependencies to EM locallang.xlf

Resolves: #59974
Releases: 6.3, 6.2
Change-Id: I8e8f1681cd486c2fbb7491c41c5f711c86e64ed0
Reviewed-on: https://review.typo3.org/31371
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Re-add unit tests for ExtensionCompatibilityTester 70/31370/3
Susanne Moog [Fri, 20 Jun 2014 10:23:21 +0000 (12:23 +0200)]
[TASK] Re-add unit tests for ExtensionCompatibilityTester

The tests for the ExtensionCompatibilityTester are currently skipped.
This patch removes the broken tests and leaves the working ones.

Releases: 6.3, 6.2
Resolves: #59700
Change-Id: I10a49d0dddf2807bd50944837e31f0105374c8c9
Reviewed-on: https://review.typo3.org/31370
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Correctly check stack in DownloadQueue 69/31369/2
Markus Klein [Sun, 29 Jun 2014 09:43:34 +0000 (11:43 +0200)]
[BUGFIX] Correctly check stack in DownloadQueue

The extension manager's DownloadQueue does now properly check
the stack when adding extensions to the queue.

Resolves: #59975
Releases: 6.3, 6.2, 6.1
Change-Id: I90e9699608c6d0f3ebd44dd54eb0f471a4e082d9
Reviewed-on: https://review.typo3.org/31369
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix position of TCEforms required field icon 68/31368/2
Frans Saris [Wed, 25 Jun 2014 08:08:17 +0000 (10:08 +0200)]
[BUGFIX] Fix position of TCEforms required field icon

If a palette is placed directly after a form field the icon to
open the pallete is placed inside the formfield wrapper. As result
the position of the required field icon is wrong.

This patch moves the palette icon outside of the wrapper.

Resolves: #59865
Releases: 6.2, 6.3
Change-Id: I35a3d4728a0dfb5ed315731366cc5ca04a7aa87e
Reviewed-on: https://review.typo3.org/31368
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Incomplete mock in ext:install 62/31362/2
Christian Kuhn [Sat, 5 Jul 2014 16:01:21 +0000 (18:01 +0200)]
[BUGFIX] Incomplete mock in ext:install

"ExtensionCompatibilityTesterTests" triggers loadBaseTca() that
loads TCA and TCA overrides of all active packages. Since the
unit test package manager activates all extensions found, this
may lead to unexpected effects with extensions hanging around
in typo3conf/ext.
The patch creates a backup of the package manager and mocks it
properly in some tests.

Change-Id: Ia5b1ccb449f1611837e6436cab226820b22a9047
Resolves: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31362
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Warning in addPlugin() 61/31361/2
Christian Kuhn [Sat, 5 Jul 2014 16:10:42 +0000 (18:10 +0200)]
[BUGFIX] Warning in addPlugin()

ExtensionManagementUtility::addPlugin() may raise a warning if
a subarray of TYPO3_LOADED_EXT is not set for whatever reason.
The patch sanitizes this.

Change-Id: I4fb8c24bcdebd6b04e856ecad5da07e624d95da4
Resolves: #60122
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31361
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Clean up buildBaseTcaFromSingleFiles() 60/31360/2
Christian Kuhn [Sat, 5 Jul 2014 16:07:17 +0000 (18:07 +0200)]
[TASK] Clean up buildBaseTcaFromSingleFiles()

The method uses two different approaches to get a list of active
packages, this is cleaned up to use the package manager only.

Change-Id: Ifc73d36ed0020914b0f7cf0b479010f91d1eba7f
Resolves: #60121
Related: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31360
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Removed clickMenu code around header icon in info window 58/31358/2
Frans Saris [Thu, 19 Jun 2014 15:58:41 +0000 (17:58 +0200)]
[BUGFIX] Removed clickMenu code around header icon in info window

The header icon in the ElementInfo screen has a click link added
but this doesn't work and doesn't make sense as shown links would
be in the wrong context.

This patch removes the javasript to open the clickmenu from the icons.

Resolves: #56250
Releases: 6.3, 6.2
Change-Id: I2b907188958f166a129617da36585c07be3a143c
Reviewed-on: https://review.typo3.org/31358
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides. 52/31352/2
Anja Leichsenring [Tue, 10 Jun 2014 19:01:45 +0000 (21:01 +0200)]
[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Ia2ae5e6c9a00aade1a65a6a89ecf809a0931025f
Resolves: #59464
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31352
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides 51/31351/2
Anja Leichsenring [Fri, 20 Jun 2014 14:57:30 +0000 (16:57 +0200)]
[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I328cbcb718ee33beec19379ea6047a18cdc370b0
Resolves: #59704
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31351
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Empty class selector crashes Update image 50/31350/2
Francois Suter [Fri, 27 Jun 2014 13:40:35 +0000 (15:40 +0200)]
[BUGFIX] Empty class selector crashes Update image

Prevent the Update image dialog box to crash when trying to access
an empty class selector.

Resolves: #59938
Releases: 6.2, 6.3
Change-Id: Ida2c3dfb185064071fcdcda158f64e330562aa01
Reviewed-on: https://review.typo3.org/31350
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Cleanup EXT:version 49/31349/2
Wouter Wolters [Sun, 22 Jun 2014 20:56:32 +0000 (22:56 +0200)]
[TASK] Cleanup EXT:version

* Update phpDoc where needed
* Import use statements where possible

Resolves: #59857
Releases: 6.3, 6.2
Change-Id: I786db3b377dbe0cc90441ea6618ce05fc67b087b
Reviewed-on: https://review.typo3.org/31349
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Updating deactivated extensions installs them 48/31348/2
Nicole Cordes [Fri, 4 Jul 2014 22:59:48 +0000 (00:59 +0200)]
[BUGFIX] Updating deactivated extensions installs them

If you update a deactivated extension it becomes activated afterwards.
This patch change from the installExtension function to
downloadMainExtension function because on updates it is enough to
download the new extension.

Resolves: #59631
Releases: 6.3, 6.2
Change-Id: Idec8c1f3521fa03241def5e171718b42cc31ce6b
Reviewed-on: https://review.typo3.org/31348
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides. 47/31347/2
Jost Baron [Mon, 9 Jun 2014 10:15:55 +0000 (12:15 +0200)]
[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Resolves: #59462
Related: #59414
Releases: 6.3,6.2
Change-Id: I0bd42865f199b7fcccc1ee9133776271a1af2bcd
Reviewed-on: https://review.typo3.org/31347
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename 46/31346/2
Jost Baron [Tue, 1 Jul 2014 12:22:31 +0000 (14:22 +0200)]
[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename

The variable '$doNothing' was not initialized, leading to PHP notices.

Resolves: #60116
Releases: 6.3, 6.2
Change-Id: I38473b73d4b1ebeb4b1dcbea5ba24d005c520487
Reviewed-on: https://review.typo3.org/31346
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Use string as constant name in FormProtectionFactory. 45/31345/2
Jost Baron [Tue, 1 Jul 2014 12:31:35 +0000 (14:31 +0200)]
[BUGFIX] Use string as constant name in FormProtectionFactory.

Currently the constant itself is used, which leads to PHP notices if it is
not defined yet.

Resolves: #60115
Releases 6.2,6.3
Change-Id: I6932f958a9cb0d01be5910860ebbd78f2c67c58a
Reviewed-on: https://review.typo3.org/31345
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides. 41/31341/2
Anja Leichsenring [Tue, 10 Jun 2014 20:10:03 +0000 (22:10 +0200)]
[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I789ea89318d76d0c709229139b0f5296042cded7
Resolves: #59466
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31341
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides 42/31342/2
Anja Leichsenring [Fri, 20 Jun 2014 15:04:19 +0000 (17:04 +0200)]
[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I1f92a7b536ffb19d30bb580ea30452fc488cd0f6
Resolves: #59705
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31342
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides. 43/31343/2
Anja Leichsenring [Tue, 10 Jun 2014 18:52:23 +0000 (20:52 +0200)]
[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Idb1be39c754d5566e52623103477b94887077cdb
Resolves: #59463
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30648
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 57b9fd213897663b4c12d025375a8564cb7d60b2)
Reviewed-on: https://review.typo3.org/31343
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides 44/31344/2
Anja Leichsenring [Fri, 20 Jun 2014 09:46:16 +0000 (11:46 +0200)]
[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I7b5240eccde3d49531bb734adf26ee623829dc59
Resolves: #59698
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30910
Reviewed-by: Olivier Dobberkau
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 920f93cc4a150c74e91a65d0309291327e600c39)
Reviewed-on: https://review.typo3.org/31344
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides 39/31339/2
Anja Leichsenring [Tue, 10 Jun 2014 19:56:42 +0000 (21:56 +0200)]
[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I3a357ddff0fe5d6f16caa67b4085372c27594234
Resolves: #59465
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31339
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides 40/31340/2
Anja Leichsenring [Tue, 10 Jun 2014 20:31:58 +0000 (22:31 +0200)]
[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: If5998b9c86bc5f7b106fd3f1c9213842b8ae242d
Resolves: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31340
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Tooltip for a shortcut in list view shows id=0 37/31337/2
Wouter Wolters [Fri, 4 Jul 2014 19:02:17 +0000 (21:02 +0200)]
[BUGFIX] Tooltip for a shortcut in list view shows id=0

In the list view the tooltip for a shortcut always shows
id=0 because the field shortcut is not fetched from the database.
Add this to the list of fields to select.

Resolves: #60033
Releases: 6.3,6.2
Change-Id: Id4949e6699657a57975977b3450f54bc3216d06d
Reviewed-on: https://review.typo3.org/31328
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 683ae94fb8bdf022981c9045c81e37149c32160e)
Reviewed-on: https://review.typo3.org/31337

5 years ago[BUGFIX] Give extension key to addPlugin() in registerPlugin() 36/31336/2
Christian Kuhn [Sat, 5 Jul 2014 11:44:19 +0000 (13:44 +0200)]
[BUGFIX] Give extension key to addPlugin() in registerPlugin()

With patch #59770 ExtensionManagementUtility::addPlugin() signature
was extended to get the extensionKey as parameter in order to not
use $GLOBALS['_EXTKEY'] anymore if possible.
The parameter is used to determine correct path to plugin icons if
the icon path is not given otherwise.
The patch changes extbase ExtensionUtility::registerPlugin() to give
the extensionKey to addPlugin, too.
With this patch registerPlugin() can be used in TCA/Overrides.
Some tests are added to verify the icon path calculation since it is
not trivial to follow the code flow with all its options and global
array access.

Change-Id: I2dd709ef7ca304bc8c4fda1e7911f18bfe7ad04c
Resolves: #60109
Related: #59770
Related: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31336
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Unit tests to addPlugin() 35/31335/2
Anja Leichsenring [Sat, 5 Jul 2014 11:51:35 +0000 (13:51 +0200)]
[TASK] Unit tests to addPlugin()

Add unit tests to ExtensionManagementUtility::addPlugin() verifying
the new third parameter $extensionKey is handled properly.

Change-Id: I0257755d0708f12141c78fb97e6e342daf7a6281
Resolves: #60110
Related: #60109
Related: #59414
Related: #59770
Related: #59468
Releases: 6.2, 6.3
Reviewed-on: https://review.typo3.org/31335
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix property access for ObjectStorage 14/31314/2
Markus Klein [Mon, 9 Jun 2014 10:02:51 +0000 (12:02 +0200)]
[BUGFIX] Fix property access for ObjectStorage

When enabling access to the content of ObjectStorages by
integer number, it was overlooked that property access might
be desired too, which has also been working before.

Fix this by not aborting the access when addressing a
non-integer property on ObjectStorages.

Resolves: #59412
Releases: 6.3, 6.2
Change-Id: I59b83ed0bf0c965efcdf0aad9440d634953a221e
Reviewed-on: https://review.typo3.org/31314
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix usergroup condition in user TSconfig 51/31151/2
Markus Klein [Tue, 24 Jun 2014 14:18:59 +0000 (16:18 +0200)]
[BUGFIX] Fix usergroup condition in user TSconfig

usergroup conditions in user TSconfig are currently failing as
the list of groups the user is part of, is not yet compiled when
the TSconfig is evaluated.

This can be fixed by moving the group evaluation some lines upwards,
as this does not influence the remaining code.

Resolves: #59813
Releases: 6.3, 6.2, 6.1
Change-Id: Id3189ea5cd31936bdf538e2bb163ecc2d46ed6a0
Reviewed-on: https://review.typo3.org/31151
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Two png files should have filemode 664 95/31295/2
Martin Bless [Wed, 2 Jul 2014 16:33:24 +0000 (18:33 +0200)]
[BUGFIX] Two png files should have filemode 664

Resolves: #60065
Releases: 6.3,6.2
Change-Id: I27917fed2a65f9810176b4afa716e8e752d7eff1
Reviewed-on: https://review.typo3.org/31295
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Create a Getter for CacheManager inside Datahandler 89/31289/3
Stefano Kowalke [Wed, 2 Jul 2014 11:26:16 +0000 (13:26 +0200)]
[TASK] Create a Getter for CacheManager inside Datahandler

At the moment the CacheManager is created by
GeneralUtility::makeInstance(
  'TYPO3\\CMS\\Core\\Cache\\CacheManager'
); within the code. This makes the particular method untestable.

Solution: Create a Getter which creates and returns the instance.
This getter can be mocked.

Resolves: #60059
Releases: 6.2, 6.3
Change-Id: I9f83ec017da94778e542410cc9d03faacddc245c
Reviewed-on: https://review.typo3.org/31289
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Workspace not always applied in RelationHandler queries 86/31286/2
Oliver Hader [Wed, 2 Jul 2014 09:28:32 +0000 (11:28 +0200)]
[BUGFIX] Workspace not always applied in RelationHandler queries

The possibly submitted value to RelationHandler::setWorkspaceId()
is not used for SQL queries to read IRRE foreign field relations.
In that case the current $BE_USER->workspace value is used which
might be different to the requested workspace id.

Resolves: #60053
Releases: 6.2, 6.3
Change-Id: Ib01e4df798ff2e1fcc8c29997f6effb814dc4344
Reviewed-on: https://review.typo3.org/31286
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Create workspace label placeholder that matches field conditions 83/31283/2
Sascha Egerer [Wed, 7 Aug 2013 17:10:04 +0000 (19:10 +0200)]
[BUGFIX] Create workspace label placeholder that matches field conditions

If a workspace placeholder record is generated the field, that
is configured as label for a table, is filled with a placeholder.
This is a hardcoded string.
If database field does not allow strings (integer, double...)
a TYPO3 warning is displayed. "... Propably value mismatch ...".
This message is very confusing because the user does not know
where it comes from.

The label should be evaluated against the TCA eval configuration
before it is written to the database.

Resolves: #31757
Releases: 6.3, 6.2, 6.1
Change-Id: I18261359550dcaddaa9bd9ca0dd77f8300e81da9
Reviewed-on: https://review.typo3.org/31283
Reviewed-by: Oliver Hader
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
5 years ago[BUGFIX] IRRE records are listed comma separated 81/31281/2
Thomas Löffler [Fri, 20 Jun 2014 19:15:14 +0000 (21:15 +0200)]
[BUGFIX] IRRE records are listed comma separated

IRRE records with foreign_field instead of MM table
are now listed as a comma separated list instead
of wrongly using the number of records as the UID.

Change-Id: Ib1434561ee823d931cc983e103fb58490ca83719
Resolves: #59671
Releases: 6.3,6.2
Reviewed-on: https://review.typo3.org/31281
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char 76/31276/2
Frans Saris [Fri, 27 Jun 2014 19:49:26 +0000 (21:49 +0200)]
[BUGFIX] Prevent spaces in BE shortcut to be replaced by + char

Due to some changes in Prototype.js the serialized form values
get wrongly escaped with the result that all spaces are replaced
by + chars.

This patch changes the used serialization of the form so the value
is correctly posted.

Resolves: #59950
Releases: 6.3, 6.2
Change-Id: I65d89ab741ae77f5bbef9421923b3878f2295570
Reviewed-on: https://review.typo3.org/31276
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix RTE width 74/31274/2
Markus Klein [Fri, 20 Jun 2014 16:58:45 +0000 (18:58 +0200)]
[BUGFIX] Fix RTE width

edit_wideDocument option has been removed with #57295 but it was forgotten
to adjust RTE accordingly.

Wide screens are default now, so we remove the check for this option
also in RTE. Furthermore the settings for small screens are superfluous
too.

Documentation is adjusted as well.

Resolves: #59692
Releases: 6.3, 6.2
Change-Id: I9bb5fc2a892f3de446137856e9fa18317f40b5c1
Reviewed-on: https://review.typo3.org/31274
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add action selector in toolbar in workspaces menu 73/31273/2
Oliver Hader [Thu, 26 Jun 2014 09:42:45 +0000 (11:42 +0200)]
[TASK] Add action selector in toolbar in workspaces menu

Currently there are two selectors in the bottom toolbar of
the workspace module. One to handle stage changes on selected
elements and one for mass actions (publish, swap, discard) for
the whole workspace. To circumvent this, an additional selector
shall be added for record selections.

Resolves: #59898
Releases: 6.2, 6.3
Change-Id: I5991cc16a65ba5ac473ec380f534379ec925cad3
Reviewed-on: https://review.typo3.org/31273
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Update phpdoc for all FormEngine members 72/31272/2
Markus Klein [Sat, 21 Jun 2014 23:17:20 +0000 (01:17 +0200)]
[CLEANUP] Update phpdoc for all FormEngine members

Furthermore ensure the initial values are correct.
All usages of the members have been checked such that no violation can
happen if the initial values have been modified.

This patch contains no change in functionality.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: I4566849bb930535b9fef8d38dba940d6a6fd86cc
Reviewed-on: https://review.typo3.org/31272
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] FormEngine: Use getters for global objects 71/31271/2
Markus Klein [Sat, 21 Jun 2014 22:29:21 +0000 (00:29 +0200)]
[CLEANUP] FormEngine: Use getters for global objects

Introduce getters for global objects like TYPO3_DB or LANG.
This patch does not change any functionality.

Resolves: #59775
Releases: 6.3, 6.2
Change-Id: Ia9a4f3adc656927467f2f51207396d9a41befe8c
Reviewed-on: https://review.typo3.org/31271
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Let live search use getRecordTitle 47/31247/3
Markus Klein [Sat, 28 Jun 2014 17:03:28 +0000 (19:03 +0200)]
[BUGFIX] Let live search use getRecordTitle

Live search uses the label configuration from TCA to get the title of a
record. An existing TODO note already suggests to use the method for
this from BackendUtility. Do this now.

Resolves: #59893
Resolves: #59957
Releases: 6.3, 6.2
Change-Id: Ic4aaabed47922863602e770b588fb8dacd9386de
Reviewed-on: https://review.typo3.org/31247
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix PHP warning in BackendUtility::getProcessedValue() 69/31269/2
Markus Klein [Mon, 30 Jun 2014 11:06:42 +0000 (13:06 +0200)]
[BUGFIX] Fix PHP warning in BackendUtility::getProcessedValue()

BackendUtility::getProcessedValue() fails to initialize a variable which
causes a PHP warning on array access.

Fix this by initializing the variable to array properly.

Resolves: #59994
Releases: 6.3, 6.2
Change-Id: I26711b512a9a7fad40000de6f2de6a2b4a81ac75
Reviewed-on: https://review.typo3.org/31269
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Show errors on distribution installation 68/31268/2
Sascha Egerer [Mon, 30 Jun 2014 09:36:00 +0000 (11:36 +0200)]
[BUGFIX] Show errors on distribution installation

When you install a distribution and an error occurred, you get a fluid
error: "Sorry, the requested view was not found."

There is currently no template / view for the action. This patch renders
the error messages as flash messages and redirects to the list view of
distributions where the errors are shown.

Resolves: #59564
Resolves: #59952
Releases: 6.3, 6.2
Change-Id: Ie0e055dfd5620d4e0a08ecf87b2f458e7877ee76
Reviewed-on: https://review.typo3.org/31268
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Use correct array structure for EM error messages 67/31267/2
Sascha Egerer [Mon, 30 Jun 2014 09:27:51 +0000 (11:27 +0200)]
[BUGFIX] Use correct array structure for EM error messages

The extension manager stores errors (like exceptions that
are thrown while installing an extension) in an array and
passes them to a fluid template.

The array has to be in a defined structure like
$errorMessages[extension name][i] = array(
»       error code,
»       error message
)

Currently, if an extension is installed from ter and an error occurs
while downloading the extension, the code and text are stored directly
under the extension name and therefore the array is not correctly parsed
by the fluid template.

Resolves: #59991
Releases: 6.3, 6.2
Change-Id: Id330f0af2a99ab99cb8b736332cb8506c857716c
Reviewed-on: https://review.typo3.org/31267
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Re-work/simplify copyright header in JS files 48/31248/2
Michael Schams [Fri, 27 Jun 2014 02:18:19 +0000 (12:18 +1000)]
[TASK] Re-work/simplify copyright header in JS files

This patch replaces the copyright/license header in JS files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

Resolves: #59916
Releases: 6.3, 6.2
Change-Id: I312bd9682fc1cf30ec327ba5d17567a3e9609c7d
Reviewed-on: https://review.typo3.org/31164
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 1ae7b94b86a64ab6a86d7417a5dfb1f19777ee75)
Reviewed-on: https://review.typo3.org/31248

5 years ago[BUGFIX] Unique IDs for pagetree root nodes 46/31246/2
Alexander Stehlik [Fri, 21 Mar 2014 18:06:33 +0000 (19:06 +0100)]
[BUGFIX] Unique IDs for pagetree root nodes

To make sure that every ID in the pagetree is unique in pagetrees
with a virtual root node (which is used for normal editors) the
page UIDs of the webmounts are set in the mountpoint property of
the tree nodes. This makes sure that all tree node ids are unique.

Resolves: #57163
Releases: 6.3, 6.2
Change-Id: Ia938a9bf4839524d60056d55c0186196dbd11289
Reviewed-on: https://review.typo3.org/31246
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years agoRevert "[TASK] Rebuild the calcAge functionality" 37/31237/5
Christian Kuhn [Sun, 29 Jun 2014 21:25:14 +0000 (23:25 +0200)]
Revert "[TASK] Rebuild the calcAge functionality"

This change was considered to need some more work during
merge post review:
* 6.2 version adds not allowed deprecations to a released branch
* It adds two arbitrary (public) constants CEIL and FLOOR
* Method names need improvement
* Violation of single responsibility
* The static utility class has dependencies
* The patch adds another "always loaded" file to main bootstrap
* Undocumented (minor) breaking changes
* (Minor) code style issues

Reverted: #20016
Releases: 6.3, 6.2

This reverts commit 4c52cb3cfe4f6819a29f1daa064859affe23989d
Change-Id: I6dff8aaa8bf8cfdb80cca56c9c967f2a2ea6fb52
Reviewed-on: https://review.typo3.org/31237
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove TCA building aspect and move code to bootstrap 34/31234/2
Christian Kuhn [Sat, 21 Jun 2014 16:25:04 +0000 (18:25 +0200)]
[TASK] Remove TCA building aspect and move code to bootstrap

The patch moves the slot code that implements the override loading
logic back to the bootstrap but keeps the signal.

Resolves: #59770
Related: #59414
Related: #59468
Releases: 6.3, 6.2
Change-Id: Ib4691eaa94f258ebd96f2609fb267cadc8356090
Reviewed-on: https://review.typo3.org/31234
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Add extension key to API 35/31235/2
Helmut Hummel [Sun, 29 Jun 2014 18:19:35 +0000 (20:19 +0200)]
[TASK] Add extension key to API

Instead of relying on a "magic" global $_EXTKEY
being set, add a new parameter to API where
this was used beforehand.

Resolves: #59770
Releases: 6.2, 6.3
Change-Id: I531bb6067d79aa42c9c592e88f3564dc7f40b29d
Reviewed-on: https://review.typo3.org/31235
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Rebuild the calcAge functionality 31/31231/2
Alexander Opitz [Sat, 12 Oct 2013 14:36:25 +0000 (16:36 +0200)]
[TASK] Rebuild the calcAge functionality

We have two calcAge functions with same functionality and same issues.
So this is moved to a new DateTimeUtility class and deprecated in the
the original classes. Also time functions from GeneralUtility are moved
to the new class.

Following issues are resolved:
* Age calculation does not respect leap years.
* Age calculation may round up so something seams older than it is.
* Between days and years there are months missing, so we get now 2 months
  instead of 60 days.

Resolves: #20016
Releases: 6.3, 6.2
Change-Id: Ie323f30b1fb97b68f89d43605ccda67f219a965a
Reviewed-on: https://review.typo3.org/31231
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Improve travis notifications to channels 24/31224/2
Helmut Hummel [Sun, 29 Jun 2014 12:00:15 +0000 (14:00 +0200)]
[TASK] Improve travis notifications to channels

By default travis notifies on each build when
posting to channels (irc, slack)

We can reduce the number of notifications by only
posting successful builds when it previously failed.

Additionally encrypt the API token for posting to slack.

Releases: 6.3, 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I882d34903c972201454e6cc5b9041393e3bd3661
Reviewed-on: https://review.typo3.org/31224
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Create required directories in test bootstrap 19/31219/2
Sebastian Bergmann [Sun, 29 Jun 2014 10:07:05 +0000 (12:07 +0200)]
[BUGFIX] Create required directories in test bootstrap

When running the core unit tests without setting up TYPO3
using the normal installation procedure then the uploads,
typo3temp, and typo3conf/ext directories do not exist.

Resolves: #59977
Releases: 6.3,6.2
Change-Id: Ib6b8ecd480b83cf818f54d865a4ff61fe62d2893
Reviewed-on: https://review.typo3.org/31216
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit f0803359e5b1b53fd626bd5d0a846b918c3afced)
Reviewed-on: https://review.typo3.org/31219

5 years ago[TASK] Update Travis CI notification settings 08/31208/2
Michael Stucki [Tue, 24 Jun 2014 08:27:07 +0000 (10:27 +0200)]
[TASK] Update Travis CI notification settings

Notify on Slack and IRC, remove email notification.

Resolves: #59838
Releases: 6.3, 6.2, 4.5
Change-Id: Ic4dacd5c7b6b4e6e2b8cfa92ae7976b666209747
Reviewed-on: https://review.typo3.org/31208
Reviewed-by: Nicole Cordes
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
5 years ago[BUGFIX] Fix insufficient mocking in ContentObjectRenderer 06/31206/2
Markus Klein [Sat, 28 Jun 2014 19:31:38 +0000 (21:31 +0200)]
[BUGFIX] Fix insufficient mocking in ContentObjectRenderer

Resolves: #59967
Releases: 6.3, 6.2
Change-Id: Ie30b8e522f9045c7cd6cbe9c032413c0ad936b1a
Reviewed-on: https://review.typo3.org/31206
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Gifbuilder: Fix image-mask-functionality 01/31201/2
Stefan Neufeind [Fri, 6 Jun 2014 14:10:26 +0000 (16:10 +0200)]
[BUGFIX] Gifbuilder: Fix image-mask-functionality

Mask-functionality is broken since the
introduction of FAL.

Change-Id: Iff28d9561e10f7581041bcc35bd56dfc972954b3
Resolves: #59392
Releases: 6.3, 6.2, 6.1
Reviewed-on: https://review.typo3.org/31201
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Add a function for clearing the rootline caches 99/31199/2
Oliver Klee [Tue, 13 May 2014 12:44:05 +0000 (14:44 +0200)]
[TASK] Add a function for clearing the rootline caches

The RootlineUtility uses two local caches and one additional cache from
the caching framework. If a unit test uses the RootlineUtility, it needs
a way of purging these caches so it does not change the environment.

Resolves: #58763
Releases: 6.3, 6.2, 6.1
Change-Id: Ia9878b808acfa03f018086829f90b84d4c5e8512
Reviewed-on: https://review.typo3.org/31199
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] BE shortcuts do not show up for editors 98/31198/2
Frans Saris [Fri, 27 Jun 2014 18:16:16 +0000 (20:16 +0200)]
[BUGFIX] BE shortcuts do not show up for editors

Due to some wrong or missing checks the link to create a shortcut
to a create new record form misses the correct name of the
"motherModName" as a result the shortcut links are not rendered
for non-admins. For admins these links do not work if PHP notices
are transformed to exceptions.

Resolves: #59946
Releases: 6.3, 6.2
Change-Id: I9acd74fd5dfefea62badc79e42e380466ce6c497
Reviewed-on: https://review.typo3.org/31198
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Use stable phpunit 4.1 instead of master 82/31182/2
Christian Kuhn [Sat, 28 Jun 2014 12:01:42 +0000 (14:01 +0200)]
[TASK] Use stable phpunit 4.1 instead of master

We had to update to phpunit "master" recently due to an issue with
phpunit-mock-objects that was not released yet but fixed in master.
The fix was released with phpunit-mock-objects 2.1.5 today, so we
can switch back to a stable combination of those packages.

Resolves: #59958
Related: #59685
Releases: 6.3, 6.2
Change-Id: I92336adef0291239c7dad606002721c91b2991fa
Reviewed-on: https://review.typo3.org/31179
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit ee2dd7719711ec3786a86d8ded7dc5a085a7d7e9)
Reviewed-on: https://review.typo3.org/31182

5 years ago[TASK] Add more files in gitignore file 47/31147/2
Fabien Udriot [Thu, 12 Jun 2014 08:00:44 +0000 (10:00 +0200)]
[TASK] Add more files in gitignore file

Whenever running the Functional Tests
directly from the Core, the framework requires
some additional folders that can be added
to the gitignore file.

More info about Functional Testing:
http://wiki.typo3.org/Functional_testing

Change-Id: If51851f32ebeda0eb6829dc3f16d87709904824a
Releases: 6.3, 6.2
Resolves: #59514
Reviewed-on: https://review.typo3.org/31147
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix RewriteRule for context to avoid HTTP 500 15/31115/2
Armin Ruediger Vieweg [Thu, 22 May 2014 14:07:53 +0000 (16:07 +0200)]
[BUGFIX] Fix RewriteRule for context to avoid HTTP 500

The affected rules are those for TYPO3_CONTEXT.
These rules should just set the ENV variable,
but should not touch the URL.
According to apache httpd docs this has to be
indicated by using a dash.

Also unnecessary grouping in the regexp has been
removed.

Resolves: #59037
Releases: 6.3, 6.2
Change-Id: I56cadcfb3cfae0a0ee679c6886cda9f5498fc47c
Reviewed-on: https://review.typo3.org/31115
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years agoRevert "[BUGFIX] Fix loading order for extensions" 98/31098/2
Markus Klein [Tue, 24 Jun 2014 01:12:29 +0000 (03:12 +0200)]
Revert "[BUGFIX] Fix loading order for extensions"

This reverts commit c0779513b431b19413873893bf630aa3de6fc1fc

The patch has two flaws:
 * Easy: packagePathStack also includes package folder which
         is incompatible to the excludedPaths search
 * Nightmare: Upon uninstalling extensions the PackageManager
         fails due to missing packagePathStack information

Change-Id: I27642b3dea7541cb5f7363172edff147d34999d1
Resolves: #59831
Reverts: #59147
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31098
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] FollowUp: Fix signal returns for associated signal arguments 73/31073/2
Marc Bastian Heinrichs [Mon, 23 Jun 2014 07:47:40 +0000 (09:47 +0200)]
[BUGFIX] FollowUp: Fix signal returns for associated signal arguments

Fix broken functional tests. Add a fallback for earlier used associated
returns. Furthermore this patch reintroduces referenced signal arguments
to support old registered slots.

Resolves: #59794
Releases: 6.3, 6.2
Change-Id: Icfe997998476b9bdf77aba280eb87ca42786def8
Reviewed-on: https://review.typo3.org/31073
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix a JS error in with TCE select wizard 21/30821/3
Rémy DANIEL [Wed, 18 Jun 2014 15:38:32 +0000 (17:38 +0200)]
[BUGFIX] Fix a JS error in with TCE select wizard

Fixes an exception with decodeURI when an item containing
a % (percent) character is added to a select.
jQuery is now only used to append the option and its label to the DOM.

Resolves: #59655
Releases: 6.3, 6.2
Change-Id: I245f2fbec347b7e149aeea1cb7148591dc47e6f8
Reviewed-on: https://review.typo3.org/30821
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make Extbase respect sys_language_mode=strict 61/31061/2
Georg Ringer [Mon, 16 Jun 2014 17:40:52 +0000 (19:40 +0200)]
[BUGFIX] Make Extbase respect sys_language_mode=strict

The Extbase query parser currently doesn't respect strict language mode
because it doesn't consider records that are only present in a localized
language version, but not in the default language.

As a consequence, records only present in a localized language version
are not fetched at all while for counting/paging the count of the default
language version is used.

This change adds a check for strict language mode and additional query
parts to solve this issue.

Releases: 6.3, 6.2
Resolves: #47183
Change-Id: Ifb0ff6dda648fb4a686992ee6f7c00419a3ee934
Reviewed-on: https://review.typo3.org/31061
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Fix signal returns for associated signal arguments 58/31058/2
Nicole Cordes [Sun, 22 Jun 2014 10:36:42 +0000 (12:36 +0200)]
[BUGFIX] Fix signal returns for associated signal arguments

The call of the dispatcher functions doesn't allow associated signal
arguments as all arguments are passed as parameter to the slot function.
This patch removes all associated signal arguments and uses numeric
arrays.

Resolves: #59794
Releases: 6.3, 6.2
Change-Id: Ie265c6c7dbf4c2b0972d3436164480bb741e15fa
Reviewed-on: https://review.typo3.org/31058
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 9 55/31055/2
Michael Schams [Sun, 22 Jun 2014 06:08:42 +0000 (16:08 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 9

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59785 for further details.

Resolves: #59785
Releases: 6.3, 6.2
Change-Id: If6a4795e7f2841474241d236d8ed33baceee0d2e
Reviewed-on: https://review.typo3.org/31055
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 8 54/31054/2
Michael Schams [Sun, 22 Jun 2014 05:56:21 +0000 (15:56 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 8

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59784 for further details.

Resolves: #59784
Releases: 6.3, 6.2
Change-Id: I1eacf9bf4537776e850d091d9d50bc72f8c2b20d
Reviewed-on: https://review.typo3.org/31054
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 7 53/31053/2
Michael Schams [Sun, 22 Jun 2014 05:52:40 +0000 (15:52 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 7

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59783 for further details.

Resolves: #59783
Releases: 6.3, 6.2
Change-Id: I0e2f68990217f7442abe5b940fd769250c37aec0
Reviewed-on: https://review.typo3.org/31053
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 6 52/31052/2
Michael Schams [Sun, 22 Jun 2014 05:49:03 +0000 (15:49 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 6

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59782 for further details.

Resolves: #59782
Releases: 6.3, 6.2
Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd
Reviewed-on: https://review.typo3.org/31052
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-work/simplify copyright header in PHP files - Part 5 51/31051/2
Michael Schams [Sun, 22 Jun 2014 05:21:16 +0000 (15:21 +1000)]
[TASK] Re-work/simplify copyright header in PHP files - Part 5

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59781 for further details.

Resolves: #59781
Releases: 6.3, 6.2
Change-Id: I7429b8e9c507a4833215750268d1975402679828
Reviewed-on: https://review.typo3.org/31051
Reviewed-by: Markus Klein
Tested-by: Markus Klein