Packages/TYPO3.CMS.git
5 years ago[RELEASE] Release of TYPO3 6.1.3 19/22719/2 TYPO3_6-1-3
TYPO3 Release Team [Tue, 30 Jul 2013 13:09:00 +0000 (15:09 +0200)]
[RELEASE] Release of TYPO3 6.1.3

Change-Id: I403489edc0c4f0a4c989befb29753b84b7b3d3cf
Reviewed-on: https://review.typo3.org/22719
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[SECURITY] fileDenyPattern ignored in file-list module 09/22709/2
Jigal van Hemert [Tue, 30 Jul 2013 12:39:27 +0000 (14:39 +0200)]
[SECURITY] fileDenyPattern ignored in file-list module

Change-Id: Icf4b3452c3b039f12335e184161083cbcbd3acec
Fixes: #47452
Releases: 6.0, 6.1, 6.2
Security-Commit: 71fa96798f6d3b85b1ad18f1dca4f86247b9d683
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22709
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in 3rd party library Flowplayer 08/22708/2
Oliver Hader [Tue, 30 Jul 2013 12:39:14 +0000 (14:39 +0200)]
[SECURITY] XSS in 3rd party library Flowplayer

Change-Id: I6bb53b23ca4df6f8d4b8ee801bd99a1a5c32f5b2
Fixes: #49209
Releases: 4.7, 6.0, 6.1, 6.2
Security-Commit: ee100f7fef667c77b2bb8278d1e4de14d3114285
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22708
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[SECURITY] XSS in 3rd party library Audio Player 07/22707/2
Oliver Hader [Tue, 30 Jul 2013 12:39:06 +0000 (14:39 +0200)]
[SECURITY] XSS in 3rd party library Audio Player

Update player.swf of version 2.0.4.6 from
http://wordpress.org/plugins/audio-player/

Change-Id: Ib9ba8c7f02279c42d619154b9b79cc38a8e2c41b
Fixes: #49210
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Security-Commit: f580e8e7182e8d2e53aed7889c9f37b5104874f4
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22707
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Deleted flag is not updated during file indexing 94/22694/2
Oliver Hader [Mon, 29 Jul 2013 14:31:44 +0000 (16:31 +0200)]
[BUGFIX] Deleted flag is not updated during file indexing

If sys_file records (file objects) have set the deleted flag, it
won't be removed once the file is physically available again
with the same file name (identifier).

Change-Id: Id6dc7466764ac3994606204edadc9c2a7d2106c8
Fixes: #50525
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22694
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] MailUtility breakLinesForEmail cuts text wrong and discard rest 77/22677/2
Tim Lochmueller [Fri, 5 Jul 2013 21:26:50 +0000 (23:26 +0200)]
[BUGFIX] MailUtility breakLinesForEmail cuts text wrong and discard rest

Now the substrStart pointer increases in case that the line is longer
than the lineWidth parameter.

Resolves: #49396
Releases: 6.2, 6.1, 6.0
Change-Id: I87b3622c2ada7efdcb4c1992c1cfa43635d68f09
Reviewed-on: https://review.typo3.org/22677
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years agoRevert "[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay" 71/22671/2
Anja Leichsenring [Mon, 29 Jul 2013 19:11:37 +0000 (21:11 +0200)]
Revert "[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay"

This reverts commit 58c9017fbdeb9108c15e80de4fb726c1f9273b8b

The patch introduces a regression. We have no easy fix for it, so the patch gets reverted. Sorry for now, we come back to the problem.

Change-Id: I8b608146a72cd48988c77ecf1036ac85074e03b0
Reviewed-on: https://review.typo3.org/22671
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years agoRevert "[BUGFIX] sys_file record doesn't get flagged as delete" 66/22666/3
Oliver Hader [Mon, 29 Jul 2013 16:39:53 +0000 (18:39 +0200)]
Revert "[BUGFIX] sys_file record doesn't get flagged as delete"

This reverts commit 640e4d51238cea1315ec40377214f4d533d9b7d0

Change-Id: I2cd6c4a03c3336e73bfe81fa86f222ce5a352f7d
Change-Id: I9c0369ca4d93bd2f2a078c008219136e39037d60
Reviewed-on: https://review.typo3.org/22666
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Use correct url schema in MediaWizardProvider 76/22376/2
Georg Ringer [Tue, 16 Jul 2013 05:00:18 +0000 (07:00 +0200)]
[BUGFIX] Use correct url schema in MediaWizardProvider

If the media provider supports https, the video should be
embedded using https instead of http.

Change-Id: Id6f1677acfd82ba071c2425f345ea20b48de9cfe
Resolves: #50041
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22376
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Workspace selector in top toolbar cannot scroll 52/22652/2
Georg Ringer [Fri, 5 Jul 2013 09:41:09 +0000 (11:41 +0200)]
[BUGFIX] Workspace selector in top toolbar cannot scroll

If there are too many workspaces defined, some of them cannot
be accessed using the workspace selector in in the top toolbar
due to a missing scrolling behaviour of that component.

Fixes: #11014
Releases: 6.2, 6.1, 6.0
Change-Id: Iaae51ebb2524116b8673a9cc81d612fd845b2d29
Reviewed-on: https://review.typo3.org/22652
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Detection of curlProxyServer settings is incorrect 50/22650/2
Dmitry Dulepov [Tue, 26 Feb 2013 13:53:17 +0000 (17:53 +0400)]
[BUGFIX] Detection of curlProxyServer settings is incorrect

Parsing of 'curlProxyServer' option during the bootstrap is incorrect.
It produces wrong host and port part in 'proxy_host' and 'proxy_port'
system options.

Change-Id: I12f66acef697dbec9b065edcba8ad0d8f78c4e01
Resolves: #45834
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22650
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Class loader tries to load classes it cannot load 28/22628/2
Andreas Wolf [Sat, 20 Jul 2013 10:19:13 +0000 (12:19 +0200)]
[BUGFIX] Class loader tries to load classes it cannot load

If a class file from a third-party package is loaded which does not
follow the Vendor\Product\Classname convention (e.g. Product\Classname),
the class loader still tries to access the third component of the class
name, leading to a warning (and thus an exception, depending on your
configuration).

To fix this problem, the class loader now checks in advance if it can
possibly load this class (or rather if the classname conforms to the
specification for the CMS universe).

Change-Id: I1cd3964b9486ea591fb373533fd6cef4e9ce3989
Resolves: #50217
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22628
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Add tests for ContentObjectRenderer::getData() 39/22639/3
Stefan Neufeind [Sun, 28 Jul 2013 09:18:49 +0000 (11:18 +0200)]
[TASK] Add tests for ContentObjectRenderer::getData()

* Adds unittests

Change-Id: I2b4ff89c828384c852e6fbf9f82c55e6ebbac281
Resolves: #50258
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22639
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Debug exception handler: set exit code on CLI 30/22630/2
Christian Weiske [Wed, 19 Dec 2012 13:50:40 +0000 (14:50 +0100)]
[BUGFIX] Debug exception handler: set exit code on CLI

Sets the exit code to 1 when an exception is caught by the debug exception
handler, so that the error state can be checked automatically.

Change-Id: Ic89a79f2ded0b4b9ccc58a4789d9416f260fd88a
Fixes: #44118
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22630
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Run phpLint and phpUnit in different travis builds 25/22625/2
Christian Kuhn [Sat, 27 Jul 2013 18:15:05 +0000 (20:15 +0200)]
[TASK] Run phpLint and phpUnit in different travis builds

phpLint checks php files for compilation errors in travis before
the unit tests are executed. This takes quite some time.
The patch configures travis to run phpLint and phpUnit in different
builds to speed up the process. Additionally, phpLint environment
does not clone phpunit and the introduction package and does no
database initialization.

Change-Id: Ie25ade5b6a8fcf4c4dc0752fc8662c433ea3c33c
Resolves: #50492
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22624
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit cae1c18432a6306a28590605f5e5a70be8a8c63d)
Reviewed-on: https://review.typo3.org/22625

5 years ago[BUGFIX] Make BackendUtility::viewOnClick honor doc 20/22620/2
Kasper Ligaard [Fri, 21 Sep 2012 12:27:28 +0000 (14:27 +0200)]
[BUGFIX] Make BackendUtility::viewOnClick honor doc

Make parameter $alternativeUrl work as documented in the docblock
and also as it worked until #22157.
This patch preserves the hook and basically just puts in an
if-statement. Also adding a unit test.

Change-Id: I7d67af438b0a0af51ca7662b3f8286aeec827c77
Fixes: #41165
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22620
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Remove empty .gitmodules file 14/22614/2
Christian Kuhn [Fri, 26 Jul 2013 21:02:46 +0000 (23:02 +0200)]
[TASK] Remove empty .gitmodules file

With removal of git submodules the .gitmodules file is empty
and can be removed now.

Change-Id: I453f63c0852825b46e9ea62f87385d9eace25134
Resolves: #50480
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22613
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 643f2e9cef2e7997e2c7ae5b8d8bbf279d9983c1)
Reviewed-on: https://review.typo3.org/22614

5 years ago[BUGFIX] Failures in em unit tests due to phpunit update 09/22609/2
Christian Kuhn [Fri, 26 Jul 2013 19:30:43 +0000 (21:30 +0200)]
[BUGFIX] Failures in em unit tests due to phpunit update

Young phpunit versions seem to handle clones a bit differently,
resulting in test failures in extension manager tests. The tests
are adapted a bit to fix this.

Change-Id: If70561743f68a62167e41ee4c23ae96b56f83ab9
Resolves: #50478
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22604
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
(cherry picked from commit eab10d590ceacc7d256a8ea195a2e562099fb52d)
Reviewed-on: https://review.typo3.org/22609
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] FAL wrong \RecursiveIteratorIterator usage 07/22607/2
Christian Kuhn [Fri, 26 Jul 2013 18:54:23 +0000 (20:54 +0200)]
[BUGFIX] FAL wrong \RecursiveIteratorIterator usage

If using \RecursiveIteratorIterator on \RecursiveDirectoryIterator,
flag SELF_FIRST must be used, otherwise only leaves (files) and not
also directories are returned. This behavior is a bit dependent on
the PHP version used, younger versions (> 5.3.3 seem to do it
correctly).

Furthermore, in copyFolderWithinStorage() $itemSubPath contains
the "relative" path part and not only the node name, checking
equality to "." or ".." fails then if handling sub directories.
So, directories may be created multiple times, resulting in mkdir()
warnings. This is fixed by getting the node name itself and using
that for comparison.

Resolves: #50476
Releases: 6.2, 6.1, 6.0

Change-Id: Ifac4b28f4e02ec8a9bf5891739cf66c1e1074af9
Reviewed-on: https://review.typo3.org/22602
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit ef8204d64f44c4643482c7e6a01313a1b702ca43)
Reviewed-on: https://review.typo3.org/22607

5 years ago[BUGFIX] FAL does not copy subfolders cleanly 05/22605/2
Christian Kuhn [Fri, 26 Jul 2013 15:43:19 +0000 (17:43 +0200)]
[BUGFIX] FAL does not copy subfolders cleanly

If full structures with sub folders are copied around in FAL
local driver, sub folders are not correctly created in the
target directory.

This is detected in unit tests after recent vfsStream updates in
ext:phpunit.

The patch adds a flag to the Iterator code to also include
directories to fix the issue.

Additionally, the existing two unit tests also tested multiple other
methods of the local driver and are functional tests. The patch moves
those two tests to the functional section and adds three simple unit
tests with correct mocking instead.

Change-Id: I30d3c8bd5c6538b3fe23405d97bcddff6c1ff405
Releases: 6.2, 6.1, 6.0
Resolves: #50472
Reviewed-on: https://review.typo3.org/22596
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit b0f8bb0d15106b6f3ee2c5b3b033cbc3e1b635e2)
Reviewed-on: https://review.typo3.org/22605

5 years ago[BUGFIX] Fix failing test 85/22585/2
Anja Leichsenring [Fri, 26 Jul 2013 09:21:45 +0000 (11:21 +0200)]
[BUGFIX] Fix failing test

The test failes due to incorrect mocking, what leads to not claimed
properties for the test.
Additionally the expected call amounts where handled more strictly
where fitting.

Releases: 6.2, 6.1, 6.0
Resolves: #50458
Change-Id: I34214fb9ef9e9935892aa03518505b877538e128
Reviewed-on: https://review.typo3.org/22585
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Uninstall extension with dependency throws Exception 78/22578/2
Wouter Wolters [Tue, 9 Jul 2013 16:49:02 +0000 (18:49 +0200)]
[BUGFIX] Uninstall extension with dependency throws Exception

Exception is thrown if uninstalling an extension with
dependecies on that extension. Catch the exception and
show a nice Flashmessage.

Change-Id: I434a4e1e1d83f43a6f5d4c99a82433e35ddd92f9
Resolves: #49722
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22578
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Test regression from patch for #47192 75/22575/2
Andreas Wolf [Sat, 20 Jul 2013 21:14:22 +0000 (23:14 +0200)]
[BUGFIX] Test regression from patch for #47192

This fixes a unit test regression introduced with the solution for
 #47192.

Change-Id: I0e70b916f24fada7f76e7fd835d31e54ca41a402
Related: #47192
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22461
Reviewed-on: https://review.typo3.org/22575
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Improve method annotation and type hinting in FAL 73/22573/2
Christian Kuhn [Thu, 25 Jul 2013 20:53:04 +0000 (22:53 +0200)]
[BUGFIX] Improve method annotation and type hinting in FAL

Add a missing "@throws" annotation and a namespaced comment.

Change-Id: Ibc929a01dbfdef9cf8730a8da259570786b6118c
Resolves: #50447
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22572
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 3a23fb06d51fda287a78745a133f293fe8a9db77)
Reviewed-on: https://review.typo3.org/22573

5 years ago[BUGFIX] rsaauth BackendFactory does not unset backend 70/22570/2
Markus Klein [Wed, 24 Jul 2013 18:12:42 +0000 (20:12 +0200)]
[BUGFIX] rsaauth BackendFactory does not unset backend

The BackendFactory of rsaauth tries to forcefully unset an
instantiated backend, but unsets the class name instead of the object.

Resolves: #50411
Releases: 6.2, 6.1, 6.0
Change-Id: I26712c73b74788cad159f95c7e54cbbbf69e8764
Reviewed-on: https://review.typo3.org/22570
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] require_once of vfsStream triggers travis fail 67/22567/2
Christian Kuhn [Thu, 25 Jul 2013 18:42:59 +0000 (20:42 +0200)]
[BUGFIX] require_once of vfsStream triggers travis fail

vfsStream is now included in ext:phpunit, the pear module is
not maintained and was removed in travis.
This triggeres a failure in the phplint check. All require_once
calls are removed for now, ext:phpunit now also provides an
autoloader for vfsSstream.

Change-Id: If1b07c31e999111e6b5d2804a9f5cc457066b7b0
Resolves: #50442
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22566
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 5ebcdc361e0efc5b1119df3bba0c46a948cf3c67)
Reviewed-on: https://review.typo3.org/22567

5 years ago[TASK] Revise typo3/sysext/README.txt 56/22556/2
Wouter Wolters [Wed, 24 Jul 2013 18:00:47 +0000 (20:00 +0200)]
[TASK] Revise typo3/sysext/README.txt

* Replace GIT repository link with the new one
* Remove information about submodules

Change-Id: I60db762ce831c7edea413d9f7780a5617b7f9e96
Resolves: #50410
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22556
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 6.1.3-dev 18/22518/2
TYPO3 Release Team [Tue, 23 Jul 2013 17:14:09 +0000 (19:14 +0200)]
[TASK] Set TYPO3 version to 6.1.3-dev

Change-Id: I59ed376c317bbda9a43b7a377587dcce3907c714
Reviewed-on: https://review.typo3.org/22518
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.1.2 17/22517/2 TYPO3_6-1-2
TYPO3 Release Team [Tue, 23 Jul 2013 17:13:42 +0000 (19:13 +0200)]
[RELEASE] Release of TYPO3 6.1.2

Change-Id: I488700726d337e3e19e979a52a86ac9c1ab8084a
Reviewed-on: https://review.typo3.org/22517
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[TASK] Make DiffUtility faster and much more scaleable. 09/22509/2
Kasper Ligaard [Mon, 22 Jul 2013 16:19:49 +0000 (18:19 +0200)]
[TASK] Make DiffUtility faster and much more scaleable.

The method DiffUtility->explodeStringIntoWords() calls array_merge()
inside a loop. The cost of constantly doing a function invocation and
merging arrays needlessly slows the method and the whole diff utility.
Moving the array merging outside the loop, the method becomes faster
and able to handle much larger input.

Change-Id: I4c2d21cff9b18392e89e316fec9dc615e715a073
Resolves: #50318
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22509
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Two mailforms on a page cause error on field validation 77/22477/2
Ernesto Baschny [Tue, 27 Nov 2012 01:38:49 +0000 (02:38 +0100)]
[BUGFIX] Two mailforms on a page cause error on field validation

Check formname for uniqueness and if need append a unique hash.

Change-Id: Ifd33c5130c383f3afc3e5e6d80c1be017f25ec5b
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Fixes: #16114
Reviewed-on: https://review.typo3.org/22477
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Width of action column is wrong 53/22453/2
Oliver Hader [Wed, 19 Jun 2013 14:53:35 +0000 (16:53 +0200)]
[BUGFIX] Width of action column is wrong

The width of the action column in the workspaces module is
wrong. 5 icons with a width of 16px each need to be displayed
and results in a required width of 80px.

Fixes: #50210
Releases: 6.0, 6.1, 6.2
Change-Id: I3e1cbfd9be53c57dad86a6003edbf38b559dab73
Reviewed-on: https://review.typo3.org/22453
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay 21/22421/2
Stanislas Rolland [Mon, 10 Jun 2013 15:25:00 +0000 (11:25 -0400)]
[BUGFIX] setRespectSysLanguage(FALSE) doesn't prevent language overlay

Solution: When this flag is set to FALSE, do not apply language
overlays.

Resolves: #47192
Releases: 6.0, 6.1, 6.2
Change-Id: Iac0d647fde2f930a63bc6982472b1c76e649601d
Reviewed-on: https://review.typo3.org/22421
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Faulty layout if row details are too long 87/22387/2
Oliver Hader [Wed, 17 Jul 2013 11:49:52 +0000 (13:49 +0200)]
[BUGFIX] Faulty layout if row details are too long

If the row details in in the workspaces difference view are too
long, e.g. a string that does not contain white-spaces like e.g.
a filename, the layout looks broken.
The solution is to introduce a new classname for the content
details and to force word breaking via CSS.

Fixes: #50114
Releases: 6.0, 6.1, 6.2
Change-Id: I9a768aed1c9bb4ebdfea5ba79083b7e5dce262d9
Reviewed-on: https://review.typo3.org/22387
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove redundant try/catches in ResourceStorage of FAL 71/22371/3
Claus Due [Fri, 21 Jun 2013 19:13:50 +0000 (21:13 +0200)]
[TASK] Remove redundant try/catches in ResourceStorage of FAL

This change simply removes some try/catch statement which did
nothing but re-throw the RuntimeException.

Fixes: #49332
Releases: 6.0, 6.1, 6.2
Change-Id: I62d7e1b0312a16926b06e0bd5eb6fc8be0829d3c
Change-Id: I2c1e2f5947071ec5aadb897b4ca1044231552ed8
Reviewed-on: https://review.typo3.org/22371
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Category API does not consider multiple tables 66/22366/2
Marc Wöhlken [Fri, 5 Jul 2013 16:23:58 +0000 (18:23 +0200)]
[BUGFIX] Category API does not consider multiple tables

Using the Category API with multiple tables, leads to wrong
results due to a missing check for the correct table.

Resolves: #45332
Releases: 6.2, 6.1, 6.0
Change-Id: Iaf5b453acd434ab8d8f58932a2c96385a66abf37
(cherry picked from commit 7c97fe9f6ac712faba8dac4ecf0e2c127038b5d6)
Reviewed-on: https://review.typo3.org/22366
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Pagetree filtering crashes on draft moves 59/21959/2
Bart Dubelaar [Thu, 20 Sep 2012 20:06:14 +0000 (22:06 +0200)]
[BUGFIX] Pagetree filtering crashes on draft moves

This bugfix fixes the following pagetree issues encountered in
a draft workspace:

1. Records moved in draft could not be found
2. Pagetree would crash if a moved page occurs in the rootline of
a filtered page.
3. Filtering only looked at live page title not the draft title

Change-Id: I49c0082d013303d39c0c259a42f9bb74346ba7c8
Fixes: #39197
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21959
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Skip link validation of RTE filelink 30/22330/2
Visay Keo [Thu, 20 Jun 2013 12:01:35 +0000 (19:01 +0700)]
[BUGFIX] Skip link validation of RTE filelink

When a text is linked to a file using RTE link wizard,
linkvalidator will detect it as internal link.
The validation check for internal page when it is a file will always fail.

This patch just skip validation if it finds a link to the file.

TODO:
* Proper validation of the file need to be applied.

Resolves: #49286
Releases: 6.0, 6.1, 6.2
Change-Id: I1b4901e2ac311ae93442fef044e4f7d7ae415753
Reviewed-on: https://review.typo3.org/22330
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Setting space before/after should use !important 56/22356/2
Georg Ringer [Tue, 16 Jul 2013 05:04:08 +0000 (07:04 +0200)]
[TASK] Setting space before/after should use !important

If the setting space before/after is used, the generated styles
should use !important to override possible CSS styles done somewhere else.

Change-Id: Ib2cbef280e6d2ac9d1503448ebaede48cf9d159b
Resolves: #50038
Releases: 6.2,6.1,6.0
Reviewed-on: https://review.typo3.org/22356
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing/Wrong copy buttons if deflangBinding is disabled 54/22354/3
Stefan Galinski [Sat, 6 Jul 2013 13:41:16 +0000 (15:41 +0200)]
[BUGFIX] Missing/Wrong copy buttons if deflangBinding is disabled

Fixes: #49712
Releases: 6.2, 6.1, 6.0
Change-Id: If3aebb786ae6b3f23964704d5f3c13ea7b0fd0af
Reviewed-on: https://review.typo3.org/22354
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Localconf upgrade wizard fails 48/22348/2
Anja Leichsenring [Tue, 16 Jul 2013 08:24:42 +0000 (10:24 +0200)]
[BUGFIX] Localconf upgrade wizard fails

Converting localconf.php to LocalConfiguration.php
with the installtool upgrade-wizard fails on
Debian Squeeze installation.

Change-Id: Id06793fc487cd1ad6b1d56ca5ee5a99960b3f4b1
Resolves: #39434
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22348
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Indexing files does not store the language 33/22333/2
Mario Rimann [Thu, 14 Mar 2013 10:32:55 +0000 (11:32 +0100)]
[BUGFIX] Indexing files does not store the language

While indexing externals (e.g. PDF files) the language of the page
being rendered is not stored with the indexed file content. Thus
the file is shown/not shown in the wrong situations.

See detailed description in bug-report regarding the "situations".

Change-Id: I69eb1e222eb186b052eba93eaa9d5a80dd1e87ab
Resolves: #46261
Releases: 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22333
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix PHP warning trigged in initFEuser 38/22338/2
Markus Klein [Mon, 15 Jul 2013 18:32:18 +0000 (20:32 +0200)]
[BUGFIX] Fix PHP warning trigged in initFEuser

TypoScriptFrontendController::initFEuser() calls
$GLOBALS['TYPO3_DB']->cleanIntList() with a possible NULL argument.
This leads to a PHP warning in GeneralUtility::trimExplode().

Resolves: #42921
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id33ee8fe5e4177716af6ce8c9084e098b86c280c
Reviewed-on: https://review.typo3.org/22338
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Fix usage of functions, which are deprecated in PHP 5.5 15/22315/2
Markus Klein [Thu, 20 Jun 2013 23:55:37 +0000 (01:55 +0200)]
[TASK] Fix usage of functions, which are deprecated in PHP 5.5

Fixes a call to preg_replace with /e modifier,
which is deprecated in PHP 5.5 now.

Resolves: #49300
Releases: 6.2, 6.1
Change-Id: I6bd4b57d64801be912e0050772420a684b1aa237
(cherry picked from commit ebe1573ba958b36876619b91de990b0f4ec60487)
Reviewed-on: https://review.typo3.org/22315
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] requestUpdate sensitive to spaces 09/22309/3
Wouter Wolters [Sat, 13 Jul 2013 17:26:28 +0000 (19:26 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Change-Id: Ifbb1fe5be59077207316e48204d65a978592f878
Resolves: #49872
Related: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22309
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Exceptions if EXT:context_help is not installed 93/22293/3
Dmitry Dulepov [Mon, 20 May 2013 11:25:34 +0000 (15:25 +0400)]
[BUGFIX] Exceptions if EXT:context_help is not installed

If the extension 'context_help' is not installed, the web
server's error log sometimes shows exceptions like "Class
'TYPO3\CMS\ContextHelp\ExtDirect\ContextHelpDataProvider'
not found" and "Invalid argument supplied for foreach()".
This happens because the class in question is registered
to ExtDirect without checking if the corresponding
extension is loaded.

Change-Id: Ic773cff2822912aac7841955be2f09d77169fdb9
Resolves: #48394
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22293
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Make DBgetDelete() update tstamp on delete by update 86/22286/2
Stefan Neufeind [Thu, 18 Apr 2013 15:03:57 +0000 (17:03 +0200)]
[BUGFIX] Make DBgetDelete() update tstamp on delete by update

If told to do so by TCA ContentObjectRenderer::DBgetDelete()
will not immediately delete a row but mark it as deleted.
This change updates the tstamp (if that column is configured)
for that "updated" row as well, like on a regular update.

Fixes: #47354
Releases: 6.2, 6.1
Change-Id: I61b9ce7d8608b73cfb974e79d2f9f59e6dc3547a
Reviewed-on: https://review.typo3.org/22286
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGIFX] RTEmagic upgrade wizard: missing attributes 85/22285/2
Francois Suter [Sat, 6 Jul 2013 14:32:56 +0000 (16:32 +0200)]
[BUGIFX] RTEmagic upgrade wizard: missing attributes

When the RTE creates a magic images it uses data-* attributes
to keep a reference to the original FAL record. The upgrade
wizard migrates the images, creates the sys_file entries but
does not add the data-* attributes.

Resolves: #49733
Releases: 6.1, 6.2
Change-Id: Ib483355336d1331892920ada847850a61c35a3af
Reviewed-on: https://review.typo3.org/22285
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Permissions backend module not accessible 28/22228/2
Wouter Wolters [Thu, 11 Jul 2013 20:59:08 +0000 (22:59 +0200)]
[BUGFIX] Permissions backend module not accessible

Permissions backend module not accessible in "List" view.

Change-Id: Ic1e4e06f387ee5450466e051162572c3392e3d53
Resolves: #49918
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22228
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] File upload in RTE-Link-Editor throws 500 error 89/22189/2
Philipp Gampe [Thu, 16 May 2013 18:42:49 +0000 (20:42 +0200)]
[BUGFIX] File upload in RTE-Link-Editor throws 500 error

When you want to add a link in the RTE-Editor, you can upload files in
the "File" tab. When you select a file and want to upload it, the
reloaded content in the create-link-overlay will throw an error.

The method is feed with a translation of "none - new file".

Bypass the file or folder lookup if we do not have an integer id
and print the message instead.

Resolves: #48219
Releases: 6.2, 6.1, 6.0
Change-Id: I9e1e6bc84b21fb04608841515ac414eec8c04130
Reviewed-on: https://review.typo3.org/22189
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Allow target attribute for more doctypes 24/22224/2
Jigal van Hemert [Thu, 11 Jul 2013 13:55:33 +0000 (15:55 +0200)]
[BUGFIX] Allow target attribute for more doctypes

The target attribute for links is allowed according to w3c documentation
in more doctypes than xhtml frameset and html5.

Change-Id: Id4110399dec1c1f1d0a4d69342440021837b51a9
Resolves: #37710
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22224
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Page title change directly updates title in content area 91/22191/2
Max Roesch [Fri, 5 Jul 2013 15:00:34 +0000 (17:00 +0200)]
[BUGFIX] Page title change directly updates title in content area

Updating the page title in the page tree by double click editing it
calls the changes in right order, by first persisting the
change and then doing the reload of the content area.

Resolves: #49706
Releases: 6.2, 6.1, 6.0
Change-Id: Id108659f1a8bd7a4ecd003337b0782d4fe7d3b68
Reviewed-on: https://review.typo3.org/22191
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Allow sys_category in rootpage 38/21338/2
Stefan Froemken [Wed, 24 Apr 2013 07:27:18 +0000 (09:27 +0200)]
[TASK] Allow sys_category in rootpage

Allow sys_category records to be stored in the rootpage. (pid=0)

Resolves: #47530
Releases: 6.2, 6.1, 6.0
Change-Id: Ie71a13ec9a1be65c57e28fff63f003fc5caa6ac1
Reviewed-on: https://review.typo3.org/21338
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] requestUpdate sensitive to spaces 85/22185/2
Francois Suter [Wed, 10 Jul 2013 12:12:32 +0000 (14:12 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Resolves: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I340090e93e7b8645493f8db0c8c374cb1227f684
Reviewed-on: https://review.typo3.org/22185
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Logging PHP errors to sys_log table does not work 71/22171/4
Robert Vock [Tue, 9 Jul 2013 20:09:08 +0000 (22:09 +0200)]
[BUGFIX] Logging PHP errors to sys_log table does not work

Logging PHP errors stopped working after changeset
3e309294309458279eef2adf08af6adb8ed4a867 when the  DatabaseConnection
class was changed.
The changed line tries to determine, if a database connection is
available and only writes the log entry if the connection was
already established.

Resolves: #49645
Releases: 6.1, 6.2
Change-Id: Idee413ed911a8c2d23f034ceadd17c955c98a337
Reviewed-on: https://review.typo3.org/22171
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Cannot load css_styled_content TS using INCLUDE_TYPOSCRIPT 69/22169/2
Ingo Renner [Thu, 27 Jun 2013 01:53:35 +0000 (18:53 -0700)]
[BUGFIX] Cannot load css_styled_content TS using INCLUDE_TYPOSCRIPT

When installing extensions they may register plugins in ext_localconf.php.
By doing so some default TypoScript is generated in
Extensionutility::configurePlugin() that is then added using
ExtensionManagementUtility::addTypoScript().

Parts of the generated TypoScript are stored in
$TYPO3_CONF_VARS['FE']['contentRenderingTemplates']* and are loaded later
during TypoScript parsing after including the content rendering template.

These TS parts are used to resolve which classes and methods to call when
a plugin needs to be rendered on a page. You can find them in
tt_content.list.20.*

"content default" used to be the old content rendering template with uid
43, today we use css_styled_content instead. The part in the TypoScript
processing chain to load these generated snippets -
TemplateService::includeStaticTypoScriptSources() - is only executed when
loading the content rendering templates using the "Include static (from
extensions)" field in template records.

In return this means if you try to move as much TS to files as possible
you will still have to include css_styled_content through the Template
records in the backend. In other words when actually trying to include
css_styled_content TS from a file, the generated snippets for
tt_content.list.20.* will not be loaded and thus no plugin can be
executed.

Resolves: #49461
Resolves: #44983
Releases: 6.2, 6.1, 6.0
Change-Id: I77c0d64759fa0b5b27cac0ae1acd55e9abefe7f8
Reviewed-on: https://review.typo3.org/22169
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
5 years ago[BUGIFX] Missing update wizard for RTE file links 34/22134/2
Francois Suter [Sat, 6 Jul 2013 11:15:44 +0000 (13:15 +0200)]
[BUGIFX] Missing update wizard for RTE file links

File links made inside a RTE-enabled field are currently not
migrated to FAL references. This patch adds such an update
wizard.

Resolves: #49233
Releases: 6.1, 6.2
Change-Id: I12b6d9da87b734c0a9d5f884d5067e3c9b08efc3
Reviewed-on: https://review.typo3.org/22134
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] False-Positives in SQL comparison 52/21352/3
Mario Rimann [Fri, 5 Apr 2013 21:10:29 +0000 (23:10 +0200)]
[BUGFIX] False-Positives in SQL comparison

When one has e.g. a field "foo INT(11) DEFAULT '0' NOT NULL" in
it's ext_tables.sql definition, the comparison will always complain
about that field, since the underlying DB lists this field as "int(11)"
which is lowercased.

This integrates a regex that lowercases the field types before
comparing the field from the definition against the existing field.

Change-Id: If76abbbca56d0ef0ab796a7f4e6bee1197ac39e6
Resolves: #41344
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21352
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] BasicFileUtility uses deprecation API in a wrong way 11/22111/2
Markus Klein [Sun, 7 Jul 2013 10:05:47 +0000 (12:05 +0200)]
[BUGFIX] BasicFileUtility uses deprecation API in a wrong way

Resolves: #49765
Releases: 6.2, 6.1, 6.0
Change-Id: Ieb5e652bb35f406207f0f0b63db894c9efbb98ff
Reviewed-on: https://review.typo3.org/22111
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years agoRevert "[BUGFIX] Files with unclean path indexed multiple times" 79/22079/2
Wouter Wolters [Sat, 6 Jul 2013 22:45:42 +0000 (00:45 +0200)]
Revert "[BUGFIX] Files with unclean path indexed multiple times"

This reverts commit b48b926c399d939a6e06b7096d501a1d72c72f67

This breaks Travis big time.

Change-Id: I2c9bb635991696ca55b8001aeb195e8f27592a59
Reviewed-on: https://review.typo3.org/22079
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Travis: Speedup cloning of repos 57/22057/2
Markus Klein [Sat, 6 Jul 2013 18:51:50 +0000 (20:51 +0200)]
[TASK] Travis: Speedup cloning of repos

Make use of the additional parameters of git clone
to vastly reduce the amount of data transfered when cloning the
repositories.

Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id0c5f3a4ed7ee0bdeb6053c6e0dc606362909d1e
Reviewed-on: https://review.typo3.org/22057
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Files with unclean path indexed multiple times 69/22069/2
Stefan Neufeind [Sat, 6 Apr 2013 15:11:52 +0000 (17:11 +0200)]
[BUGFIX] Files with unclean path indexed multiple times

When adding a file or requesting a file by an identifier
cleanup any . and .. in the path before handing off
to the driver so files are not indexed multiple times.

Change-Id: I324c4637621165a56470fb95864eeff1254f62dc
Fixes: #46989
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22069
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] sys_file record doesn't get flagged as delete 60/22060/2
Steffen Ritter [Sat, 6 Jul 2013 20:05:52 +0000 (22:05 +0200)]
[BUGFIX] sys_file record doesn't get flagged as delete

File is deleted by driver and deleted property of FileObject is set by
ResourceStorage but new state is not persisted.
Update deleted property in updateProperties array in FileObject and
persist change.

Reintroduced after fixing tests in 9f081830c3537e286378e406579e914ffc162969.

Change-Id: I0784c84af4bfb8021c648139c2feee577f3e9dc1
Fixes: #48336
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22060
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Move functional test case to functional folder 50/22050/2
Steffen Ritter [Sat, 6 Jul 2013 17:15:27 +0000 (19:15 +0200)]
[BUGFIX] Move functional test case to functional folder

ext:core File/ExtendedFileUtilityTest unit test is not really
a unit test, but more a functional test case since it does no
mocking at all and writes data directly to database.
The test case has side effects and is move to the functional
section for now.

Resolves: #49746
Releases: 6.2, 6.1, 6.0
Change-Id: I3f3917f0800a9492b01676bf2b67e81eea1ae16f
Reviewed-on: https://review.typo3.org/22050
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years agoRevert "[BUGFIX] sys_file record doesn't get flagged as delete" 37/22037/2
Christian Kuhn [Sat, 6 Jul 2013 16:09:55 +0000 (18:09 +0200)]
Revert "[BUGFIX] sys_file record doesn't get flagged as delete"

This reverts commit 27039510ebf9e456330face27d465863af5d0a0c

The patch kills unit tests. We guess there is some incomplete
mocking in Resource tests but are not able to quickly find
the root of it. The patch is reverted for now until the tests
are green again.

Change-Id: I5e7bb6e14187f7179e00b0b00decda644e1c6efe
Resolves: #48336
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22037
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] CE:Image - backend preview of image order 28/22028/2
Tim Spiekerkoetter [Fri, 5 Jul 2013 20:54:01 +0000 (22:54 +0200)]
[BUGFIX] CE:Image - backend preview of image order

The Backend preview does not reflect the sorting of the elements in the
content element. This patch added the sorting field from the TCA to the
thumbCode method.

Resolves: #48645
Releases: 6.2, 6.1, 6.0
Change-Id: I9dcec1c2baae226aeded9c4c93d368c067c0bad2
Reviewed-on: https://review.typo3.org/22028
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Add advice to RTEmagic wizard 26/22026/2
Francois Suter [Sat, 6 Jul 2013 11:38:37 +0000 (13:38 +0200)]
[BUGFIX] Add advice to RTEmagic wizard

The update wizard that migrates RTE magic images relies on
sys_refindex for finding the magic images. There should be
a warning in the wizard description that users should be sure
their reference index is up to date.

Resolves: #49727
Releases: 6.1, 6.2
Change-Id: I7301a4a52174424655a76b58c7b7856f5f5209a2
Reviewed-on: https://review.typo3.org/22026
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] sys_file record doesn't get flagged as delete 24/22024/2
Frans Saris [Wed, 22 May 2013 18:36:31 +0000 (20:36 +0200)]
[BUGFIX] sys_file record doesn't get flagged as delete

File is deleted by driver and deleted property of FileObject is set by
ResourceStorage but new state is not persisted.

Update deleted property in updateProperties array in FileObject and
persist change.

Fixes: #48336
Releases: 6.2, 6.1, 6.0
Change-Id: I6cac106dcf89125e0b98b8b12a03c0b3f56d484f
Reviewed-on: https://review.typo3.org/22024
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Use database name property in admin_get_tables 22/22022/2
Helmut Hummel [Fri, 5 Jul 2013 10:46:07 +0000 (12:46 +0200)]
[BUGFIX] Use database name property in admin_get_tables

The admin_get_tables method in the DatabaseConnection
uses the constant instead of the class property.
This delivers wrong results if using multiple
DatabaseConnection objects.

Use the class property instead.

Change-Id: I93e05fdabb53b170782c61ef4ebfa97190cddfb6
Resolves: #49738
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/22022
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX][Cache] Typo3DbBackend forgets tag entries in flushByTag 16/22016/2
Christian Zenker [Wed, 12 Jun 2013 14:45:57 +0000 (16:45 +0200)]
[BUGFIX][Cache] Typo3DbBackend forgets tag entries in flushByTag

flushByTags removes cache entries tagged with a given tag, but
if those cache entries have other tags assigned, they are not
deleted in the tags table.
The patch fixes this with an additional query.

Resolves: #48984
Releases: 6.2, 6.1, 6.0
Change-Id: I7096e63cf823633f0c8a47f698bd475d7d02b83c
Reviewed-on: https://review.typo3.org/22016
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Don't show translated categories in parent tree 10/22010/2
Markus Klein [Mon, 24 Jun 2013 11:22:15 +0000 (13:22 +0200)]
[BUGFIX] Don't show translated categories in parent tree

The parent category tree should only show categories in default
language.

Resolves: #44915
Releases: 6.2, 6.1, 6.0
Change-Id: I7920cf7ae208ba2db3bd24f7da5439824064c167
Reviewed-on: https://review.typo3.org/22010
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] CSV rendering in CType table not properly done 99/21999/3
Patrick Broens [Thu, 25 Apr 2013 13:09:43 +0000 (15:09 +0200)]
[BUGFIX] CSV rendering in CType table not properly done

The CSV rendering in CType table is not done properly in
css_styled_content method render_table. It uses explode with the
delimiter, but this character can also be in the cell itself.

This patch uses the PHP function str_getcsv, which is supported from PHP
version 5.3 >

Change-Id: I5707b006ab1143c108473e5ed7079e6e65cdddca
Fixes: #47356
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/21999
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] StorageRepository::findByStorageType() uses wrong typeField 93/21993/2
Philipp Gampe [Fri, 17 May 2013 03:52:17 +0000 (05:52 +0200)]
[BUGFIX] StorageRepository::findByStorageType() uses wrong typeField

The table "sys_file_storage" has no field "type".
Use the field "driver" instead.

Resolves: #48127
Releases: 6.2, 6.1, 6.0
Change-Id: I64e66a8244ddae85faf68ec3d46b4b9f2f1934ff
Reviewed-on: https://review.typo3.org/21993
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Shared defaults for CE wizard using TCAdefaults 80/21980/2
Jigal van Hemert [Thu, 27 Sep 2012 19:42:19 +0000 (21:42 +0200)]
[BUGFIX] Shared defaults for CE wizard using TCAdefaults

The page TSconfig settings for the New Content Element wizard have
a higher priority than the user TSconfig TCAdefaults. Settings which
are not different for each CE type should be set in TCAdefaults. If
they are set in the tt_content_defVals the values will be different
if the editor selected the right CE type directly than if the editor
switched CE type.

Change-Id: I8b84b3059b17f88a3d674b6faae889844cae9c67
Fixes: #41434
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21980
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Enable table property for all user settings types 76/21976/2
Philipp Gampe [Sun, 5 May 2013 21:40:14 +0000 (23:40 +0200)]
[BUGFIX] Enable table property for all user settings types

The property 'table' for user settings can also be used for other
types than password and text.

Resolves: #47966
Releases: 6.2, 6.1, 6.0
Change-Id: Icf69d480013ff1be6c0b5d43212c179468885344
Reviewed-on: https://review.typo3.org/21976
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Support mysql socket connection 73/21973/3
Philipp Gampe [Mon, 20 May 2013 14:58:20 +0000 (16:58 +0200)]
[BUGFIX] Support mysql socket connection

With the switch to mysqli in 6.1, the connection to mysql server via
socket broke.
With mysqli, the definition is now:
* If hostname is "localhost", a socket is used and the socket file
can be given optionally if it is different from the default.
* If hostname is not "localhost" but an IP address, a port can be
given that may be different from the default mysql 3306.

This backport just considers the LocalConfiguration.php setting and
does not change anything in the installer.

Resolves: #48117
Releases: 6.2, 6.1
Change-Id: I968a72dbaf90b3f319c03e697137630534d325c1
Reviewed-on: https://review.typo3.org/21973
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Exception on thumbnail generation in TCA 26/21926/2
Stefan Galinski [Mon, 10 Jun 2013 17:58:42 +0000 (19:58 +0200)]
[BUGFIX] Exception on thumbnail generation in TCA

In order to test this you are needing a non-FAL
TCA file reference field. Just reference something
here, remove the reference in the filesystem again
and reload the TCA of the record. An exception will
be thrown, because the file isn't available anymore.

Fixes: #49009
Releases: 6.2, 6.1, 6.0
Change-Id: I6eccb3ef77de703551a64f52ab3904cead517c8a
Reviewed-on: https://review.typo3.org/21926
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
5 years ago[BUGFIX] RTEmagic upgrade wizard fails and uses wrong directory 14/21914/2
Stefan Galinski [Mon, 6 May 2013 20:29:36 +0000 (22:29 +0200)]
[BUGFIX] RTEmagic upgrade wizard fails and uses wrong directory

The RTE upgrade wizard fails, because it uses a
non-existing field name as the table and writes wrong
image paths back into the RTE content. Also the migration
directory should equal the already available migration
directory of the FAL upgrade wizards.

You can test the issue by adding an image to a
RTE field in a 4.7 instance and try to migrate to 6.1
afterwards.

Fixes: #47998
Releases: 6.2, 6.1
Change-Id: Ie6d3947f475e80ac36eb5ba43f258b5215e19928
Reviewed-on: https://review.typo3.org/21914
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
5 years ago[BUGFIX] Improve jumpUrl download of large files 17/21917/2
Till Busch [Thu, 11 Oct 2012 13:22:48 +0000 (15:22 +0200)]
[BUGFIX] Improve jumpUrl download of large files

* Prevent output-buffering
* Add Content-Length header

Fixes: #41718
Releases: 6.2, 6.1, 6.0
Change-Id: I8a1a33dc4337a5947bafbad980b73343be637da7
Reviewed-on: https://review.typo3.org/21917
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Web->Page - Language view not usable 90/21890/2
Stefan Galinski [Tue, 18 Jun 2013 15:26:50 +0000 (17:26 +0200)]
[BUGFIX] Web->Page - Language view not usable

Since the "all language" elements are displayed in each
language (introduced in 4.7), the language view of the
page module is not really usable anymore. If you have
activated the mod.web_layout.defLangBinding setting in the
Page TS configuration  "all language" elements are not
displayed anymore. Also you cannot overwrite "all language"
elements in an easy way inside another languages
and overwritten elements are displayed together with their
"all language" default element inside a column. Furthermore
the sorting order is sometimes broken on non-default languages
if the "all language" element is rendered inside the column.
The patch fixes all this issues in the languages view by
reverting the changes introduced the 4.7 branch just for the
languages view. The columns view works like it was intented with
the fix from the 4.7 branch (it still has the same flaws as
the languages view, but this issues can be fixed with another
changeset).

Fixes: #42768
Fixes: #42771
Releases: 6.2, 6.1, 6.0
Change-Id: Ibd222c3980ebcc7a5f273d85b3d99d6938291e9e
Reviewed-on: https://review.typo3.org/21890
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
5 years ago[TASK] Remove Comment for deprecation of f:translate key 01/21901/2
Ingo Pfennigstorf [Thu, 4 Jul 2013 20:00:27 +0000 (22:00 +0200)]
[TASK] Remove Comment for deprecation of f:translate key

In future versions the usage of f:translate key and f:translate id
will both be possible, so the comment about a deprecation is removed.

Change-Id: I71a2fc1e9abec6b26c8b3848dd31e234fc056699
Fixes: #49670
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21901
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Rootline utility must respect pageOverlayFields 22/21722/2
Stefan Galinski [Wed, 15 May 2013 14:18:05 +0000 (16:18 +0200)]
[BUGFIX] Rootline utility must respect pageOverlayFields

The rootline calculation always overlays all fields
from the pages table. This causes trouble in e.g. the
case that you want to reuse media images from the default
language in other languages. In the previous implementation
(pre 6.x) only the overlay fields from the
 $GLOBALS['TYPO3_CONF_VARS']['FE']['pageOverlayFields']
setting were overlaid.

Fixes: #48224
Releases: 6.2, 6.1, 6.0
Change-Id: I6f5a10150c916df24542ee83e33663a27bdb593f
Reviewed-on: https://review.typo3.org/21722
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
5 years ago[BUGFIX] RTE: Importing google webfonts breaks style sheet parsing 61/21861/2
Stanislas Rolland [Wed, 3 Jul 2013 22:45:12 +0000 (18:45 -0400)]
[BUGFIX] RTE: Importing google webfonts breaks style sheet parsing

Problem: Firefox raises a security error because the file is not in the
same domain as the executing script. Probably a Firefox bug since the
file certainly has adequate headers: the font are indeed displayed in
the RTE.

Solution: Since the Webfont style sheet does not contain any css rules
anyways, we will catch the error, and if it is a security error, log it
to the Javascript console (or Firebug) and silently continue. Re-throw
any other type of error.

Resolves: #49648
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Change-Id: I225152ad5d84de50f29d3830be6f1f3e10f249c8
Reviewed-on: https://review.typo3.org/21861
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Invalid cache backend option "compression" for NullBackend 00/21800/2
Xavier Perseguers [Tue, 2 Jul 2013 12:55:07 +0000 (14:55 +0200)]
[BUGFIX] Invalid cache backend option "compression" for NullBackend

If a Typo3DatabaseBackend is changed to NullBackend, the compression flag
may be set and should be part of the NullBackend interface.

Change-Id: Id70dc582ddbe87eb8388dd79963364c23900e417
Fixes: #49585
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21800
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] EM: Scheduler task does not persist to database 92/21792/2
Alexander Opitz [Mon, 1 Jul 2013 11:47:42 +0000 (13:47 +0200)]
[BUGFIX] EM: Scheduler task does not persist to database

The scheduler task for updating extension list of the extension
manager does not persist his data to database. As Scheduler is no
extbase extension and the task is no extbase task this peristence
isn't called at end of script.

Change-Id: I75629874f698f45f1b7dab47636857b5865e8d24
Resolves: #49528
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21792
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Wrong top/bottom margin rendering in CSC 86/21786/2
Patrick Broens [Thu, 25 Apr 2013 12:38:50 +0000 (14:38 +0200)]
[BUGFIX] Wrong top/bottom margin rendering in CSC

When a top or bottom margin has been chosen together with section_frame
"no frame" -> 66, no entry is made in the temporary stylesheet.

This patch solves this issue by changing the stdWrap variable to
classStdWrap for the method renderSpace().

Change-Id: Iee6c98537e2a4a8c917dfd450289f26ce50e3ca9
Fixes: #47403
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/20155
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/21786

5 years ago[BUGFIX] Increase the width of the content element of type Plain HTML 66/21766/2
Philipp Gampe [Sun, 19 May 2013 15:55:35 +0000 (17:55 +0200)]
[BUGFIX] Increase the width of the content element of type Plain HTML

The current editor field for content elements of type HTML is for too
small. Without t3editor it is only 5 lines in height and with t3editor
it is limited to 200px which is not much more.

Increase the default size for tt_content.bodytext to 80x15 and set the
height for t3editor fields to 60% as done in setup.

Resolves: #43112
Releases: 6.2, 6.1, 6.0
Change-Id: Icc27cb013cc3009dace5dedef2f9515af1975ec0
Reviewed-on: https://review.typo3.org/20923
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/21766

5 years ago[BUGFIX] Do not show System Extensions Wizard when done 51/21751/2
Helmut Hummel [Sun, 30 Jun 2013 14:34:52 +0000 (16:34 +0200)]
[BUGFIX] Do not show System Extensions Wizard when done

The check if the wizard has been executed before and
includes all available system extensions have been installed
is wrong. Rather than casting to bool, we should
check if the difference between "seen extensions" and
available system extensions is an empty array.

This correctly shows the wizard when not finished and
hides it when finished.

Resolves: #49256
Releases: 6.2, 6.1, 6.0
Change-Id: I7bd655b2b7eeaaa5b1dd91e80564f150b1d0d038
Reviewed-on: https://review.typo3.org/21751
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] createEncryptionKey always returns key with 96 characters 49/21749/2
Mario Rimann [Tue, 29 Nov 2011 21:00:51 +0000 (22:00 +0100)]
[TASK] createEncryptionKey always returns key with 96 characters

Update the createEncryptionKey method to use the same underlying
call as its copy in the eID script.

Change-Id: I666a3620080fd0f5281e899250f5c710e2550173
Resolves: #29220
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/21749
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] EM: TimeSinceLastUpdateViewHelper fatals if never updated 45/21745/2
Alexander Opitz [Fri, 14 Jun 2013 13:22:08 +0000 (15:22 +0200)]
[BUGFIX] EM: TimeSinceLastUpdateViewHelper fatals if never updated

If the repository was never updated (or the update failed) last_update
has the value of zero in the database.
Then NULL->format in the TimeSinceLastUpdateViewHelper leads to the fatal
error.

Resolves: #47726
Releases: 6.2, 6.1, 6.0
Change-Id: Ia41c50f2037fb1c7ef935a8855a200b303347383
Reviewed-on: https://review.typo3.org/21745
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Improve error message in NotFoundView to identify source 33/21733/2
Claus Due [Sat, 29 Jun 2013 12:43:54 +0000 (14:43 +0200)]
[TASK] Improve error message in NotFoundView to identify source

The error message before this change would only report the
action name, after this change it will reflect the controller and
extension name as well.

Set to apply to all maintained version since this changes no functions
whatsoever - it only improves error feedback.

Resolves: #49519
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I61dc32a4542b8664ca9443414278e983bc181c4a
Reviewed-on: https://review.typo3.org/21733
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Wrong placement of image caption in text with image 26/21726/2
Philipp Gampe [Sat, 29 Jun 2013 12:41:28 +0000 (14:41 +0200)]
[BUGFIX] Wrong placement of image caption in text with image

If you omit the first caption, then the following captions are shifted
into this position, meaning the the captions are off by the number of
empty captions in front.

This happens because the captions are stored with a newline "\n" as
separator which is removed by a trim = 1.

Remove this trim from tt_content.image.20.caption.1.1 as the trimming of
the actual content happens with
tt_content.image.20.caption.1.stdWrap.trim = 1.

The change also has a few cleanups that popped up in PhpStorm while
investigation the issue.

Resolves: #48354
Releases: 6.2, 6.1, 6.0
Change-Id: I4523fa40cbf991b3941d18145a09e72d5e5254d3
Reviewed-on: https://review.typo3.org/21726
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix localization of the BE user module 24/21724/2
Wouter Wolters [Sat, 29 Jun 2013 12:14:59 +0000 (14:14 +0200)]
[BUGFIX] Fix localization of the BE user module

Fix some hardcoded labels by replacing them with
f:translate tags.

Change-Id: Ic75f7bd021ff8353b7709906859d2c02eb452b23
Resolves: #49402
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21724
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] compressJs returns wrong filenames 09/21409/2
Philipp Gampe [Thu, 16 May 2013 18:23:00 +0000 (20:23 +0200)]
[BUGFIX] compressJs returns wrong filenames

If you enable
    config.concatenateJs = 1
    config.compressJs = 1
then the uncompressed version of the file is linked.

This does not change much, because compression is disabled and the files
will always be uncompressed, however the right link should be generated.

The allows extension to override the compress method and implement
compression without fixing the rest of the code.

The bug is a regression introduced with: #27694 (4.6).

Return the correct filename by overriding the filename with the returned
value of compressJsFile.

Resolves: #48213
Related: #27694
Releases: 6.2, 6.1, 6.0, 4.7
Change-Id: I1f65576db8084b54f9e5a13947ced258eef893d7
Reviewed-on: https://review.typo3.org/20845
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-on: https://review.typo3.org/21409

5 years ago[BUGFIX] stdWrap for special.value applied twice 86/21686/2
Markus Klein [Fri, 14 Sep 2012 07:28:59 +0000 (09:28 +0200)]
[BUGFIX] stdWrap for special.value applied twice

In HMENU the stdWrap for special.value is applied twice.
This patches removes the superfluous call
in HierarchicalMenuContentObject.php.

Furthermore it also moves the stdWrap for excludeUidList
to AbstractMenuContentObject.php for consistency reasons.

Change-Id: Ia6594a76602acdab8b39d50803595343e65f6d02
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Fixes: #40855
Reviewed-on: https://review.typo3.org/14588
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-on: https://review.typo3.org/21686

5 years ago[TASK] Add support for "outdated" extensions 19/21719/2
Jigal van Hemert [Sun, 23 Jun 2013 18:50:20 +0000 (20:50 +0200)]
[TASK] Add support for "outdated" extensions

Extension Manager displays installed extensions which are marked as
"outdated" with different styling. Reports module also checks for
installed and available "outdated" extensions.

Change-Id: I3050f3f7142e4153954f1b7f76b4bf64a3066223
Resolves: #49350
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21719
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] ActionController must use namespaced object view pattern 12/21712/2
Alexander Schnitzler [Fri, 28 Jun 2013 12:39:48 +0000 (14:39 +0200)]
[BUGFIX] ActionController must use namespaced object view pattern

The ActionController still uses the old pattern like
Tx_@extension_View_@controller_@action@format for resolving
custom view objects. When using a namespaced extension it
must be possible to also use namespaced view objects.
Therefore a new view object pattern has to be introduced:
@vendor\@extension\View\@controller\@action@format

Releases: 6.2, 6.1, 6.0
Resolves: #47609
Change-Id: Iedc6120469f2277b482c5e1c40b89790404e9bbe
Reviewed-on: https://review.typo3.org/21712
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix property mapping of checkbox arrays 99/21699/2
Helmut Hummel [Thu, 27 Jun 2013 18:09:37 +0000 (20:09 +0200)]
[BUGFIX] Fix property mapping of checkbox arrays

If multiple checkboxes are rendered but none of it is
selected, an exception is thrown as the value of the hidden field,
that is submitted is a string.

This must be the case because we need to be able to clear out
selected checkboxes and cannot craft a hidden field that will
be translated to a GET/POST arument which is an empty array.

Because of that the ArrayConverter must be able to convert
empty strings to an empty array, just like the "old"
property mapper did.

Change-Id: I115831014caca4868d1f421eb968e01178e1169b
Resolves: #47832
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21699
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix localization of the language module 76/21676/2
Wouter Wolters [Wed, 26 Jun 2013 18:10:51 +0000 (20:10 +0200)]
[BUGFIX] Fix localization of the language module

The table headers are not translatable yet.
Replace them with f:translate tags.

Change-Id: Ibe9fc989eba193f3401f40b1b7f5f8be081189ef
Resolves: #49401
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21676
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Fix one language label in the extension manager 74/21674/2
Krzysztof Adaczmyk [Wed, 26 Jun 2013 09:09:24 +0000 (11:09 +0200)]
[BUGFIX] Fix one language label in the extension manager

Make hardcoded "Search:" label translatable.

Change-Id: I006f6b98f45f0d2e82c02c1b40ed549a15ac93fd
Resolves: #49404
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21674
Reviewed-by: Markus Klein
Tested-by: Markus Klein